[PATCH] D90984: Update matchers to be traverse-aware

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (!Finder->isTraversalAsIs() && (*MatchIt)->isImplicit()) +return false; If the traversal is not `AsIs`, that doesn't mean it's `IgnoreUnlessSpelledInS

[clang] 9c504ec - [VE] Disable -fsigaddr option for VE

Author: Kazushi (Jam) Marukawa Date: 2020-11-13T06:22:12+09:00 New Revision: 9c504ec06da636832d03e98581eade3d8f81eb24 URL: https://github.com/llvm/llvm-project/commit/9c504ec06da636832d03e98581eade3d8f81eb24 DIFF: https://github.com/llvm/llvm-project/commit/9c504ec06da636832d03e98581eade3d8f81e

[PATCH] D91350: [VE] Disable -fsigaddr option for VE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c504ec06da6: [VE] Disable -fsigaddr option for VE (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D91385: [DFSan][NewPM] Handle dfsan under NPM

aeubanks created this revision. aeubanks added reviewers: ychen, leonardchan, asbirlea. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks requested review of this revision. 14/16 check-dfsan tests failed with NPM enabled, now all pass. Repository: rG LLVM Github M

[PATCH] D91387: [Driver] Support UBSan multilib

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. phosek requested review of this revision. This is analogous to the existing ASan multilib. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D91376: [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b568a9c8db: [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP. (authored by ABataev). Repository: rG LLVM Github M

[clang] 07b568a - [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP.

Author: Alexey Bataev Date: 2020-11-12T13:26:11-08:00 New Revision: 07b568a9c8db8e5d4d4af4c766ecfb38145fb0bf URL: https://github.com/llvm/llvm-project/commit/07b568a9c8db8e5d4d4af4c766ecfb38145fb0bf DIFF: https://github.com/llvm/llvm-project/commit/07b568a9c8db8e5d4d4af4c766ecfb38145fb0bf.diff

[PATCH] D91372: Some updates/fixes to the creduce script.

akhuang updated this revision to Diff 304964. akhuang marked an inline comment as done. akhuang added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91372/new/ https://reviews.llvm.org/D91372 Files: clang/utils/creduce-

[PATCH] D91387: [Driver] Support UBSan multilib

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91387/new/ https://reviews.llvm.org/D91387 ___

[PATCH] D91372: Some updates/fixes to the creduce script.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c80b542d38b: Some updates/fixes to the creduce script. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D91389: [MemProf][NewPM] Make memprof passes required

aeubanks created this revision. aeubanks added reviewers: leonardchan, ychen, asbirlea. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. aeubanks requested review of this revision. Just like other sanitizers. Fixes check-memprof under NPM. Repository: rG

[clang] 0c80b54 - Some updates/fixes to the creduce script.

Author: Amy Huang Date: 2020-11-12T13:40:26-08:00 New Revision: 0c80b542d38b4819809c600e71a6997a9b4e4294 URL: https://github.com/llvm/llvm-project/commit/0c80b542d38b4819809c600e71a6997a9b4e4294 DIFF: https://github.com/llvm/llvm-project/commit/0c80b542d38b4819809c600e71a6997a9b4e4294.diff LOG

[PATCH] D91385: [DFSan][NewPM] Handle dfsan under NPM

aeubanks updated this revision to Diff 304967. aeubanks added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. make it required, update tests to also use opt-bisect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91385

[PATCH] D89980: [hip] Remove the coercion on aggregate kernel arguments.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:55 struct S { int *x; arsenm wrote: > Should also have a case with a single element struct, which will be treated > li

[PATCH] D89980: [hip] Remove the coercion on aggregate kernel arguments.

hliao updated this revision to Diff 304969. hliao added a comment. Add a test case for the single element struct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( daltenty wrote: > I think that rather that adding CC, we should just

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:60 enum GCMode { NonGC, GCOnly, HybridGC }; - enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq }; + enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq, SSPUnspecified }; -

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

shivanshu3 updated this revision to Diff 304973. shivanshu3 edited the summary of this revision. shivanshu3 added a comment. Use getFileLoc instead of getExpansionLoc to get the location of error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91129/

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392342 , @jhuber6 wrote: > In D91370#2392319 , @ABataev wrote: > >> From libomptarget. It must be different. Could you copy it here? > > Yeah, I think there's some extra informati

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392616 , @ABataev wrote: > Could you try this patch: > > diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp > b/clang/lib/CodeGen/CGOpenMPRuntime.cpp > index ce8846140d4..854b7f3e830 100644 > --- a/clang/lib/CodeG

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392616 , @ABataev wrote: > Could you try this patch: > > diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp > b/clang/lib/CodeGen/CGOpenMPRuntime.cpp > index ce8846140d4..854b7f3e830 100644 > --- a/clang/lib/CodeG

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

eugenis added a comment. Hi Sam, this patch is failing on the ubsan bot with: [ RUN ] SerializationTest.NoCrashOnBadArraySize /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang-tools-extra/clangd/index/Serialization.cpp:90:26: runtime error: left shift of 127 by 28 places cannot be re

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392641 , @jhuber6 wrote: > In D91370#2392616 , @ABataev wrote: > >> Could you try this patch: >> >> diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp >> b/clang/lib/CodeGen/CG

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith updated this revision to Diff 304984. rsmith marked 5 inline comments as done. rsmith added a comment. - Address review comments. - Extend libc++ changes to cover . - Bugfixes from further testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith updated this revision to Diff 304985. rsmith added a comment. - Remove debugging code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91311/new/ https://reviews.llvm.org/D91311 Files: clang/include/clang/Basic/Attr.td clang/include/clang

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2367 +def PreferredName : InheritableAttr { + let Spellings = [Clang<"preferred_name">]; + let Subjects = SubjectList<[ClassTmpl]>; aaron.ballman wrote: > This seems like one we should

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

nridge added a comment. Thanks for working on this! Comment at: clang/lib/Tooling/CompilationDatabase.cpp:73 CompilationDatabasePluginRegistry::entries()) { +Plugins.emplace_back(Database.getName(), Database.instantiate()); + } A side effect of thi

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a subscriber: jansvoboda11. ayermolo added a comment. @jansvoboda11 Can you take a look? The failing test is unrelated it seems. Fails locally even without my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://

[PATCH] D89980: [hip] Remove the coercion on aggregate kernel arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hliao marked an inline comment as done. Closed by commit rG8920ef06a138: [hip] Remove the coercion on aggregate kernel arguments. (authored by hliao). Repository: rG

[clang] 8920ef0 - [hip] Remove the coercion on aggregate kernel arguments.

Author: Michael Liao Date: 2020-11-12T21:19:30-05:00 New Revision: 8920ef06a138c46b208fb6471d500261c4b9bacc URL: https://github.com/llvm/llvm-project/commit/8920ef06a138c46b208fb6471d500261c4b9bacc DIFF: https://github.com/llvm/llvm-project/commit/8920ef06a138c46b208fb6471d500261c4b9bacc.diff

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

njames93 added inline comments. Comment at: clang/lib/Tooling/CompilationDatabase.cpp:73 CompilationDatabasePluginRegistry::entries()) { +Plugins.emplace_back(Database.getName(), Database.instantiate()); + } nridge wrote: > A side effect of this chan

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Not sure if I'm authorized to approve changes to libTooling, but this LGTM! Comment at: clang/lib/Tooling/CompilationDatabase.cpp:73 CompilationDatabasePluginRegistry

[PATCH] D91047: Add a call super attribute plugin example

psionic12 updated this revision to Diff 305011. psionic12 marked an inline comment as done. psionic12 added a comment. fix grammer errors in warning messages and documents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91047/new/ https://reviews.llv

[PATCH] D91047: Add a call super attribute plugin example

psionic12 marked 5 inline comments as done. psionic12 added inline comments. Comment at: clang/docs/ClangPlugins.rst:117 +Defining CallSuperAttr +=== + aaron.ballman wrote: > aaron.ballman wrote: > > The number of underlines here looks off -- can

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( Xiangling_L wrote: > daltenty wrote: > > I think that rather that addin

[PATCH] D91047: Add a call super attribute plugin example

psionic12 added a comment. I just enabled `LLVM_ENABLE_DOXYGEN` `LLVM_BUILD_DOCS`, and use `make doxygen-clang`, it seems no error with my newest patch, is this > This still appears to be incorrect and will cause build errors for the > documentation. use the same way? Repository: rG LLVM G

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

faisalv updated this revision to Diff 305020. faisalv added a comment. This revision includes the following changes to the initial patch: - revert the bit-field to unsigned from enum (so as to avoid that nettlesome gcc warning) - specified a fixed underlying type of 'unsigned char' for the enum

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

rsmith added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1762 }; +using FDK = FunctionDefinitionKind; I don't think it's OK to have an initialism like this in the `clang` namespace scope -- generally-speaking, the larger the scope of a na

[clang] 7602ef7 - Suppress trailing template arguments equivalent to default arguments

Author: Richard Smith Date: 2020-11-12T21:10:34-08:00 New Revision: 7602ef768b1af99b6184faf6edfc4e06b718c7c5 URL: https://github.com/llvm/llvm-project/commit/7602ef768b1af99b6184faf6edfc4e06b718c7c5 DIFF: https://github.com/llvm/llvm-project/commit/7602ef768b1af99b6184faf6edfc4e06b718c7c5.diff

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

smhc added a comment. In D90282#2391360 , @aaron.ballman wrote: > In D90282#2391005 , @njames93 wrote: > >> Should this be a NamingStyle option instead. >> `{key: readability-identifier-naming.ParameterShortSizeThr

[PATCH] D78903: [Driver] Add option -fproc-stat-report

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92d7a84e128a: [Driver] Add option -fproc-stat-report (authored by sepavloff). Herald added a subscriber: dang. Changed prior to commit: https://re

[clang] 92d7a84 - [Driver] Add option -fproc-stat-report

Author: Serge Pavlov Date: 2020-11-13T14:15:42+07:00 New Revision: 92d7a84e128a20cd23e3129dee82c48f1750966a URL: https://github.com/llvm/llvm-project/commit/92d7a84e128a20cd23e3129dee82c48f1750966a DIFF: https://github.com/llvm/llvm-project/commit/92d7a84e128a20cd23e3129dee82c48f1750966a.diff

<    1   2