[PATCH] D86217: rename sram-ecc as sramecc in clang

2020-11-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. Herald added a subscriber: dexonsmith. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86217/new/ https://reviews.llvm.org/D86217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

2020-11-11 Thread Felix Berger via Phabricator via cfe-commits
flx added a comment. In D90042#2368219 , @aaron.ballman wrote: > In D90042#2360042 , @flx wrote: > >> In D90042#2357078 , @aaron.ballman >> wrote: >> >>> In D90042#2356265

[PATCH] D91315: [RISCV] Handle zfh in the arch string.

2020-11-11 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.scott, asb, kito-cheng, luismarques, Jim. Herald added subscribers: cfe-commits, frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, lenary, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rog

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

2020-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90484/new/ https://reviews.llvm.org/D90484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

2020-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90053/new/ https://reviews.llvm.org/D90053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC

2020-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90485/new/ https://reviews.llvm.org/D90485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

2020-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90733/new/ https://reviews.llvm.org/D90733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

2020-11-11 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2abc33683b2b: [PowerPC] [Clang] Define macros to identify quad-fp semantics (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ ht

[clang] 2abc336 - [PowerPC] [Clang] Define macros to identify quad-fp semantics

2020-11-11 Thread Qiu Chaofan via cfe-commits
Author: Qiu Chaofan Date: 2020-11-12T10:26:13+08:00 New Revision: 2abc33683b2b702c00c366d56c6285fda6d1e436 URL: https://github.com/llvm/llvm-project/commit/2abc33683b2b702c00c366d56c6285fda6d1e436 DIFF: https://github.com/llvm/llvm-project/commit/2abc33683b2b702c00c366d56c6285fda6d1e436.diff L

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

2020-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90497/new/ https://reviews.llvm.org/D90497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

2020-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90887/new/ https://reviews.llvm.org/D90887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D87981: [X86] AMX programming model prototype.

2020-11-11 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:101 + unsigned SubIdx = (BitSize == 8) ? X86::sub_8bit : X86::sub_16bit; + unsigned Opc = (BitSize == 8) ? X86::MOV8mr : X86::MOV16mr; + MachineInstr *NewMI = LuoYuanke wrote: >

[clang] 2d4035e - Fix structural comparison of template template arguments to compare the

2020-11-11 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-11-11T19:15:21-08:00 New Revision: 2d4035e493e3933e8819ee090a66fd6db3cbd8ef URL: https://github.com/llvm/llvm-project/commit/2d4035e493e3933e8819ee090a66fd6db3cbd8ef DIFF: https://github.com/llvm/llvm-project/commit/2d4035e493e3933e8819ee090a66fd6db3cbd8ef.diff

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

2020-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, jansvoboda11. Herald added subscribers: llvm-commits, ributzka, hiraditya. Herald added a project: LLVM. dexonsmith requested review of this revision. Add an overload of `RedirectingFileSystem::create` that builds a redire

[PATCH] D87981: [X86] AMX programming model prototype.

2020-11-11 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke updated this revision to Diff 304703. LuoYuanke added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/a

[PATCH] D90275: [clang][IR] Add support for leaf attribute

2020-11-11 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote: > gulfem wrote: > > aaron.ballman wrote: > >

[clang] cd89c4d - [NFC][coroutines] remove unused argument in SemaCoroutine

2020-11-11 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2020-11-12T13:22:20+08:00 New Revision: cd89c4dbdd3a32749f85cb3ac666b1e9e43e9c0e URL: https://github.com/llvm/llvm-project/commit/cd89c4dbdd3a32749f85cb3ac666b1e9e43e9c0e DIFF: https://github.com/llvm/llvm-project/commit/cd89c4dbdd3a32749f85cb3ac666b1e9e43e9c0e.diff LO

[PATCH] D91243: [NFC][Coroutines] Remove unused `IsImplicit` argument in maybeTailCall

2020-11-11 Thread Chuanqi Xu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcd89c4dbdd3a: [NFC][coroutines] remove unused argument in SemaCoroutine (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

2020-11-11 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

2020-11-11 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis updated this revision to Diff 304719. zinovy.nis added a comment. Fixed fix-it section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new/ https://reviews.llvm.org/D91037 Files: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp clang-tools-ex

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

2020-11-11 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 304729. kbobyrev added a comment. Use early return in FieldDecl canonicalization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/ref

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

2020-11-11 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 updated this revision to Diff 304730. LiuChen3 added a comment. Rebase. Adding the '{}' to prefix when generate IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90441/new/ https://reviews.llvm.org/D90441 Files: clang/lib/AST/Stmt.cpp

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

2020-11-11 Thread LiuChen via Phabricator via cfe-commits
LiuChen3 added inline comments. Comment at: clang/lib/AST/Stmt.cpp:801 +// since we don't support masm style prefix in backend. +if (Instruction.startswith("vex ")) + MSAsmString += '{' + Instruction.substr(0, 3).str() + '}' + From X86AsmParser, the

[PATCH] D90457: [clang][driver] Set LTO mode based on input files

2020-11-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Is the motivation just to avoid -flto or -flto=lto at link time? I am afraid that the advantage probably is not large enough to justify the potentially costly object file parsing in the driver. Before this, as I understand it, object files are opaque to the driver. The

<    1   2   3