[PATCH] D91239: Update attribute example to fit the new Annotation API

psionic12 created this revision. psionic12 added reviewers: john.brawn, aaron.ballman, Tyker, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. psionic12 requested review of this revision. Since AnnotationAttr can add extra arguments now, update Attribute plugin ex

[PATCH] D91239: Update attribute example to fit the new Annotation API

psionic12 added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:59 + +// First we have to create an `StringLiteralExpr`. +StringRef AnnotationString = "example"; `AnnotationAttr` is used as an extra information in attribute plugin desi

[PATCH] D91134: [clangd] Abort rename when given the same name

kbobyrev updated this revision to Diff 304423. kbobyrev marked an inline comment as done. kbobyrev added a comment. - Change error message to description rather than suggestion. - Move test to more appropriate location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:636 +// Filter out any reformat fixits, we don't handle these. +// FIXME: Can we? +llvm::erase_if(FixIts, in theory yes, as we have access to source manager, we can f

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll abandoned this revision. simoll added a comment. Taking this off the review queues - we will use the `ext_vector_type` attribute instead (D88905 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ ht

[PATCH] D91134: [clangd] Abort rename when given the same name

kbobyrev marked an inline comment as not done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218 +case ReasonToReject::SameName: + return "new name should differ from the old name"; } hokein wrote: > sammcc

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/call-hierarchy.test:39 +--- +{"jsonrpc":"2.0","id":2,"method":"callHierarchy/incomingCalls","params":{"item":{"data":"F0E64FE3F8FEA480","kind":12,"name":"callee","range":{"end":{"character":16,"line":0},"st

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

kadircet added inline comments. Comment at: clang-tools-extra/clangd/README.md:30 + We suggest building in RELEASE mode as building DEBUG binaries requires + considerably more resources. You can check [Building LLVM with CMake + documentation](https://llvm.org/docs/CMake.html)

[PATCH] D91134: [clangd] Abort rename when given the same name

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:780 +void func() { + int V^ar; +} Add a comment or rename `Var` =

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-branch-condition] + // CHECK-FIXES: {{^\ *

[PATCH] D91240: [clangd] Continue test adoption from Clang-Rename

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Tests can not be adopted 1:1 (e.g. Clang-Renam

[PATCH] D91134: [clangd] Abort rename when given the same name

kbobyrev updated this revision to Diff 304434. kbobyrev added a comment. Add a comment to the test to make it more explicit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91134/new/ https://reviews.llvm.org/D91134 Files: clang-tools-extra/clangd

[clang-tools-extra] 91ce6fb - [clangd] Abort rename when given the same name

Author: Kirill Bobyrev Date: 2020-11-11T11:13:47+01:00 New Revision: 91ce6fb5a65f75c1b29c898f2cb76e2c5d1ac681 URL: https://github.com/llvm/llvm-project/commit/91ce6fb5a65f75c1b29c898f2cb76e2c5d1ac681 DIFF: https://github.com/llvm/llvm-project/commit/91ce6fb5a65f75c1b29c898f2cb76e2c5d1ac681.diff

[PATCH] D91134: [clangd] Abort rename when given the same name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91ce6fb5a65f: [clangd] Abort rename when given the same name (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev abandoned this revision. kbobyrev added a comment. There are more revisions that are buggy, can't test them all :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https://reviews.llvm.org/D84232 __

[libunwind] e7b8d37 - [libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake.

Author: Daniel Kiss Date: 2020-11-11T11:21:17+01:00 New Revision: e7b8d3776f36beb9b73cd0f7c81fdc4b832b6df3 URL: https://github.com/llvm/llvm-project/commit/e7b8d3776f36beb9b73cd0f7c81fdc4b832b6df3 DIFF: https://github.com/llvm/llvm-project/commit/e7b8d3776f36beb9b73cd0f7c81fdc4b832b6df3.diff L

[clang] 454579e - Reland [Syntax] Add minimal TableGen for syntax nodes. NFC

Author: Sam McCall Date: 2020-11-11T11:24:47+01:00 New Revision: 454579e46a87b67c20504e12eadd865c8f40ccd3 URL: https://github.com/llvm/llvm-project/commit/454579e46a87b67c20504e12eadd865c8f40ccd3 DIFF: https://github.com/llvm/llvm-project/commit/454579e46a87b67c20504e12eadd865c8f40ccd3.diff LO

[PATCH] D91240: [clangd] Continue test adoption from Clang-Rename

kbobyrev updated this revision to Diff 30. kbobyrev added a comment. Check for equality with .endswith() and remove ---END--- hack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91240/new/ https://reviews.llvm.org/D91240 Files: clang-tools-ex

[PATCH] D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument

Elvina added a comment. Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I had the same issue with another PR https://reviews.llvm.org/D89972 and other people also faced it https://reviews.llvm.org/D89895 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 304447. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/c

[PATCH] D91240: [clangd] Continue test adoption from Clang-Rename

kbobyrev abandoned this revision. kbobyrev added a comment. As discussed offline, these tests are for qualified rename paths so not really useful :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91240/new/ https://reviews.llvm.org/D91240

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

sammccall marked 3 inline comments as done. sammccall added a comment. In D90543#2373962 , @eduucaldas wrote: >> Compared to Dmitri's prototype, Nodes.td looks more like a class hierarchy >> and >> less like a grammar. (E.g. variants list the Alternatives

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:636 +// Filter out any reformat fixits, we don't handle these. +// FIXME: Can we? +llvm::erase_if(FixIts, kadircet wrote: > in theory yes, as we have access to source

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. I think it should be good for merging now. I addressed all remarks. I'm still convinced that "workaround" is the proper term though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524

[clang] 77b4841 - [clang-format] do not break before @tags in JS comments

Author: Krasimir Georgiev Date: 2020-11-11T12:27:15+01:00 New Revision: 77b484116971337c9584fe101cdf1bca7f07f4dd URL: https://github.com/llvm/llvm-project/commit/77b484116971337c9584fe101cdf1bca7f07f4dd DIFF: https://github.com/llvm/llvm-project/commit/77b484116971337c9584fe101cdf1bca7f07f4dd.d

[PATCH] D91078: [clang-format] do not break before @tags in JS comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77b484116971: [clang-format] do not break before @tags in JS comments (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D91051: [clangd] Improve clangd-indexer performance

This revision was automatically updated to reflect the committed changes. Closed by commit rGdad804a193ed: [clangd] Improve clangd-indexer performance (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91051/new/ https://reviews.ll

[clang-tools-extra] dad804a - [clangd] Improve clangd-indexer performance

Author: Aleksandr Platonov Date: 2020-11-11T14:38:06+03:00 New Revision: dad804a193edf092322d80bb404fabb2f6f2c888 URL: https://github.com/llvm/llvm-project/commit/dad804a193edf092322d80bb404fabb2f6f2c888 DIFF: https://github.com/llvm/llvm-project/commit/dad804a193edf092322d80bb404fabb2f6f2c888.

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

sammccall updated this revision to Diff 304457. sammccall added a comment. Address comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90543/new/ https://reviews.llvm.org/D90543 Files: clang/include/clang/Tooling/Syntax/CMakeLists.txt

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98aa067109ed: [Syntax] Start to move trivial Node class definitions to TableGen. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo

[clang] 98aa067 - [Syntax] Start to move trivial Node class definitions to TableGen. NFC

Author: Sam McCall Date: 2020-11-11T12:39:43+01:00 New Revision: 98aa067109ed482e428bc16e1321dbe756efc57c URL: https://github.com/llvm/llvm-project/commit/98aa067109ed482e428bc16e1321dbe756efc57c DIFF: https://github.com/llvm/llvm-project/commit/98aa067109ed482e428bc16e1321dbe756efc57c.diff LO

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304463. kbobyrev added a comment. Reset unittests to HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp clan

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304464. kbobyrev added a comment. Actually reset RenameTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Still WIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 ___ cfe-commits mailing list cfe-c

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304466. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp Index

[PATCH] D82860: Port ObjCMTAction to new option parsing system

This revision was automatically updated to reflect the committed changes. Closed by commit rG09248a5d25bb: [clang][cli] Port ObjCMTAction to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new

[clang] 09248a5 - [clang][cli] Port ObjCMTAction to new option parsing system

Author: Jan Svoboda Date: 2020-11-11T13:03:02+01:00 New Revision: 09248a5d25bb1c9f357247fa3da8fbe4470e9c67 URL: https://github.com/llvm/llvm-project/commit/09248a5d25bb1c9f357247fa3da8fbe4470e9c67 DIFF: https://github.com/llvm/llvm-project/commit/09248a5d25bb1c9f357247fa3da8fbe4470e9c67.diff L

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

joechrisellis marked an inline comment as done. joechrisellis added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8563-8566 +if (const auto *BT = FirstType->getAs()) { + if (const auto *VT = SecondType->getAs()) { +if (VT->getVectorKind() == VectorTyp

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

joechrisellis updated this revision to Diff 304469. joechrisellis marked 3 inline comments as done. joechrisellis added a comment. Address @fpetrogalli's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91067/new/ https://reviews.llvm.org/D9

[PATCH] D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.

fpetrogalli updated this revision to Diff 304473. fpetrogalli added a comment. I have added more test coverage for the codegen of the examples mentioned in section 3.7.3.3 of the SVE ACLE. The tests are generic to work for `-msve-vector-bits=128|...|2048`. Repository: rG LLVM Github Monorepo

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:45 ifStmt( hasCondition(ignoringParenImpCasts(anyOf( declRefExpr(hasDeclaration(ImmutableVar)), Just noticed, as

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304477. njames93 marked 2 inline comments as done. njames93 added a comment. Removed the first loop for clangd diagnostic, turns out it didnt make the following code that much messier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:677 // If requested and possible, create a message like "change 'foo' to 'bar'". -if (SyntheticMessage && FixIts.size() == 1) { - const auto &FixIt = FixIts.front(); +if (Synth

[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

mtrofin created this revision. mtrofin added a reviewer: jhenderson. Herald added subscribers: llvm-commits, cfe-commits, frasercrmck, nikic, okura, jdoerfert, kuter, kerbowa, luismarques, apazos, sameer.abuasal, pzheng, pengfei, s.egerton, lenary, dmgreen, Jim, asbirlea, thopre, mstorsjo, jocewe

[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

mtrofin added a comment. FYI - I realize the change is enormous. I don't necessarily mean to land it as-is, we can chunk it by directories and iteratively update this as those land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91229/new/ https://

[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

jhenderson added a subscriber: RKSimon. jhenderson added a comment. Maybe one way to do this is to do what @RKSimon suggests in the D90281 , and to enable it on a per-directory basis using lit.local.cfg. That would potentially require changing the "0 or 1" occur

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

aganea updated this revision to Diff 304364. aganea edited the summary of this revision. aganea edited reviewers, added: mstorsjo; removed: reames, espindola. aganea added a comment. Simplify. Added coverage when using `clang-cl` since this is a MSVC-specific feature. When `-fdebug-compilation-dir

[PATCH] D91251: [VE] Support vector register in inline asm

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. Support a vector register constraint in inline asm of clang. Add a regression test also. Repository: rG LLVM Git

[PATCH] D91239: Update attribute example to fit the new Annotation API

Tyker added a comment. I recently made it much easier to create AnnotationAttr in this context with https://reviews.llvm.org/rGd093401a2617d3c46aaed9eeaecf877e3ae1a9f1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91239/new/ https://reviews.llvm.

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. Thank you @joechrisellis - LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91067/new/ https://reviews.llvm.org/D91067 __

[PATCH] D83071: Add support for options with two flags for controlling the same field.

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking control of this revision, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.l

[PATCH] D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.

fpetrogalli added a comment. @rengolin - thank you for looking into this. The patch has changed quite a bit since you approved it (faulty codegen for one of the macros, which I have removed from this patch). You might want to re-look at it. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] fdbc7e5 - [flang][driver] Make sure that `-###` is marked as supported (NFC)

Author: Andrzej Warzynski Date: 2020-11-11T13:12:51Z New Revision: fdbc7e505c0cb424bf629a0d6901bc6812302dcc URL: https://github.com/llvm/llvm-project/commit/fdbc7e505c0cb424bf629a0d6901bc6812302dcc DIFF: https://github.com/llvm/llvm-project/commit/fdbc7e505c0cb424bf629a0d6901bc6812302dcc.diff

[PATCH] D83071: Add support for options with two flags for controlling the same field.

jansvoboda11 updated this revision to Diff 304487. jansvoboda11 added a comment. Rebase on top of recent changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.

[PATCH] D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument

Anastasia added a comment. In D91237#2388168 , @Elvina wrote: > Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" > looks bogus. I had the same issue with another PR > https://reviews.llvm.org/D89972 and other people also faced it

[PATCH] D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91237/new/ https://reviews.llvm.org/D91237 __

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm updated this revision to Diff 304488. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89031/new/ https://reviews.llvm.org/D89031 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clan

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > gulfem wrote: > >

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

faisalv added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1837 /// Actually a FunctionDefinitionKind. - unsigned FunctionDefinition : 2; + FunctionDefinitionKind FunctionDefinition : 2; aaron.ballman wrote: > faisalv wrote: > > aaron.b

[PATCH] D83071: Add support for options with two flags for controlling the same field.

jansvoboda11 updated this revision to Diff 304491. jansvoboda11 added a comment. Apply unique_ptr workaround for older Clang versions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/c

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov updated this revision to Diff 304493. azabaznov added a comment. Addressed all concerns except replacing //__opencl_c_int64 //definition into header. The reason for this as follows: this macro should be predefined regardless if clang includes default header or not. CHANGES SINCE LAST

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske marked an inline comment as done. balazske added a comment. Maybe it is better to have this check for every system function that has non-void return value (except specific functions)? This check is applicable to CERT rule ERR33-C, POS54-C and EXP12-C too (it is restricted but can find a

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

yaxunl updated this revision to Diff 304494. yaxunl edited the summary of this revision. yaxunl added a comment. added diagnosing referencing host variable in device functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91088/new/ https://reviews.llvm.org/D91088 Files: clang/includ

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added a comment. > What did you think in mind regarding activation of features for SPIR? I don't see any difference between extensions and features in that case (at least for now), so in the latest patch x86 and spir targets will define all the features. CHANGES SINCE LAST ACTION

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1837 /// Actually a FunctionDefinitionKind. - unsigned FunctionDefinition : 2; + FunctionDefinitionKind FunctionDefinition : 2; faisalv wrote: > aaron.ballman wrote: > > f

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

t.p.northover added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2170 + SmallVector Ops; + if (TLI.getLibcallName(LC)) { +Ops.append(Node->op_begin() + 2, Node->op_end()); jyknight wrote: > t.p.northover wrote: > > I t

[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

fhahn created this revision. fhahn added reviewers: rjmccall, rsmith, Bigcheese. Herald added a subscriber: tschuett. Herald added a project: clang. fhahn requested review of this revision. The Itanium CXX ABI grammer has been extended to support parameterized vendor extended types [1]. This patc

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

c-rhodes added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3032 +The vector width is specified by +``vectorize_width(_value_[, fixed|scalable])``, where __value__ is a positive +integer and the type of vectorization can be specified with an optional ---

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3353-3371 + auto &ASTCtx = getASTContext(); + unsigned BitWidth = ASTCtx.getTypeSize(ASTCtx.getSizeType()); + llvm::APSInt Rows(BitWidth); + Rows = T->getNumRows(); + mangleIntegerLiteral(ASTCtx.getSize

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added a comment. In D91037#2387377 , @njames93 wrote: > Taking a step back, rather than worrying about if its an `ExprWithCleanups`. > Shouldn't we just get the condition removing all implicit nodes. > > const Expr* Cond = InnerIf->getCond

[PATCH] D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument

Elvina added a comment. Anastasia, thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91237/new/ https://reviews.llvm.org/D91237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG624bced7eec0: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument (authored by Elvina). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 624bced - [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument

Author: Elvina Yakubova Date: 2020-11-11T17:01:57+03:00 New Revision: 624bced7eec09a6a70f6e04faeddd0adc1553799 URL: https://github.com/llvm/llvm-project/commit/624bced7eec09a6a70f6e04faeddd0adc1553799 DIFF: https://github.com/llvm/llvm-project/commit/624bced7eec09a6a70f6e04faeddd0adc1553799.dif

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304500. kbobyrev added a comment. I think this is the first version that is ready for a review. Let me know if you have any questions, @hokein! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

SjoerdMeijer added a comment. I am very sorry that I am late to this... but I do have some concerns. The concern that I have is that we extend vecorize_width with a scalable/fixed boolean, but there are more vectorisation pragma that set vectorisation options which imply enabling vectorisation:

[clang] 3109ce5 - clang-cl: Expose -f[no-]delete-null-pointer-checks as clang-cl flag

Author: Nico Weber Date: 2020-11-11T09:19:02-05:00 New Revision: 3109ce51d465b7c6e40f855bd88776654eaf08cc URL: https://github.com/llvm/llvm-project/commit/3109ce51d465b7c6e40f855bd88776654eaf08cc DIFF: https://github.com/llvm/llvm-project/commit/3109ce51d465b7c6e40f855bd88776654eaf08cc.diff LO

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a subscriber: sdmitriev. bader added a comment. In D89909#2353931 , @Anastasia wrote: > In the RFC it has been discussed to either use target address spaces or > perhaps to introduce a new attribute to reflect a semantic needed for SYCL, > bu

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

saghir accepted this revision. saghir added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90799/new/ https://reviews.llvm.org/D90799 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Previously a corrupted index shard could

[clang] 3e5533b - [CodeGen] Remove unused check prefixes

Author: Simon Pilgrim Date: 2020-11-11T14:57:38Z New Revision: 3e5533bafdc956c3ba04acfb430a68d8c13765ce URL: https://github.com/llvm/llvm-project/commit/3e5533bafdc956c3ba04acfb430a68d8c13765ce DIFF: https://github.com/llvm/llvm-project/commit/3e5533bafdc956c3ba04acfb430a68d8c13765ce.diff LOG:

[clang] 8cb97fb - [CodeGen] Fix check prefix mismatch on neon-immediate-ubsan.c tests

Author: Simon Pilgrim Date: 2020-11-11T14:57:37Z New Revision: 8cb97fb9c9c76878afcd6678ab5311ee2766530d URL: https://github.com/llvm/llvm-project/commit/8cb97fb9c9c76878afcd6678ab5311ee2766530d DIFF: https://github.com/llvm/llvm-project/commit/8cb97fb9c9c76878afcd6678ab5311ee2766530d.diff LOG:

[PATCH] D90662: [Syntax] Tablegen operator<<(NodeKind). NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG138189ee33ab: [Syntax] Tablegen operator<<(NodeKind). NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 138189e - [Syntax] Tablegen operator<<(NodeKind). NFC

Author: Sam McCall Date: 2020-11-11T16:02:01+01:00 New Revision: 138189ee33ab4359bbda834d8715b16d096c1087 URL: https://github.com/llvm/llvm-project/commit/138189ee33ab4359bbda834d8715b16d096c1087 DIFF: https://github.com/llvm/llvm-project/commit/138189ee33ab4359bbda834d8715b16d096c1087.diff LO

[PATCH] D91261: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. OMP_MAP_TARGET_PARAM flag is used to mark the data that shoud be passed as arguments to the target kernels, noth

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

joechrisellis created this revision. joechrisellis added reviewers: fpetrogalli, peterwaller-arm, DavidTruby. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. joechrisellis requested review of this revision. T

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:29-33 +static ast_matchers::internal::Matcher +hasAnyNameStdString(std::vector Names) { + return ast_matchers::internal::Matcher( + new ast_matchers::internal::HasNa

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

joechrisellis updated this revision to Diff 304513. joechrisellis added a comment. Add tests for C-style casts to/from scalable/fixed float vector types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91262/new/ https://reviews.llvm.org/D91262 File

[PATCH] D91229: [FileCheck] Flip -allow-unused-prefixes to false by default

mtrofin added a comment. In D91229#2387923 , @jhenderson wrote: > Maybe one way to do this is to do what @RKSimon suggests in the D90281 > , and to enable it on a per-directory basis > using lit.local.cfg. That would pote

[PATCH] D90659: [Syntax] Tablegen Sequence classes. NFC

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.td:123 +Role<"CloseParen", Token<"r_paren">>, + ]; +} gribozavr2 wrote: > The reason why in my prototype the grammar rules are separate is to allow > expressing rules that

[clang] ea4d24c - [Syntax] Tablegen Sequence classes. NFC

Author: Sam McCall Date: 2020-11-11T16:29:19+01:00 New Revision: ea4d24c899ea17ee6bd4a84eff0192503c12a5b6 URL: https://github.com/llvm/llvm-project/commit/ea4d24c899ea17ee6bd4a84eff0192503c12a5b6 DIFF: https://github.com/llvm/llvm-project/commit/ea4d24c899ea17ee6bd4a84eff0192503c12a5b6.diff LO

[PATCH] D90659: [Syntax] Tablegen Sequence classes. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea4d24c899ea: [Syntax] Tablegen Sequence classes. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D90659?vs=302443&

[clang] c1e3d38 - [CodeGenOpenCL] Fix check prefix typo on convergent.cl test

Author: Simon Pilgrim Date: 2020-11-11T15:44:59Z New Revision: c1e3d38301c305357debcedbda4999335fd727cc URL: https://github.com/llvm/llvm-project/commit/c1e3d38301c305357debcedbda4999335fd727cc DIFF: https://github.com/llvm/llvm-project/commit/c1e3d38301c305357debcedbda4999335fd727cc.diff LOG:

[clang] fc80931 - [CodeGenCUDA] Fix check prefix typo on device-stub.cu tests

Author: Simon Pilgrim Date: 2020-11-11T15:44:57Z New Revision: fc80931b87661ade91502d5301ae90f06560343b URL: https://github.com/llvm/llvm-project/commit/fc80931b87661ade91502d5301ae90f06560343b DIFF: https://github.com/llvm/llvm-project/commit/fc80931b87661ade91502d5301ae90f06560343b.diff LOG:

[clang] 10fc39b - [CodeGenObjC] Remove unused check prefixes

Author: Simon Pilgrim Date: 2020-11-11T15:44:58Z New Revision: 10fc39b29171cce5629bf5da09224ae5ac33d7ed URL: https://github.com/llvm/llvm-project/commit/10fc39b29171cce5629bf5da09224ae5ac33d7ed DIFF: https://github.com/llvm/llvm-project/commit/10fc39b29171cce5629bf5da09224ae5ac33d7ed.diff LOG:

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:121 + template + LLVM_NODISCARD bool consumeSize(T &Container, unsigned MinSize = 1) { +auto Size = consumeVar(); regarding minsizes, i suppose the idea was to pas

[clang] e3b64eb - [CodeGenCXX] Remove unused check prefixes

Author: Simon Pilgrim Date: 2020-11-11T16:19:53Z New Revision: e3b64eb31c0e9a9f1ac4891b834d71532e545cad URL: https://github.com/llvm/llvm-project/commit/e3b64eb31c0e9a9f1ac4891b834d71532e545cad DIFF: https://github.com/llvm/llvm-project/commit/e3b64eb31c0e9a9f1ac4891b834d71532e545cad.diff LOG:

[PATCH] D91269: [Clang][CodeGen][RISCV] Add hard float ABI tests with empty struct

luismarques created this revision. luismarques added reviewers: asb, lenary, rjmccall, efriedma. Herald added subscribers: cfe-commits, frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-

[PATCH] D91270: [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct

luismarques created this revision. luismarques added reviewers: asb, lenary, rjmccall, efriedma. Herald added subscribers: cfe-commits, frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

fpetrogalli added inline comments. Comment at: clang/test/Sema/aarch64-sve-explicit-casts-fixed-size.cpp:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -msve-vector-bits=512 -flax-vector-conversions=none -fallow-half-arguments-and-returns -ffreestandi

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jpienaar added a comment. This seems to breaking clang-5 builds: utils/TableGen/CMakeFiles/llvm-tblgen.dir/OptParserEmitter.cpp.o: In function `llvm::EmitOptParser(llvm::RecordKeeper&, llvm::raw_ostream&)': /var/lib/buildkite-agent/builds/buildkite-69fdf6c495-wt2bd-1/mlir/mlir-core/llvm/utils/Ta

  1   2   3   >