[PATCH] D90749: [clangd] Introduce config compilation for External blocks

kadircet updated this revision to Diff 304064. kadircet marked 7 inline comments as done. kadircet added a comment. - Use ExternalBlock's range for diags. - Move diagnostic emitting to makeAbsolute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9074

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to exclude everything between 1.26.0 and 1.27.0, not set this as the minimum (Ubuntu packages are outdated). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https:/

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

hokein added a comment. thanks for doing this! Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:525 + +TEST_F(WithinFileRenameTest, Member) { + Tests = { I'm not sure about the motivation of having a separated `TEST_F`, are these tests special?

[PATCH] D91131: [clangd] Bump index version number.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. https://reviews.llvm.org/D89670 changed the Ref structure, we n

[PATCH] D91132: clang-format: [JS] support new assignment operators.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. mprobst requested review of this revision. Before: a && = b; After: a &&= b; These operators are new additions in ES2021. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D911

[PATCH] D91132: clang-format: [JS] support new assignment operators.

mprobst updated this revision to Diff 304069. mprobst added a comment. - fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91132/new/ https://reviews.llvm.org/D91132 Files: clang/lib/Format/FormatToken.h clang/lib/Format/FormatTokenLex

[clang] 16212b8 - clang-format: [JS] support new assignment operators.

Author: Martin Probst Date: 2020-11-10T09:26:46+01:00 New Revision: 16212b8b3e4fd5fbb73aecabf6f0b6fec91913d2 URL: https://github.com/llvm/llvm-project/commit/16212b8b3e4fd5fbb73aecabf6f0b6fec91913d2 DIFF: https://github.com/llvm/llvm-project/commit/16212b8b3e4fd5fbb73aecabf6f0b6fec91913d2.diff

[PATCH] D91132: clang-format: [JS] support new assignment operators.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16212b8b3e4f: clang-format: [JS] support new assignment operators. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91078: [clang-format] do not break before @tags in JS comments

mprobst added a comment. For posterity: there was a question whether this is legal syntax in JSDoc in the first place (e.g. whether it should be escaped). That remains unclear - Closure Compiler parser however does ignore JSDoc tags if the line does not start with an `@` tag. So the safe thing

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev updated this revision to Diff 304071. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve comments. Since member tests seem to be covered already, add enum and alias tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

bruno added a comment. Very nice explanation, thanks for improving this! Can you also add a AST dump test? The idea is to test for the presence of `ExprWithCleanups`s. Something along the lines of `clang/test/AST/coroutine-source-location-crash.cpp` ignoring the serialization part should be go

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks. Please update the patch description when landing it (the description is stale now). Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:95 - // rename is

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev updated this revision to Diff 304076. kbobyrev added a comment. Also add class tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91102/new/ https://reviews.llvm.org/D91102 Files: clang-tools-extra/clangd/unittests/RenameTests.cpp In

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev updated this revision to Diff 304077. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91102/new/ https://reviews.llvm.org/D91102 Files: clang-tools-ext

[clang-tools-extra] ca892f4 - [clangd] Enhance Clangd rename testing coverage

Author: Kirill Bobyrev Date: 2020-11-10T10:08:49+01:00 New Revision: ca892f46fe12288f2abe9b60faba7664713d97af URL: https://github.com/llvm/llvm-project/commit/ca892f46fe12288f2abe9b60faba7664713d97af DIFF: https://github.com/llvm/llvm-project/commit/ca892f46fe12288f2abe9b60faba7664713d97af.diff

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca892f46fe12: [clangd] Enhance Clangd rename testing coverage (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D91131: [clangd] Bump index version number.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Ah thanks, and sorry for missing it during the review :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91131/new/ https://reviews.llvm.org/D

[clang-tools-extra] 085f900 - [clangd] Update remote index documentation

Author: Kirill Bobyrev Date: 2020-11-10T10:18:38+01:00 New Revision: 085f900830e6687de54d3d6115c9517a55cc860a URL: https://github.com/llvm/llvm-project/commit/085f900830e6687de54d3d6115c9517a55cc860a DIFF: https://github.com/llvm/llvm-project/commit/085f900830e6687de54d3d6115c9517a55cc860a.diff

[PATCH] D91134: [clangd] Abort rename when given the same name

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. When user wants to rename the symbol to the sa

[clang-tools-extra] 71064b0 - [clangd] Bump index version number.

Author: Haojian Wu Date: 2020-11-10T10:31:59+01:00 New Revision: 71064b02701dd65065dd412fb01afe81ff83f746 URL: https://github.com/llvm/llvm-project/commit/71064b02701dd65065dd412fb01afe81ff83f746 DIFF: https://github.com/llvm/llvm-project/commit/71064b02701dd65065dd412fb01afe81ff83f746.diff LO

[PATCH] D91131: [clangd] Bump index version number.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71064b02701d: [clangd] Bump index version number. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:1210 + +llvm::json::Value toJSON(const CallHierarchyItem &I) { + llvm::json::Object Result{ we should also populate tags and detail conditionally. rather than providing empty stri

[PATCH] D91144: Add utility for testing if we're matching nodes AsIs

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91144 Files: clang/include/clang/ASTMatch

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire updated this revision to Diff 304103. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTNodeTraverse

[PATCH] D90984: Update matchers to be traverse-aware

steveire updated this revision to Diff 304104. steveire marked an inline comment as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90984/new/ https://reviews.llvm.org/D90984 Files: clang/include/clang/ASTMat

[PATCH] D90984: Update matchers to be traverse-aware

steveire added a comment. I added the release note to D90982 , which this change follows. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (Finder->getASTContext().getParentMapContext().getTraversalKind() != + TK_

[PATCH] D91047: Add a call super attribute plugin example

psionic12 added inline comments. Comment at: clang/docs/ClangPlugins.rst:119 + +Attribute plugin to mark a virtual method as call_super, sub-classes must call it in overridden the method. + psionic12 wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > S

[clang] defc597 - Add a llvm_unreachable to fix MSVC unhandled enum warning. NFCI.

Author: Simon Pilgrim Date: 2020-11-10T10:43:45Z New Revision: defc59734a00cc0f476f6a93c35fd0b313ed587a URL: https://github.com/llvm/llvm-project/commit/defc59734a00cc0f476f6a93c35fd0b313ed587a DIFF: https://github.com/llvm/llvm-project/commit/defc59734a00cc0f476f6a93c35fd0b313ed587a.diff LOG:

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

thakis added a comment. This breaks compillation on windows when using clang as compiler: http://45.33.8.238/win/27605/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89790/new/ https://reviews.llvm.org/D89790 ___

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D91147: AArch64: classify Triple::aarch64_32 as AArch64

t.p.northover created this revision. Herald added subscribers: dexonsmith, danielkiss, s.egerton, simoncook, hiraditya, kristof.beyls, mcrosier. Herald added a project: LLVM. t.p.northover requested review of this revision. We want `arm64_32` to omit leaf frame pointers. At the moment this is pr

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304126. njames93 added a comment. Add `isReformatFixit` method to `FixItHint` to better express intent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.org/D91103 Files: clang-

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein added a comment. In D89790#2385267 , @thakis wrote: > This breaks compillation on windows when using clang as compiler: > http://45.33.8.238/win/27605/step_4.txt sorry, looking at it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91047: Add a call super attribute plugin example

psionic12 updated this revision to Diff 304129. psionic12 added a comment. Add more detail in ClangPlugins.rst. Re-design overridden usage checking. Fix some code style issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91047/new/ https://review

[clang-tools-extra] 47fcf23 - [clangd] Fix recommended gRPC version

Author: Kirill Bobyrev Date: 2020-11-10T15:07:03+03:00 New Revision: 47fcf233ce6cb64f2f94e0747bbea1854cdb562f URL: https://github.com/llvm/llvm-project/commit/47fcf233ce6cb64f2f94e0747bbea1854cdb562f DIFF: https://github.com/llvm/llvm-project/commit/47fcf233ce6cb64f2f94e0747bbea1854cdb562f.diff

[clang-tools-extra] a97d7b9 - Fix the buildbot failure.

Author: Haojian Wu Date: 2020-11-10T13:11:54+01:00 New Revision: a97d7b9159a0178b774c20358047035f0091efb3 URL: https://github.com/llvm/llvm-project/commit/a97d7b9159a0178b774c20358047035f0091efb3 DIFF: https://github.com/llvm/llvm-project/commit/a97d7b9159a0178b774c20358047035f0091efb3.diff LO

[PATCH] D91047: Add a call super attribute plugin example

psionic12 added inline comments. Comment at: clang/examples/CallSuperAttribute/CallSuperAttrInfo.cpp:133 + PluginASTAction::ActionType getActionType() override { +return AddBeforeMainAction; + } `AddAfterMainAction` will get run after IR codes were generate

[PATCH] D91149: [clang-tidy] Fix formatting of else after return check

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Simplifies the code in the fix-it generation. Addresses https://bugs.llvm.org/show_bug.cgi?id=47809 (hopefully) By not changing the whole els

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 304136. LuoYuanke added a comment. Config palette. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/H

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 added a comment. An example of this in action is D91149 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.org/D91103 ___ cfe-commits

[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

njames93 updated this revision to Diff 304145. njames93 marked 2 inline comments as done. njames93 added a comment. Made `-fix-notes` imply `-fix` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 Files: cl

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

zahiraam added a comment. In D91089#2383433 , @hans wrote: > Please take a look. @hans Thanks for looking at this. This test case is still crashing with the patch: ksh-3.2$ cat test.cpp template class __declspec(dllexport) foo { foo(int x = 0); };

[PATCH] D91144: Add utility for testing if we're matching nodes AsIs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:195 +bool ASTMatchFinder::isTraversalAsIs() const { + return getASTContext().getParentM

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. Thanks for all your suggestions! But I don't have commit access, can anyone help me commit this with "Yang Fan " ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 _

[PATCH] D90984: Update matchers to be traverse-aware

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (Finder->getASTContext().getParentMapContext().getTraversalKind() != + TK_AsIs && steveire wrote: > aaron.ballman wrote: > > Given how often this

[PATCH] D91033: [clang-tidy][NFC] Tweak GlobList to iterate backwards

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a request to add a comment. Comment at: clang-tools-extra/clang-tidy/GlobList.cpp:56 bool GlobList::contains(StringRef S) { - bool Contains = false;

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

ilinpv created this revision. ilinpv added reviewers: jyknight, eli.friedman. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, dang, danielkiss, jfb, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. ilinpv requested review of this revision. This patch implements out o

[PATCH] D91033: [clang-tidy][NFC] Tweak GlobList to iterate backwards

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/GlobList.cpp:56 bool GlobList::contains(StringRef S) { - bool Contains = false; - for (const GlobListItem &Item : Items) { + for (const GlobListItem &Item : llvm::reverse(Items)) { if (Item.Regex.ma

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

Meinersbur updated this revision to Diff 304013. Meinersbur added a comment. Last update pushed only the change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91109/new/ https://reviews.llvm.org/D91109 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

Meinersbur created this revision. Meinersbur added a reviewer: jdoerfert. Meinersbur added a project: OpenMP. Herald added subscribers: cfe-commits, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, r

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5dba2d7e5a6: [OMPIRBuilder] Start 'Create' methods with lower case. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D91033: [clang-tidy][NFC] Tweak GlobList to iterate backwards

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/GlobList.cpp:56 bool GlobList::contains(StringRef S) { - bool Contains = false; - for (const GlobListItem &Item : Items) { + for (const GlobListItem &Item : llvm::reverse(Items)) { if (Item.Reg

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:85 // remove the inner `if`. - const auto *BinOpCond = dyn_cast(InnerIf->getCond()); + const auto *BinOpCond = dyn_cast_or_null(InnerIf->getCond()); + i

[PATCH] D91033: [clang-tidy][NFC] Tweak GlobList to iterate backwards

This revision was automatically updated to reflect the committed changes. Closed by commit rGe076fee63dd3: [clang-tidy][NFC] Tweak GlobList to iterate backwards (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D91033?vs=303725&id=304166#toc Repository: rG LLVM Github

[PATCH] D91158: Fix the DeclContextLookupResult::iterator non-copyable.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. The value_type is a const pointer, which makes the iteator non-copyable. Before the patch, the normal usage like below was illegal: auto It = lookupresult.b

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

spatel added a comment. In D87188#2348343 , @spatel wrote: > In D87188#2348326 , @nikic wrote: > >> Reopening this so we don't forget... >> >> I believe @spatel is working on the cost modelling. I did not have much

[PATCH] D91134: [clangd] Abort rename when given the same name

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218 +case ReasonToReject::SameName: + return "new name should differ from the old name"; } returning an error seems to be an interesting idea, thinking more about

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:1070 InstCombinerImpl &IC) { if (!Cmp.hasOneUse() || !isa(Cmp.getOperand(1))) return nullptr; nikic wrote: > nikic

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

t.p.northover added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6366 + // Option -moutline-atomics supported for AArch64 target only. + if (Triple.getArch() != llvm::Triple::aarch64) { +D.Diag(diag::warn_drv_moutline_atomics_unsupported_op

[PATCH] D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion.

adamcz created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. adamcz requested review of this revision. This addresses a new type of assert() crash since f7f2e4261a98b2da519d58e7f6794b013cda7a4b

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. Thanks for fixing for tests and formatting. LGTM if there are no other concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90799/new/ https://re

[PATCH] D91164: [clang-tidy] Improve C++ support in bugprone-signal-handler.

balazske created this revision. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. Herald added a project: clang. balazske requested review of this revision. Check for namespaces and lambda signal handler was added. Repository: rG LLVM Github

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao updated this revision to Diff 304181. hliao added a comment. Remove aggregate kernel argument coercion only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added a comment. One thing that's not clear to me in the patch is what the behavior should be when the user specifies that they want the POSIX set but they're compiling for a non-POSIX system like Windows. Do you have thoughts on that situation? Comment at: clan

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao updated this revision to Diff 304182. hliao added a comment. Revise the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenCU

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > gulfem wrote: > >

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

hans added a comment. > clang.exe -c test.cpp > Assertion failed: !hasUninstantiatedDefaultArg() && "Default argument is not > yet instantiated!", file > D:\IUSERS\zahiraam\llorg_ws\ws1\llvm\clang\lib\AST\Decl.cpp, line 2719 > PLEASE submit a bug report to https://bugs.llvm.org/ and include the

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

hans updated this revision to Diff 304190. hans added a comment. Handling the decl only case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91089/new/ https://reviews.llvm.org/D91089 Files: clang/include/clang/Sema/Sema.h clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/lib/Sema/SemaD

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 304189. segoon edited the summary of this revision. segoon added a comment. - add `Libc` option - improve docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/misc/CMakeL

[PATCH] D90890: Frontend: Change ComputePreambleBounds to take MemoryBufferRef, NFC

dexonsmith updated this revision to Diff 304195. dexonsmith added a comment. Missed a couple of calls from clang-tools-extra. Fixed those. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90890/new/ https://reviews.llvm.org/D90890 Files: clang-tools-extra/clangd/CodeComplete.cpp clang

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

aaron.ballman added a comment. In D77493#1962465 , @njames93 wrote: > In my mind this check is definitely in the realm of the static analyser, > clang-tidy just isn't designed for this. +1, I think this probably should be handled in the static analyzer i

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

DiggerLin added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2870 + +.. option:: -mvecnvol, -mnovecnvol + I think it should be ```.. option:: -mvecnvol, -mnovecnvol Only supported On AIX. Specify usage of volatile and nonvolatile vect

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304198. njames93 added a comment. Herald added subscribers: usaxena95, kadircet, arphaman. Teach clangd to ignore these fix-its. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.or

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. Hi Kevin, sorry for the late response. I don't think adding new tests is necessary as long as the flag is used in existing ones. Comment at: clang/inc

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 6 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); aaron.ballm

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added a comment. In D90851#2385744 , @aaron.ballman wrote: > One thing that's not clear to me in the patch is what the behavior should be > when the user specifies that they want the POSIX set but they're compiling > for a non-POSIX system like

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

lxfind added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:475 + if (!AwaitSuspend) +return Calls; if (!AwaitSuspend->getType()->isDependentType()) { bruno wrote: > In case `AwaitSuspend` is null, is there any need to set `Calls.IsInvalid`

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

fpetrogalli added a comment. Hi @joechrisellis - thank you for this patch! I have left a couple of comments. Francesco Comment at: clang/lib/AST/ASTContext.cpp:8563-8566 +if (const auto *BT = FirstType->getAs()) { + if (const auto *VT = SecondType->getAs()) { +

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

lxfind added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:475 + if (!AwaitSuspend) +return Calls; if (!AwaitSuspend->getType()->isDependentType()) { lxfind wrote: > bruno wrote: > > In case `AwaitSuspend` is null, is there any need to set

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.h:25 public: + enum class AsyncSafeFunctionSetType { Minimal, POSIX }; + balazske wrote: > aaron.ballman wrote: > > I don't think this needs to be public?

[PATCH] D90890: Frontend: Change ComputePreambleBounds to take MemoryBufferRef, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90890/new/ https://reviews.llvm.org/D90890 ___ cfe-commits mailing list cfe

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); Xiangling_L wrote: > aaron.ballman wrote: > > There's a

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

zahiraam added a comment. In D91089#2385821 , @hans wrote: >> clang.exe -c test.cpp >> Assertion failed: !hasUninstantiatedDefaultArg() && "Default argument is not >> yet instantiated!", file >> D:\IUSERS\zahiraam\llorg_ws\ws1\llvm\clang\lib\AST\Decl.cpp

[PATCH] D82860: Port ObjCMTAction to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 ___ cfe-commits mailing list cfe-comm

[PATCH] D91158: Fix the DeclContextLookupResult::iterator non-copyable.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DeclBase.h:1249 llvm::iterator_adaptor_base; + std::random_access_iterator_tag, NamedDec

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

lxfind updated this revision to Diff 304233. lxfind added a comment. Add AST test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90990/new/ https://reviews.llvm.org/D90990 Files: clang/lib/Sema/SemaCoroutine.cpp clang/test/AST/Inputs/std-corout

[PATCH] D90928: [OpenCL] Add assertions to extension lookup

Anastasia added a comment. In D90928#2382111 , @erik2020 wrote: > In D90928#2379322 , @Anastasia wrote: > >> Ok, it would still segfault but perhaps it is acceptable as this is an >> internal frontend only option f

[PATCH] D91184: [clang-tidy] Merge options inplace instead of copying

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Changed `ClangTidyOptions::mergeWith` to operate on the instance instead of ret

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

ille added inline comments. Comment at: clang/lib/AST/Decl.cpp:2491 +bool VarDecl::isCapturedByOwnInit() const { + return hasAttr() && NonParmVarDeclBits.CapturedByOwnInit; +} rjmccall wrote: > You should check `isEscapingByref()` here rather than just `hasAttr`

[PATCH] D91134: [clangd] Abort rename when given the same name

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218 +case ReasonToReject::SameName: + return "new name should differ from the old name"; } hokein wrote: > returning an error seems to be an interesting idea,

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis updated this revision to Diff 304242. zinovy.nis marked 2 inline comments as done. zinovy.nis added a comment. *iterator -> getSubExpr() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new/ https://reviews.llvm.org/D91037 Files: clang-tools-extra/clang-tidy/bugprone/Re

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis marked an inline comment as done and 2 inline comments as not done. zinovy.nis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:85 // remove the inner `if`. - const auto *BinOpCond = dyn_cast(InnerIf->getCo

[clang] 58c586e - Allow searching for prebuilt implicit modules.

Author: Alexandre Rames Date: 2020-11-10T10:14:13-08:00 New Revision: 58c586e701889250c08285193dc75d94a7ed302d URL: https://github.com/llvm/llvm-project/commit/58c586e701889250c08285193dc75d94a7ed302d DIFF: https://github.com/llvm/llvm-project/commit/58c586e701889250c08285193dc75d94a7ed302d.dif

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Adds minimal cmake configuration required t

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:85 // remove the inner `if`. - const auto *BinOpCond = dyn_cast(InnerIf->getCond()); + const auto *BinOpCond = dyn_cast_or_null(InnerIf->getCond()); + i

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); aaron.ballm

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90990/new/ https://reviews.llvm.org/D90990 ___ cfe

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); Xiangling_L wrote: > aaron.ballman wrote: > > Xiangling

[PATCH] D91134: [clangd] Abort rename when given the same name

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218 +case ReasonToReject::SameName: + return "new name should differ from the old name"; } sammccall wrote: > hokein wrote: > > returning an error seems to be an

[PATCH] D91051: [clangd] Improve clangd-indexer performance

ArcsinX updated this revision to Diff 304262. ArcsinX added a comment. Don't check that `AbsPath` is not in `Files` twice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91051/new/ https://reviews.llvm.org/D91051 Files: clang-tools-extra/clangd/i

  1   2   >