[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

rnk added a comment. Given that only three tests fail when the `nossp` attribute gets added from `-cc1` with no stack protector, I think it's reasonable to add it and skip adding the extra enum. I think it would be weird if we LTO'd together three kinds of objects (sp on, sp off, sp unspecifie

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

dreachem updated this revision to Diff 303258. dreachem added a comment. Marking the "begin/end declare variant" feature as 'done' in the 5.1 table. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90802/new/ https://reviews.llvm.org/D90802 Files: clang/docs/OpenMPSupport.rst Index: cl

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. In D90809#2377221 , @hliao wrote: > In D90809#2377083 , @rampitec wrote: > >> In D90809#2376994

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

dreachem added a comment. I don't have commit access. @jdoerfert, please commit the change if you think it's ready. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90802/new/ https://reviews.llvm.org/D90802 ___ cfe-commits mailing list

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added a comment. Having looked a bit more at the callers here, I think the pattern we're going to want is: - everywhere that prints a template argument list also asks for a list of corresponding template parameters - if the list of template parameters is unknown (perhaps because the temp

[PATCH] D90885: Tooling: Remove dead code for ToolingInvocation::mapVirtualFile

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Follows through on c4cb3b10dc8c50e46c9fb1b7ae95e3c3c94975d3's FIXME from 2015. Anyone using this should migrate to InMemoryFileS

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. As part of reducing use of PreprocessorOptions::RemappedFileBuffers, stop abusing it to pass information around remapped files i

[PATCH] D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. `ASTUnit::Parse` sets up the `FileManager` earlier in the same function, ensuring `ASTUnit::getFileManager()` matches `Clang->get

[PATCH] D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

dexonsmith added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:1135-1141 // Ensure that Clang has a FileManager with the right VFS, which may have // changed above in AddImplicitPreamble. If VFS is nullptr, rely on // createFileManager to create one. if

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. In D90714#2377231 , @mibintc wrote: > I'm sorry, I don't see how to build up an identifier with an arbitrary number > of characters using the token pasting, for example an ident with 4095 > characters is not a power of 2. I trie

[PATCH] D90889: Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This parameter is always set to `None`. Remove it. https://reviews.llvm.org/D90889 Files: clang/include/clang/Frontend/ASTUn

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

dblaikie added a comment. In D90719#2377324 , @rnk wrote: > I had another thought, which is that even if it is UB, perhaps we really > shouldn't be using UB as the basis for debug info emission. All programs have > bugs, and most bugs invoke some form of

[PATCH] D90890: Frontend: Change ComputePreambleBounds to take MemoryBufferRef, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added subscribers: usaxena95, ributzka, kadircet. dexonsmith requested review of this revision. Avoid requiring an actual MemoryBuffer in ComputePreambleBounds, when a MemoryBufferRef will do just fine.

[PATCH] D90891: [clang] ns_error_domain attribute also supports CFString typed variables

arphaman created this revision. arphaman added reviewers: erik.pilkington, MForster. Herald added subscribers: ributzka, jkorous. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. The change in a5b8757506b07e3091fe243b6c1e004220d3cba3

[PATCH] D90763: Traverse-ignore explicit template instantiations

steveire updated this revision to Diff 303268. steveire added a comment. Uppate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90763/new/ https://reviews.llvm.org/D90763 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/ASTM

[PATCH] D90763: Traverse-ignore explicit template instantiations

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: clang/unittests/AST/ASTTraverserTest.cpp:1092 + +// Explicit instantiation of template functions do not appear in the AST +template float timesTwo(float); aaron.ballman wrote:

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added a comment. @thakis, thanks for the heads up, I've disabled the test on Windows - I should've disabled it on Windows in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 __

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, yusra.syeda, aaron.ballman, sfertile, hfinkel. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. Support __attribute__((constructor

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

dblaikie added a comment. Thanks for taking a look at this! Comment at: clang/test/Sema/implicit-decl.c:2 +// RUN: %clang_cc1 %s -verify=expected,implicit -fsyntax-only -Werror=implicit-function-declaration +// RUN: %clang_cc1 %s -verify -fsyntax-only -Wno-implicit-function-de

[PATCH] D90763: Traverse-ignore explicit template instantiations

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:506 +if (const auto *CTSD = Node.get()) { + auto SK = CTSD->getSpecializationKind(); + if (SK == TSK_ExplicitInstantiationDeclaration || aaron.ballman wrote: > Same

[PATCH] D90767: Add new matchers for dependent names in templates

steveire updated this revision to Diff 303271. steveire marked an inline comment as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90767/new/ https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersR

[PATCH] D90767: Add new matchers for dependent names in templates

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} aaron.ballman wrote: > This will allow us

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 303272. Xiangling_L added a comment. Remove unused function parameters; Move testcases to CodeGenCXX folder; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp cla

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay added inline comments. Comment at: clang/test/Sema/implicit-decl.c:2 +// RUN: %clang_cc1 %s -verify=expected,implicit -fsyntax-only -Werror=implicit-function-declaration +// RUN: %clang_cc1 %s -verify -fsyntax-only -Wno-implicit-function-declaration + db

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay updated this revision to Diff 303273. MaskRay added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90874/new/ https://reviews.llvm.org/D90874 Files: clang/test/Modules/diagnose-missing-import.m clang/test/Sema/implic

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay updated this revision to Diff 303277. MaskRay added a comment. Discard an unintentional change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90874/new/ https://reviews.llvm.org/D90874 Files: clang/test/Modules/diagnose-missing-import.m

[PATCH] D68997: Allow searching for prebuilt implicit modules.

stella.stamenova added a comment. This change broke the windows lldb bot: http://lab.llvm.org:8011/#/builders/83/builds/570 Can you please fix this or revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D6899

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

nickdesaulniers added a comment. In D90194#2377337 , @rnk wrote: > Given that only three tests fail when the `nossp` attribute gets added from > `-cc1` with no stack protector, I think it's reasonable to add it and skip > adding the extra enum. Sorry, w

[clang] 23c6d15 - [amdgpu] Add `llvm.amdgcn.endpgm` support.

Author: Michael Liao Date: 2020-11-05T19:06:50-05:00 New Revision: 23c6d1501d80073784cab367d30d50419ffa5706 URL: https://github.com/llvm/llvm-project/commit/23c6d1501d80073784cab367d30d50419ffa5706 DIFF: https://github.com/llvm/llvm-project/commit/23c6d1501d80073784cab367d30d50419ffa5706.diff

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23c6d1501d80: [amdgpu] Add `llvm.amdgcn.endpgm` support. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Bigcheese accepted this revision. Bigcheese added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] 4fcdfc4 - [AMDGPU] Simplify amdgpu-macros.cl test. NFC.

Author: Stanislav Mekhanoshin Date: 2020-11-05T16:29:16-08:00 New Revision: 4fcdfc4398bdf9295cd0259d6416a7dc1d2da47f URL: https://github.com/llvm/llvm-project/commit/4fcdfc4398bdf9295cd0259d6416a7dc1d2da47f DIFF: https://github.com/llvm/llvm-project/commit/4fcdfc4398bdf9295cd0259d6416a7dc1d2da4

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. In D90719#2377485 , @dblaikie wrote: > In D90719#2377324 , @rnk wrote: > >> I had another thought, which is that even if it is UB, perhaps we really >> shouldn't be using UB as the basis fo

[clang] c67656b - Revert "Allow searching for prebuilt implicit modules."

Author: Stella Stamenova Date: 2020-11-05T17:16:14-08:00 New Revision: c67656b994c87224e0b33e2c4b09093986a5cfa6 URL: https://github.com/llvm/llvm-project/commit/c67656b994c87224e0b33e2c4b09093986a5cfa6 DIFF: https://github.com/llvm/llvm-project/commit/c67656b994c87224e0b33e2c4b09093986a5cfa6.di

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 303303. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D90896: [Clang][Driver] default to nossp

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, rnk. Herald added subscribers: cfe-commits, jdoerfert, atanasyan, jrtc27, kbarton, nemanjai. Herald added a project: clang. nickdesaulniers requested review of this revision. This patch does 2 things: 1. the default va

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

nickdesaulniers added a comment. D90896 is the alternative solution that doesn't add any new enumeration values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90194/new/ https://reviews.llvm.org/D90194 __

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

dblaikie added inline comments. Comment at: clang/test/Sema/vecshift.c:3-4 +// RUN: %clang_cc1 -fsyntax-only -DEXT -DERR -verify=expected,vecelemsize %s +// RUN: %clang_cc1 -fsyntax-only -DERR -verify %s -Wno-vec-elem-size +// RUN: %clang_cc1 -fsyntax-only -DEXT -DERR -verify %s

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay updated this revision to Diff 303310. MaskRay added a comment. Fix vecshift.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90874/new/ https://reviews.llvm.org/D90874 Files: clang/test/Modules/diagnose-missing-import.m clang/test/Sema/

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/test/Sema/vecshift.c:3-4 +// RUN: %clang_cc1 -fsyntax-only -DEXT -DERR -verify=expected,vecelemsize %s +// RUN: %clang_cc1 -fsyntax-only -DERR -verify %s -Wno-vec-elem-size +// RUN: %clang_

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

rsmith added a comment. Perhaps we could address both the UB and the debug info homing issue by adding a new attribute on the libc++ types that says it's valid to create an instance of the type without calling a constructor? (If we want to support old libc++ with trunk clang, we could detect th

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90874/new/ https://reviews.llvm.org/D90874 _

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

NoQ added a comment. Everything looks good to me here. The new-expression `new int;` has 1 implicit argument (allocation size passed to the implementation of operator new, the value is probably 4) and 0 placement arguments (the ones that are explicitly written down after `new` and before `int`)

[PATCH] D90754: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90754/new/ https://reviews.llvm.org/D90754 ___

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

dblaikie added a comment. In D90719#2377883 , @rsmith wrote: > Perhaps we could address both the UB and the debug info homing issue by > adding a new attribute on the libc++ types that says it's valid to create an > instance of the type without calling a

[clang] 247c5b5 - [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

Author: Fangrui Song Date: 2020-11-05T20:08:23-08:00 New Revision: 247c5b5d69631c9f5fce9bf914f09f84e5cf8232 URL: https://github.com/llvm/llvm-project/commit/247c5b5d69631c9f5fce9bf914f09f84e5cf8232 DIFF: https://github.com/llvm/llvm-project/commit/247c5b5d69631c9f5fce9bf914f09f84e5cf8232.diff

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG247c5b5d6963: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size (authored by MaskRay). Repository: rG LLVM Github Mon

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

pengfei accepted this revision. pengfei added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D90507: Adding DWARF64 clang flag

ikudrin added a comment. 1. The patch needs tests to check the added functionality. 2. DWARF64 can be generated only for a limited number of targets. There should be diagnostics for invalid switch combinations to prevent misuse. @MaskRay mentioned that in the patch for `llc`, D87011#2254749

<    1   2