[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

pengfei added inline comments. Comment at: clang/lib/Headers/gfniintrin.h:24 +#ifdef __AVXINTRIN_H +#ifdef __AVX512BWINTRIN_H +#ifdef __AVX512VLINTRIN_H `__AVX512VLBWINTRIN_H` is better. Comment at: clang/lib/Headers/gfniintrin.h:52 U,

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

Elvina added a comment. @SjoerdMeijer thanks for the review! @bryanpkc does everything look fine? Can I commit it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89972/new/ https://reviews.llvm.org/D89972 ___ cfe-commits mailing list cfe-comm

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Add IgnoreMainLikeFunctions to the per file config. This can be extended for ne

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

t.p.northover added a comment. With current CodeGen by the time you reach the trap you have no idea what came before so I think you'd still need a separate trap instruction per failure kind. So the Clang and generic LLVM side would be unaffected. I suppose on X86 it could save a few bytes in .t

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

t.p.northover marked an inline comment as done. t.p.northover added a comment. > Was this measured with all of -fsanitize=undefined enabled? If so, the actual > size overhead is likely lower, as only a subset of these checks get enabled > in production settings. Yes, I used `-fsanitize=undefine

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23657d9cc332: [SyntaxTree] Add reverse links to syntax Nodes. (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 23657d9 - [SyntaxTree] Add reverse links to syntax Nodes.

Author: Eduardo Caldas Date: 2020-11-05T09:33:53Z New Revision: 23657d9cc33282208bdac074abccd73bd4d4f8be URL: https://github.com/llvm/llvm-project/commit/23657d9cc33282208bdac074abccd73bd4d4f8be DIFF: https://github.com/llvm/llvm-project/commit/23657d9cc33282208bdac074abccd73bd4d4f8be.diff LOG

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: alexfh, njames93, thakis. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: kbarton, xazax.hun, nemanjai. DmitryPolukhin requested review of this revision. This diff is an attempt to workaround a

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe updated this revision to Diff 303073. FreddyYe added a comment. Reorganize intrinsic orders to avoid using nested macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 Files: clang/lib/Headers/

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

pengfei added inline comments. Comment at: clang/lib/Headers/gfniintrin.h:104-111 #define _mm512_mask_gf2p8affineinv_epi64_epi8(S, U, A, B, I) \ (__m512i)__builtin_ia32_selectb_512((__mmask64)(U), \ (__v64qi)_mm512_gf2p8affineinv_epi64_ep

[PATCH] D90766: [OpenCL] Support vec_step in C++ for OpenCL mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac9bcc746b9: [OpenCL] Support vec_step in C++ for OpenCL mode (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90766/new/ https://review

[clang] 8ac9bcc - [OpenCL] Support vec_step in C++ for OpenCL mode

Author: Sven van Haastregt Date: 2020-11-05T12:02:59Z New Revision: 8ac9bcc746b9bb4b0ccdd71c6cbeda3b406e7b46 URL: https://github.com/llvm/llvm-project/commit/8ac9bcc746b9bb4b0ccdd71c6cbeda3b406e7b46 DIFF: https://github.com/llvm/llvm-project/commit/8ac9bcc746b9bb4b0ccdd71c6cbeda3b406e7b46.diff

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

gbencze updated this revision to Diff 303082. gbencze added a comment. Herald added a subscriber: mgrang. Sorry for the slow update on this. I fixed the behavior when reusing tail padding as mentioned by @rsmith and took a shot at unifying the code paths for base classes and fields. Let me know

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

gbencze added inline comments. Comment at: clang/test/SemaCXX/has_unique_object_reps_no_unique_addr.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -verify -std=c++2a %s +// expected-no-diagnostics Just to be sure: is the specifying the t

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm added a comment. I'll hold off on any more changes for now to give @fhahn a chance to reply to your comment @sdesmalen about the fallback behaviour when scalable vectorisation is unsupported. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:939 +def warn

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe marked 3 inline comments as done. FreddyYe added inline comments. Comment at: clang/lib/Headers/gfniintrin.h:131-138 #define _mm512_mask_gf2p8affine_epi64_epi8(S, U, A, B, I) \ (__m512i)__builtin_ia32_selectb_512((__mmask64)(U), \

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

ilya-golovenko added a comment. It is also possible to force MSVC to treat a certain source code files as UTF-8 by adding the following pragma to the beginning of the file: #ifdef _MSVC_VER #pragma execution_character_set("utf-8"); #endif Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

FreddyYe updated this revision to Diff 303087. FreddyYe marked an inline comment as done. FreddyYe added a comment. Refine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 Files: clang/lib/Headers/gfniintr

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

aaron.ballman added a comment. In D90180#2374839 , @nickdesaulniers wrote: > In D90180#2357247 , @aaron.ballman > wrote: > >> When you pass `-fix` to clang-tidy, it will apply fix-its from the compiler >> as well

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > gulfem wrote: > >

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc added a comment. In D90714#2374913 , @dblaikie wrote: > Since the same code is used to mangle all these things, probably just test > one of them? > > Could use macros to stamp out longer names without having to write them out > manually? Not sur

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas updated this revision to Diff 303091. pratlucas added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90765/new/ https://reviews.llvm.org/D90765 Files: clang/test/Driver/aarch64-cpus.c clang/test/Driver/

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

aaron.ballman added a comment. Is there a way to test this functionality out? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90832/new/ https://reviews.llvm.org/D90832 ___ cfe-commits mailing list cfe-com

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

aqjune added a comment. Herald added a subscriber: frasercrmck. In D82317#2201215 , @rjmccall wrote: > second, it's yet another contribution towards the giant pile of attributes > that seem to have become necessary to do any work in LLVM I don't think th

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

njames93 added a comment. In D90832#2375934 , @aaron.ballman wrote: > Is there a way to test this functionality out? There's already tests for loading the individual styles from other files, I'm sure I could extend that Repository: rG LLVM Github Mo

[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

hans created this revision. hans added a reviewer: rnk. Herald added a project: clang. hans requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90849 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport.cpp Index: clang/test/C

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

aaron.ballman added a comment. In D90832#2376009 , @njames93 wrote: > In D90832#2375934 , @aaron.ballman > wrote: > >> Is there a way to test this functionality out? > > There's already tests for loading the indivi

[clang] 659f4bd - [clang] Add an option for hiding line numbers in diagnostics

Author: Raphael Isemann Date: 2020-11-05T16:10:18+01:00 New Revision: 659f4bd87efc7cae379aa128814e03fc8b006471 URL: https://github.com/llvm/llvm-project/commit/659f4bd87efc7cae379aa128814e03fc8b006471 DIFF: https://github.com/llvm/llvm-project/commit/659f4bd87efc7cae379aa128814e03fc8b006471.dif

[PATCH] D83038: [clang] Add an option for hiding line numbers in diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG659f4bd87efc: [clang] Add an option for hiding line numbers in diagnostics (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mono

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

dreachem added inline comments. Comment at: clang/docs/OpenMPSupport.rst:343 ++--+--+--+---+ +| misc

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske created this revision. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. Herald added a project: clang. balazske requested review of this revision. An option is added to the check to select wich set of functions is defined as asynchronou

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-handler.rst:31 + is not included). Default is ``POSIX``. \ No newline at end of file Please add newline. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added a comment. @rjmccall ping. Any further concerns for this patch? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b104ea4b463: Implement Lambda Conversion Operators for All CCs for MSVC. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 6b104ea - Implement Lambda Conversion Operators for All CCs for MSVC.

Author: Erich Keane Date: 2020-11-05T07:25:44-08:00 New Revision: 6b104ea4b4630c2fa841c6d5f7c7a69b08d31979 URL: https://github.com/llvm/llvm-project/commit/6b104ea4b4630c2fa841c6d5f7c7a69b08d31979 DIFF: https://github.com/llvm/llvm-project/commit/6b104ea4b4630c2fa841c6d5f7c7a69b08d31979.diff L

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

njames93 added a comment. Didn't mean for there to be any formatting changes. I'll remove those later too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90832/new/ https://reviews.llvm.org/D90832 ___ cfe-

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 303121. DmitryPolukhin added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/new/ https://reviews.llvm.org/D90835 Files: clang-tools-extra/clang-tidy/ClangTidyDia

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. I guess targets like SPIR will be supporting all features by default? At this point, I would prefer that we only add the features that affect the parsing directly i.e. used in the clang source code. FYI I think we need to explain the common design of features and exte

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. PS I think it's better to move both test files to SemaOpenCL folder as they are not related to common parsing but OpenCL specifically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89869/new/ https://reviews.llvm.org/D89869 __

Re: [PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

@hans they are ignored because Clang behaves like MSVC with these options enabled (C++ standard conformance mode) On Wed, Nov 4, 2020, 16:03 Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added a comment. > > I'm not sure ignoring these is the right thing to do. Maybe th

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

jan-wassenberg added a comment. @nik here's an unusual but real-world example that triggers this. https://github.com/google/highway compiles the same source multiple times (with different macros set) for generating code for multiple SIMD instruction sets. The main source file sets a macro to its

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

bsaleil updated this revision to Diff 303132. bsaleil added a comment. Add support for the paired load/store intrinsics in `PPCLoopInstrFormPrep` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90799/new/ https://reviews.llvm.org/D90799 Files: cla

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:154-155 +AARCH64_CPU_NAME("neoverse-v1", ARMV8_4A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_RAS | AArch64::AEK_SVE | AArch64::AEK_SSBS | + AArch64:

[PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

hans added a comment. In D87372#2376305 , @ki.stfu wrote: > @hans they are ignored because Clang behaves like MSVC with these options > enabled (C++ standard conformance mode) Ah, I got it backwards. Yeah, ignoring these makes sense. Can you add the vari

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

rnk added a comment. In D90719#2372656 , @dblaikie wrote: > My understanding is that such code is UB, is that right? I guess I'm not convinced it's UB, and need some language lawyering help to decide. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

rnk added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5887-5915 if (MD->isUserProvided()) { // Instantiate non-default class member functions ... // .. except for certain kinds of template specializations. if (TSK == TSK_Implici

[clang-tools-extra] f253823 - [clangd] Trivial: Log missing completion signals.

Author: Utkarsh Saxena Date: 2020-11-05T18:52:44+01:00 New Revision: f253823398dd2894ee5d9333c541c534b7a407fb URL: https://github.com/llvm/llvm-project/commit/f253823398dd2894ee5d9333c541c534b7a407fb DIFF: https://github.com/llvm/llvm-project/commit/f253823398dd2894ee5d9333c541c534b7a407fb.diff

[PATCH] D90828: [clangd] Trivial: Log missing completion signals.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf253823398dd: [clangd] Trivial: Log missing completion signals. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

bsaleil updated this revision to Diff 303152. bsaleil added a comment. Rebase patch and add Sema check test case for the builtins Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90799/new/ https://reviews.llvm.org/D90799 Files: clang/include/clang

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 _

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1581 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrNoMem, IntrHasSideEffects] +>; Mayby also IntrCold? Repository: r

[clang] c6a384d - [Sema] Special case -Werror-implicit-function-declaration and reject other -Werror-

Author: Fangrui Song Date: 2020-11-05T10:25:30-08:00 New Revision: c6a384df1f8ab85815160297543ab329e02560ef URL: https://github.com/llvm/llvm-project/commit/c6a384df1f8ab85815160297543ab329e02560ef DIFF: https://github.com/llvm/llvm-project/commit/c6a384df1f8ab85815160297543ab329e02560ef.diff

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I think the test case looks good as is, FWIW. Token pasting might make it more readable, but it's improving the existing test, and not necessarily in scope for this patch. Repository: rG L

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

dblaikie added a comment. In D90719#2376388 , @rnk wrote: > In D90719#2372656 , @dblaikie wrote: > >> My understanding is that such code is UB, is that right? > > I guess I'm not convinced it's UB, and need some lan

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

dblaikie added a comment. How's this compare to the similar checks for variable templates? Is there some code/checking we could share here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 _

[clang] 82f86ae - APINotes: add APINotesYAMLCompiler

Author: Saleem Abdulrasool Date: 2020-11-05T18:55:13Z New Revision: 82f86ae01a54ff8e3a5aaefd24745ef2b7b917ba URL: https://github.com/llvm/llvm-project/commit/82f86ae01a54ff8e3a5aaefd24745ef2b7b917ba DIFF: https://github.com/llvm/llvm-project/commit/82f86ae01a54ff8e3a5aaefd24745ef2b7b917ba.diff

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82f86ae01a54: APINotes: add APINotesYAMLCompiler (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D88859?vs=302298&id=303

[clang] b69af88 - [gn build] (manually) port 82f86ae01

Author: Nico Weber Date: 2020-11-05T14:11:26-05:00 New Revision: b69af88481aa88e04ff4490dc8d420ec570ec0f1 URL: https://github.com/llvm/llvm-project/commit/b69af88481aa88e04ff4490dc8d420ec570ec0f1 DIFF: https://github.com/llvm/llvm-project/commit/b69af88481aa88e04ff4490dc8d420ec570ec0f1.diff LO

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

njames93 updated this revision to Diff 303198. njames93 added a comment. Herald added a subscriber: aheejin. Removed unnecessary formatting changes Added test cases. With the test cases I removed some cases that actually were never tested due to the order in which clang-tidy handles applying con

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 303200. gulfem added a comment. Remove direct from description and ObjCMethod for Obj functionality Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files: clang/includ

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. In D90714#2375911 , @mibintc wrote: > In D90714#2374913 , @dblaikie wrote: > >> Since the same code is used to mangle all these things, probably just test >> one of them? >> >> Could use m

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some tiny nits! Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:172 SmallString<64> StyleString; + auto Styl

[PATCH] D90870: [NFC][NewPM] Reuse PassBuilder callbacks with -O0

aeubanks created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks requested review of this revision. This removes lots of duplicated code which was necessary before https://reviews.llvm.org/D89158. Mostly sanitizer stuff. Repository: rG LLVM Github

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem marked an inline comment as done. gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote: > gu

[PATCH] D90870: [NFC][NewPM] Reuse PassBuilder callbacks with -O0

aeubanks updated this revision to Diff 303207. aeubanks added a comment. small cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90870/new/ https://reviews.llvm.org/D90870 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clang/lib/CodeGen/B

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. In D90714#2376667 , @rnk wrote: > lgtm > > I think the test case looks good as is, FWIW. Token pasting might make it > more readable, but it's improving the existing test, and not necessarily in > scope for this patch. Oh, sorr

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 303209. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

rjmccall added a comment. Okay. It sounds like strict compatibility with GCC implies ignoring pragmas in fast, and that's what we're most concerned with, since this is originally a GCC option. So the only question I have now is whether `faststd` is the best name for this. Does anyone want to

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2838 +/// Matches template-dependent, but known, member names +/// Missing full stop at the end of the comment. Comment at: clang/include/clang/AST

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b9b90a1914f: [clang-tidy] Extend IdentifierNamingCheck per file config (authored by njames93). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao updated this revision to Diff 303213. hliao added a comment. Add `IntrCold`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/ https://reviews.llvm.org/D90809 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/test/CodeGenC

[clang-tools-extra] 3b9b90a - [clang-tidy] Extend IdentifierNamingCheck per file config

Author: Nathan James Date: 2020-11-05T19:51:05Z New Revision: 3b9b90a1914f1e470ba7d333b26bd34787337806 URL: https://github.com/llvm/llvm-project/commit/3b9b90a1914f1e470ba7d333b26bd34787337806 DIFF: https://github.com/llvm/llvm-project/commit/3b9b90a1914f1e470ba7d333b26bd34787337806.diff LOG:

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao marked an inline comment as done. hliao added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1581 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrNoMem, IntrHasSideEffects] +>; r

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall, arphaman. Herald added subscribers: ributzka, jkorous. erik.pilkington requested review of this revision. D89523 removed support for promoting VLAs to constant arrays when t

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

thakis added a comment. Looks like the test doesn't pass on Windows: http://45.33.8.238/win/27342/step_7.txt Please take a look, and revert if it takes a while to fix. Here's the output of the diff on that Win bot: thakis@thakis6-w MINGW64 /c/src/llvm-project (merge) $ diff --strip-trailin

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

b-sumner added a comment. Should this also be IntrConvergent? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/ https://reviews.llvm.org/D90809 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Nov 4, 2020 at 9:07 PM Fāng-ruì Sòng wrote: > > It is rare to report an error in BackendUtil.cpp . So I checked the > other Diags.Report instance and noticed that -split-dwarf-file a.dwo > -split-dwarf-output a.dwo (when a.dwo is not writable) suppresses the > output. So there is no reason

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

kernigh added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4723 + bool isInt = Ty->isIntegerType() || Ty->hasPointerRepresentation() || + Ty->isAggregateType(); bool isF64 = Ty->isFloatingType() && getContext().getTypeSize(Ty) == 64; ---

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > gulfem wrote: > >

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay created this revision. MaskRay added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90874 Files: clang/test/Modules/diagnose-missing-

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec added a comment. In D90809#2376994 , @b-sumner wrote: > Should this also be IntrConvergent? Probably yes... This is control flow after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames marked an inline comment as done. arames added a comment. Fixed the trailing whitespace. I also just got commit rights, so I will commit it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 __

[clang] 1af037f - [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

Author: Albion Fung Date: 2020-11-05T15:35:14-05:00 New Revision: 1af037f643fc5499f83d92e5aec199950871d475 URL: https://github.com/llvm/llvm-project/commit/1af037f643fc5499f83d92e5aec199950871d475 DIFF: https://github.com/llvm/llvm-project/commit/1af037f643fc5499f83d92e5aec199950871d475.diff L

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

Yes, that's right. I think most errors are caught in Sema. There "if there is an error, the output should be suppressed" should be a consensus. For some auxiliary files it was a bit fuzzy to me. So I checked .dwo which is a similar auxiliary output - the output is suppressed with an error - so it b

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG1af037f643fc: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:249-251 + if (!HeaderFilter) +HeaderFilter = +std::make_unique(*getOptions().HeaderFilterRegex); This should also check if the Optional has a val

[PATCH] D90763: Traverse-ignore explicit template instantiations

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:503 TraversalKind Traversal, BindKind Bind) { +auto ScopedTraversal = TraversingTemplateInstantiationNotSpelledInSource; + Please spell this t

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e7dca5ca92: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C… (authored by j0le, committed by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] d2e7dca - [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

Author: Jan Ole Hüser Date: 2020-11-05T12:57:17-08:00 New Revision: d2e7dca5ca92c655e451d6fcb806df38d7f2d56b URL: https://github.com/llvm/llvm-project/commit/d2e7dca5ca92c655e451d6fcb806df38d7f2d56b DIFF: https://github.com/llvm/llvm-project/commit/d2e7dca5ca92c655e451d6fcb806df38d7f2d56b.diff

[clang] 71e108c - Allow searching for prebuilt implicit modules.

Author: Alexandre Rames Date: 2020-11-05T13:10:53-08:00 New Revision: 71e108cd86e70b06c5fa3a63689dcb3555c3d13f URL: https://github.com/llvm/llvm-project/commit/71e108cd86e70b06c5fa3a63689dcb3555c3d13f DIFF: https://github.com/llvm/llvm-project/commit/71e108cd86e70b06c5fa3a63689dcb3555c3d13f.dif

[PATCH] D68997: Allow searching for prebuilt implicit modules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e108cd86e7: Allow searching for prebuilt implicit modules. (authored by arames). Changed prior to commit: https://reviews.llvm.org/D68997?vs=300

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao marked an inline comment as done. hliao added a comment. In D90809#2377083 , @rampitec wrote: > In D90809#2376994 , @b-sumner wrote: > >> Should this also be IntrConvergent? > > Probably yes... This is control

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc added a comment. I'm sorry, I don't see how to build up an identifier with an arbitrary number of characters using the token pasting, for example an ident with 4095 characters is not a power of 2. I tried pasting together X2048 X1024 X512 etc but that doesn't work fu.cpp:12:18: error: p

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

scanon added a comment. I do not much like faststd, as there's nothing "standard" about it. I do not, however, have a better suggestion off the top of my head. Let's pause and consider the name a little bit longer, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https

[clang] e551578 - APINotes: repair the Windows builders

Author: Saleem Abdulrasool Date: 2020-11-05T21:25:52Z New Revision: e55157874cf20acef55ca20a87699bf77b7cfd3a URL: https://github.com/llvm/llvm-project/commit/e55157874cf20acef55ca20a87699bf77b7cfd3a DIFF: https://github.com/llvm/llvm-project/commit/e55157874cf20acef55ca20a87699bf77b7cfd3a.diff

[PATCH] D68997: Allow searching for prebuilt implicit modules.

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3382 } +if (Args.hasFlag(options::OPT_fprebuilt_implicit_modules, false)) + CmdArgs.push_back("-fprebuilt-implicit-modules"); You need to use a fno_ flag as 2nd param if

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

rnk added a comment. I had another thought, which is that even if it is UB, perhaps we really shouldn't be using UB as the basis for debug info emission. All programs have bugs, and most bugs invoke some form of UB. If we don't provide sufficient info when UB is involved, it can become harder t

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/OpenMPSupport.rst:343 ++--+--+--

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

rnk added a comment. Why does `-cc1` need to distinguish between enabled, disabled, unset? The design philosophy is that the driver figures out all the target-specific configuration stuff, and then tells cc1 which features to enable. See, for example, -fexceptions, which is off by default in cc

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

jdoerfert added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1242 +def int_ubsantrap : Intrinsic<[], [llvm_i8_ty], + [IntrNoReturn, IntrCold, ImmArg>]>; should this be readonly and inaccesiblememonly? CHANGES SI

  1   2   >