[PATCH] D88220: [C++20] Implement more implicit moves for return statements(Part of P1825R0)

nullptr.cpp updated this revision to Diff 302544. nullptr.cpp added a comment. Implement whole P1825R0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D90436: [Bundler] Use argv[0] as the default choice for the Executable name.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90436/new/ https://reviews.llvm.org/D90436

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1281 + /// Additionally, we are ensuring that the default-free/default-member and + /// call-operator calling convention are generated as well. + if (S.getLangOpts().MSVCCompat) { S

[clang] abd8cd9 - [CUDA][HIP] Fix linkage for -fgpu-rdc

Author: Yaxun (Sam) Liu Date: 2020-11-03T08:07:19-05:00 New Revision: abd8cd9199d1e14cae961e1067b78df7044179a3 URL: https://github.com/llvm/llvm-project/commit/abd8cd9199d1e14cae961e1067b78df7044179a3 DIFF: https://github.com/llvm/llvm-project/commit/abd8cd9199d1e14cae961e1067b78df7044179a3.dif

[PATCH] D90311: [CUDA][HIP] Fix linkage for -fgpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rGabd8cd9199d1: [CUDA][HIP] Fix linkage for -fgpu-rdc (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90311/

[PATCH] D90531: [clangd][WIP] Start implementing clang-tidy options into clangd config

njames93 updated this revision to Diff 302552. njames93 added a comment. Removed support for using clang-tidy that will happen in a follow up as its a more involved change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90531/new/ https://reviews.l

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aronsky updated this revision to Diff 302558. aronsky retitled this revision from "Include attribute details when dumping AST in JSON" to "Include more attribute details when dumping AST in JSON". aronsky edited the summary of this revision. aronsky added a comment. Updated the relevant unit-test

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2369317 , @Mordante wrote: > Then me try to clear up the confusion. > The parser first parses the `LabelDecl` and tries to attach the attributes to > this declaration. If that fails instead of issue a diagnostic fo

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 302559. simoll marked 13 inline comments as done. simoll added a comment. - Addressed comments. - Made ext_vector_type bool un-castable (as any other ext_vector_type) - with tests. - Made bool vector element access illegal - with tests. - Rebased. Repository

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane updated this revision to Diff 302562. erichkeane added a comment. update comment as @aaron.ballman requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D90634 Files: clang/lib/Sema/SemaLambda.cpp clang/test/CodeGenCXX/lambda-conver

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl updated this revision to Diff 302560. yaxunl added a comment. updated manual CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/LangOptions.h

[PATCH] D78899: [Driver] Add callback to Command execution

sepavloff updated this revision to Diff 302563. sepavloff added a comment. Added documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 Files: clang/include/clang/Driver/Compilation.h clang/lib/D

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3910 +in library functions. Functions marked with the ``leaf`` attribute are not allowed +to jump back into the caller's translation unit, whether through invoking a +callback function, a dire

[PATCH] D90595: [clangd] Fix race in background index rebuild, where index could stay stale.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:848 +// The first two times the queue goes idle, add a couple more tasks. +// This should caute OnIdle to run again. +if (++IdleCount <= 2) { --

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:488-489 + +The memory representation of a dense boolean vector is the smallest fitting +integer. The alignment is the number of bits rounded up to the next +power-of-two but at most the maximum vector al

[PATCH] D90682: [clangd][NFC] Make Located::operator->() use pointer sematics

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This enables using the arrow opera

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added a comment. @beanz This patch looks good to me, can you confirm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89942/new/ https://reviews.llvm.org/D89942 ___ cfe-commits mailing li

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90303: [ASTMatchers] Made isExpandedFromMacro Polymorphic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb091af790f19: [ASTMatchers] Made isExpandedFromMacro Polymorphic (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D90303?

[clang] b091af7 - [ASTMatchers] Made isExpandedFromMacro Polymorphic

Author: Nathan James Date: 2020-11-03T14:36:51Z New Revision: b091af790f192c5532b59159fc029f9c368285c0 URL: https://github.com/llvm/llvm-project/commit/b091af790f192c5532b59159fc029f9c368285c0 DIFF: https://github.com/llvm/llvm-project/commit/b091af790f192c5532b59159fc029f9c368285c0.diff LOG:

[PATCH] D90672: [clang] Simplify buildSyntaxTree API

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:21 /// Build a syntax tree for the main file. +syntax::TranslationUnit *buildSyntaxTree(Arena &A, ASTC

[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrFormats.td:98 + +def BPF_ATOMIC_FETCH : BPFAtomicFlag<0x1>; jackmanb wrote: > Per Alexei's email comments let's call this BPF_FETCH? I can do this. Note naming in llvm may not be exact

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. In D89980#2368506 , @arsenm wrote: > I think this is a dead end approach. I don't see the connection to the > original problem you are trying to solve. Can you send me an IR testcase that > this is supposed to help? That's probabl

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm added a comment. In D89980#2371270 , @hliao wrote: > In D89980#2368506 , @arsenm wrote: > >> I think this is a dead end approach. I don't see the connection to the >> original problem you are trying to solve

[clang] 89d41f3 - [AMDGPU] Add gfx1033 target

Author: Tim Renouf Date: 2020-11-03T16:27:48Z New Revision: 89d41f3a2b820c17edeb86a2e9d458ca69eca34e URL: https://github.com/llvm/llvm-project/commit/89d41f3a2b820c17edeb86a2e9d458ca69eca34e DIFF: https://github.com/llvm/llvm-project/commit/89d41f3a2b820c17edeb86a2e9d458ca69eca34e.diff LOG: [A

[clang] ee3e642 - [AMDGPU] Add gfx90c target

Author: Tim Renouf Date: 2020-11-03T16:27:43Z New Revision: ee3e642627575bc8fb0a7008f8a02c891e172b7b URL: https://github.com/llvm/llvm-project/commit/ee3e642627575bc8fb0a7008f8a02c891e172b7b DIFF: https://github.com/llvm/llvm-project/commit/ee3e642627575bc8fb0a7008f8a02c891e172b7b.diff LOG: [A

[PATCH] D90447: [AMDGPU] Add gfx1033 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89d41f3a2b82: [AMDGPU] Add gfx1033 target (authored by tpr). Changed prior to commit: https://reviews.llvm.org/D90447?vs=301953&id=302591#toc Repo

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added subscribers: aqjune, fhahn, efriedma, reames. jdoerfert added a comment. The more I think about it, the more I think we should never create a `leaf`/`nocallback` definition. Only declarations should carry that attribute. I'm also still not convinced `nocallback` is a good name. @

[PATCH] D90419: [AMDGPU] Add gfx90c target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee3e64262757: [AMDGPU] Add gfx90c target (authored by tpr). Herald added a subscriber: emaste. Herald added a reviewer: espindola. Changed prior to c

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1282 + /// call-operator calling convention are generated as well. + /// NOTE: We intentionally generate a 'thiscall' (on Win32) despite MSVC not. + /// We do this in order to ensure that someone wh

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added a comment. Hello @@DmitryPolukhin , When I submitted latest via 'arc diff' my commit-message was... Can you please help to have following commit message? Below commit message is more clear and helpful. Sorry for inconvenience caused! commit 653cb7912bbe4daabc8d6dd6dca71b2cf9a10365

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane updated this revision to Diff 302595. erichkeane marked 2 inline comments as done. erichkeane added a comment. Made another attempt at fixing the comment. Wordsmithing welcomed/encouraged :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D9

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. The code could be simply converted to a kernel one following the same pattern: struct S { float *p; float a[64]; int n; }; __global__ void kernel(S s) { *s.p = s.a[s.n]; } Here's the LLVM IR after frontend define protec

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske created this revision. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity, mgorny. Herald added a reviewer: Szelethus. Herald added a pr

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84962/new/ https://reviews.llvm.org/D84962 ___ cfe-commits mailing list cfe-commit

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM but you should wait a day or so in case @rjmccall has opinions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D90634 _

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. > Hello @@DmitryPolukhin , > > When I submitted latest via 'arc diff' my commit-message was... > Can you please help to have following commit message? Below commit message is > more clear and helpful. > Sorry for inconvenience caused! It is not possible to update

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane added a comment. In D90634#2371436 , @aaron.ballman wrote: > This LGTM but you should wait a day or so in case @rjmccall has opinions. Thanks, will do! Comment at: clang/lib/Sema/SemaLambda.cpp:1281 + /// Additionally, we

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske added a comment. This is a very simplified form of the check that is implemented in D72705 but still may be useful in practical cases. This check could be a clang-tidy check but it is planned that the checker takes use of the planned new attributes to

[PATCH] D78760: Check a class doesn't have a dependent type before iterating over its base classes

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78760/new/ https://reviews.llvm.org/D78760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

vsk accepted this revision. vsk added subscribers: kcc, eugenis. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm with two comments -- > Because of the extra traps there is a small code-size penalty, but it's > pretty small compared to what we accept just for th

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added a comment. In D90275#2371343 , @jdoerfert wrote: > The more I think about it, the more I think we should never create a > `leaf`/`nocallback` definition. Only declarations should carry that attribute. When talking about the IR that ge

[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:715 + +let Predicates = [BPFHasAtomicExt, BPFHasALU32], DecoderNamespace = "BPFALU32" in { + def XFADDW32 : XFALU32; i think -mcpu=v4 should include alu32. Otherwise the test matrix will

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D89980: [hip] Remove kernel argument coercion.

tra added a subscriber: jlebar. tra added a comment. @jlebar -- FYI. This looks pretty similar to the issue you've reported recently for NVPTX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 _

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 302606. atmnpatel added a comment. Hopefully the unrelated hwasan test failure is now fixed on master, trying again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

rjmccall added a comment. Hmm. Do we actually want this behavior of `fast` overriding pragmas? What do other compilers do here? It might be reasonable to just treat this as a bug. Comment at: clang/docs/LanguageExtensions.rst:3214 +should be noted that ``-ffp-contract=fast`

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. In D89980#2371526 , @tra wrote: > @jlebar -- FYI. This looks pretty similar to the issue you've reported > recently for NVPTX. is that reported in bugs.llvm.org? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante marked 2 inline comments as done. Mordante added a comment. In D86559#2371058 , @aaron.ballman wrote: > In D86559#2369317 , @Mordante wrote: > >> Then me try to clear up the confusion. >> >>> However, I co

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

Mordante added a comment. In D90568#2370079 , @njames93 wrote: > Added JsonNodeDumper and argument comments. Thanks, I've no further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

scanon added a comment. GCC doesn't respect the pragma, so "what other compilers do" is not a particularly useful metric. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___ cfe-commits mailing list c

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

scanon added a comment. (If you tell GCC to respect the pragma via -std=c17 or similar, then -ffp-contract=fast overrides it just like clang's current behavior: https://godbolt.org/z/5dxxGb) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174

[PATCH] D89980: [hip] Remove kernel argument coercion.

tra added a comment. In D89980#2371580 , @hliao wrote: > is that reported in bugs.llvm.org? It was exposed in our internal code, but the situation is almost identical to your IR example. https://godbolt.org/z/EPPn6h For NVPTX we lower byval arguments as

[clang] be86b67 - [CUDA] Allow local static variables with target attributes.

Author: Artem Belevich Date: 2020-11-03T10:30:38-08:00 New Revision: be86b6773b6ba4d101a848e109540548181d2ed5 URL: https://github.com/llvm/llvm-project/commit/be86b6773b6ba4d101a848e109540548181d2ed5 DIFF: https://github.com/llvm/llvm-project/commit/be86b6773b6ba4d101a848e109540548181d2ed5.diff

<    1   2