[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

kbobyrev added a comment. LGTM, thanks! Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h sammccall wrote: > kbobyrev wrote: > > On line 89

[PATCH] D89126: [clangd] Support CodeActionParams.only

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Sorry, it seems I forgot about this one :( LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89126/new/ https://reviews.llvm.org/D89126 ___

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llvm.org/D90362 ___ c

[clang-tools-extra] 5627ae6 - [clangd] Support CodeActionParams.only

Author: Sam McCall Date: 2020-10-29T09:44:08+01:00 New Revision: 5627ae6c507d62ef52d30fe80a0120f2ee033123 URL: https://github.com/llvm/llvm-project/commit/5627ae6c507d62ef52d30fe80a0120f2ee033123 DIFF: https://github.com/llvm/llvm-project/commit/5627ae6c507d62ef52d30fe80a0120f2ee033123.diff LO

[PATCH] D89126: [clangd] Support CodeActionParams.only

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5627ae6c507d: [clangd] Support CodeActionParams.only (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

sammccall added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h kbobyrev wrote: > sammccall wrote: > > kbobyrev wrote: > >

[clang-tools-extra] 1d773a4 - [CMake] Support inter-proto dependencies in generate_protos.

Author: Sam McCall Date: 2020-10-29T10:04:20+01:00 New Revision: 1d773a4ff05d0dcfab112719b82b2bd5d0c93ff5 URL: https://github.com/llvm/llvm-project/commit/1d773a4ff05d0dcfab112719b82b2bd5d0c93ff5 DIFF: https://github.com/llvm/llvm-project/commit/1d773a4ff05d0dcfab112719b82b2bd5d0c93ff5.diff LO

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d773a4ff05d: [CMake] Support inter-proto dependencies in generate_protos. (authored by sammccall). Changed prior to commit: https://reviews.llvm.

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

xazax.hun added a comment. I know that the current situation is a mess, but there is an alternative version of scan-build-py on Github, which is also distributed on pypi. Could you check if that version is also susceptible to this problem and open a pull request for the author in case it is? T

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:162 return false; +llvm::StringRef Path = P.Path; +// Ignore the file if it is not nested under Fragment and strip the sammccall wrote: >

[PATCH] D90376: [clangd] Add requests logging to clangd-index-server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will allow us to track metrics of the s

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:51 +return llvm::StringRef(); + return Path; +} not that if Path == FragmentDir you're going to return "" which means "not under". I don't think this can happen yet, but

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:337 + +Config.assign((*Text)->getBuffer()); + } DmitryPolukhin wrote: > I suggest creating new local variable with text of the config from `Config` > or `C

[PATCH] D90291: [clangd] Add lit tests for remote index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:1 +# RUN: rm -rf %/t +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex nit: `/` shouldn't be needed here. the difference between %t and %/

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf00267f1fdb: clang-format: Add a consumer to diagnostics engine (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] df00267 - clang-format: Add a consumer to diagnostics engine

Author: Krasimir Georgiev Date: 2020-10-29T11:28:27+01:00 New Revision: df00267f1fdb0b098dc42f1caa8a59b29c8e0e5f URL: https://github.com/llvm/llvm-project/commit/df00267f1fdb0b098dc42f1caa8a59b29c8e0e5f DIFF: https://github.com/llvm/llvm-project/commit/df00267f1fdb0b098dc42f1caa8a59b29c8e0e5f.d

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @krasimir Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:337 + +Config.assign((*Text)->getBuffer()); + } DmitryPolukhin wrote: > DmitryPolukhin wrote: > > I suggest creating new local variable with text of the config from

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. Thanks for the feedback Duncan. I don't think this patch introduces any changes the parser. We only change the way how `CodeGenOpts` and `LangOpts` get populated when using `DefaultAnyOf<[...]>`. I've added a test of `CompilerInvocation` that checks just that.

[PATCH] D90291: [clangd] Add lit tests for remote index

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex +# RUN: python %/S/pipeline_helper.py --input-file-name=%s --server-address=0.0.0.0:50051 --test-directo

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

njames93 added a comment. It's also be nice if --config-file would also support being passed a directory. If a directory was passed it would append ".clang-tidy" to the path and load that file, WDYT? Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 301564. jansvoboda11 added a comment. Herald added a subscriber: mgrang. Integrated code review suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files: clang/include/clang/Basic/LangOption

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. In D89936#2361580 , @njames93 wrote: > It's also be nice if --config-file would also support being passed a > directory. If a directory was passed it would append ".clang-tidy" to the > path and load that file, WDYT? It m

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +if (!Checks.empty()) { + llvm::errs() << "Error: --config-file and --checks are mutually " + "exclusive. Specify only one.\n"; + retur

[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ilya-golovenko requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Google test matcher DeclKind uses NamedDecl::getDeclKindNam

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +if (!Checks.empty()) { + llvm::errs() << "Error: --config-file and --checks are mutually " + "exclusive. Specify only one.\n"; + return nullpt

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

teemperor updated this revision to Diff 301577. teemperor added a comment. - Respect forced deserialisation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80878/new/ https://reviews.llvm.org/D80878 Files: clang/include/clang/AST/TextNodeDumper.h clang/lib/AST/ASTDumper.cpp clang/

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:320-324 +if (!Checks.empty()) { + llvm::errs() << "Error: --config-file and --checks are mutually " + "exclusive. Specify only one.\n"; + retur

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

Elvina added a comment. Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89972/new/ https://reviews.llvm.org/D89972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

SjoerdMeijer added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:298 +// RUN: %clang -target aarch64 -mcpu=tsv110 -### -c %s 2>&1 | FileCheck -check-prefix=TSV110 %s +// RUN: %clang -target aarch64 -mlittle-endian -mcpu=tsv110 -### -c %s 2>&1 | FileCheck -chec

[libunwind] 05598e3 - [libunwind] Fix linker flag handling in the tests.

Author: Daniel Kiss Date: 2020-10-29T14:02:44+01:00 New Revision: 05598e3d3047cf028cc3e61f3268ff7d999e5f26 URL: https://github.com/llvm/llvm-project/commit/05598e3d3047cf028cc3e61f3268ff7d999e5f26 DIFF: https://github.com/llvm/llvm-project/commit/05598e3d3047cf028cc3e61f3268ff7d999e5f26.diff L

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

hans added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + akyrtzi wrote: > Hi Anastasia, apologies for not catching this earlier, but libclang is > intended to keep a stable ABI and changing the e

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov added a comment. Who can confirm if this is correct or somewhere it needs fixes? Here is a generated result of `evalCast` from the origin branch(before the patch): void foo(int* x, // &SymRegion{reg_$0} int** y, // &SymRegion{reg_$0} int***z) // &SymRegion{

[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Great! Thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90384/new/ https://reviews.llvm.org/D90384

[PATCH] D90389: Test commit, please ignore

goncharov created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. goncharov requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90389 Files: clang-tools-extra/docs/new_file.txt Index: clang-tools-extra/docs/

[PATCH] D90364: [AMDGPU] Update AMD GPU documentation

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90364/new/ https://reviews.llvm.org/D90364 _

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly created this revision. ckennelly added reviewers: EricWF, ymandel. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ckennelly requested review of this revision. This extends the check for default initialization in arrays added in 547f89d6070 to include sca

[PATCH] D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr

mantognini created this revision. mantognini added reviewers: arphaman, akyrtzi, rsmith, Anastasia. Herald added a project: clang. Herald added a subscriber: cfe-commits. mantognini updated this revision to Diff 301579. mantognini added a comment. mantognini published this revision for review. Bum

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added a comment. I've put up https://reviews.llvm.org/D90385 as a fix for this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 ___ cfe-commits m

[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

ilya-golovenko added a comment. I don't have commit access could you please commit it on my behalf? Ilya Golovenko Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90384/new/ https://reviews.llvm.org/D90384 __

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:135 + New->getAllocatedType(), *Result.Context); + if (!Initiali

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + hans wrote: > akyrtzi wrote: > > Hi Anastasia, apologies for not catching this earlier, but libclang is > > intended to keep a stable

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89559/new/ https://reviews.llvm.org/D89559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301606. kbobyrev marked 8 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-to

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

c-rhodes updated this revision to Diff 301603. c-rhodes edited the summary of this revision. c-rhodes added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88233/new/ https://reviews.llvm.org/D88233 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301607. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/CMakeLists.txt clan

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

c-rhodes marked 2 inline comments as done. c-rhodes added a comment. In D88233#2359022 , @fpetrogalli wrote: > Hi @c-rhodes, Peter asked me to take a look at this. LGTM, I only have minor > stuff. > > In the commit message: > >> Arm C Language Extensions

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

awarzynski added a comment. Hi All, I've just noticed this patch and realised that it takes `DiagnosticBuilder` in the direction tangential to what we proposed in [1]. I've just restarted our efforts with regard to refactoring these APIs and feel that it would be good to coordinate any future

[PATCH] D90396: [VE] Change to use integrated assembly by defualt

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added a project: clang. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. We've implemented integrated assembler. Now, we change to use integrated assembler by

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis reopened this revision. thakis added a comment. This revision is now accepted and ready to land. This doe snot lgtm. clang-format should not depend on clangFrontend, see the lengthy discussion in https://reviews.llvm.org/D68554 . Let's try to find another fix here (and include a test for

[clang] 637c77f - Revert "clang-format: Add a consumer to diagnostics engine"

Author: Nico Weber Date: 2020-10-29T10:29:53-04:00 New Revision: 637c77fda64a9b4c021be9c2f89fe8995613c7ed URL: https://github.com/llvm/llvm-project/commit/637c77fda64a9b4c021be9c2f89fe8995613c7ed DIFF: https://github.com/llvm/llvm-project/commit/637c77fda64a9b4c021be9c2f89fe8995613c7ed.diff LO

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex +# RUN: python %/S/pipeline_helper.py --input-file-name=%s --server-address=0.0.0.0:50051 --test-direct

[PATCH] D80499: Remove obsolete ignore*() matcher uses

steveire added a comment. > ! In D80499#2353187 , @alexfh wrote: > You should be ready for back and forth with this change, if users hit > widespread issues not caught by tests. Maybe splitting it into separate > pieces and involving check authors where

[PATCH] D90396: [VE] Change to use integrated assembly by defualt

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Great work! Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90396/new/ https://reviews.llvm.org/D90396

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

krasimir added a comment. In D90121#2361985 , @thakis wrote: > This doe snot lgtm. clang-format should not depend on clangFrontend, see the > lengthy discussion in https://reviews.llvm.org/D68554 . Let's try to find > another fix here (and include a test

[PATCH] D90291: [clangd] Add lit tests for remote index

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %S/Inputs/Source.cpp > %t.idx +# RUN: %python %S/pipeline_helper.py --input-file-name=%s --project-root=%/S --index-file=%t.idx | FileCheck %s +# REQUIRES

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @thakis There's a simple option of moving `TextDiagnosticPrinter` into `libBasic` thus eliminating neccessety to depend on `libFrontend`. How does that sound? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https:

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301619. kbobyrev marked an inline comment as done. kbobyrev added a comment. Rebase on top of master, don't force forward slashes in project root, format Python helper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D90366: [ThinLTO] Strenghten the test for .llvmcmd embedding

tejohnson added a comment. The motivation and effects of the change are unclear to me. Does this mean that the .llvmcmd section is always emitted? Or always emitted whenever any bitcode embedding is requested? Comment at: clang/test/CodeGen/thinlto_embed_bitcode.ll:28 ; RUN:

[PATCH] D90366: [ThinLTO] Strenghten the test for .llvmcmd embedding

mtrofin added a comment. In D90366#2362052 , @tejohnson wrote: > The motivation and effects of the change are unclear to me. Does this mean > that the .llvmcmd section is always emitted? Or always emitted whenever any > bitcode embedding is requested? T

[PATCH] D90397: [clangd] Value initialize SymbolIDs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. We were default initializing SymbolIDs befo

Re: [clang] 552c6c2 - PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

Hi Richard, this fires on thakis@thakis:~/src/llvm-project$ cat foo.m static const int gSignals[] = { 0, 1, 2, 3, 4 }; static const int kNumSignals = sizeof(gSignals) / sizeof(gSignals[0]); static int gPreviousSignalHandlers[kNumSignals]; thakis@thakis:~/src/llvm-project$ out/gn/bin/clang -c foo

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. IIUC, this is handling the case where `Ptr.reset(new int)` which is different to `Ptr.reset(new int())` because the former doesn't initialise the int while the latter default(zer

[PATCH] D90397: [clangd] Value initialize SymbolIDs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolID.h:57 + bool isValid() const { return HashValue != std::array{}; } + I'm not a big fan of LLVM's habit of calling the sentinel value "invalid". Consider SourceLocation - one c

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis added a comment. Can you expand a bit on what exactly is going wrong? (As part of that, please include a test case that shows the crash this is about.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121

[PATCH] D90396: [VE] Change to use integrated assembly by defualt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5ac3721c8a4: [VE] Change to use integrated assembly by defualt (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b5ac372 - [VE] Change to use integrated assembly by defualt

Author: Kazushi (Jam) Marukawa Date: 2020-10-30T00:16:04+09:00 New Revision: b5ac3721c8a497ebf33a9d0cc0d300564b0cefe1 URL: https://github.com/llvm/llvm-project/commit/b5ac3721c8a497ebf33a9d0cc0d300564b0cefe1 DIFF: https://github.com/llvm/llvm-project/commit/b5ac3721c8a497ebf33a9d0cc0d300564b0ce

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

ymandel added inline comments. Comment at: clang/lib/AST/Expr.cpp:2822 + if (SE->getSourceRange() == E->getSourceRange()) +return Cast->getSubExpr(); +} nit: just `return SE`? Comment at: clang/unittests/ASTMatchers/ASTMatchers

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

steveire updated this revision to Diff 301636. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82278/new/ https://reviews.llvm.org/D82278 Files: clang/lib/AST/Expr.cpp clang/lib/AST/ParentMapContext.cpp clang/u

[PATCH] D90366: [ThinLTO] Strenghten the test for .llvmcmd embedding

mtrofin updated this revision to Diff 301641. mtrofin added a comment. fixed sentence Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90366/new/ https://reviews.llvm.org/D90366 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CodeGen/

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added inline comments. Comment at: clang/lib/APINotes/APINotesYAMLCompiler.cpp:33 +namespace yaml { +template <> +struct ScalarEnumerationTraits { martong wrote: > Could you please clang-format the code? The `Lint: Pre-merge checks` are all > over the c

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith added a comment. In D82756#2361565 , @jansvoboda11 wrote: > Thanks for the feedback Duncan. > > I don't think this patch introduces any changes the parser. We only change > the way how `CodeGenOpts` and `LangOpts` get populated when using >

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

jkorous added a comment. Friendly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89959/new/ https://reviews.llvm.org/D89959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 301648. ckennelly added a comment. Apply feedback from ymandel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: clang-tools-extra/clang-tidy/modernize/MakeSma

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 301649. ckennelly marked 3 inline comments as done. ckennelly added a comment. Apply review feedback from njames93 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Fil

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. In D90392#2362118 , @njames93 wrote: > IIUC, this is handling the case where `Ptr.reset(new int)` which is different > to `Ptr.reset(new int())` because the former doesn't initialise the int while > the latter default(zero) ini

[PATCH] D90366: [ThinLTO] Fix empty .llvmcmd sections

mtrofin updated this revision to Diff 301650. mtrofin marked an inline comment as done. mtrofin added a comment. updated description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90366/new/ https://reviews.llvm.org/D90366 Files: clang/lib/Fronte

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

lebedev.ri added a comment. In D90392#2362308 , @ckennelly wrote: > In D90392#2362118 , @njames93 wrote: > >> IIUC, this is handling the case where `Ptr.reset(new int)` which is >> different to `Ptr.reset(new int()

[PATCH] D90366: [ThinLTO] Fix empty .llvmcmd sections

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90366/new/ https://reviews.llvm.org/D90366 ___

[PATCH] D90251: [AMDGPU] Add __builtin_amdgcn_grid_size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdee7704829bd: [AMDGPU] Add __builtin_amdgcn_grid_size (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] dee7704 - [AMDGPU] Add __builtin_amdgcn_grid_size

Author: Jon Chesterfield Date: 2020-10-29T16:25:13Z New Revision: dee7704829bd421ad3cce4b2132d28f4459b7319 URL: https://github.com/llvm/llvm-project/commit/dee7704829bd421ad3cce4b2132d28f4459b7319 DIFF: https://github.com/llvm/llvm-project/commit/dee7704829bd421ad3cce4b2132d28f4459b7319.diff L

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

vsk added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3447 // If we're optimizing, collapse all calls to trap down to just one per // function to save on code size. + if (TrapBBs.size() <= CheckHandlerID) 'per check, per function'?

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:799 + return CB(Offset.takeError()); +if (auto O = positionToOffset(Inputs->Inputs.Contents, R.end)

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

vsk added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3458 +llvm::CallInst *TrapCall = +Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::ubsantrap), + llvm::ConstantInt::get(CGM.Int32Ty, CheckHandlerID)); v

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @thakis We've stumbled upon this problem when tried to format in-place a read-only file. `clang-format` tries to report this problem via `DiagnosticEngine`, and that fails on assert

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

aabbaabb added a comment. Differential Revision: https://reviews.llvm.org/D90362 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llvm.org/D90362 ___ cfe-commits mailing list cfe-

[clang] 13aee94 - [ThinLTO] Fix empty .llvmcmd sections

Author: Mircea Trofin Date: 2020-10-29T09:57:42-07:00 New Revision: 13aee94bc710bfa6277c1f07146c714ee65bf2de URL: https://github.com/llvm/llvm-project/commit/13aee94bc710bfa6277c1f07146c714ee65bf2de DIFF: https://github.com/llvm/llvm-project/commit/13aee94bc710bfa6277c1f07146c714ee65bf2de.diff

[PATCH] D90366: [ThinLTO] Fix empty .llvmcmd sections

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13aee94bc710: [ThinLTO] Fix empty .llvmcmd sections (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire updated this revision to Diff 301667. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80623/new/ https://reviews.llvm.org/D80623 Files: clang/include/clang/ASTMatchers/ASTMatchFinder.h clang/lib/ASTMatch

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChain.cpp:1203 +unsigned DiagID = +Diags.getCustomDiagID(DiagnosticsEngine::Error, + "invalid

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire marked an inline comment as done. steveire added a comment. Reviving this so it can be used to port `clang-tidy` checks to `IgnoreUnlessSpelledInSource`. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:118 +/// behavior of clang-tidy. +virtual llv

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

aabbaabb added a comment. Gabor or Petr, Can any one of you help me commit this change? Not sure if I could commit myself. In D90362#2361400 , @xazax.hun wrote: > I know that the current situation is a mess, but there is an alternative > version of sca

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:107 +if (!PP.getTargetInfo().hasStrictFP() && !PP.getLangOpts().ExpStrictFP) { + PP.Diag(Tok.getLocation(), diag::warn_pragma_fp_ignored) + << "FENV_ACCESS"; Can yo

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis added a comment. Is it possible to add an automated test for this in clang/test/Format/... using chmod -w in a RUN line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121 _

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88233/new/ https://reviews.llvm.org/D88233 ___ cfe-commits mailin

[PATCH] D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/CodeGen/CGObjC.cpp:3874 if (!CGM.IsOSVersionAtLeastFn) { llvm::FunctionType *FTy = Isn't the rest of the function bas

[PATCH] D90397: [clangd] Value initialize SymbolIDs

kadircet updated this revision to Diff 301678. kadircet marked an inline comment as done. kadircet added a comment. - change invalid -> null. - add an implicit bool conversion operator. - update apis returning optionals. Note that all the functional changes are in SymbolID.h, rest is api updates.

[PATCH] D89670: [clangd] Store the containing symbol for refs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:91 RefKind Kind = RefKind::Unknown; + SymbolID Container; }; i am afraid we are going to have an indeterminate value here if for whatever reason `Container` detection fails. (e

[clang] be6f507 - [WebAssembly] Implement SIMD signselect instructions

Author: Thomas Lively Date: 2020-10-29T11:06:20-07:00 New Revision: be6f50798e79336cdfd8fe464f37d41ac135640d URL: https://github.com/llvm/llvm-project/commit/be6f50798e79336cdfd8fe464f37d41ac135640d DIFF: https://github.com/llvm/llvm-project/commit/be6f50798e79336cdfd8fe464f37d41ac135640d.diff

[PATCH] D90357: [WebAssembly] Implement SIMD signselect instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe6f50798e79: [WebAssembly] Implement SIMD signselect instructions (authored by tlively). Herald added a subscriber: wingo. Repository: rG LLVM Gi

  1   2   >