[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

oneraynyday added a comment. Hi there, Thank you for taking a look! Sorry about the mess with diff's - this is my first time working with Arcanist. I thought `arc diff --update ` in Arcanist meant a push to the branch. Moving forward, should I use `arc diff` to add extra changes onto the code

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 299278. venkataramanan.kumar.llvm added a comment. Herald added a subscriber: dexonsmith. Added a test case for testing vector library calls for VF=2 and VF=8. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://revie

[PATCH] D89709: [clang-format] Drop clangFrontend dependency for FormatTests

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, I'm for anything that speeds up the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89709/new/ https://reviews.llvm.or

[PATCH] D89770: Don't use C++17 features

oneraynyday created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. oneraynyday requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89770 Files: clang-tools-extra/clang-cast/Matcher.h Index: clang-tools-extr

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 299280. venkataramanan.kumar.llvm added a comment. Remove an incorrect file that got attached with my earlier patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://reviews.llvm.org/D88154 Files: clang/include/c

[PATCH] D88553: [clangd] Stash a patch piece

kbobyrev updated this revision to Diff 299281. kbobyrev added a comment. Add support for compound statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticSelect

[PATCH] D89770: Don't use C++17 features

oneraynyday updated this revision to Diff 299282. oneraynyday added a comment. C++17 features cause buildkite to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89770/new/ https://reviews.llvm.org/D89770 Files: clang-tools-extra/clang-cast/M

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM, but it could be better with a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80488/new/ https://reviews.llvm.org/D80488 _

[PATCH] D88553: [clangd] Stash a patch piece

kbobyrev updated this revision to Diff 299284. kbobyrev added a comment. Add one more test and remove unused include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/Semant

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev added a comment. @sammccall I've reduced the patch to the bare minimum (compound statements) as I've had some issues with couple of other kinds of folding ranges and I'll be adding support for the node kinds one by one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89771: [clangd] NFC: Resolve Clang-Tidy warnings in Protocol.cpp

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https

[PATCH] D89771: [clangd] NFC: Resolve Clang-Tidy warnings in Protocol.cpp

kbobyrev updated this revision to Diff 299288. kbobyrev added a comment. Add forgotten fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89771/new/ https://reviews.llvm.org/D89771 Files: clang-tools-extra/clangd/Protocol.cpp Index: clang-to

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. > Looks good to me - thanks! Great! Can you please commit this for me as I have no commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list

[PATCH] D88640: [Format] Don't treat compound extension headers (foo.proto.h) as foo.cc main file.

hokein added a comment. In D88640#2339349 , @rupprecht wrote: > It looks like this fix caused a different regression in not accepting > `name..h` as the main header for `name..cc`, e.g.: > > $ cat /tmp/foo.bar.cc > #include "a.h" > #include "z.h" >

[clang] f2cca0b - Silence unused variable warning in Release builds. NFCI.

Author: Benjamin Kramer Date: 2020-10-20T10:48:48+02:00 New Revision: f2cca0b291491f25dc6d2c073d71a2799625ad3b URL: https://github.com/llvm/llvm-project/commit/f2cca0b291491f25dc6d2c073d71a2799625ad3b DIFF: https://github.com/llvm/llvm-project/commit/f2cca0b291491f25dc6d2c073d71a2799625ad3b.dif

[PATCH] D89670: [clangd] Store the containing symbol for refs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:349 +SymbolRef{SM.getFileLoc(Loc), Roles, + dyn_cast_or_null(ASTNode.Parent)}); // Don't continue indexing if this is a mere reference. What

[PATCH] D89708: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2214757e2ca: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h (authored by arichardson). Repository: rG LLVM Github Monorep

[clang] a221475 - Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h

Author: Alex Richardson Date: 2020-10-20T10:13:28+01:00 New Revision: a2214757e2ca445112f19395493a78e820389655 URL: https://github.com/llvm/llvm-project/commit/a2214757e2ca445112f19395493a78e820389655 DIFF: https://github.com/llvm/llvm-project/commit/a2214757e2ca445112f19395493a78e820389655.dif

[PATCH] D89709: [clang-format] Drop clangFrontend dependency for FormatTests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66a3b9073ac1: [clang-format] Drop clangFrontend dependency for FormatTests (authored by arichardson). Changed prior to commit: https://reviews.llv

[clang] 66a3b90 - [clang-format] Drop clangFrontend dependency for FormatTests

Author: Alex Richardson Date: 2020-10-20T10:13:28+01:00 New Revision: 66a3b9073ac116f0ee39baf625c733abe18140e5 URL: https://github.com/llvm/llvm-project/commit/66a3b9073ac116f0ee39baf625c733abe18140e5 DIFF: https://github.com/llvm/llvm-project/commit/66a3b9073ac116f0ee39baf625c733abe18140e5.dif

[PATCH] D89771: [clangd] NFC: Resolve Clang-Tidy warnings in Protocol.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG691eb814c1ae: [clangd] NFC: Resolve Clang-Tidy warnings in Protocol.cpp (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89771/new/ htt

[clang-tools-extra] 691eb81 - [clangd] NFC: Resolve Clang-Tidy warnings in Protocol.cpp

Author: Kirill Bobyrev Date: 2020-10-20T11:23:40+02:00 New Revision: 691eb814c1ae38d5015bf070dfed3fd54d542582 URL: https://github.com/llvm/llvm-project/commit/691eb814c1ae38d5015bf070dfed3fd54d542582 DIFF: https://github.com/llvm/llvm-project/commit/691eb814c1ae38d5015bf070dfed3fd54d542582.diff

[PATCH] D89783: [format] foo..h should be the main-header for foo..cc

hokein created this revision. hokein added a reviewer: adamcz. Herald added a project: clang. hokein requested review of this revision. This fixes a regression introduced in https://reviews.llvm.org/D88640. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89783 Files: clang/in

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

hokein added a comment. Looks like there are some failing tests in premerge bots, e.g. https://reviews.llvm.org/harbormaster/unit/view/185822/ Also run `clang/docs/tools/dump_ast_matchers.py` script to update the `LibASTMatchersReference.html` file. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D89301: [X86] Add user-level interrupt instructions

tianqing updated this revision to Diff 299317. tianqing added a comment. Herald added a subscriber: dexonsmith. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89301/new/ https://reviews.llvm.org/D89301 Files: clang/docs/C

[PATCH] D89785: [clangd] Add basic support for attributes (selection, hover)

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. These aren't terribly common, but

[PATCH] D89529: [clangd][remote] Add Windows paths support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd99b2a976a37: [clangd][remote] Add Windows paths support (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang-tools-extra] d99b2a9 - [clangd][remote] Add Windows paths support

Author: Aleksandr Platonov Date: 2020-10-20T13:04:20+03:00 New Revision: d99b2a976a37f5a63117086d464df40c124f5777 URL: https://github.com/llvm/llvm-project/commit/d99b2a976a37f5a63117086d464df40c124f5777 DIFF: https://github.com/llvm/llvm-project/commit/d99b2a976a37f5a63117086d464df40c124f5777.

[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

sstefan1 closed this revision. sstefan1 added a comment. Commited in rGfbfb1c790982 . Forgot to add the revision link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86021/new/ h

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall updated this revision to Diff 299324. sammccall added a comment. Update docs, dynamic registry and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89743/new/ https://reviews.llvm.org/D89743 Files: clang/docs/LibASTMatchersReferenc

[PATCH] D89783: [format] foo..h should be the main-header for foo..cc

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:243 + StringRef MatchingFileStem = matchingStem(FileName); // foo for foo.cu.cc + // main-head

[PATCH] D89783: [format] foo..h should be the main-header for foo..cc

hokein updated this revision to Diff 299332. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89783/new/ https://reviews.llvm.org/D89783 Files: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h clang

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

sammccall added a comment. Yep, let's revert to the previous state and land that, and I'll puzzle over the examples you give (because always returning false shouldn't affect behavior, just performance). I have put together D89785 for more general attribute sup

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker updated this revision to Diff 299333. Tyker marked 4 inline comments as done. Tyker added a comment. Herald added a subscriber: dexonsmith. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3706 + +if (!Result || !Notes.empty()) { + Diag(E->getBeginLoc(), diag::err_attribute_argument_n_type) aaron.ballman wrote: > I'm surprised that the presence of notes alone would me

[clang] 84048e2 - [format] foo..h should be the main-header for foo..cc

Author: Haojian Wu Date: 2020-10-20T13:27:02+02:00 New Revision: 84048e234f8f0d81871caab842dbed84b84aa86f URL: https://github.com/llvm/llvm-project/commit/84048e234f8f0d81871caab842dbed84b84aa86f DIFF: https://github.com/llvm/llvm-project/commit/84048e234f8f0d81871caab842dbed84b84aa86f.diff LO

[PATCH] D89783: [format] foo..h should be the main-header for foo..cc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG84048e234f8f: [format] foo..h should be the main-header for foo..cc (authored by hokein). Repos

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

martong added a comment. Unfortunately, I could not reproduce the mentioned crash on our macOS machine. The mentioned test just passed with the output below. I gave up. myuser@msmarple ~/llvm3/build/release_assert $ /usr/local/Frameworks/Python.framework/Versions/3.8/bin/python3.8 /Users/myu

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89752/new/ https://reviews.llvm.org/D89752

[PATCH] D88498: [FPEnv] Apply dynamic rounding to function body only

sepavloff abandoned this revision. sepavloff added a comment. In D88498#2339630 , @rsmith wrote: > The tests in this patch exhibit the same behavior with and without the patch > applied; I think almost all the functionality changes from here are > supe

[clang] c0cdd22 - Introduce CfgTraits abstraction

Author: Nicolai Hähnle Date: 2020-10-20T13:50:52+02:00 New Revision: c0cdd22c72fab47a3c37b5a8401763995cadaa77 URL: https://github.com/llvm/llvm-project/commit/c0cdd22c72fab47a3c37b5a8401763995cadaa77 DIFF: https://github.com/llvm/llvm-project/commit/c0cdd22c72fab47a3c37b5a8401763995cadaa77.diff

[PATCH] D83088: Introduce CfgTraits abstraction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0cdd22c72fa: Introduce CfgTraits abstraction (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

eduucaldas added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:49-51 + if (Node->getKind() == syntax::NodeKind::CompoundStatement) { +const auto *Tree = dyn_cast(Node); +assert(Tree); Comment at: clang-to

[PATCH] D89441: [xray] Honor xray-never function-instrument attribute

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM -- thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89441/new/ https://reviews.llvm.org/D89441

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:158 if (!VersionFile) { - // CUDA 7.0 doesn't have a version.txt, so guess that's our version if - // version.txt isn't present. - Version = CudaVersion::CUDA_70; + // CUDA 7.

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki updated this revision to Diff 299340. miyuki edited the summary of this revision. miyuki added a comment. Added an example of usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89719/new/ https://reviews.llvm.org/D89719 Files: clang-too

[PATCH] D32838: [libcxx] Make __shared_weak_count VTable consistent across all build configurations

ldionne updated this revision to Diff 299342. ldionne added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added 1 blocking reviewer(s): libc++. Rebase onto master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D89528: [clang][test] Fix prefix operator++ signature in iterators

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Ok, thanks for the context. LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89528/new/ https://reviews.

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

gribozavr2 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:37 -// Recursively collects FoldingRange from a symbol and its children. -void collectFoldingRanges(DocumentSymbol Symbol, - std::vector &Result) { +FoldingRang

[PATCH] D32838: [libcxx] Make __shared_weak_count VTable consistent across all build configurations

ldionne updated this revision to Diff 299344. ldionne added a comment. Herald added a subscriber: mgorny. Herald added a project: libc++abi. Herald added a reviewer: libc++abi. Remove uses of _LIBCPP_BUILD_STATIC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D32838: [libcxx] Make __shared_weak_count VTable consistent across all build configurations

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. For libc++: We never manually define `_LIBCPP_BUILD_STATIC`, so libc++ always contains `__shared_weak_count::__get_deleter`. For libc++abi: It could happen that `_LIBCPP_BUILD_STATIC` is defi

[PATCH] D32838: [libcxx] Make __shared_weak_count VTable consistent across all build configurations

This revision was automatically updated to reflect the committed changes. Closed by commit rG229db3647491: [libc++] Make __shared_weak_count vtable consistent across all build… (authored by EricWF, committed by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums

njames93 added a comment. In D85697#2340317 , @janosbenjaminantal wrote: > In D85697#2338249 , @njames93 wrote: > >> In D85697#2234468 , >> @janosbenjaminantal wrote: >> >>

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88566/new/ https://reviews.llvm.org/D88566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 299347. eduucaldas marked 2 inline comments as not done. eduucaldas added a comment. Add tests, `ElementAndDelimiter` are input iterators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://revi

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini added a comment. Herald added a subscriber: dexonsmith. I don't want to stop the wider discussion, that being said I think I've addressed the comment regarding the content of this PR. Let me know if the latest version is fine or needs further addressing. Thanks. Repository: rG LLV

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/FileEntry.h:33 + +using llvm::Optional; +using llvm::StringRef; JDevlieghere wrote: > Won't this now make `llvm::Optional` visible as `clang::Optional` everywhere > this header is included?

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:39 FoldingRange Range; - Range.startLine = Symbol.range.start.line; - Range.startCharacter = Symbol.range.start.character; - Range.endLine = Symbol.range.end.line; - Range.endCharac

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89719/new/ https://reviews.llvm.org/D89719

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 299348. eduucaldas added a comment. rename getBeforeBegin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/

[clang-tools-extra] 6487ffa - Reland "[yaml2obj][ELF] - Simplify the code that performs sections validation."

Author: Georgii Rymar Date: 2020-10-20T16:25:33+03:00 New Revision: 6487ffafd1dd5ab81c440dde46163218a85d90b5 URL: https://github.com/llvm/llvm-project/commit/6487ffafd1dd5ab81c440dde46163218a85d90b5 DIFF: https://github.com/llvm/llvm-project/commit/6487ffafd1dd5ab81c440dde46163218a85d90b5.diff

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. With this patch, we reject the rename if the new nam

[clang] 1ed506d - [clang] Fix warnings on the missing of explicitly copy constructor on the base class. NFC.

Author: Michael Liao Date: 2020-10-20T10:06:24-04:00 New Revision: 1ed506deaddb41870d22f5b48d52ba710e8d6c00 URL: https://github.com/llvm/llvm-project/commit/1ed506deaddb41870d22f5b48d52ba710e8d6c00 DIFF: https://github.com/llvm/llvm-project/commit/1ed506deaddb41870d22f5b48d52ba710e8d6c00.diff

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added a comment. In D89579#2341513 , @sammccall wrote: > Yep, let's revert to the previous state and land that, and I'll puzzle over > the examples you give (because always returning false shouldn't affect > behavior, just performance). > > I ha

[PATCH] D89708: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h

thakis added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89708/new/ https://reviews.llvm.org/D89708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D89612: NFC: Fix -Wsign-compare warnings on 32-bit builds

dantrushin accepted this revision. dantrushin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89612/new/ https://reviews.llvm.org/D89612 _

[clang] e7a6915 - Revert "[clang] Fix warnings on the missing of explicitly copy constructor on the base class. NFC."

Author: Michael Liao Date: 2020-10-20T10:25:20-04:00 New Revision: e7a69158635a30cb673e443a3b95ece359c72cc1 URL: https://github.com/llvm/llvm-project/commit/e7a69158635a30cb673e443a3b95ece359c72cc1 DIFF: https://github.com/llvm/llvm-project/commit/e7a69158635a30cb673e443a3b95ece359c72cc1.diff

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

ahatanak abandoned this revision. ahatanak added a comment. This was fixed by https://reviews.llvm.org/D86854. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82999/new/ https://reviews.llvm.org/D82999 ___

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

MyDeveloperDay added subscribers: sammccall, djasper, klimek. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6636 - verifyFormat("a *a = aaa, *b = bbb,\n" - " *b = bb

[clang] b78045c - Add a C++ test case for https://reviews.llvm.org/D86854

Author: Akira Hatanaka Date: 2020-10-20T07:34:38-07:00 New Revision: b78045c2ce2dba9b43c0e48340c2a69e444386ec URL: https://github.com/llvm/llvm-project/commit/b78045c2ce2dba9b43c0e48340c2a69e444386ec DIFF: https://github.com/llvm/llvm-project/commit/b78045c2ce2dba9b43c0e48340c2a69e444386ec.diff

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 299356. dgoldman added a comment. Revert to previous AttributedTypeLoc behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selec

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This is *awesome*, thank you so much for working on it! One question I have is: as it stands, this is not a particularly useful matcher because it can only be used to say "yup, there's an attribute" -- are you planning

[PATCH] D89793: [libc++] Explicitly request new/delete in libc++ for Win to ARM Linux builds

ldionne created this revision. ldionne added a reviewer: broadwaylamb. Herald added subscribers: cfe-commits, jkorous, kristof.beyls, mgorny. Herald added a project: clang. ldionne requested review of this revision. Since 9b40ee8eb0c1

[PATCH] D89793: [libc++] Explicitly request new/delete in libc++ for Win to ARM Linux builds

ldionne added a subscriber: rsmith. ldionne added a comment. This should fix the Win to ARM Linux bot failures seen by @rsmith in https://reviews.llvm.org/D68269. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89793/new/ https://reviews.llvm.org/D8

[PATCH] D89794: [SyntaxTree] Implement "by-pointer output parameter to return value" refactoring.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Example of such refactoring: Customer* C; getCustumer(C); Customer C = getCustumer(); Repository: rG LLVM Github Monorepo https://revi

[PATCH] D89793: [libc++] Explicitly request new/delete in libc++ for Win to ARM Linux builds

broadwaylamb accepted this revision. broadwaylamb added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89793/new/ https://reviews.llvm.org/D89793 _

[PATCH] D89793: [libc++] Explicitly request new/delete in libc++ for Win to ARM Linux builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaa928b71a09: [libc++] Explicitly request new/delete in libc++ for Win to ARM Linux builds (authored by ldionne). Repository: rG LLVM Github Monor

[clang] eaa928b - [libc++] Explicitly request new/delete in libc++ for Win to ARM Linux builds

Author: Louis Dionne Date: 2020-10-20T10:51:05-04:00 New Revision: eaa928b71a090905cb178c22054cdf6aa8eb80cb URL: https://github.com/llvm/llvm-project/commit/eaa928b71a090905cb178c22054cdf6aa8eb80cb DIFF: https://github.com/llvm/llvm-project/commit/eaa928b71a090905cb178c22054cdf6aa8eb80cb.diff

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. The build failure is unrelated (see D89463 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89719/new/ https://reviews.llvm.org/D89719 ___ cfe-comm

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

MyDeveloperDay added a comment. I think this patch needs rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88239/new/ https://reviews.llvm.org/D88239 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] 234c47a - [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

Author: Mikhail Maltsev Date: 2020-10-20T15:52:59+01:00 New Revision: 234c47ae2a8e1877de8c661d5bb862ba952eabf9 URL: https://github.com/llvm/llvm-project/commit/234c47ae2a8e1877de8c661d5bb862ba952eabf9 DIFF: https://github.com/llvm/llvm-project/commit/234c47ae2a8e1877de8c661d5bb862ba952eabf9.dif

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG234c47ae2a8e: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2330689 , @njames93 wrote: > Is this diff been created incorrectly again? > > Taking a step back, Is Hungarian notation really a case style, Seems to me > its mainly about the prefix and a user may want `DWORD dwUPPER_C

[clang] c76cdea - Explicitly initialize StreamingDiagnostic in derived class copy ctors

Author: Hans Wennborg Date: 2020-10-20T17:18:46+02:00 New Revision: c76cdeac93380b434349738d96f83d3ffda9869c URL: https://github.com/llvm/llvm-project/commit/c76cdeac93380b434349738d96f83d3ffda9869c DIFF: https://github.com/llvm/llvm-project/commit/c76cdeac93380b434349738d96f83d3ffda9869c.diff

[clang] 03a5f7c - Try to make GCC5 happy about the CfgTraits thing

Author: Hans Wennborg Date: 2020-10-20T17:18:42+02:00 New Revision: 03a5f7ce12e2111c8b7bc5a95cff4c51b516250f URL: https://github.com/llvm/llvm-project/commit/03a5f7ce12e2111c8b7bc5a95cff4c51b516250f DIFF: https://github.com/llvm/llvm-project/commit/03a5f7ce12e2111c8b7bc5a95cff4c51b516250f.diff

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/FileEntry.h:33 + +using llvm::Optional; +using llvm::StringRef; dexonsmith wrote: > JDevlieghere wrote: > > Won't this now make `llvm::Optional` visible as `clang::Optional` > > everywhere t

[clang-tools-extra] 7819411 - [clang] Use SourceLocation as key in hash maps, NFCI

Author: Mikhail Maltsev Date: 2020-10-20T16:24:09+01:00 New Revision: 781941183700b52d11b27227e3341385447610fa URL: https://github.com/llvm/llvm-project/commit/781941183700b52d11b27227e3341385447610fa DIFF: https://github.com/llvm/llvm-project/commit/781941183700b52d11b27227e3341385447610fa.dif

[PATCH] D69840: [clang] Use SourceLocation as key in hash maps, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG781941183700: [clang] Use SourceLocation as key in hash maps, NFCI (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D69840?vs=299126&id=299366#toc Repository: rG LLVM Github Mo

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

dexonsmith updated this revision to Diff 299365. dexonsmith added a comment. Use `#include ` to pull `StringRef` and `Optional` into `clang::`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89761/new/ https://reviews.llvm.org/D89761 Files: clang/include/clang/Basic/FileEntry.h cla

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall added a comment. In D89743#2341779 , @aaron.ballman wrote: > This is *awesome*, thank you so much for working on it! Thanks for the comments - haven't addressed them yet, but wanted to clarify scope first. > One question I have is: as it stan

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

hubert.reinterpretcast added a comment. I have two concerns over the choice of the option form/name. Firstly, there's an `-mabi=` option that is used to select for ABI extensions. The choice of using an `-mabi=` suboption for selecting between the extended vector ABI and the default vector ABI

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski created this revision. Herald added subscribers: cfe-commits, dexonsmith, dang. Herald added a project: clang. awarzynski requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. As discussed in [1], ClangFlags::DriverOption is currentl

[PATCH] D89801: [SystemZ][ZOS] Set short-enums as the default for z/OS

Jonathan.Crowther created this revision. Jonathan.Crowther added reviewers: rsmith, abhina.sreeskantharajan, dlj. Herald added a project: clang. Herald added a subscriber: cfe-commits. Jonathan.Crowther requested review of this revision. This patch sets short-enums to be the default for z/OS. Re

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jhuber6 added a comment. Initial version. This fails a few tests and needs additional test cases for the additional functionality as well as support inside the runtime library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89802/new/ https://revie

[PATCH] D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros

baloghadamsoftware updated this revision to Diff 299378. baloghadamsoftware added a comment. Tests added, code reformatted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89380/new/ https://reviews.llvm.org/D89380 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInit

[PATCH] D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In D89380#2330076 , @alexfh wrote: > Thanks for the fix! However, I'm not sure it's possible to correctly rewrite > code in all cases where macros are involved. See a

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM. I'm not sure why we need 3 different test files to test the very similar patterns - just programmer preference? Wait a day or so to commit in case anyone else has comments. CHANGES SIN

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki added a comment. In D69903#2340020 , @dexonsmith wrote: > An alternative would be to update the unions to an `AlignedCharArrayUnion` > and use `SourceLocation` directly. WDYT? So, say, in `DeclarationNameLoc`, I would add `AlignedCharArrayUnion` a

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. In D86671#2341838 , @dougpuob wrote: > Hi @njames93, > > It's a smart idea, the rework for it is worth. There is a special case if > lowercase name with Hungarian prefix, it possibly makes variable ambiguous, > like the `Case1`.

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2341638 , @mantognini wrote: > I don't want to stop the wider discussion, that being said I think I've > addressed the comment regarding the content of this PR. Let me know if the > latest version is fine or needs fur

  1   2   3   >