[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx updated this revision to Diff 298745. flx added a comment. Add more complete fake version of std::function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89332/new/ https://reviews.llvm.org/D89332 Files: clang-tools-extra/clang-tidy/performa

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} lebedev.ri wrote: > flx wrote: > > lebedev

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89523/new/ https://reviews.llvm.org/D89523 _

[PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

bcardiff abandoned this revision. bcardiff added a comment. Closing in favor of D84563 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87590/new/ https://reviews.llvm.org/D87590 _

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:807 +default: + break; +} Do we want to error in the "default" case? Not that anyone is likely to use -mfloat-abi on those targets, but I'd prefer not to silently miscompile

[clang] 24b5266 - [Format/ObjC] Correctly handle base class with lightweight generics and protocol

Author: Ben Hamilton Date: 2020-10-16T15:12:25-06:00 New Revision: 24b5266892c30e2c9cb6ea28c2631e988a5754b6 URL: https://github.com/llvm/llvm-project/commit/24b5266892c30e2c9cb6ea28c2631e988a5754b6 DIFF: https://github.com/llvm/llvm-project/commit/24b5266892c30e2c9cb6ea28c2631e988a5754b6.diff

[PATCH] D89496: [Format/ObjC] Correctly handle base class with lightweight generics and protocol

This revision was automatically updated to reflect the committed changes. Closed by commit rG24b5266892c3: [Format/ObjC] Correctly handle base class with lightweight generics and protocol (authored by benhamilton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 298757. dgoldman added a comment. Lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/clangd

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 298759. dgoldman added a comment. Fix merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/clangd/

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

yaxunl added a comment. I am OK with the changes regarding null pointer. I guess people seldom set pointer to zero address in OpenCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520 ___

[clang] 552c6c2 - PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

Author: Richard Smith Date: 2020-10-16T14:34:35-07:00 New Revision: 552c6c2328723a248c2b4d2765f75d49129dff20 URL: https://github.com/llvm/llvm-project/commit/552c6c2328723a248c2b4d2765f75d49129dff20 DIFF: https://github.com/llvm/llvm-project/commit/552c6c2328723a248c2b4d2765f75d49129dff20.diff

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG552c6c232872: PR44406: Follow behavior of array bound constant folding in more recent… (authored by rsmith). Changed prior to commit: https://revi

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith updated this revision to Diff 298764. rsmith added a comment. Rebase on D89523 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520 Files: clang/lib/AST/ExprConstant.c

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; erichkeane wrote: > rjmccall wrote: > > ...I made this comment in my first review, but Phabricator threw it

[clang] d30155f - [PowerPC] Implementation of 128-bit Binary Vector Rotate builtins

Author: Albion Fung Date: 2020-10-16T18:03:22-04:00 New Revision: d30155feaa9c4ddd09cb115fb30ea5810f63af9c URL: https://github.com/llvm/llvm-project/commit/d30155feaa9c4ddd09cb115fb30ea5810f63af9c DIFF: https://github.com/llvm/llvm-project/commit/d30155feaa9c4ddd09cb115fb30ea5810f63af9c.diff L

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGd30155feaa9c: [PowerPC] Implementation of 128-bit Binary Vector Rotate builtins (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D86819?vs=295393&id=298770#toc Repository: rG

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; rsmith wrote: > erichkeane wrote: > > rjmccall wrote: > > > ...I made this comment in my first review, but

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

rnk added inline comments. Comment at: lld/Common/ErrorHandler.cpp:78 } - _exit(val); + llvm::sys::Process::Exit(val); } This appears to have regressed shutdown. `sys::Process::Exit` calls `exit`, not `_exit`, so now atexit destructors are run. That's unin

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2445 + FPO.getFPExceptionMode() != LangOptions::FPE_Ignore || + FPO.getAllowFEnvAccess()) && Info.Ctx.getLangOpts().CPlusPlus) { +Info.FFDiag(E, diag::note_constexpr_float_arithmetic_strict);

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

phosek added a comment. I apologize for the late response, I somehow missed the earlier responses. We have successfully used this feature in Fuchsia and found it useful, but I agree that the issues raised need to be addressed. Unfortunately @paulkirth is no longer working on this project. I hop

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

aganea marked an inline comment as done. aganea added inline comments. Comment at: lld/Common/ErrorHandler.cpp:78 } - _exit(val); + llvm::sys::Process::Exit(val); } rnk wrote: > This appears to have regressed shutdown. `sys::Process::Exit` calls `exit`, >

[clang] d4aac67 - Make the check for whether we should memset(0) an aggregate

Author: Richard Smith Date: 2020-10-16T16:48:22-07:00 New Revision: d4aac67859640bdb7e8ed3123a00c3f200f89b9c URL: https://github.com/llvm/llvm-project/commit/d4aac67859640bdb7e8ed3123a00c3f200f89b9c DIFF: https://github.com/llvm/llvm-project/commit/d4aac67859640bdb7e8ed3123a00c3f200f89b9c.diff

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; rsmith wrote: > rsmith wrote: > > erichkeane wrote: > > > rjmccall wrote: > > > > ...I made this commen

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2335627 , @jvesely wrote: > In D89372#2335027 , @Anastasia wrote: > >> In D89372#2334728 , @jvesely wrote: >> >>> In D89372#2334225

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added a comment. We can't have it always match, that would require us to reject the conversion to a bare function-pointer type, which is required by the standard. I'm not sure if MSVC's multiple conversions hack is conformant or not, but it's at least more conformant than that. CHANG

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes created this revision. compositeprimes added reviewers: alexfh, gribozavr. compositeprimes added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. compositeprimes requested review of this revision. Currently, this would not correct

[PATCH] D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Marking as "Request changes" to get this off my queue; are you still interested in pursuing this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

LLVM buildbot will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D89612: NFC: Fix -Wsign-compare warnings on 32-bit builds

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: dantrushin, hokein, daltenty, stevewan, jasonliu. Herald added a subscriber: hiraditya. Herald added projects: clang, LLVM. hubert.reinterpretcast requested review of this revision. Comparing 32-bit `ptrdiff_t`

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added a comment. In D66324#2336186 , @phosek wrote: > I apologize for the late response, I somehow missed the earlier responses. We > have successfully used this feature in Fuchsia and found it useful, but I > agree that the issues raised need

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

njames93 added a comment. How does this type alias and typedef, In theory that should also be handled. using Functor = std::function<...>; Functor Copy = Orig; // No warning. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:39-44 +AST

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

njames93 added a comment. Probably not quite as verbose but should do the job // RUN: clang-tidy %s --checks=-*,my-check-to-test --warnings-as-errors=* -- -std=c++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

gribozavr2 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:409 + +namespace std { + flx wrote: > gribozavr2 wrote: > > Could you add a nested inline namespace to better imitate what de

<    1   2