[clang] 1992e30 - [WebAssembly] Prototype i8x16.popcnt

Author: Thomas Lively Date: 2020-10-15T21:18:22Z New Revision: 1992e30c2d751f6f1f6ad5190f84e37dece04f7f URL: https://github.com/llvm/llvm-project/commit/1992e30c2d751f6f1f6ad5190f84e37dece04f7f DIFF: https://github.com/llvm/llvm-project/commit/1992e30c2d751f6f1f6ad5190f84e37dece04f7f.diff LOG:

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tlively marked an inline comment as done. Closed by commit rG1992e30c2d75: [WebAssembly] Prototype i8x16.popcnt (authored by tlively). Repository: rG LLVM Github Mon

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option

Xiangling_L added a comment. I am wondering can we split the option related changes to a separate patch for reviews? That would make current patch a bit easier to review and faster to be committed as two small pieces. If it's possible, I am thinking we can try to split it up to the following tw

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rsmith added a comment. In D85802#2333105 , @leonardchan wrote: > In D85802#2332895 , @phosek wrote: > >> In D85802#2332808 , @rnk wrote: >> >>> Would "f[no-]fuchsia-c++-abi-

[clang] 79829a4 - Revert "[clang] Add -fc++-abi= flag for specifying which C++ ABI to use"

Author: Leonard Chan Date: 2020-10-15T14:24:38-07:00 New Revision: 79829a47040512fe54001db839ac59146ca55aec URL: https://github.com/llvm/llvm-project/commit/79829a47040512fe54001db839ac59146ca55aec DIFF: https://github.com/llvm/llvm-project/commit/79829a47040512fe54001db839ac59146ca55aec.diff

[clang] e384e94 - Revert "[HIP] Change default --gpu-max-threads-per-block value to 1024"

Author: Yaxun (Sam) Liu Date: 2020-10-15T17:25:55-04:00 New Revision: e384e94fbe7c1d5c89fcdde33ffda04e9802c2ce URL: https://github.com/llvm/llvm-project/commit/e384e94fbe7c1d5c89fcdde33ffda04e9802c2ce DIFF: https://github.com/llvm/llvm-project/commit/e384e94fbe7c1d5c89fcdde33ffda04e9802c2ce.dif

[PATCH] D89498: HeaderSearch: Simplify use of FileEntryRef in HeaderSearch::LookupFile, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Simplify `HeaderSearch::LookupFile`. Instead of deconstructing a `FileEntryRef` into a name and `FileEntry` and then rebuilding it later, use

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. If the answer is that we consider (2) to be incorrect, but that this is only a partial step in that direction, I think that's fine -- that's enough that we can know where the bug is if / when

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

rnk updated this revision to Diff 298473. rnk added a comment. - simplify some more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89362/new/ https://reviews.llvm.org/D89362 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeGenCXX/mic

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Makes a lot more sense now. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89362/new/ https://reviews.llvm.org/D89362

[PATCH] D74130: [clang] fix consteval call in default arguements

keryell added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:16329 + /// If we can't handle immediate invocations yet. add them to the outer scope. + /// This occurs for default argument of lambdas as we can't know if the lambda Repository: r

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fbab4025eb5: [MS] Apply `inreg` to AArch64 sret parms on instance methods (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 5fbab40 - [MS] Apply `inreg` to AArch64 sret parms on instance methods

Author: Reid Kleckner Date: 2020-10-15T14:54:42-07:00 New Revision: 5fbab4025eb57b12f2842ab188ff07a110708e1d URL: https://github.com/llvm/llvm-project/commit/5fbab4025eb57b12f2842ab188ff07a110708e1d DIFF: https://github.com/llvm/llvm-project/commit/5fbab4025eb57b12f2842ab188ff07a110708e1d.diff

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#2333247 , @rsmith wrote: > In D85802#2333105 , @leonardchan > wrote: > >> In D85802#2332895 , @phosek wrote: >> >>> In D85802#2332808

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay updated this revision to Diff 298480. MaskRay edited the summary of this revision. MaskRay added a comment. Add an example about inconsistency. Elaborate on the limitation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88712/new/ https://re

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. In D88712#2333294 , @rsmith wrote: > If the answer is that we consider (2) to be incorrect, but that this is only > a partial step in that direction, I think that's fine -- that's enough that > we can know where the bug is if / w

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a338599fbaa: [CGBuiltin] Respect asm labels and redefine_extname for builtins with… (authored by MaskRay). Repository: rG LLVM Github Monorepo C

[clang] 5a33859 - [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

Author: Fangrui Song Date: 2020-10-15T15:14:38-07:00 New Revision: 5a338599fbaa805587227779bde0a9986cb4646d URL: https://github.com/llvm/llvm-project/commit/5a338599fbaa805587227779bde0a9986cb4646d DIFF: https://github.com/llvm/llvm-project/commit/5a338599fbaa805587227779bde0a9986cb4646d.diff

[PATCH] D89503: SourceManager: Factor out helpers for common SLocEntry lookup pattern, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Add helpers `getSLocEntryOrNull`, which handles the `Invalid` logic around `getSLocEntry`, and `getSLocEntryForFile`, which also checks for

[PATCH] D89507: SourceManager: Change SourceManager::isMainFile to take a FileEntry, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. `SourceManager::isMainFile` does not use the filename, so it doesn't need the full `FileEntryRef`; in fact, it's misleading to take the name b

[PATCH] D89508: SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. `SourceManager::getFileEntryRefForID`'s remaining callers just want the filename component, which is coming from the `FileInfo`. Rep

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith added a comment. In D89488#2332998 , @dexonsmith wrote: > I'd still appreciate feedback on the direction, but > `clang/test/ClangScanDeps/modules-full.cpp` is failing (getting > `""` listed twice under `"file-deps"` for each translation unit)

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

Eugene.Zelenko added a comment. I think will be good idea to add test for suffix/prefix too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89407/new/ https://reviews.llvm.org/D89407 ___ cfe-commits maili

[PATCH] D74130: [clang] fix consteval call in default arguments

rsmith added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2928 + SmallVectorImpl &ParamInfo, + SourceLocation &EllipsisLoc, bool InConstantConstext = false); void ParseBracketDeclarator(Declarator &D); Comment a

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 298503. dexonsmith added a comment. Rebased on top of https://reviews.llvm.org/D89508. Still some things to split apart, but the bug is fixed and this is a fair bit smaller. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89488/new/ https://review

[PATCH] D89508: SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC

dexonsmith added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:729-730 if (const SrcMgr::SLocEntry *Entry = getSLocEntryForFile(FID)) if (auto *Content = Entry->getFile().getContentCache()) if (Content && Content->OrigEntry) +return Entry->

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG273c299d5d64: [PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting (authored by vsk, committed by compnerd). Repository: rG LLVM Git

[clang] 273c299 - [PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting

Author: Vedant Kumar Date: 2020-10-15T23:13:33Z New Revision: 273c299d5d649a0222fbde03c9a41e41913751b4 URL: https://github.com/llvm/llvm-project/commit/273c299d5d649a0222fbde03c9a41e41913751b4 DIFF: https://github.com/llvm/llvm-project/commit/273c299d5d649a0222fbde03c9a41e41913751b4.diff LOG:

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 298508. dexonsmith added a comment. Removing some noise from the patch that I missed in the last update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89488/new/ https://reviews.llvm.org/D89488 Files: clang-tools-extra/clangd/ParsedAST.cpp c

[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: usaxena95, ributzka, kadircet. dexonsmith requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. In `ReplayPreamble::replay`, use `getFileRef` instead of `getFile`, and

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 298517. dexonsmith added a comment. Peeled off the clangd change into https://reviews.llvm.org/D89514 and rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89488/new/ https://reviews.llvm.org/D89488 Files: clang/include/clang/Basic/FileMa

[PATCH] D89484: [AMDGPU][HIP] Switch default DWARF version to 5

t-tye accepted this revision. t-tye added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89484/new/ https://reviews.llvm.org/D89484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] fc031d2 - Switch the default of VerifyIntegerConstantExpression from constant

Author: Richard Smith Date: 2020-10-15T16:58:47-07:00 New Revision: fc031d29bea856f2b91a250fd81c5f9fb79dbe07 URL: https://github.com/llvm/llvm-project/commit/fc031d29bea856f2b91a250fd81c5f9fb79dbe07 DIFF: https://github.com/llvm/llvm-project/commit/fc031d29bea856f2b91a250fd81c5f9fb79dbe07.diff

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. In D89177#2332675 , @beanz wrote: > In D89177#2332627 , @ldionne wrote: > >> That isn't what I meant. It's entirely okay for the runtimes to be driven >> via `AddExternalProject` like the r

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith created this revision. rsmith added reviewers: Anastasia, bader, yaxunl. Herald added subscribers: kerbowa, nhaehnle, jvesely. Herald added a project: clang. rsmith requested review of this revision. Permitting non-standards-driven "do the best you can" constant-folding of array bounds is p

[PATCH] D89521: FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This reduces noise in a future patch, but shouldn't change anything otherwise. https://reviews.llvm.org/D89521 Files: clang/include/clang

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 298530. dexonsmith retitled this revision from "WIP: FileManager: Shrink FileEntryRef to the size of a pointer" to "FileManager: Shrink FileEntryRef to the size of a pointer". dexonsmith added a comment. Rebase on top of https://reviews.llvm.org/D89521 to

[PATCH] D89441: RFC: Potential fixes to function-instrument=xray-never

ianlevesque updated this revision to Diff 298534. ianlevesque added a comment. Apply the fix in XRayInstrumentation, add test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89441/new/ https://reviews.llvm.org/D89441 Files: llvm/lib/CodeGen

[clang-tools-extra] cc175c2 - Support ObjC in IncludeInserter

Author: Alexander Kornienko Date: 2020-10-16T04:12:32+02:00 New Revision: cc175c2cc8e638462bab74e0781e06f9b6eb5017 URL: https://github.com/llvm/llvm-project/commit/cc175c2cc8e638462bab74e0781e06f9b6eb5017 DIFF: https://github.com/llvm/llvm-project/commit/cc175c2cc8e638462bab74e0781e06f9b6eb5017

[PATCH] D89276: Support ObjC in IncludeInserter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc175c2cc8e6: Support ObjC in IncludeInserter (authored by alexfh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith created this revision. rsmith added a reviewer: eli.friedman. Herald added a project: clang. rsmith requested review of this revision. Old GCC used to aggressively fold VLAs to constant-bound arrays at block scope in GNU mode. That's non-conforming, and more modern versions of GCC only do t

[PATCH] D89372: [OpenCL] Remove unused extensions

jvesely added a comment. In D89372#2332997 , @Anastasia wrote: > In D89372#2332853 , @jvesely wrote: > >> `cl_khr_byte_addressable_stores` changes language semantics. without it, >> pointer dereferences of types sm

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

efriedma added a comment. Also update the documentation? See https://clang.llvm.org/docs/UsersManual.html#differences-between-various-standard-modes . Comment at: clang/lib/Sema/SemaDecl.cpp:5939 +ElemTy = TryToFixInvalidVariablyModifiedType(ElemTy, Context, +

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

efriedma added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2278 ArraySize, &SizeVal, Diagnoser, - (S.LangOpts.GNUMode || S.LangOpts.OpenCL) ? Sema::AllowFold -: Sema::NoFold); + S.LangOpts.OpenCL ? Sema

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

catskul added a comment. In D14484#2246171 , @FStefanni wrote: > Hi to all, > > I am also interested to this option, since match my personal style, but more > important, in my experience, this kind of formatting is very used. > I hope it will be implement

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:409 + +namespace std { + Could you add a

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith marked 3 inline comments as done. rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5939 +ElemTy = TryToFixInvalidVariablyModifiedType(ElemTy, Context, + SizeIsNegative, Oversized); +if (ElemTy.isN

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 298546. LuoYuanke added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/am

[PATCH] D89025: [RISCV] Add -mtune support

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfa7094e49cf: [RISCV] Add -mtune support (authored by Kito Cheng ). Herald added a subscriber: NickHung. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] cfa7094 - [RISCV] Add -mtune support

Author: Kito Cheng Date: 2020-10-16T13:55:08+08:00 New Revision: cfa7094e49cfb7e37a84c0aa57c85c64c0581d17 URL: https://github.com/llvm/llvm-project/commit/cfa7094e49cfb7e37a84c0aa57c85c64c0581d17 DIFF: https://github.com/llvm/llvm-project/commit/cfa7094e49cfb7e37a84c0aa57c85c64c0581d17.diff LO

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} flx wrote: > lebedev.ri wrote: > >

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added inline comments. Comment at: llvm/lib/IR/AsmWriter.cpp:379 +Out << "aarch64_darwincc"; +break; case CallingConv::SPIR_FUNC: Out << "spir_func"; break; mstorsjo wrote: > The new code here has a different indentation than the rest; the

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added inline comments. Comment at: llvm/lib/IR/AsmWriter.cpp:379 +Out << "aarch64_darwincc"; +break; case CallingConv::SPIR_FUNC: Out << "spir_func"; break; aguinet wrote: > mstorsjo wrote: > > The new code here has a different indentation

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 298548. aguinet added a comment. Fix one clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 Files: clang/include/clang-c/Index.h clang/include/clang

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

sepavloff added a comment. Probably there is an issue with code generation. The source: constexpr float func_01(float x, float y) { return x + y; } float V1 = func_01(1.0F, 0x0.01p0F); compiled with '-frounding-math' must produce dynamic initializer. It however is evaluated at

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added inline comments. Comment at: llvm/lib/AsmParser/LLParser.cpp:2147 +CC = CallingConv::Tail; +break; case lltok::kw_cc: { Again here this "big" diff is a result of clang-format. We can see that "kw_aarch64_sve_vector_pcs" has been "clang-f

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:876 SDValue LowerAAPCS_VASTART(SDValue Op, SelectionDAG &DAG) const; + SDValue LowerAAPCSFromDarwin_VASTART(SDValue Op, SelectionDAG &DAG) const; SDValue LowerDarwin_VASTART(SDValue O

<    1   2