[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Reading up on the Ninja multi-config generator a bit, you can define your own build types, so you should be able to create e.g. one build type for LTO and another for PIC. You'd still need some external logic to define that you use the LTO mode for executables and the P

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek added a comment. In D89177#2326832 , @smeenai wrote: > In D89177#2325566 , @phosek wrote: > >> We've already considered introducing a similar mechanism so thank you for >> working on this! There's one issue

[PATCH] D89300: [clang-rename] Fix rename on variable templates.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added a project: clang. hokein requested review of this revision. This patch adds support for renaming variable templates. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89300 Files: clang/include/clang/

[PATCH] D89301: [X86] Add user-level interrupt instructions

tianqing created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya, mgorny. Herald added projects: clang, LLVM. tianqing requested review of this revision. For more details about these instructions, please refer to the latest ISE document: https://software.intel.c

[clang] 6c23cbc - [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

Author: Simon Pilgrim Date: 2020-10-13T09:28:39+01:00 New Revision: 6c23cbc5603cf0011f8d57b0354954aeca695daf URL: https://github.com/llvm/llvm-project/commit/6c23cbc5603cf0011f8d57b0354954aeca695daf DIFF: https://github.com/llvm/llvm-project/commit/6c23cbc5603cf0011f8d57b0354954aeca695daf.diff

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c23cbc5603c: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics… (authored by RKSimon). Repository: rG LLVM Github M

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet added a comment. In D89277#2326376 , @nridge wrote: > This is neat! Are there plans to add vscode client support to invoke this? Yes, since we control the plugin in vscode we should have a way to invoke it there. (we already have support for `sw

[PATCH] D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89220/new/ https://reviews.llvm.org/D89220

[PATCH] D89300: [clang-rename] Fix rename on variable templates.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Oh, that's neat, thanks! Comment at: clang/include/clang/AST/DeclTemplate.h:3098 llvm::FoldingSetVector & - getPartialSpecializations(); + getPartialSpecializations(

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Mon, 12 Oct 2020 at 22:01, Galina Kistanova wrote: > Thanks, Vitaly! > > Let's have them there for at least 24 hours, shall we? > We can do that. > > Could you move sanitizer-buildbot1, sanitizer-buildbot3, > sanitizer-buildbot7 as well, please? > Done. > AnnotatedCommand on the staging

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. - Add assertions for other preconditions. - If nothing is modified, don't mark it. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas updated this revision to Diff 297800. eduucaldas added a comment. minor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89303/new/ https://reviews.llvm.org/D89303 Files: clang/lib/Tooling/Syntax/Tree.cpp Index: clang/lib/Tooling/Synta

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas updated this revision to Diff 297803. eduucaldas added a comment. minor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89303/new/ https://reviews.llvm.org/D89303 Files: clang/lib/Tooling/Syntax/Tree.cpp Index: clang/lib/Tooling/Synta

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:103 #ifndef NDEBUG - for (auto *N = New; N; N = N->getNextSibling()) { + for (auto *N = New; N; N = N->NextSibling) { assert(N->Parent == nullptr); ---

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

SouraVX added a comment. Thanks for the patch! Overall it's in pretty nice state and conformant to design highlighted. Could you please `clang-format` this patch, There are lot of `lint` warning that causes lot of noise while reviewing. Couple of NIT comments inline. I've tried marking all but

[PATCH] D89307: [clangd] Disable extract variable for RHS of assignments

kadircet created this revision. kadircet added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https:/

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added a comment. Hi, Thank you for modifying the implementation to facilitate the extension to other targets. Please add `libmvec`-specific tests is `clang/Driver/fveclib.c`, and simplify the loop-vectorize tests. Other than that, I only have minor comments. Francesco

[clang] 9fa7f48 - [Fixed Point] Add fixed-point to floating point cast types and consteval.

Author: Bevin Hansson Date: 2020-10-13T13:26:56+02:00 New Revision: 9fa7f48459761fa13205f4c931484b0977c35746 URL: https://github.com/llvm/llvm-project/commit/9fa7f48459761fa13205f4c931484b0977c35746 DIFF: https://github.com/llvm/llvm-project/commit/9fa7f48459761fa13205f4c931484b0977c35746.diff

[clang] 101309f - [AST] Change return type of getTypeInfoInChars to a proper struct instead of std::pair.

Author: Bevin Hansson Date: 2020-10-13T13:26:56+02:00 New Revision: 101309fe048e66873cfd972c47c4b7e7f2b99f41 URL: https://github.com/llvm/llvm-project/commit/101309fe048e66873cfd972c47c4b7e7f2b99f41 DIFF: https://github.com/llvm/llvm-project/commit/101309fe048e66873cfd972c47c4b7e7f2b99f41.diff

[PATCH] D86447: [AST] Change return type of getTypeInfoInChars to a proper struct instead of std::pair.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG101309fe048e: [AST] Change return type of getTypeInfoInChars to a proper struct instead of… (authored by ebevhan). Repository: rG LLVM Github Mono

[PATCH] D86631: [Fixed Point] Add fixed-point to floating point cast types and consteval.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fa7f4845976: [Fixed Point] Add fixed-point to floating point cast types and consteval. (authored by ebevhan). Repository: rG LLVM Github Monorepo

[PATCH] D89307: [clangd] Disable extract variable for RHS of assignments

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:400 + // This would just result in duplicating the code. + if (const auto *BO = Parent->ASTNode

[clang-tools-extra] 002968a - [clang-tidy] Add an example for misc-unused-alias-decls

Author: Sylvestre Ledru Date: 2020-10-13T13:56:04+02:00 New Revision: 002968a320463237f0ccea754a7482b229e34cf1 URL: https://github.com/llvm/llvm-project/commit/002968a320463237f0ccea754a7482b229e34cf1 DIFF: https://github.com/llvm/llvm-project/commit/002968a320463237f0ccea754a7482b229e34cf1.dif

[PATCH] D89270: [clang-tidy] Add an example for misc-unused-alias-decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG002968a32046: [clang-tidy] Add an example for misc-unused-alias-decls (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske updated this revision to Diff 297828. balazske added a comment. Removed C++ support. Other small changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https://reviews.llvm.org/D87449 Files: clang-tools-extra/clang-tidy/cert/

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov updated this revision to Diff 297822. ASDenysPetrov added a comment. Updated. Removed a new test file, moved the test to an existing file instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89055/new/ https://reviews.llvm.org/D89055 Files: clang/lib/StaticAnalyzer/Co

[PATCH] D89309: [ThinLTO] In documentation, mention possible value for concurrency flags

aganea created this revision. aganea added reviewers: thakis, hans. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. aganea requested review of this revision. As suggested here: https://reviews.llvm.org/D75153#2323939 Repository:

[clang] bddef54 - Raise the timeout in DirectoryWatcherTest to 10 s

Author: Hans Wennborg Date: 2020-10-13T14:25:25+02:00 New Revision: bddef54c502811fa1406d1161d4baa15b56ebc32 URL: https://github.com/llvm/llvm-project/commit/bddef54c502811fa1406d1161d4baa15b56ebc32 DIFF: https://github.com/llvm/llvm-project/commit/bddef54c502811fa1406d1161d4baa15b56ebc32.diff

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

hans added a comment. We're seeing the tests for this fail in Chromium's Clang builds: https://bugs.chromium.org/p/chromium/issues/detail?id=1137737 I'll try increasing the test's timeout for now and see if that helps. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D89312: [SVE][CodeGen]Use TypeSize comparison operators in clang

CarolineConcatto created this revision. Herald added subscribers: cfe-commits, psnobl, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. CarolineConcatto requested review of this revision. The patch replaces comparison greater/lower or equal than by TypeSize::isKnownXY, w

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2326551 , @rsmith wrote: > In D76620#2324858 , @erichkeane > wrote: > >> The feature that this supports is a part of the SYCL 2020 Provisional Spec, >> I thought that was suff

[PATCH] D89309: [ThinLTO] In documentation, mention possible values for concurrency flags

hans added a comment. Thanks for documenting these! I wonder if including the "CPU sockets" part is more confusing than helpful (especially if the reader doesn't know about CPU sockets). The sockets don't really matter here anyway. Sometimes the term "physical core" is used in relation to hype

[clang] c78da03 - [clang] Improve handling of physical registers in inline assembly operands.

Author: Jonas Paulsson Date: 2020-10-13T15:09:52+02:00 New Revision: c78da037783bda0f27f4d82060149166e6f0c796 URL: https://github.com/llvm/llvm-project/commit/c78da037783bda0f27f4d82060149166e6f0c796 DIFF: https://github.com/llvm/llvm-project/commit/c78da037783bda0f27f4d82060149166e6f0c796.diff

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc78da037783b: [clang] Improve handling of physical registers in inline assembly operands. (authored by jonpa). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D89313: Fix implicit TypeSize casts in EmitCheckValue

CarolineConcatto created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CarolineConcatto requested review of this revision. Using getFixedSize() with: V->getType()->getPrimitiveSizeInBits() like this: V->getType()->getPrimitiveSizeInBits().getFixedSize() m

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

spatel added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls-finite.ll:9 +define void @exp_f32(float* nocapture %varray) { +; CHECK-LABEL: @exp_f32( +; CHECK-NEXT: entry: fpetrogalli wrote: > I think you are over-testing her

[PATCH] D89314: [SyntaxTree] Bug fix in `MutationsImpl::addAfter`.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. - Add assertions to other `MutationsImpl` member functions - `findPrevious` is a free function Repository: rG LLVM Github Monorepo https://rev

[PATCH] D89146: [SyntaxTree] Fix rtti for `Expression`.

eduucaldas updated this revision to Diff 297842. eduucaldas added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89146/new/ https://reviews.llvm.org/D89146 Files: clang/include/clang/Tooling/Syntax/Nodes.h Index: clang/include

[PATCH] D89284: [clangd] Propagate CollectMainFileRefs to BackgroundIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3c13fab6be: [clangd] Propagate CollectMainFileRefs to BackgroundIndex (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang-tools-extra] cb3c13f - [clangd] Propagate CollectMainFileRefs to BackgroundIndex

Author: Nathan Ridge Date: 2020-10-13T09:20:18-04:00 New Revision: cb3c13fab6beac4666865b68bea59aae593aaf83 URL: https://github.com/llvm/llvm-project/commit/cb3c13fab6beac4666865b68bea59aae593aaf83 DIFF: https://github.com/llvm/llvm-project/commit/cb3c13fab6beac4666865b68bea59aae593aaf83.diff

[clang] f84c77f - Revert "Raise the timeout in DirectoryWatcherTest to 10 s"

Author: Hans Wennborg Date: 2020-10-13T15:21:06+02:00 New Revision: f84c77f424e15316f7f46f484880162a7cbcd80b URL: https://github.com/llvm/llvm-project/commit/f84c77f424e15316f7f46f484880162a7cbcd80b DIFF: https://github.com/llvm/llvm-project/commit/f84c77f424e15316f7f46f484880162a7cbcd80b.diff

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fhahn added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls-finite.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt -vector-library=LIBMVEC-X86 -inject-tli-mappings -loop-vectorize -S < %s | FileChe

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fhahn added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls.ll:1 +; RUN: opt -vector-library=LIBMVEC -inject-tli-mappings -force-vector-width=4 -force-vector-interleave=1 -loop-vectorize -S < %s | FileCheck %s + spatel wrot

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fhahn added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls-finite.ll:82 + +!1 = distinct !{!1, !2, !3} +!2 = !{!"llvm.loop.vectorize.width", i32 4} fhahn wrote: > I don't think we need this. You can just pass `-force-vector

[PATCH] D89309: [ThinLTO] In documentation, mention possible values for concurrency flags

aganea updated this revision to Diff 297845. aganea added a comment. As suggested by @hans. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89309/new/ https://reviews.llvm.org/D89309 Files: clang/docs/ThinLTO.rst Index: clang/docs/ThinLTO.rst ==

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added a comment. Hi Fangrui(@MaskRay), are you okay with this patch to land as is? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

Xiangling_L updated this revision to Diff 297848. Xiangling_L added a comment. Use regex to match AIX layout dumping format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89064/new/ https://reviews.llvm.org/D89064 Files: clang/test/Layout/itanium-pack-and-align.cpp clang/test/Layou

[PATCH] D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with suggestion. Comment at: clang/test/Layout/itanium-pack-and-align.cpp:19 // CHECK-NEXT: 1 | int y -// CHECK-NEXT:

[PATCH] D89309: [ThinLTO] In documentation, mention possible values for concurrency flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1dbf05f5b44d: [ThinLTO][Documentation] Mention possible values for concurrency flags (authored by aganea). Repository: rG LLVM Github Monorepo CH

[clang] 1dbf05f - [ThinLTO][Documentation] Mention possible values for concurrency flags

Author: Alexandre Ganea Date: 2020-10-13T09:57:58-04:00 New Revision: 1dbf05f5b44db17dcd8520b032e83061189ff4f8 URL: https://github.com/llvm/llvm-project/commit/1dbf05f5b44db17dcd8520b032e83061189ff4f8 DIFF: https://github.com/llvm/llvm-project/commit/1dbf05f5b44db17dcd8520b032e83061189ff4f8.dif

[libunwind] 6b7a49b - Fix all the CMake code that can only handle -stdlib= but not --stdlib=

Author: Raphael Isemann Date: 2020-10-13T16:05:21+02:00 New Revision: 6b7a49bb43d58c2c08fddb9f6c538ee52806de0a URL: https://github.com/llvm/llvm-project/commit/6b7a49bb43d58c2c08fddb9f6c538ee52806de0a DIFF: https://github.com/llvm/llvm-project/commit/6b7a49bb43d58c2c08fddb9f6c538ee52806de0a.dif

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

martong created this revision. martong added reviewers: teemperor, shafik. Herald added subscribers: cfe-commits, pengfei, gamesh411, Szelethus, arphaman, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong requested review of this revision. During the imp

[PATCH] D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr

martong created this revision. martong added reviewers: teemperor, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong requested review of this revision. During the import of FormatAttrs w

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. > Perhaps this'd be more robust with ScopeExit? Not really, `OnError` is not executed when/if the function succeeds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-c

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

yaxunl added a comment. CUDA/HIP are facing similar issues, i.e. consistency of name mangling of kernels between host/device compilation of the same TU. I hope this feature to be implemented in a generic way so that it may be reusable for other offloading languages. Repository: rG LLVM Gith

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2327617 , @yaxunl wrote: > CUDA/HIP are facing similar issues, i.e. consistency of name mangling of > kernels between host/device compilation of the same TU. I hope this feature > to be implemented in a generic way s

[PATCH] D89146: [SyntaxTree] Fix rtti for `Expression`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8f1790fdb8c: [SyntaxTree] Fix rtti for `Expression`. (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] a8f1790 - [SyntaxTree] Fix rtti for `Expression`.

Author: Eduardo Caldas Date: 2020-10-13T14:47:43Z New Revision: a8f1790fdb8ce1c53f024870cd51f32724d4c55f URL: https://github.com/llvm/llvm-project/commit/a8f1790fdb8ce1c53f024870cd51f32724d4c55f DIFF: https://github.com/llvm/llvm-project/commit/a8f1790fdb8ce1c53f024870cd51f32724d4c55f.diff LOG

[PATCH] D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/ASTMerge/attr/Inputs/FormatAttr.cpp:2 +int foo(const char * fmt, ...) +__attribute__ ((__format__ (__scanf__, 1, 2)));

[PATCH] D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89319/new/ https://reviews.llvm.org/D89319 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D89025: [RISCV] Add -mtune support

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM, but I would like other people to also review this, if possible. (Just be sure to check/fix the clang-format warnings and the inline comments). Comment at: cla

[PATCH] D89025: [RISCV] Add -mtune support

luismarques added a comment. In D89025#2324334 , @khchen wrote: > RISCV supports `-mcpu` with default empty arch to align gcc's `-mtune` > behavior since clang didn't support `-mtune` before. But now clang has > `-mtune`, is it a good idea to remove thos

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 ___ cfe-commits mailing list cfe-commits@

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

hans added a comment. The longer timeout didn't help :( I'm not sure what's different about the machine where this is failing. Maybe it's some filesystem issue due to being a VM? Any ideas for good printfs or similar that could be added to figure out exactly what part is failing? Repository:

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

saudi added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1420 + if (Var->getInit()) +Value = Var->evaluateValue(); + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { I encountered an assert inside `evaluateValue(

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

saudi added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1420 + if (Var->getInit()) +Value = Var->evaluateValue(); + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { saudi wrote: > I encountered an assert inside

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. You know on both sides that a lambda is used as a kernel, yes? Why not simply introduce that into the mangling of lambdas, so that the subset of lambdas used as kernels form a stable sequence? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2327901 , @rjmccall wrote: > You know on both sides that a lambda is used as a kernel, yes? Why not > simply introduce that into the mangling of lambdas, so that the subset of > lambdas used as kernels form a stable

[PATCH] D89312: [SVE][CodeGen]Use TypeSize comparison functions in clang

CarolineConcatto updated this revision to Diff 297884. CarolineConcatto added a comment. -Use getFixedSize instead of isKnowXY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89312/new/ https://reviews.llvm.org/D89312 Files: clang/lib/CodeGen/CGBu

[PATCH] D89125: AMDGPU: Remove -mamdgpu-debugger-abi option

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2eaa914514c: AMDGPU: Remove -mamdgpu-debugger-abi option (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] e2eaa91 - AMDGPU: Remove -mamdgpu-debugger-abi option

Author: Konstantin Zhuravlyov Date: 2020-10-13T12:20:28-04:00 New Revision: e2eaa914514c26c8e51c76148996a2e9cf74613c URL: https://github.com/llvm/llvm-project/commit/e2eaa914514c26c8e51c76148996a2e9cf74613c DIFF: https://github.com/llvm/llvm-project/commit/e2eaa914514c26c8e51c76148996a2e9cf7461

Re: [PATCH] D88666: DirectoryWatcher: add an implementation for Windows

If I had to guess, my money would be on a deadlock. To unblock, I'd propose reverting this patch until we can figure it out. During the review, a deadlock was fixed related to the watcher thread, but perhaps we missed one for the notifier thread. On Tue, Oct 13, 2020 at 8:40 AM Hans Wennborg via

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

aeubanks added a comment. I've also been seeing some failures on phab reviews, e.g. https://reviews.llvm.org/D89188. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. In D76620#2327910 , @erichkeane wrote: > In D76620#2327901 , @rjmccall wrote: > >> You know on both sides that a lambda is used as a kernel, yes? Why not >> simply introduce that into the

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2327976 , @rjmccall wrote: > In D76620#2327910 , @erichkeane > wrote: > >> In D76620#2327901 , @rjmccall wrote: >> >>> You know on both

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:618-619 FPOptions OldFPFeatures; +llvm::fp::ExceptionBehavior OldExcept; +llvm::RoundingMode OldRounding; Optional FMFGuard; sepavloff wrote: > Is it possible to merge th

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. In D76620#2327988 , @erichkeane wrote: > In D76620#2327976 , @rjmccall wrote: > >> In D76620#2327910 , @erichkeane >> wrote: >> >>> In D76620#23279

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2328011 , @rjmccall wrote: > In D76620#2327988 , @erichkeane > wrote: > >> In D76620#2327976 , @rjmccall wrote: >> >>> In D76620#232791

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/ASTImporter.cpp:8109 + FromAttr->getAttributeSpellingListIndex()); + ToAttr->setPackExpansion(FromAttr->isPackExpansion()); + ToAttr->se

[PATCH] D89184: Support complex target features combinations

tra accepted this revision. tra added a subscriber: echristo. tra added a comment. This revision is now accepted and ready to land. @echristo : FYI, just in case you have an opinion on bringing required feature constraint checks one step closer to being Turing-complete. :-) LGTM as far as syntax

[PATCH] D89184: Support complex target features combinations

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. Sorry, I didn't mean to stamp the change as LGTM overall yet. Can't find a way to un-LGTM, so marking it as `Request Changes` for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D89332: Always allow std::function to be copied.

flx created this revision. flx added a reviewer: aaron.ballman. Herald added a project: clang. flx requested review of this revision. Since its call operator is const but can modify the state of its underlying functor we cannot tell whether the copy is necessary or not. This avoids false positive

[PATCH] D89184: Support complex target features combinations

craig.topper added a comment. This is needed for D89105 and was split from it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ cfe-commits mailing list cfe-commit

[PATCH] D88314: Added llvm-string-referencing check

aaron.ballman added a comment. In D88314#2322870 , @bogser01 wrote: > @aaron.ballman Thank you for picking up this review! Running the check over > the entire LLVM causes ~74K warnings across 430 files. As to the false > positive rate it's tricky to meas

[clang] b76dc11 - [analyzer] NFC: Move IssueHash to libAnalysis.

Author: Artem Dergachev Date: 2020-10-13T10:53:10-07:00 New Revision: b76dc111dd02672488df794570d82e3edbbfa5d8 URL: https://github.com/llvm/llvm-project/commit/b76dc111dd02672488df794570d82e3edbbfa5d8 DIFF: https://github.com/llvm/llvm-project/commit/b76dc111dd02672488df794570d82e3edbbfa5d8.dif

[clang] 44b7cf2 - [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Author: Artem Dergachev Date: 2020-10-13T10:53:10-07:00 New Revision: 44b7cf2983b6a8373c99a9b254f8c3f944e03f35 URL: https://github.com/llvm/llvm-project/commit/44b7cf2983b6a8373c99a9b254f8c3f944e03f35 DIFF: https://github.com/llvm/llvm-project/commit/44b7cf2983b6a8373c99a9b254f8c3f944e03f35.dif

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd4b3f123d6e: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions. (authored by dergachev.a). Herald added a subscriber: steakhal. Repository: rG LLVM Github Monorepo CHANGES S

[clang] fd4b3f1 - [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Author: Artem Dergachev Date: 2020-10-13T10:53:10-07:00 New Revision: fd4b3f123d6e64769881e4c6351d5bbbdac30ce3 URL: https://github.com/llvm/llvm-project/commit/fd4b3f123d6e64769881e4c6351d5bbbdac30ce3 DIFF: https://github.com/llvm/llvm-project/commit/fd4b3f123d6e64769881e4c6351d5bbbdac30ce3.dif

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG44b7cf2983b6: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis. (authored by dergachev.a). Ch

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb76dc111dd02: [analyzer] NFC: Move IssueHash to libAnalysis. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://rev

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} Just put it here? Repository: r

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > NoQ wrote: >

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > No

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:103 #ifndef NDEBUG - for (auto *N = New; N; N = N->getNextSibling()) { + for (auto *N = New; N; N = N->NextSibling) { assert(N->Parent == nullptr); eduucaldas wrote: > Through

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} lebedev.ri wrote: > Just put it here? I tr

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:46 + +void ConstCorrectnessCheck::registerMatchers(MatchFinder *Finder) { + const auto ConstType = hasType(isConstQualified()); JonasToth w

[PATCH] D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O

compnerd abandoned this revision. compnerd added a comment. Sure, I think I can do that instead. Thanks for pointing me to that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89078/new/ https://reviews.llvm.org/D89078

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

FWIW, I don't see any issues with my two bots that use buildbot annotated commands: http://lab.llvm.org:8011/#/builders/sanitizer-windows http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc The individual steps don't highlight as green or red, but that's OK for now. On Mon, Oct 12, 2020 at

[PATCH] D89184: Support complex target features combinations

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D89184#2328144 , @craig.topper wrote: > This is needed for D89105 and was split > from it. D89105

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Mon, Oct 12, 2020 at 10:01 PM Galina Kistanova via lldb-commits wrote: > If somebody else could move their AnnotatedCommand bots to the staging area, > that would be much appreciated. I moved the libc bots to staging to now. Thanks, Siva Chandra __

  1   2   >