[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

rjmccall added a comment. It does seem necessary to distinguish weak definitions from weak non-definitions, but that's completely reasonable — those two cases essentially act like totally different attributes that happen to be written with the same spelling. If we acknowledge that, I think tha

[PATCH] D89146: [SyntaxTree] Fix rtti for `Expression`.

eduucaldas updated this revision to Diff 297502. eduucaldas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89146/new/ https://reviews.llvm.org/D89146 Files: clang/include/clang/Tooling/Syntax/Nodes.h Index: clang/include

[PATCH] D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added a project: clang. hokein requested review of this revision. Instead of collecting all specializations and doing a post-filterin, we can just get all targeted specializations from getPartialSpecializationsizations. Rep

[PATCH] D89221: [clang-rename] Fix rename on function template specializations.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added a project: clang. hokein requested review of this revision. previously, we missed to rename occurrences to explicit function template specilizations. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D892

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

junparser added a comment. In D89066#2324151 , @lxfind wrote: > In D89066#2324115 , @junparser wrote: > >> why we should not do this with normal await call? > > To be honest, I don't know yet. My understanding of ho

[PATCH] D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`.

eduucaldas updated this revision to Diff 297511. eduucaldas added a comment. Add asserts to `MutationsImpl::remove` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89147/new/ https://reviews.llvm.org/D89147 Files: clang/include/clang/Tooling/Synta

[PATCH] D89148: [SyntaxTree] Artificial use of the Mutations API.

eduucaldas added a subscriber: gribozavr2. eduucaldas added a comment. This patch implements the use case we discussed. It is merely for illustration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89148/new/ https://reviews.llvm.org/D89148 ___

[PATCH] D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

hokein updated this revision to Diff 297512. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89098/new/ https://reviews.llvm.org/D89098 Files: clang-tools-ex

[PATCH] D89025: [RISCV] Add -mtune support

khchen added a comment. RISCV supports `-mcpu` with default empty arch to align gcc's `-mtune` behavior since clang didn't support `-mtune` before. But now clang has `-mtune`, is it a good idea to remove those options? (ex. `rocket-rv32/rv64`, `sifive-7-rv32/64`) Comment at:

[PATCH] D89131: [clangd] Validate optional fields more strictly.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:800 + return O && O.map("applied", R.applied) && + O.mapOptional("failureReason", R.failureReason); } R.failureReason's type is `llvm::Optional`, I think we should probably

[clang-tools-extra] 702529d - [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

Author: Haojian Wu Date: 2020-10-12T10:46:18+02:00 New Revision: 702529d899c87e9268bb33d836dbc91b6bce0b16 URL: https://github.com/llvm/llvm-project/commit/702529d899c87e9268bb33d836dbc91b6bce0b16 DIFF: https://github.com/llvm/llvm-project/commit/702529d899c87e9268bb33d836dbc91b6bce0b16.diff LO

[PATCH] D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG702529d899c8: [clang] Fix returning the underlying VarDecl as top-level decl for… (authored by hokein). Changed prior to commit: https://reviews.l

[PATCH] D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb406f36dca3: [AST][RecoveryExpr] Build dependent callexpr in C for error-recovery. (authored by hokein). Repository: rG LLVM Github Monorepo CHA

[clang] bb406f3 - [AST][RecoveryExpr] Build dependent callexpr in C for error-recovery.

Author: Haojian Wu Date: 2020-10-12T11:15:01+02:00 New Revision: bb406f36dca3d53690a31e051d6f75f11eba6aa1 URL: https://github.com/llvm/llvm-project/commit/bb406f36dca3d53690a31e051d6f75f11eba6aa1 DIFF: https://github.com/llvm/llvm-project/commit/bb406f36dca3d53690a31e051d6f75f11eba6aa1.diff LO

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. @reviewers A note regarding the changes in Clang. This patch introduces a Flang option (`-test-io`), that should not be available/visible in Clang. AFAIK, there's no precedent of that, hence `options::NoClangOption` is introduced. This is discussed in more detail her

[PATCH] D89045: [AST][RecoveryExpr] Don't perform early typo correction in C.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8852d30b1c1b: [AST][RecoveryExpr] Don't perform early typo correction in C. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89045/new/ h

[clang] 8852d30 - [AST][RecoveryExpr] Don't perform early typo correction in C.

Author: Haojian Wu Date: 2020-10-12T11:24:45+02:00 New Revision: 8852d30b1c1b3b65cec0147cdf442051aa35e31b URL: https://github.com/llvm/llvm-project/commit/8852d30b1c1b3b65cec0147cdf442051aa35e31b DIFF: https://github.com/llvm/llvm-project/commit/8852d30b1c1b3b65cec0147cdf442051aa35e31b.diff LO

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:191 -- Support for -march=sapphirerapids was added. +* Support for ``-march=sapphirerapids`` and ``-march=x86-64-v[234]`` has been added. Fix the bullet point: '-' Please can you extend

[PATCH] D89135: [clangd] Stop capturing trace args if the tracer doesn't need them.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/support/Trace.cpp:91 public: -JSONSpan(JSONTracer *Tracer, llvm::StringRef Name, llvm::json::Object *Args) +llvm::jso

[PATCH] D88463: [clangd] Try harder to get accurate ranges for documentSymbols in macros

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! This seems totally complete now, though I bet there's another case possible somehow! Comment at: clang-tools-extra/clangd/FindSymbols.cpp:157 + SourceLocation

[PATCH] D89225: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled

mati865 created this revision. mati865 added a reviewer: mstorsjo. mati865 added a project: clang. Herald added subscribers: cfe-commits, mgorny. mati865 requested review of this revision. Otherwise it's easy to hit 2^16 DLL exports limit. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 abandoned this revision. mati865 added a comment. Opened https://reviews.llvm.org/D89225 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D87547 ___ cfe-commits m

[clang-tools-extra] f1bf41e - Fix buildbot failure for 702529d899c87e9268bb33d836dbc91b6bce0b16.

Author: Haojian Wu Date: 2020-10-12T12:04:44+02:00 New Revision: f1bf41e433e196ecffcc4fb7cd04c58d48445425 URL: https://github.com/llvm/llvm-project/commit/f1bf41e433e196ecffcc4fb7cd04c58d48445425 DIFF: https://github.com/llvm/llvm-project/commit/f1bf41e433e196ecffcc4fb7cd04c58d48445425.diff LO

[PATCH] D88204: [clangd] Drop path suffix mapping for std symbols

kadircet marked an inline comment as done. kadircet added a comment. > We don't have an alternative database for these. Maybe we should keep the > mechanism but stop using it for the standard library? What do you think? Yes i think you are right. Just dropping STL mappings from the list. Repos

[PATCH] D88204: [clangd] Drop path suffix mapping for std symbols

kadircet updated this revision to Diff 297528. kadircet added a comment. - Only drop STL mapping instead of getting rid of suffix mapping completely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88204/new/ https://reviews.llvm.org/D88204 Files:

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

sepavloff added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:137-139 + FPOptions FPFeatures = E->getFPFeaturesInEffect(CGF.getLangOpts()); + + ConstructorHelper(FPFeatures); The local variable `FPFeatures` can be eliminated here. ===

[PATCH] D89204: Make likelihood lit test less brittle

jmorse accepted this revision. jmorse added a comment. This revision is now accepted and ready to land. This fixes things for us, and by limiting to one optimisation pass it's much less brittle for the future -- much appreciated! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: Upcoming upgrade of LLVM buildbot

Thanks, I see them. On Wed, 7 Oct 2020 at 16:32, Galina Kistanova wrote: > They are online now - http://lab.llvm.org:8011/#/waterfall?tags=sanitizer > > AnnotatedCommand has severe design conflict with the new buildbot. > We have changed it to be safe and still do something useful, but it will >

[PATCH] D88413: [clangd] Add a metric for tracking memory usage

kadircet updated this revision to Diff 297542. kadircet marked an inline comment as done. kadircet added a comment. - Make traversal a free function and take metric to populate as a parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88413/new/

[clang-tools-extra] c2d4280 - [clangd] Validate optional fields more strictly.

Author: Sam McCall Date: 2020-10-12T13:01:59+02:00 New Revision: c2d4280328e4f69fd9e1258196e9dbc8362fce95 URL: https://github.com/llvm/llvm-project/commit/c2d4280328e4f69fd9e1258196e9dbc8362fce95 DIFF: https://github.com/llvm/llvm-project/commit/c2d4280328e4f69fd9e1258196e9dbc8362fce95.diff LO

[PATCH] D89131: [clangd] Validate optional fields more strictly.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGc2d4280328e4: [clangd]

[PATCH] D89225: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled

mstorsjo added a reviewer: ASDenysPetrov. mstorsjo added a comment. +1, looks sensible to me - I can give it the formal approval a bit later, but leaving it open for a bit for others to comment on first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D89135: [clangd] Stop capturing trace args if the tracer doesn't need them.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/Trace.cpp:91 public: -JSONSpan(JSONTracer *Tracer, llvm::StringRef Name, llvm::json::Object *Args) +llvm::json::Object Args; +JSONSpan(JSONTra

[PATCH] D89135: [clangd] Stop capturing trace args if the tracer doesn't need them.

sammccall updated this revision to Diff 297555. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89135/new/ https://reviews.llvm.org/D89135 Files: clang-tools-e

[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. so that we could start experiment for C. Previously

[PATCH] D89135: [clangd] Stop capturing trace args if the tracer doesn't need them.

kadircet accepted this revision. kadircet added a comment. still LGTM. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89135/new/ https://reviews.llvm.org/D89135 ___ cfe-commits mailing list cfe-co

[PATCH] D89225: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. It works for me. Well done! I've applied your patch and tried this: cmake -GNinja ../llvm -DLLVM_LIT_ARGS=-sv -DLLVM_LINK_LLVM_DYLIB=ON -DLLVM_ENABLE_PROJECTS=clang -DLLVM_TAR

[clang-tools-extra] 8f1de22 - [clangd] Stop capturing trace args if the tracer doesn't need them.

Author: Sam McCall Date: 2020-10-12T13:43:05+02:00 New Revision: 8f1de22c7681a21fcdbe2d8c39de7698baab724a URL: https://github.com/llvm/llvm-project/commit/8f1de22c7681a21fcdbe2d8c39de7698baab724a DIFF: https://github.com/llvm/llvm-project/commit/8f1de22c7681a21fcdbe2d8c39de7698baab724a.diff LO

[PATCH] D89135: [clangd] Stop capturing trace args if the tracer doesn't need them.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f1de22c7681: [clangd] Stop capturing trace args if the tracer doesn't need them. (authored by sammccall). Repository: rG LLVM Github Monorepo CH

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:211 + return element == Other.element && delimiter == Other.delimiter; +} }; Please also define `operator!=` even if it is not used yet. Comment

[PATCH] D89131: [clangd] Validate optional fields more strictly.

sammccall added a comment. Sorry, I thought this was accepted. Had addressed the two comments, happy to address more or revert, LMK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89131/new/ https://reviews.llvm.org/D89131 _

[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is fine as is, but could consider retiring the flags instead. Comment at: clang-tools-extra/clangd/ClangdServer.h:131 +/// If true, turn on the `-frecovery-ast

[PATCH] D89131: [clangd] Validate optional fields more strictly.

hokein added a comment. ah, I thought I clicked the accepted button. anyway, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89131/new/ https://reviews.llvm.org/D89131 ___ cfe-commits mailing list c

[clang-tools-extra] 9407686 - [clangd][NFC] Fix formatting in ClangdLSPServer

Author: Kadir Cetinkaya Date: 2020-10-12T14:24:44+02:00 New Revision: 9407686687907fa2af24219e1d6e57787872bef8 URL: https://github.com/llvm/llvm-project/commit/9407686687907fa2af24219e1d6e57787872bef8 DIFF: https://github.com/llvm/llvm-project/commit/9407686687907fa2af24219e1d6e57787872bef8.dif

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet updated this revision to Diff 297565. kadircet marked 5 inline comments as done. kadircet added a comment. - Separate profiling and exporting into 2 functions - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88417/new/ https://review

[clang-tools-extra] 1968a61 - [clang-tidy] Fix IncludeInserter usage example in a comment.

Author: Alexander Kornienko Date: 2020-10-12T15:05:42+02:00 New Revision: 1968a6155fd5ef178598b204cc6a176719b99f2e URL: https://github.com/llvm/llvm-project/commit/1968a6155fd5ef178598b204cc6a176719b99f2e DIFF: https://github.com/llvm/llvm-project/commit/1968a6155fd5ef178598b204cc6a176719b99f2e

[PATCH] D88417: [clangd] Record memory usages after each notification

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:72 + /// Profiles resource-usage. No-op if there's no active tracer. + void profile(MemoryTree &MT) const

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2324119 , @rjmccall wrote: > Richard and I just found out about this commit, and we've decided to revert > it. I apologize for the very late reversion, but the reality of Clang > development is that it's very diffic

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet updated this revision to Diff 297568. kadircet marked an inline comment as done. kadircet added a comment. - Update stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88417/new/ https://reviews.llvm.org/D88417 Files: clang-tool

[PATCH] D88411: [clangd] Introduce MemoryTrees

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9317f7bf6bd: [clangd] Introduce MemoryTrees (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang-tools-extra] 23a5330 - [clangd] Introduce memory usage dumping to TUScheduler, for Preambles and ASTCache

Author: Kadir Cetinkaya Date: 2020-10-12T15:25:29+02:00 New Revision: 23a53301c545b45a6c809cc3f444c5f4e577f6c0 URL: https://github.com/llvm/llvm-project/commit/23a53301c545b45a6c809cc3f444c5f4e577f6c0 DIFF: https://github.com/llvm/llvm-project/commit/23a53301c545b45a6c809cc3f444c5f4e577f6c0.dif

[clang-tools-extra] f9317f7 - [clangd] Introduce MemoryTrees

Author: Kadir Cetinkaya Date: 2020-10-12T15:25:29+02:00 New Revision: f9317f7bf6bdac10d6f8a1c106ef8d489da7efbf URL: https://github.com/llvm/llvm-project/commit/f9317f7bf6bdac10d6f8a1c106ef8d489da7efbf DIFF: https://github.com/llvm/llvm-project/commit/f9317f7bf6bdac10d6f8a1c106ef8d489da7efbf.dif

[clang-tools-extra] c9d2876 - [clangd] Add a metric for tracking memory usage

Author: Kadir Cetinkaya Date: 2020-10-12T15:25:29+02:00 New Revision: c9d2876da95c5a15c85de8473a0cb5fb44eb3289 URL: https://github.com/llvm/llvm-project/commit/c9d2876da95c5a15c85de8473a0cb5fb44eb3289 DIFF: https://github.com/llvm/llvm-project/commit/c9d2876da95c5a15c85de8473a0cb5fb44eb3289.dif

[clang-tools-extra] a74d594 - [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

Author: Kadir Cetinkaya Date: 2020-10-12T15:25:29+02:00 New Revision: a74d594948611164f88a79ca0544721183a0b19c URL: https://github.com/llvm/llvm-project/commit/a74d594948611164f88a79ca0544721183a0b19c DIFF: https://github.com/llvm/llvm-project/commit/a74d594948611164f88a79ca0544721183a0b19c.dif

[clang-tools-extra] 20f69cc - [clangd] Add a helper for exposing tracer status

Author: Kadir Cetinkaya Date: 2020-10-12T15:25:29+02:00 New Revision: 20f69ccfe64aeab9c32d1698df399bd864dda8b1 URL: https://github.com/llvm/llvm-project/commit/20f69ccfe64aeab9c32d1698df399bd864dda8b1 DIFF: https://github.com/llvm/llvm-project/commit/20f69ccfe64aeab9c32d1698df399bd864dda8b1.dif

[clang-tools-extra] 35871fd - [clangd] Record memory usages after each notification

Author: Kadir Cetinkaya Date: 2020-10-12T15:25:29+02:00 New Revision: 35871fde55ac98b543edd2e7c62d1456a26562d8 URL: https://github.com/llvm/llvm-project/commit/35871fde55ac98b543edd2e7c62d1456a26562d8 DIFF: https://github.com/llvm/llvm-project/commit/35871fde55ac98b543edd2e7c62d1456a26562d8.dif

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa74d59494861: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex (authored by kadircet). Repository: rG LLVM Github M

[PATCH] D88413: [clangd] Add a metric for tracking memory usage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9d2876da95c: [clangd] Add a metric for tracking memory usage (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D88417: [clangd] Record memory usages after each notification

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35871fde55ac: [clangd] Record memory usages after each notification (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D88415: [clangd] Introduce memory usage dumping to TUScheduler, for Preambles and ASTCache

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23a53301c545: [clangd] Introduce memory usage dumping to TUScheduler, for Preambles and… (authored by kadircet). Repository: rG LLVM Github Monore

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 297574. eduucaldas marked 8 inline comments as done. eduucaldas added a comment. Answer comments, TODO: think about templated iterators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://review

[PATCH] D79674: [clang-tidy] Better support for Override function in RenamerClangTidy based checks

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Thanks for the fix! IIUC, this is related to https://bugs.llvm.org/show_bug.cgi?id=34879? Makes sense to specify this in the patch description. Repository: rG LLVM Github Monor

[PATCH] D79674: [clang-tidy] Better support for Override function in RenamerClangTidy based checks

alexfh added a comment. Feel free to ping patches every week or so. It looks like in this case all the reviewers were swamped with something else at the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79674/new/ https://reviews.llvm.org/D79674

[PATCH] D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

hokein added a subscriber: rsmith. hokein added a comment. > Is this https://github.com/clangd/clangd/issues/554 ? :-) Yeah, the github issue exposes multiple bugs, this is part of the fix. The AST of `VarTemplateSpeicalizationDecl` is a bit unusual, given the follow code, template bool X =

[PATCH] D62574: Add support for target-configurable address spaces.

Anastasia added a comment. In D62574#2249817 , @ebevhan wrote: > In D62574#2242471 , @Anastasia wrote: > >> The only thing is that it would be good to test the new target setting logic >> somehow... do you have any

Re: [clang-tools-extra] 702529d - [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

ParsedASTTest.TopLevelDecls has not recovered on clang-ppc64le-rhel since this went in (even when including f1bf41e433e196ecffcc4fb7cd04c58d48445425, which is purported to fix buildbot failures from this commit). http://lab.llvm.org:8011/#/builders/57/builds/81 On Mon, Oct 12, 2020 at 5:06 AM Hao

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88469/new/ https://reviews.llvm.org/D88469 __

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 __

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh added a comment. Sorry for the delay. This patch fell through the cracks. If you're still interested, could you rebase it on top of current HEAD and upload a full diff? Or use the arcanist tool, see https://llvm.org/docs/Phabricator.html. Repository: rCTE Clang Tools Extra CHANGES SI

[clang-tools-extra] b144cd8 - Dump decl when the test matcher fails.

Author: Haojian Wu Date: 2020-10-12T15:42:18+02:00 New Revision: b144cd867b6fdfbf0e80064cb67d06c267fa295c URL: https://github.com/llvm/llvm-project/commit/b144cd867b6fdfbf0e80064cb67d06c267fa295c DIFF: https://github.com/llvm/llvm-project/commit/b144cd867b6fdfbf0e80064cb67d06c267fa295c.diff LO

Re: [clang-tools-extra] 702529d - [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

sorry, I'm looking at it. On Mon, 12 Oct 2020 at 15:35, Hubert Tong wrote: > ParsedASTTest.TopLevelDecls has not recovered on clang-ppc64le-rhel since > this went in (even when including f1bf41e433e196ecffcc4fb7cd04c58d48445425, > which is purported to fix buildbot failures from this commit). >

Re: [clang-tools-extra] 702529d - [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

On Mon, Oct 12, 2020 at 9:43 AM Haojian Wu wrote: > sorry, I'm looking at it. > No problem, thanks! > On Mon, 12 Oct 2020 at 15:35, Hubert Tong < > hubert.reinterpretc...@gmail.com> wrote: > >> ParsedASTTest.TopLevelDecls has not recovered on clang-ppc64le-rhel since >> this went in (even when

[clang-tools-extra] 16a4b0f - [clangd] Disable a failure TopLevelDecls test.

Author: Haojian Wu Date: 2020-10-12T16:03:52+02:00 New Revision: 16a4b0f0e36c8e1efa586ca4b2be8effefa75e6e URL: https://github.com/llvm/llvm-project/commit/16a4b0f0e36c8e1efa586ca4b2be8effefa75e6e DIFF: https://github.com/llvm/llvm-project/commit/16a4b0f0e36c8e1efa586ca4b2be8effefa75e6e.diff LO

Re: [clang-tools-extra] 702529d - [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

I haven't found out the root cause yet. I have disabled this test to make the buildbot happey. Will continue to investigate tomorrow. On Mon, 12 Oct 2020 at 15:45, Hubert Tong wrote: > On Mon, Oct 12, 2020 at 9:43 AM Haojian Wu wrote: > >> sorry, I'm looking at it. >> > No problem, thanks! > >

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov updated this revision to Diff 297579. ASDenysPetrov added a comment. Updat patch due to suggestions and fixed formating. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89055/new/ https://reviews.llvm.org/D89055 Files: clang/lib/StaticAnalyzer/Core/Store.cpp clang/test/

[PATCH] D89238: [clangd] Go-to-definition from non-renaming alias is unambiguous.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. It's not helpful to show the alia

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, kbarton, PowerPC, wschmidt, rsmith. Herald added subscribers: cfe-commits, steven.zhang, pengfei, shchenz. Herald added a project: clang. qiucf requested review of this revision. This patch adds three intrinsics compatible to x86'

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. @rsmith , @teemperor , @ldionne , thoughts on the above? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88984/new/ https://revi

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297606. MaskRay added a comment. Fix bullet point. Add a link to https://gitlab.com/x86-psABIs/x86-64-ABI/-/commit/77566eb03bc6a326811cb7e9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://revi

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:191 -- Support for -march=sapphirerapids was added. +* Support for ``-march=sapphirerapids`` and ``-march=x86-64-v[234]`` has been added. RKSimon

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87604/new/ https://reviews.llvm.org/D87604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

teemperor added a comment. From the LLDB side we can just change our test setup to explicitly add an include the libc++ in our build tree (and have -nostdinc to avoid the libc++ in the SDK). So it wouldn't be a problem for us. I can make a review for that once this gets accepted. Repository:

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon added a comment. I'd prefer that our docs explicitly state what we've implemented instead of just referencing an external webpage. Please add the full explanation to UserManual.rst under the "CPU Architectures Features and Limitations" x86 section for long term reference - the release

[PATCH] D87360: clang-cl: Alias /wd4101 to -Wno-unused-variable

ki.stfu added a comment. @rsmith Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87360/new/ https://reviews.llvm.org/D87360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D87368: clang-cl: Alias /wd5054 to -Wno-deprecated-anon-enum-enum-conversion

ki.stfu added a comment. @rsmith Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87368/new/ https://reviews.llvm.org/D87368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D87364: clang-cl: Alias /wd4238 to -Wno-address-of-temporary

ki.stfu added a comment. @rsmith Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87364/new/ https://reviews.llvm.org/D87364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

ki.stfu added a comment. @rsmith Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87372/new/ https://reviews.llvm.org/D87372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297612. MaskRay added a comment. Update clang/docs/UsersManual.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 Files: clang/docs/ReleaseNotes.rst clang/docs/Use

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard accepted this revision. ostannard added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

MaskRay updated this revision to Diff 297613. MaskRay added a comment. ReleaseNotes.rst: use `` :doc:`UsersManual` `` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

arphaman added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:459 Position P) { - llvm::StringRef Code = SM.getBuffer(SM.getMainFileID())->getBuffer(); + llvm::StringRef Code = SM.getBufferOrFake(SM.

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

lxfind added a comment. In D89066#2324291 , @junparser wrote: > In D89066#2324151 , @lxfind wrote: > >> In D89066#2324115 , @junparser >> wrote: >> >>> why we should not do

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:222 - const llvm::MemoryBuffer *getBufferPtr() const { return Buffer.get(); } + const char *getBufferPtr() const { +return Buffer ? nullptr : Buffer->getBuff

[PATCH] D89204: Make likelihood lit test less brittle

Mordante added a comment. In D89204#2324563 , @jmorse wrote: > This fixes things for us, and by limiting to one optimisation pass it's much > less brittle for the future -- much appreciated! I'm glad to hear it fixes your issue. Thanks for testing! Rep

[PATCH] D89204: Make likelihood lit test less brittle

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG551caec4a8af: Make likelihood lit test less brittle (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 551caec - Make likelihood lit test less brittle

Author: Mark de Wever Date: 2020-10-12T18:58:21+02:00 New Revision: 551caec4a8af79483823e2940d40afb4c1df5da1 URL: https://github.com/llvm/llvm-project/commit/551caec4a8af79483823e2940d40afb4c1df5da1 DIFF: https://github.com/llvm/llvm-project/commit/551caec4a8af79483823e2940d40afb4c1df5da1.diff

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

sylvestre.ledru added a comment. @JakeMerdichAMD as the regression caused by this change is way more significant than the initial bug, I am planning to revert this patch in the next few days (both in master and 11). Please let me know if you have any objection. Repository: rG LLVM Github Mon

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. Thank you. If it were SYCL-namespaced and -restricted, that would be fine, but as is it's positioned as a generic language feature. (I think we might still have had implementation/design feedback, though.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 __

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG012dd42e027e: [X86] Support -march=x86-64-v[234] (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

  1   2   3   >