[PATCH] D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Previously `replaceChildRangeLowLevel` took the new child range as a `Node* New`. `New` was expected to have siblings attached already, and thus i

[PATCH] D89148: [SyntaxTree] Artificial use of the Mutations API.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Not intended for submission. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89148 Files: clang/include/clang/Tooling/Syntax/

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added a comment. In D88737#2321921 , @MaskRay wrote: > A less intrusive approach is to not touch the existing > InitTargetOptionsFromCodeGenFlags without parameters. You can add an > `initTargetOptionsFromCodeGenFlags` with `const Tripe &` as it

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. @ASDenysPetrov what CMake options do you use? I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D87547

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[&CalledFunctions](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +CalledFunctions.push_back(CE); +}}; --

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322325 , @mati865 wrote: > @ASDenysPetrov what CMake options do you use? > I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. How many exports does your DLL end up with - is it close to the

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88754/new/ https://reviews.llvm.org/D88754

[PATCH] D88976: [clang] Use correct address space for global variable debug info

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That looks much nicer. Comment at: clang/test/CodeGenHIP/debug-info-address-class.hip:8 + +// CHECK-DAG: ![[FILEVAR0:[0-9]+]] = distinct !DIGlobalVariable(name: "FileVar0"

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1579 if (EmitDebugInfo && HaveInsertPoint()) { -Address DebugAddr = address; +Address DebugAddr = AllocaAddr.isValid() ? AllocaAddr : address; bool UsePointerValue = NRVO && ReturnValuePointer

[clang] 40cef5a - [clang] Add a test for CGDebugInfo treatment of blocks

Author: Scott Linder Date: 2020-10-09T19:03:21Z New Revision: 40cef5a00eb83f44e946912b74be83e8dc02effb URL: https://github.com/llvm/llvm-project/commit/40cef5a00eb83f44e946912b74be83e8dc02effb DIFF: https://github.com/llvm/llvm-project/commit/40cef5a00eb83f44e946912b74be83e8dc02effb.diff LOG:

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG40cef5a00eb8: [clang] Add a test for CGDebugInfo treatment of blocks (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88754/new/ ht

[PATCH] D89130: [WIP][Sparc] Fix long double on 32-bit Solaris/SPARC

efriedma added a comment. SparcTargetLowering::LowerCall_32 is Sparc-specific code. Maybe you can take a look at where it's crashing, and ask some more specific question? The compiler-rt requirement for __uint128_t is a bit inconvenient, I guess; maybe it could be changed, but that's probably

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 297297. jhuber6 added a comment. Fixing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/captur

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. aeubanks requested review of this revision. Some targets may add required passes via TargetMachine::registerPassBuilderCallbacks(). We need to run those even under -O

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

ASDenysPetrov added a comment. In D87547#2322325 , @mati865 wrote: > @ASDenysPetrov what CMake options do you use? > I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. Sorry for not mentioning that. This is my cmd: cmake -GN

[PATCH] D88976: [clang] Use correct address space for global variable debug info

scott.linder updated this revision to Diff 297309. scott.linder added a comment. Replace uses of CHECK-DAG, use more meaningful names in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88976/new/ https://reviews.llvm.org/D88976 Files: clang/l

[PATCH] D88976: [clang] Use correct address space for global variable debug info

scott.linder added inline comments. Comment at: clang/test/CodeGenHIP/debug-info-address-class.hip:8 + +// CHECK-DAG: ![[FILEVAR0:[0-9]+]] = distinct !DIGlobalVariable(name: "FileVar0", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: {{[0-9]+}}, type: !{{[0-9]+}}, isLocal: false,

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

DiggerLin added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:46 + +void ConstCorrectnessCheck::registerMatchers(MatchFinder *Finder) { + const auto ConstType = hasType(isConstQualified()); JonasToth w

[PATCH] D88314: Added llvm-string-referencing check

aaron.ballman added a comment. It looks like you generated a diff from a previous diff instead of trunk -- can you regenerate the diff against trunk so that reviewers can see the full content of the changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

aaron.ballman added a comment. In D88645#2321980 , @jdoerfert wrote: > (Drive By: This is cool) I didn't say this before, but yeah, I agree -- this is really quite neat, thank you for working on it! Comment at: clang/include/clang/Sem

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. > How many exports does your DLL end up with - is it close to the 64k limit, or > far from it? Is there maybe some other library that is linked in, that > increases the number of exported symbols (=all), or does this DLL only export > explicitly intended symbols with dl

[PATCH] D88968: [WebAssembly] Prototype i16x8.q15mulr_sat_s

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_q15mulr_saturate_s_i8x16, "V8UsV8UsV8Us", "nc", "simd128") + aheejin wrote: > - Is it implemented in the VM? If not shouldn't we use

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:15 +#include "llvm/Support/Windows/WindowsSupport.h" #include #include amccarth wrote: > I don't see a reaso

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd updated this revision to Diff 297324. compnerd marked an inline comment as done. compnerd added a comment. Herald added a subscriber: jfb. Remove unnecessary include, fix an incorrect wait (verified that unit tests now pass!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

Xiangling_L added a comment. In D89064#2320133 , @hubert.reinterpretcast wrote: > Can we use a regex to make this also work in AIX? Sure we can also do that. May I ask is that because we prefer letting AIX support as many LIT testcases as possible? Re

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d74c4351175: DirectoryWatcher: add an implementation for Windows (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5d74c43 - DirectoryWatcher: add an implementation for Windows

Author: Saleem Abdulrasool Date: 2020-10-09T20:55:57Z New Revision: 5d74c435117526616d2c2665f030263b8f60da1b URL: https://github.com/llvm/llvm-project/commit/5d74c435117526616d2c2665f030263b8f60da1b DIFF: https://github.com/llvm/llvm-project/commit/5d74c435117526616d2c2665f030263b8f60da1b.diff

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322643 , @mati865 wrote: >> How many exports does your DLL end up with - is it close to the 64k limit, >> or far from it? Is there maybe some other library that is linked in, that >> increases the number of exported s

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1579 if (EmitDebugInfo && HaveInsertPoint()) { -Address DebugAddr = address; +Address DebugAddr = AllocaAddr.isValid() ? AllocaAddr : address; bool UsePointerValue = NRVO && ReturnValuePo

[clang] d8f58bf - [WebAssembly] Prototype i16x8.q15mulr_sat_s

Author: Thomas Lively Date: 2020-10-09T21:17:53Z New Revision: d8f58bf53a98574ef14568fd830edac5d1fb37f3 URL: https://github.com/llvm/llvm-project/commit/d8f58bf53a98574ef14568fd830edac5d1fb37f3 DIFF: https://github.com/llvm/llvm-project/commit/d8f58bf53a98574ef14568fd830edac5d1fb37f3.diff LOG:

[PATCH] D88968: [WebAssembly] Prototype i16x8.q15mulr_sat_s

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8f58bf53a98: [WebAssembly] Prototype i16x8.q15mulr_sat_s (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D88968?vs=29667

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

hubert.reinterpretcast added a comment. In D89064#2322717 , @Xiangling_L wrote: > In D89064#2320133 , > @hubert.reinterpretcast wrote: > >> Can we use a regex to make this also work in AIX? > > Sure we can also do

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

keryell added a comment. Great feature for all the weird pieces of hardware all around the world! :-) Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2229-2233 + SmallVector Args = { + AnnotatedVal, + Builder.CreateBitCast(CGM.EmitAnnotationString(AnnotationStr),

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jyu2 accepted this revision. jyu2 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

joaomoreira added a comment. I noticed that this commit breaks MUSL 1.2.0. Here is an isolated test-case that illustrates the issue: https://godbolt.org/z/6bdnEh Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87822/new/ https://reviews.llvm.org/D8

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. Reproduced by adding `-DLLVM_ENABLE_ASSERTIONS=ON`. With `-DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON` libLLVM.dll also fails to link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8754

[PATCH] D88314: Added llvm-string-referencing check

bogser01 added a comment. @aaron.ballman Thank you for picking up this review! Running the check over the entire LLVM causes ~74K warnings across 430 files. As to the false positive rate it's tricky to measure. Based on previous analysis on //flang// codebase, I would say roughly 50% of the fix

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. With `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_RANLIB_COMPILER=llvm-ranlib -DCMAKE_AR_COMPILER=llvm-ar -DCMAKE_LINKER=ld.lld -DLLVM_ENABLE_LLD=ON` libclang-cpp.dll has 65535 exports, seems it got truncated? Repository:

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 297355. bogser01 added a comment. Rebase diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-extr

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +// NOT-MS-SAME: line: [[@LINE-3]]

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

I think this is the cause of https://crbug.com/1134762. Can we speculatively revert while coming up with a repro? Or would you like a repro first? On Sun, Sep 27, 2020 at 7:06 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-09-27T19:05:

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek, tstellar. Herald added subscribers: llvm-commits, cfe-commits, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_ami

LLVM buildbot will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88712/new/ https://reviews.llvm.org/D88712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rjmccall added a comment. The GCC docs seem pretty clear that `-frounding-math` is meant to allow dynamic access to the FP environment. There might be optimizations that are perfectly legal with a constant but non-default rounding mode, and there might be some flag that only implies that weake

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322900 , @mati865 wrote: > With `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_C_COMPILER=clang > -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_RANLIB_COMPILER=llvm-ranlib > -DCMAKE_AR_COMPILER=llvm-ar -DCMAKE_LINKER=ld.lld -DLLVM_ENABL

<    1   2