[clang] 8568113 - Fix Wparentheses warning. NFCI.

Author: Simon Pilgrim Date: 2020-10-08T20:02:19+01:00 New Revision: 85681131019db5d6831fb3980aec683d517e1674 URL: https://github.com/llvm/llvm-project/commit/85681131019db5d6831fb3980aec683d517e1674 DIFF: https://github.com/llvm/llvm-project/commit/85681131019db5d6831fb3980aec683d517e1674.diff

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

ASDenysPetrov added a comment. @NoQ @steakhal Hi, guys. I've just uploaded a patch for solving this and related D77062 . Welcome to review D89055 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

Xiangling_L created this revision. Xiangling_L added reviewers: daltenty, hubert.reinterpretcast, stevewan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. AIX has different layout dumping format from other itanium abis. And for

Re: [cfe-dev] Upcoming upgrade of LLVM buildbot

Hello bot owners, I see a lot of builders went down and not connecting back to the production buildbot. Could you check your bots to make sure they are up and running, please? And report connectivity issues if any with quotes from the logs directly to me. Thanks Galina On Thu, Oct 8, 2020 at

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 created this revision. njames93 added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 requested review of this revision. If a static assert has a message as the right side of an and condition, suggest a fix it of replacing the '&&' to '

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. I don't see any support for verifying fix-its in the test cases so unsure how i could go about testing this change. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:18 #include "clang/Basic/CharInfo.h" +#include "clang/Basic/DiagnosticParse.h" #include

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

v.g.vassilev added a comment. @shafik, I suppose that with a good amount of effort we may be able to test it in a unittest setup. In my point of view, this patch is rather fixing an interface inconsistency which was discovered in the context of cling. The ASTImporter already makes a promise to

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

lxfind created this revision. lxfind added reviewers: lewissbaker, wenlei, bruno, junparser, rjmccall. Herald added subscribers: cfe-commits, modimo, dexonsmith, modocache. Herald added a project: clang. lxfind requested review of this revision. In https://reviews.llvm.org/D87470 I added the chang

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

hubert.reinterpretcast added a comment. Can we use a regex to make this also work in AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89064/new/ https://reviews.llvm.org/D89064 ___ cfe-commits mailing

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

jasonliu added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:340 +LANGOPT(AIXPragmaPack, 1, 0, "AIX #pragma pack handling") + Not sure if AIXPragmaPack is the best name here. It's more like IBM xl pragma pack handling on AIX. Would it

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. akhuang requested review of this revision. We used to only emit static const data members in CodeView as S_CONSTANTS when they

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

dblaikie added a comment. I'll probably leave the llvm/CodeView parts of this for @rnk - but for the clang parts, they should have corresponding clang test coverage & I'd be curious to see the test for that to understand what the IR was before/after this change. (& to understand if/how either o

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

steveire added a comment. In D88275#2319290 , @ymandel wrote: > TL;DR Stephen's fix works; I'll drop this patch. > This is a longer discussion and not necessarily worth having on this review > thread. Are you attending the dev meeting today? If so, wan

Re: [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hey Andrzej, What are you seeing in your buildbot logs? Is it this error? `twisted.spread.flavors.NoSuchMethod: No such method: remote_getWorkerInfo` If so, you might want to try updating your buildbot worker. I updated llvmlibc's to 2.8.4 and that seemed to solve the connection problem: https:/

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. In D89072#2320209 , @dblaikie wrote: > I'll probably leave the llvm/CodeView parts of this for @rnk - but for the > clang parts, they should have corresponding clang test coverage & I'd be > curious to see the test for that to un

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rGafff74e5c26f: [HWAsan][NewPM] Handle hwasan like other sanitizers (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88936/new/ https://r

[clang] afff74e - [HWAsan][NewPM] Handle hwasan like other sanitizers

Author: Arthur Eubanks Date: 2020-10-08T14:43:21-07:00 New Revision: afff74e5c26fd8b57968ae111a2a4fc8fc8deda8 URL: https://github.com/llvm/llvm-project/commit/afff74e5c26fd8b57968ae111a2a4fc8fc8deda8 DIFF: https://github.com/llvm/llvm-project/commit/afff74e5c26fd8b57968ae111a2a4fc8fc8deda8.diff

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:82 +DirectoryWatcherCallback Receiver) +: Callback(Receiver) { + // Pre-compute the real location as we will be handing

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

avemilia added a comment. As a workaround, you can use a standalone utility called `unbuffer` from Tcl/Tk's expect bundle. Just put it in front of the clang-tidy invocation. In case you use run-clang-tidy, you can put `invocation.insert(0, 'unbuffer')` right above `proc = subprocess.Popen(invoc

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

NoQ added a comment. This actually looks correct to me but i suggest a bit more investigation. Architecturally, it doesn't make sense to me that `CastRetrievedVal()` does anything beyond `svalBuilder.dispatchCast(V, castTy)`. After all, there's only one way to cast a value from one type to anot

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 297068. akhuang added a comment. Update clang test for static data members, and make it test the general cases on the windows target as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://rev

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 297069. atmnpatel added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 297070. atmnpatel added a comment. Fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 updated this revision to Diff 297072. njames93 added a comment. Remove unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 Files: clang/lib/Parse/ParseDeclCXX.cpp Index: clang/l

[PATCH] D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O

compnerd created this revision. compnerd added reviewers: vsk, rnk. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya. Herald added projects: clang, LLVM. compnerd requested review of this revision. In order for the hot/cold splitting pass to graduate out of experimental status,

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked 3 inline comments as done. compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:92 +Length = GetFinalPathNameByHandleW(DirectoryHandle, Buffer.data(), + Buffer.capacit

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd updated this revision to Diff 297079. compnerd marked an inline comment as done. compnerd added a comment. address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666 Files: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-win

Re: [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hi Paula, This error is fine. The buildbot has tested the worker version. 0.8.x apparently does not have that method. The error gets handled gracefully on the server side. At least it seems so so far. That should not prevent your bot from connecting. Thanks Galina On Thu, Oct 8, 2020 at 2:11 P

[clang] d1751d1 - PR47175: Ensure type-dependent function-style casts have dependent

Author: Richard Smith Date: 2020-10-08T17:00:22-07:00 New Revision: d1751d14a6b2787974a4d203be2b554de9fa613c URL: https://github.com/llvm/llvm-project/commit/d1751d14a6b2787974a4d203be2b554de9fa613c DIFF: https://github.com/llvm/llvm-project/commit/d1751d14a6b2787974a4d203be2b554de9fa613c.diff

[clang] 66face6 - Re-land [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Author: Alexandre Ganea Date: 2020-10-08T20:49:17-04:00 New Revision: 66face6aa0f5f68de56067b0dff3295e47fdf66c URL: https://github.com/llvm/llvm-project/commit/66face6aa0f5f68de56067b0dff3295e47fdf66c DIFF: https://github.com/llvm/llvm-project/commit/66face6aa0f5f68de56067b0dff3295e47fdf66c.dif

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

jdoerfert added a comment. The new code/functionality wrt. no exit blocks should be a separate commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 ___ cfe-com

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

tejohnson created this revision. tejohnson added a reviewer: davidxl. Herald added subscribers: wenlei, dang, hiraditya. Herald added projects: clang, LLVM. tejohnson requested review of this revision. Similar to -fprofile-generate=, add -fmemory-profile= which takes a directory path. This is pass

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

bnbarham updated this revision to Diff 297098. bnbarham added a comment. Removed platform-specific path separator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89024/new/ https://reviews.llvm.org/D89024 Files: clang/lib/AST/DeclObjC.cpp clang/test/Index/Inputs/hidden-redecls-sub.h

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

LiuChen3 abandoned this revision. LiuChen3 added a comment. In D60748#2310148 , @RKSimon wrote: > @wxiao3 @LiuChen3 Are you still looking at this or should it be abandoned? I will abandon this patch for it is difficult to confirm the behavior of gcc. CH

[clang] fbb499e - [AST] Fix crashes caused by redeclarations in hidden prototypes

Author: Ben Barham Date: 2020-10-08T19:48:36-07:00 New Revision: fbb499ef255b77c5a3300543de88956b13e706b7 URL: https://github.com/llvm/llvm-project/commit/fbb499ef255b77c5a3300543de88956b13e706b7 DIFF: https://github.com/llvm/llvm-project/commit/fbb499ef255b77c5a3300543de88956b13e706b7.diff LO

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbb499ef255b: [AST] Fix crashes caused by redeclarations in hidden prototypes (authored by bnbarham, committed by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D78699: [X86] Passing union type through register.

This revision was automatically updated to reflect the committed changes. Closed by commit rG26cfb6e562f1: [X86] Passing union type through register (authored by LiuChen3). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 26cfb6e - [X86] Passing union type through register

Author: Liu, Chen3 Date: 2020-10-09T11:24:29+08:00 New Revision: 26cfb6e562f12f8c0d8952120d9df81151dc9c19 URL: https://github.com/llvm/llvm-project/commit/26cfb6e562f12f8c0d8952120d9df81151dc9c19 DIFF: https://github.com/llvm/llvm-project/commit/26cfb6e562f12f8c0d8952120d9df81151dc9c19.diff LO

[PATCH] D78699: [X86] Passing union type through register.

LiuChen3 added a comment. In D78699#2320678 , @bruno wrote: > LGTM Thanks for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78699/new/ https://reviews.llvm.org/D78699

[PATCH] D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd8c9ed726d: [clangd] Add more incomplete_type diagnostics that could be fixed by include… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] efd8c9e - [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

Author: Haojian Wu Date: 2020-10-09T08:51:18+02:00 New Revision: efd8c9ed726df5376ca8ac3ddc75ab91a40dd873 URL: https://github.com/llvm/llvm-project/commit/efd8c9ed726df5376ca8ac3ddc75ab91a40dd873 DIFF: https://github.com/llvm/llvm-project/commit/efd8c9ed726df5376ca8ac3ddc75ab91a40dd873.diff LO

<    1   2