[PATCH] D88985: [clangd] Temporary fix for bad inference in Decision Forest.

usaxena95 abandoned this revision. usaxena95 added a comment. Yeah. Not very critical as of now. You can patch it if you want incase you want to try it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88985/new/ https://reviews.llvm.org/D88985

[clang-tools-extra] 69daa36 - [clangd] Disambiguate overloads of std::move for header insertion.

Author: Sam McCall Date: 2020-10-07T19:42:41+02:00 New Revision: 69daa368cad34c3cff7e170d2a32652ce31ca9e5 URL: https://github.com/llvm/llvm-project/commit/69daa368cad34c3cff7e170d2a32652ce31ca9e5 DIFF: https://github.com/llvm/llvm-project/commit/69daa368cad34c3cff7e170d2a32652ce31ca9e5.diff LO

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. > Furthermore, instead of always adding both search paths, we find > the first search path that exists and only add that one. Huh, I'm surprised this wasn't already the behavi

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:557 // :-( llvm::SmallString<256> QName; for (const auto &Entry : IncludeFiles) this one is no longer needed. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69daa368cad3: [clangd] Disambiguate overloads of std::move for header insertion. (authored by sammccall). Repository: rG LLVM Github Monorepo CHA

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

dexonsmith added a comment. Note that I don't see any issues besides splitting the patch and dealing with the clang-format linter problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88984/new/ https://reviews.llvm.org/D88984 _

[PATCH] D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88916/new/ https://reviews.llvm.org/D88916 _

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

tejohnson added a comment. Can you add a test? You can probably just beef up clang/test/CodeGenCXX/virtual-function-elimination.cpp to test this option as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88349/new/ https://reviews.llvm.org/D883

[PATCH] D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:709 ns::X *x; + auto& $type[[[]]a] = *x; x$access[[->]]f(); kadircet wrote: > should this be `$type[[a]]` ? yeah, but this is the actual diagnostic range, tho

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added a comment. The reason that I added the overlapped event was specifically for the cancellation and overlooked the fact that it will be used by the kernel side as well, thanks for catching that! Comment at: clang/unittests/DirectoryWatcher/CMakeLists.txt:1 -if(AP

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 296747. atmnpatel added a comment. Fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296748. jhuber6 added a comment. Removing the architecture detection from lit. Simply changing the tests to use specific architectures, in this case x86_64 and aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

dexonsmith resigned from this revision. dexonsmith added a reviewer: Bigcheese. dexonsmith added a subscriber: Bigcheese. dexonsmith added a comment. Herald added a subscriber: dexonsmith. I'll let @erik.pilkington and @Bigcheese finish this review. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 296752. atmnpatel added a comment. Bump for bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopI

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D86447: [AST] Change return type of getTypeInfoInChars to a proper struct instead of std::pair.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. Sorry I forgot about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86447/new/ https://reviews.llvm.org/D86447

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D87451: add new option -mignore-xcoff-visibility

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: llvm/include/llvm/Target/TargetOptions.h:126 FunctionSections(false), DataSections(false), - UniqueSectionNames(true), UniqueBasicBlockSectionNames(false), - Trap

[clang] 42d9143 - [CodeGen][X86] Cleanup labels on some sse/avx intrinsics tests. NFCI.

Author: Simon Pilgrim Date: 2020-10-07T19:33:14+01:00 New Revision: 42d91438ad27fda6df9499ae2a99b569fc6e2f75 URL: https://github.com/llvm/llvm-project/commit/42d91438ad27fda6df9499ae2a99b569fc6e2f75 DIFF: https://github.com/llvm/llvm-project/commit/42d91438ad27fda6df9499ae2a99b569fc6e2f75.diff

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3209-3214 + else if ((T.isArch64Bit() && TT.isArch32Bit()) || + (T.isArch64Bit() && TT.isArch16Bit()) || + (T.isArch32Bit() && TT.isArch64Bit()) || +

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dblaikie added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962 + case Triple::Wasm: +return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash), + ~0); dschuff wrote: > dschuff wrote: > > I may a

[PATCH] D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC.

hokein updated this revision to Diff 296767. hokein added a comment. update: don't change the order in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88964/new/ https://reviews.llvm.org/D88964 Files: clang-tools-extra/clangd/IncludeFixer.cp

[clang-tools-extra] 9c09e20 - [clangd] Add a NewName optional parameter to clangdServer::prepareRename.

Author: Haojian Wu Date: 2020-10-07T21:18:51+02:00 New Revision: 9c09e2055ee4d4e3b26e393ab460635825a79538 URL: https://github.com/llvm/llvm-project/commit/9c09e2055ee4d4e3b26e393ab460635825a79538 DIFF: https://github.com/llvm/llvm-project/commit/9c09e2055ee4d4e3b26e393ab460635825a79538.diff LO

[PATCH] D88643: [NFC] Correct name of profile function to Profile in APValue

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Good idea. (My use for this in class type non-type template parameters doesn't directly use `APValue`s as values in a folding set, but that seems like a reasonable use case for this functional

[PATCH] D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c09e2055ee4: [clangd] Add a NewName optional parameter to clangdServer::prepareRename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

ldionne created this revision. ldionne added reviewers: arphaman, dexonsmith. Herald added subscribers: cfe-commits, jkorous. Herald added a project: clang. ldionne requested review of this revision. Currently, Clang looks for libc++ headers alongside the installation directory of Clang, and it al

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

ldionne updated this revision to Diff 296772. ldionne added a comment. Split the patch in two Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88984/new/ https://reviews.llvm.org/D88984 Files: clang-tools-extra/test/clang-tidy/infrastructure/Inputs

[PATCH] D85144: [clang] Improve Dumping of APValues

rsmith added a comment. Ideally we should be tree-dumping the `LValue` representation rather than pretty-printing it (and similarly for member pointers and label address differences). The problem with doing so is that we can't interpret the `LValuePathEntry`s without knowing the type of the lva

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

rsmith added a comment. This seems like it would break the opposite situation: a user places a custom clang and the corresponding libc++ somewhere (perhaps in `$HOME`, or perhaps they run Clang from the build tree). Right now we use the custom clang and its corresponding libc++, but with this c

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296778. jhuber6 added a comment. Changed method for comparing the architectures. Enum is local to the loop so it shouldn't pollute the namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https:

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

ABataev added a comment. LG with a nit. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3195 +enum ArchPtrSize { Arch16Bit, Arch32Bit, Arch64Bit }; +auto getArchPtrSize = [](llvm::Triple &T) { + if (T.isArch16Bit()) `const Triple &` Reposit

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4137 +// TODO: Reject __device__ constexpr and __device__ inline in Sema. +if (!D->hasExternalStorage() && !D->isInline()) getCUDARuntime().registerDeviceVar(D, *GV, !D->hasDefin

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

ddcc updated this revision to Diff 296782. ddcc added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88349/new/ https://reviews.llvm.org/D88349 Files: clang/include/clang/Driver/Options.td clang/test/CodeGenCXX/virtual-funct

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296783. jhuber6 added a comment. Okay, I'll push it after this finishes its build and see if buildbot sends me angry emails again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962 + case Triple::Wasm: +return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash), + ~0); dblaikie wrote: > dschuff wrote: > > dschuff

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

mibintc added a comment. ping! Comment at: clang/lib/Parse/ParseDecl.cpp:2290 + // rounding mode. + if (VD->isFileVarDecl() || VD->isConstexpr() || + (!getLangOpts().CPlusPlus && VD->isStaticLocal())) { sepavloff wrote: > sepavlof

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM with the test change suggested below. Comment at: clang/test/CodeGenCXX/virtual-function-elimination.cpp:2 // RUN: %clang_cc1 -triple x86_64-unknown-linux -flto -

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2290 + // rounding mode. + if (VD->isFileVarDecl() || VD->isConstexpr() || + (!getLangOpts().CPlusPlus && VD->isStaticLocal())) { mibintc wrote: > sepavloff wro

[PATCH] D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer

vrnithinkumar updated this revision to Diff 296785. vrnithinkumar added a comment. - Addressing review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87043/new/ https://reviews.llvm.org/D87043 Files: clang/lib/StaticAnalyzer/Checkers/Smar

[PATCH] D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer

vrnithinkumar marked an inline comment as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:106 const auto *InnerPointVal = State->get(ThisRegion); - return InnerPointVal && InnerPointVal->isZeroConstant(); + return

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

plotfi added a comment. Herald added a subscriber: wenlei. @vsk any update on this? Is there anything we can do to help in landing this patch in llvm-project/main? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 updated this revision to Diff 296792. jhuber6 added a comment. Implementing Ye's code. I changed it to putput the architecture as a dependency and then set the value where we define the default architecture. I did a full build from scratch using this and got the sm_70 libraries for my ma

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4137 +// TODO: Reject __device__ constexpr and __device__ inline in Sema. +if (!D->hasExternalStorage() && !D->isInline()) getCUDARu

Re: Upcoming upgrade of LLVM buildbot

It looks like all sanitizer builder are still offline http://lab.llvm.org:8011/#/builders On Tue, 6 Oct 2020 at 00:34, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello everyone, > > The staging buildbot was up and running for 6 days now, and looks good. > > Tomorrow a

[PATCH] D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename.

danielmartin added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:277 + /// + /// If NewName is provided, it peforms a name validation. void prepareRename(PathRef File, Position Pos, Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dblaikie added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962 + case Triple::Wasm: +return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash), + ~0); dschuff wrote: > dblaikie wrote: > > dschuf

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

phosek updated this revision to Diff 296813. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88452/new/ https://reviews.llvm.org/D88452 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.

[PATCH] D89013: [libcxx] Support per-target __config in per-target runtime build

phosek created this revision. phosek added a reviewer: ldionne. Herald added subscribers: libcxx-commits, cfe-commits, s.egerton, dexonsmith, simoncook, mgorny. Herald added projects: clang, libc++. Herald added a reviewer: libc++. phosek requested review of this revision. When using the per-targ

[PATCH] D89013: [libcxx] Support per-target __config in per-target runtime build

phosek added a comment. This is the per-target `__config` (or more preferable `__config_site`) support I mentioned in D88843 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D8901

[PATCH] D88659: [FE]Split SuitableAlign into two parts

jyknight added a comment. > As you mentioned, without this patch, `SuitableAlign` is used for the > predefined `__BIGGEST_ALIGNMENT__` and alignment for alloca. But on AIX, the > __BIGGEST_ALIGNMENT__ should be 8bytes, alloca and > `__attribute__((aligned))` should align to 16bytes considerin

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jdoerfert added a comment. @ye-luo good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88929/new/ https://reviews.llvm.org/D88929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

ddcc updated this revision to Diff 296826. ddcc added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88349/new/ https://reviews.llvm.org/D88349 Files: clang/test/CodeGenCXX/virtual-function-elimination.cpp Index: clang/t

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

ddcc added a comment. Hmm, looks like this was already fixed by e5158b52730d323bb8cd2cba6dc6c89b90cba452 . I guess I'll just commit the test then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

steveire added a comment. I don't get email notifications when I'm pinged on Phab for some reason. I didn't know about this until the email from Aaron. // Fails EXPECT_TRUE( matches(Input, declRefExpr(traverse(TK_IgnoreImplicitCastsAndParentheses,

Re: Upcoming upgrade of LLVM buildbot

They are online now - http://lab.llvm.org:8011/#/waterfall?tags=sanitizer AnnotatedCommand has severe design conflict with the new buildbot. We have changed it to be safe and still do something useful, but it will need more love and care. Please let me know if you have some spare time to work on

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

tejohnson accepted this revision. tejohnson added a comment. LGTM for test - thanks! Yeah, it looks like that cleanup patch inadvertently fixed this issue as a side effect. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88349/new/ https://reviews.l

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc10248829357: Add test for disabling Dead Virtual Function Elimination (authored by ddcc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c102488 - Add test for disabling Dead Virtual Function Elimination

Author: Dominic Chen Date: 2020-10-07T19:20:16-04:00 New Revision: c10248829357fd90030ba091e01b6c253e5848f1 URL: https://github.com/llvm/llvm-project/commit/c10248829357fd90030ba091e01b6c253e5848f1 DIFF: https://github.com/llvm/llvm-project/commit/c10248829357fd90030ba091e01b6c253e5848f1.diff

[PATCH] D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thank you! I think you can commit it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87043/new/ https://reviews.llvm.org/D87043 ___

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88929/new/ https://reviews.llvm.org/D88929 ___ c

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

bnbarham created this revision. bnbarham added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, arphaman, dexonsmith. Herald added a project: clang. bnbarham requested review of this revision. ObjCContainerDecl.getMethod returns a nullptr by default when the container is a hidden protot

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

akyrtzi accepted this revision. akyrtzi added a comment. This revision is now accepted and ready to land. Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89024/new/ https://reviews.llvm.org/D89024

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

bnbarham updated this revision to Diff 296859. bnbarham added a comment. Ran clang-format again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89024/new/ https://reviews.llvm.org/D89024 Files: clang/lib/AST/DeclObjC.cpp clang/test/Index/Inputs/hidden-redecls-sub.h clang/test/Index

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng created this revision. kito-cheng added reviewers: asb, evandro, lenary, khchen. kito-cheng added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, dang, luismarques, apazos, sameer.abuasal, pzheng, pengfei, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes

bnbarham updated this revision to Diff 296861. bnbarham added a comment. Update test to include explicit OSX target triple CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89024/new/ https://reviews.llvm.org/D89024 Files: clang/lib/AST/DeclObjC.cpp clang/test/Index/Inputs/hidden-redec

[clang] b4ffc40 - Update documentation and implementation of stage3 build

Author: Serge Guelton Date: 2020-10-08T07:55:37+02:00 New Revision: b4ffc40d622bb2647852284c78c5e83346f2d630 URL: https://github.com/llvm/llvm-project/commit/b4ffc40d622bb2647852284c78c5e83346f2d630 DIFF: https://github.com/llvm/llvm-project/commit/b4ffc40d622bb2647852284c78c5e83346f2d630.diff

[PATCH] D88990: Update documentation on stage3 cmake build

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4ffc40d622b: Update documentation and implementation of stage3 build (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github M

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

MaskRay added inline comments. Comment at: lld/Common/TargetOptionsCommandFlags.cpp:17 +llvm::TargetOptions +lld::initTargetOptionsFromCodeGenFlags(const llvm::Triple &TheTriple) { + return llvm::codegen::InitTargetOptionsFromCodeGenFlags(TheTriple); jasonliu wr

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:700 Res = ImplicitCastExpr::Create(Context, T, CK, E, nullptr, VK_RValue, - FPOptionsOverride()); + CurFPFeatureOverrides()); -

<    1   2