[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

fanbo-meng created this revision. fanbo-meng added reviewers: abhina.sreeskantharajan, hubert.reinterpretcast, Kai, uweigand. Herald added a project: clang. Herald added a subscriber: cfe-commits. fanbo-meng requested review of this revision. Set the default alignment control variables for z/OS t

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin marked 7 inline comments as done. DiggerLin added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file(XCOFF only) + -

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin updated this revision to Diff 296267. DiggerLin marked 3 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451 Files: clang/docs/Cla

[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

fanbo-meng updated this revision to Diff 296269. fanbo-meng added a comment. fix no newline at end of file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88845/new/ https://reviews.llvm.org/D88845 Files: clang/lib/Basic/Targets/OSTargets.h clang/test/CodeGen/zos-alignment.c Index:

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM to remove rather than move into `readability` unless someone has a good argument as to why it belongs there. I don't think this pattern makes code more readable in general as it recommends using a more verbose syntax (poin

[clang] a2cc883 - [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

Author: Fangrui Song Date: 2020-10-05T12:53:59-07:00 New Revision: a2cc8833683dd124cf2ee96f6d17f7f835da1fc8 URL: https://github.com/llvm/llvm-project/commit/a2cc8833683dd124cf2ee96f6d17f7f835da1fc8 DIFF: https://github.com/llvm/llvm-project/commit/a2cc8833683dd124cf2ee96f6d17f7f835da1fc8.diff

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___ cfe-commits mailing list cfe

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2cc8833683d: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

DiggerLin added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:46 ///< aliases to base ctors when possible. -CODEGENOPT(DataSections , 1, 0) ///< Set when -fdata-sections is enabled. +CODEGENOPT(DataSections

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

ddcc added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88349/new/ https://reviews.llvm.org/D88349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16447 + +bool AIXBitfieldViolation = false; +if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs()) { sfertile wrote: > Can this change can be split out into its own patch? I

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d6d8a2769b3: [RISCV] Add SiFive cores to the CPU option (authored by evandro). Herald added subscribers: cfe-commits, jrtc27. Herald added a project: clang. Changed prior to commit: https://reviews.llv

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe00f189d392d: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 5d6d8a2 - [RISCV] Add SiFive cores to the CPU option

Author: Evandro Menezes Date: 2020-10-05T15:50:57-05:00 New Revision: 5d6d8a2769b3a91fd65b125c2cda64ea27a894bf URL: https://github.com/llvm/llvm-project/commit/5d6d8a2769b3a91fd65b125c2cda64ea27a894bf DIFF: https://github.com/llvm/llvm-project/commit/5d6d8a2769b3a91fd65b125c2cda64ea27a894bf.dif

[clang] e00f189 - [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

Author: Roman Lebedev Date: 2020-10-06T00:00:30+03:00 New Revision: e00f189d392dd9bf95f6a98f05f2d341d06cd65c URL: https://github.com/llvm/llvm-project/commit/e00f189d392dd9bf95f6a98f05f2d341d06cd65c DIFF: https://github.com/llvm/llvm-project/commit/e00f189d392dd9bf95f6a98f05f2d341d06cd65c.diff

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

aaron.ballman added a comment. One request though: can you add a release note about the removal with a brief explanation of why it was removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://reviews.llvm.org/D88831 _

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

yaxunl added a comment. This patch may break some existing HIP applications. For rdc mode, device vars are merged. Host shadow vars should also be in comdat and merged. HIP runtime just ignores the same shadow var registered with the same device var, everything should work. For nordc mode, dev

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

nikic added a comment. This ended up having a rather large impact... Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=567462b48eba1c2d286ce97117994463f4535d2e&to=e00f189d392dd9bf95f6a98f05f2d341d06cd65c&stat=instructions Code size: https://llvm-compile-time-tracker.com/compa

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

bsaleil accepted this revision. bsaleil added a comment. LGTM, please fix the unrelated change when committing. Comment at: clang/test/CodeGen/builtins-ppc-vsx.c:1 -// REQUIRES: powerpc-registered-target +// requires: powerpc-registered-target // RUN: %clang_cc1 -target-featur

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd created this revision. compnerd added reviewers: gribozavr2, MForster. Herald added subscribers: jfb, mgorny. Herald added a project: clang. compnerd requested review of this revision. This adds the skeleton of the YAML Compiler for APINotes. This change only adds the YAML IO model for t

[PATCH] D88863: [docs] Fix vector literal examples that don't compile

ahatanak created this revision. ahatanak added reviewers: nemanjai, ayartsev. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. ahatanak requested review of this revision. Guard the AltiVec vector variables with `#ifdef __VEC__` and remove the last line, wh

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/29545/step_7.txt Can you take a look and revert for now if it takes a while to fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88759/new/ https://reviews.llvm.org/D8875

[clang] a48d480 - [RISCV] Fix broken test

Author: Evandro Menezes Date: 2020-10-05T19:28:31-05:00 New Revision: a48d480e1f7ebc5d5f93507fe1f519496621e259 URL: https://github.com/llvm/llvm-project/commit/a48d480e1f7ebc5d5f93507fe1f519496621e259 DIFF: https://github.com/llvm/llvm-project/commit/a48d480e1f7ebc5d5f93507fe1f519496621e259.dif

[PATCH] D88863: [docs] Fix vector literal examples that don't compile

ahatanak planned changes to this revision. ahatanak added a comment. The parenthesis initialization does not work as documented for GCC or OpenCL vectors, so that has to be fixed too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88863/new/ https:

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

jrtc27 added a comment. In D88759#2313236 , @thakis wrote: > This seems to break tests: http://45.33.8.238/linux/29545/step_7.txt > > Can you take a look and revert for now if it takes a while to fix? I see it should already have been fixed in a48d480e1f

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 updated this revision to Diff 296340. shivanshu3 added a comment. Address Reid's comments: - Use hasFlag instead of hasArg - Add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88680/new/ https://reviews.llvm.org/D88680 Files:

[clang] ded79be - [c++17] Implement P0145R3 during constant evaluation.

Author: Richard Smith Date: 2020-10-05T19:04:14-07:00 New Revision: ded79be63555f4e5bfdb0db27ef22b71fe568474 URL: https://github.com/llvm/llvm-project/commit/ded79be63555f4e5bfdb0db27ef22b71fe568474 DIFF: https://github.com/llvm/llvm-project/commit/ded79be63555f4e5bfdb0db27ef22b71fe568474.diff

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel added a comment. In D88275#2305989 , @aaron.ballman wrote: > In D88275#2303283 , @ymandel wrote: > >>> I'm not concerned about the basic idea behind the proposed matcher, I'm >>> only worried we're making

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. In D87962#2312617 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes I need! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___

Buildbot numbers for the week of 09/20/2020 - 09/26/2020

Hello everyone, Below are some buildbot numbers for the week of 09/20/2020 - 09/26/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

Buildbot numbers for the week of 09/13/2020 - 09/19/2020

Hello everyone, Below are some buildbot numbers for the week of 09/13/2020 - 09/19/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

Buildbot numbers for the week of 09/27/2020 - 10/03/2020

Hello everyone, Below are some buildbot numbers for the last week of 09/27/2020 - 10/03/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

NoQ added a comment. With Z3 //constraint// manager you absolutely want your constraints to be as precise as possible. The only reason we don't add these casts is because it confuses the constraint manager a lot. With a better constraint manager we would have spared ourselves a lot of suffering

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. > i'm pretty worried about our ability to actually achieve that in the near > future This whole cast problem that you're looking into in D85528 is definitely a part of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

asbirlea added a comment. Thank you, Ankit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88138/new/ https://reviews.llvm.org/D88138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert added a comment. In D88491#2306099 , @aaron.ballman wrote: > Do you have test cases for this change? I didn't see any relevant ones in > D88384 . In the revert (rG4fc69ab002382675d84f611f22599cb3cb4a0787

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 296367. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226 Files: clang/include/clang/A

[clang] 70d9dc8 - [AST][RecoveryExpr] Support dependent binary operator in C for error recovery.

Author: Haojian Wu Date: 2020-10-06T08:53:31+02:00 New Revision: 70d9dc867417ac63fe280ab145776f75a9487f0f URL: https://github.com/llvm/llvm-project/commit/70d9dc867417ac63fe280ab145776f75a9487f0f DIFF: https://github.com/llvm/llvm-project/commit/70d9dc867417ac63fe280ab145776f75a9487f0f.diff LO

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70d9dc867417: [AST][RecoveryExpr] Support dependent binary operator in C for error recovery. (authored by hokein). Repository: rG LLVM Github Mono

<    1   2