[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:410-411 setRoundingMode(LO.getFPRoundingMode()); +// FENV access is true if rounding math is enabled. +setAllowFEnvAccess((getRoundingMode() == llvm::RoundingMode::Dynamic)); se

[PATCH] D88810: [clangd] Add isKeyword function.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will be used in rename for doing basic name val

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:578 +for (const NamedDecl *ND : getMembersReferencedViaDependentName( + resolveNestedNameSpecifierToType(DTST->getQualifier()), + [DTST](ASTContext &) { retur

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3423d5c9da81: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

hokein added a comment. @rsmith I'm landing this patch now. Happy to follow-up if you have other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86048/new/ https://reviews.llvm.org/D86048 ___ cf

[clang] 3423d5c - [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

Author: Haojian Wu Date: 2020-10-05T10:35:29+02:00 New Revision: 3423d5c9da812b0076d1cf14e96ce453e35257b6 URL: https://github.com/llvm/llvm-project/commit/3423d5c9da812b0076d1cf14e96ce453e35257b6 DIFF: https://github.com/llvm/llvm-project/commit/3423d5c9da812b0076d1cf14e96ce453e35257b6.diff LO

[PATCH] D85354: [clangd] Reduce availability of extract function

kadircet updated this revision to Diff 296110. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85354/new/ https://reviews.llvm.org/D85354 Files: clang-tools-ex

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet updated this revision to Diff 296111. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88411/new/ https://reviews.llvm.org/D88411 Files: clang-tools-ex

[PATCH] D88413: [clangd] Add a metric for tracking memory usage

kadircet updated this revision to Diff 296112. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88413/new/ https://reviews.llvm.org/D88413 Files: clang-tools-extra/clangd/support/Trace.cpp clang-tools-extra/clan

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

kadircet updated this revision to Diff 296113. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88414/new/ https://reviews.llvm.org/D88414 Files: clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/c

[PATCH] D88415: [clangd] Introduce memory usage dumping to TUScheduler, for Preambles and ASTCache

kadircet updated this revision to Diff 296114. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88415/new/ https://reviews.llvm.org/D88415 Files: clang-tools-extra/clangd/TUScheduler.cpp clang-tools-extra/clangd

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet updated this revision to Diff 296115. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88417/new/ https://reviews.llvm.org/D88417 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! (and sorry for taking too long on this one.) Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232 +TEST_F(BackgroundIndexTest, RelationsM

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 296118. nomanous added a comment. In this revision I delete the useless main function in the new test case and rename ext_multichar_character_literal & ext_four_char_character_literal to warn_multichar_character_literal & warn_four_char_character_literal.

[PATCH] D88810: [clangd] Add isKeyword function.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:638 + // Keywords are initialized in constructor. + clang::IdentifierTable KeywordsTable(LangOpts); + return

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. LGTM, thanks for working on this! As this is a fairly large change, could you wait for one more reviewer to approve? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87989/new/ https://reviews.llvm.org/D87989 ___

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

hokein updated this revision to Diff 296120. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87350/new/ https://reviews.llvm.org/D87350 Files: clang/lib/Sema/SemaOverload.cpp clang/test/AST/ast-dump-reco

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12880 return Result.getValueOr(QualType()); } sammccall wrote: > hokein wrote: > > sammccall wrote: > > > Wouldn't we be better to handle undeduced type here rather than in the > > >

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Looks good - some concerns that the traversal isn't flexible enough but we can address that later once it's used. Comment at: clang-tools-extra/clangd/support/MemoryTr

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

CarolineConcatto accepted this revision. CarolineConcatto added a comment. This revision is now accepted and ready to land. Thank you @awarzynski for working on this. It is good because now we do not depend on clang frontend to build flang frontend. LGTM Repository: rG LLVM Github Monorepo C

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

sammccall accepted this revision. sammccall added a comment. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87350/new/ https://reviews.llvm.org/D87350 ___ cfe-commits mailing list cfe-commits@

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.h:35 + + /// No copy of the \p Name. + MemoryTree *addChild(llvm::StringLiteral Name) { return &createChild(Name); } Maybe mention that child pointers are invalidated by fu

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88665/new/ https://reviews.llvm.org/D88665 __

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will enable queries like "clangd::" to find symbols under clangd namespace,

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

teemperor added a comment. > I am not sure how much do you guys value these diags in LLDB I think we don't even display them most of the time (IIUC they go to the diagnostic engine which is not always hooked up for the ASTs in LLDB as only a few actually come from Clang). Repository: rG LLV

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:419 + IndexedSymbols.attachMemoryUsage(*MT.addChild("symbols")); + MT.addChild("index")->addUsage(estimateMemoryUsage()); +} Hmm, we should be careful now, estimateMemory

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.h:36 + /// No copy of the \p Name. + MemoryTree *addChild(llvm::StringLiteral Name) { return &createChild(Name); } + sammccall wrote: > actually, why do these return pointe

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 296135. simoll added a comment. Herald added subscribers: llvm-commits, nikic, pengfei, hiraditya, mgorny. Herald added a project: LLVM. fixed for privatized ElementCount members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 296137. simoll added a comment. (wrong Diff attached in earlier update) - rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein added a comment. I think this patch is ready for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226 ___ cfe-commits mailing list cfe-

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f05fe1aeeb0: [AST][RecoveryExpr] Fix a crash on undeduced type. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 7f05fe1 - [AST][RecoveryExpr] Fix a crash on undeduced type.

Author: Haojian Wu Date: 2020-10-05T12:52:04+02:00 New Revision: 7f05fe1aeeb005b552c6a3093b61659e7b578b14 URL: https://github.com/llvm/llvm-project/commit/7f05fe1aeeb005b552c6a3093b61659e7b578b14 DIFF: https://github.com/llvm/llvm-project/commit/7f05fe1aeeb005b552c6a3093b61659e7b578b14.diff LO

[PATCH] D88013: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88013/new/ https://reviews.llvm.org/D88013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D88822: [clangd] Describe non-handling of most IWYU pragmas. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Mono

[clang-tools-extra] 96c8a17 - [clangd] Remove unused using-decls in TypeHierarchyTests, NFC.

Author: Haojian Wu Date: 2020-10-05T13:14:53+02:00 New Revision: 96c8a17c800b2370f6d43fe67559ca10d5e44196 URL: https://github.com/llvm/llvm-project/commit/96c8a17c800b2370f6d43fe67559ca10d5e44196 DIFF: https://github.com/llvm/llvm-project/commit/96c8a17c800b2370f6d43fe67559ca10d5e44196.diff LO

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. In D88680#2308601 , @zahen wrote: > This patch doesn't need a test case outside of the one that @rnk requested to > make sure that the flag flows from the clang-cl driver appropriately. > `pch-instantiate-templates` as authored doe

[PATCH] D78902: [Driver] Add output file to properties of Command

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:135 + Bundler, BundlerArgs, Inputs, + InputInfo(&JA, Output.c_str(; } I would suggest to use `Args.M

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG007dd12d5468: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl (authored by martong). Repository: rG LLVM Github Monorep

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

martong added a comment. > Currently, we are totally inconsistent about the diagnostics. Either we > should emit a diagnostic before all return false or we should not ever emit > any diags. The diagnostics in their current form are misleading, because > there could be many notes missing. I am n

[clang] 007dd12 - [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

Author: Gabor Marton Date: 2020-10-05T14:06:09+02:00 New Revision: 007dd12d546814977519b33ca38b1cc8b31fee26 URL: https://github.com/llvm/llvm-project/commit/007dd12d546814977519b33ca38b1cc8b31fee26 DIFF: https://github.com/llvm/llvm-project/commit/007dd12d546814977519b33ca38b1cc8b31fee26.diff

[PATCH] D88745: [clangd][WIP] Add new code completion signals to improve MRR by 3%.

usaxena95 updated this revision to Diff 296159. usaxena95 edited the summary of this revision. usaxena95 added a comment. Updated the references to old signals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88745/new/ https://reviews.llvm.org/D8874

[PATCH] D88828: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D88828: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, but can you add some description about why you've decided to do it now :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88828/new/ htt

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/ASTContext.h:668 + // clang's C-only codepath doesn't support dependent types yet, it is used to + // perform early typo cor

[PATCH] D88810: [clangd] Add isKeyword function.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:638 + // Keywords are initialized in constructor. + clang::IdentifierTable KeywordsTable(LangOpts); + return KeywordsTable.find(NewName) != KeywordsTable.end(); sammccall wrote:

[PATCH] D88810: [clangd] Add isKeyword function.

hokein updated this revision to Diff 296168. hokein marked an inline comment as done. hokein added a comment. address code comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88810/new/ https://reviews.llvm.org/D88810 Files: clang-tools-extr

[clang-tools-extra] 1425c72 - [clangd] Add isKeyword function.

Author: Haojian Wu Date: 2020-10-05T15:11:24+02:00 New Revision: 1425c72236766ad9107d86cb645ee8c6a3ee0eb1 URL: https://github.com/llvm/llvm-project/commit/1425c72236766ad9107d86cb645ee8c6a3ee0eb1 DIFF: https://github.com/llvm/llvm-project/commit/1425c72236766ad9107d86cb645ee8c6a3ee0eb1.diff LO

[PATCH] D88810: [clangd] Add isKeyword function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1425c7223676: [clangd] Add isKeyword function. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang] 7a932f4 - [Parser] ParseMicrosoftAsmStatement - Replace bit '|' operator with logical '||' operator. (PR47071)

Author: Simon Pilgrim Date: 2020-10-05T14:23:28+01:00 New Revision: 7a932f4f4ccbc0c4294c6911d404f74529f3259b URL: https://github.com/llvm/llvm-project/commit/7a932f4f4ccbc0c4294c6911d404f74529f3259b DIFF: https://github.com/llvm/llvm-project/commit/7a932f4f4ccbc0c4294c6911d404f74529f3259b.diff

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, gribozavr2, aaron.ballman. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: martong, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun, whisperity, mgorny. Herald added a

[PATCH] D88829: [OpenMP][RTL] Remove dead code

JonChesterfield added a comment. Change looks great to me. Rolling the reduction in leading whitespace in nvptx_target_parallel_reduction_codegen.cpp in with the patch might be contentious, added a couple more reviewers to see if other people would prefer that part split out. I'll accept in a

[PATCH] D88829: [OpenMP][RTL] Remove dead code

grokos added a comment. In D88829#2311768 , @JonChesterfield wrote: > Rolling the reduction in leading whitespace in > nvptx_target_parallel_reduction_codegen.cpp in with the patch might be > contentious, added a couple more reviewers to see if other pe

[PATCH] D88833: Do not warn on pointer decays in system macros

fiesh created this revision. fiesh added a reviewer: aaron.ballman. fiesh added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. fiesh requested review of this revision. As system headers are in general out of reach, it makes no

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. Continued in https://reviews.llvm.org/D88833 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.org/D31130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri updated this revision to Diff 296173. lebedev.ri added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88789/new/ https://reviews.llvm.org/D88789 Files: clang/test/CodeGen/attr-arm-sve-vector-bits-bitcast.c clang/test/C

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

Eugene.Zelenko added a comment. Does this check make sense in content of other style guides? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://reviews.llvm.org/D88831 ___ cfe-commits maili

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

lebedev.ri added a comment. In D88831#2311800 , @Eugene.Zelenko wrote: > Does this check make sense in content of other style guides? I'd +1 to moving it to `readability`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D88829: [OpenMP][RTL] Remove dead code

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks for removing dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88829/new/ https://reviews.llvm.org/D88829 ___

[PATCH] D88829: [OpenMP][RTL] Remove dead code

JonChesterfield accepted this revision. JonChesterfield added a comment. Thanks guys, will remember that as the local convention on rolling whitespace changes into other stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88829/new/ https://revie

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jdoerfert accepted this revision. jdoerfert added a comment. LGTM, a new triple makes sense here, we don't support arbitrary combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 ___

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

baloghadamsoftware added a comment. In D88831#2311802 , @lebedev.ri wrote: > In D88831#2311800 , @Eugene.Zelenko > wrote: > >> Does this check make sense in content of other style guides? > > I'd +1 to moving it to

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi accepted this revision. sameeranjoshi added a comment. Thanks for patch. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___ cfe-commits

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added a subscriber: jyknight. jdoerfert added a comment. One minor nit from me. @jyknight @aaron.ballman @rjmccall any more thoughts? Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + ge

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:74 auto Names = splitQualifiedName(Query); Add a comment here (or elsewhere, I guess) about how qualified names are handled. - exact namespace: boosted on the index sid

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

DiggerLin added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:46 ///< aliases to base ctors when possible. -CODEGENOPT(DataSections , 1, 0) ///< Set when -fdata-sections is enabled. +CODEGENOPT(DataSections

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16447 + +bool AIXBitfieldViolation = false; +if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs()) { Can this change can be split out into its own patch? If it can i would sugg

[clang] eaf7329 - [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

Author: Joseph Huber Date: 2020-10-05T11:02:13-04:00 New Revision: eaf73293cb6b8d45dd85ffced57aea7ad4177754 URL: https://github.com/llvm/llvm-project/commit/eaf73293cb6b8d45dd85ffced57aea7ad4177754 DIFF: https://github.com/llvm/llvm-project/commit/eaf73293cb6b8d45dd85ffced57aea7ad4177754.diff

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf73293cb6b: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload (authored by jhuber6). Repository: rG LLVM Github Monor

Re: [PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

Nice! I'm glad to see the patch being revived. Thanks for that :) Em seg, 5 de out de 2020 10:48, fiesh via Phabricator < revi...@reviews.llvm.org> escreveu: > fiesh added a comment. > > Continued in https://reviews.llvm.org/D88833 > > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D311

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. I neglected to hit the "submit" button last week, these are the inline questions I have. Also in addition to the comments above, check-clang is showing 1 LIT test failing AST/const-fpfeatures.cpp I believe the clang constant folder is returning False for the expression,

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:410-411 setRoundingMode(LO.getFPRoundingMode()); +// FENV access is true if rounding math is enabled. +setAllowFEnvAccess((getRoundingMode() == llvm::RoundingMode::Dynamic)); setF

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Google C++ style guide does not have this rule anymore. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/

[clang] 1dce692 - Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload"

Author: Joseph Huber Date: 2020-10-05T12:35:39-04:00 New Revision: 1dce692de1896412693f25a3afb4818883a611e7 URL: https://github.com/llvm/llvm-project/commit/1dce692de1896412693f25a3afb4818883a611e7 DIFF: https://github.com/llvm/llvm-project/commit/1dce692de1896412693f25a3afb4818883a611e7.diff

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

aprantl added a comment. I think that this should either hardcode a 64-bit architecture or it shouldn't test for explicit offsets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88754/new/ https://reviews.llvm.org/D88754 __

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296204. jhuber6 added a comment. Changing method of determining architecture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 Files: clang/include/clang/Basic/Diagnos

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d51d37e0628: [flang] Introduce DiagnosticConsumer classes in libflangFrontend (authored by awarzynski). Repository: rG LLVM Github Monorepo CHAN

[clang] 8d51d37 - [flang] Introduce DiagnosticConsumer classes in libflangFrontend

Author: Andrzej Warzynski Date: 2020-10-05T17:46:44+01:00 New Revision: 8d51d37e0628bde3eb5a3200507ba7135dfc2751 URL: https://github.com/llvm/llvm-project/commit/8d51d37e0628bde3eb5a3200507ba7135dfc2751 DIFF: https://github.com/llvm/llvm-project/commit/8d51d37e0628bde3eb5a3200507ba7135dfc2751.d

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

jmorse added a comment. Hi -- We (Sony) are running into a bit of difficulty with the test for this change, as it relies on the configuration of the -O1 optimisation pipeline. Would it be possible to reduce down to a frontend test, and then tests for whatever passes are to interpret the IR prod

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 296218. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226 Files: clang/include/clang/A

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14365 + "Should only occur in error-recovery path."); +if (BinaryOperator::isCompoundAssignmentOp(Opc)) + return CompoundAssignOperator::Create( sammccall wrote: > isAssignme

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 296221. mibintc added a comment. In the previous version of this patch, I enabled FENV_ACCESS if frounding-math, but @sepavloff commented that this deduction is not correct. I changed the logic to check for the "ffp-model=strict" settings, and if those sett

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. For the LIT test clang/test/AST/const-fpfeatures.cpp, currently failing in this patch, the variables V1 and others are initialized via call to "global var init" which performs the rounding at execution time, I think that's correct not certain. Repository: rG LLVM Gi

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. In D88659#2306403 , @jyknight wrote: > Hm, to start with, the current state of this confuses me. > > In GCC, the preprocessor macro `__BIGGEST_ALIGNMENT__` was supposed to expose > the alignment used by `__attribute__((aligned

[PATCH] D88013: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88013/new/ https://reviews.llvm.org/D88013 _

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

nemanjai added a comment. Hi @gribozavr do you think we can do something about this test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 ___ cfe-commits mailing

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

tra added a comment. > If such a variable (which has a comdat group) is discarded (a copy from > another > translation unit is prevailing and selected), accessing the variable from > outside the section group (__cuda_register_globals) is a violation of the ELF > specification and will be rejected

[clang] 85d5064 - docs: add documentation describing API Notes

Author: Saleem Abdulrasool Date: 2020-10-05T18:29:13Z New Revision: 85d506400081e121ef876a4c66fb337b050dcae6 URL: https://github.com/llvm/llvm-project/commit/85d506400081e121ef876a4c66fb337b050dcae6 DIFF: https://github.com/llvm/llvm-project/commit/85d506400081e121ef876a4c66fb337b050dcae6.diff

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

MaskRay added a comment. In D88786#2312329 , @tra wrote: >> If such a variable (which has a comdat group) is discarded (a copy from >> another >> translation unit is prevailing and selected), accessing the variable from >> outside the section group (__cud

[PATCH] D88446: docs: add documentation describing API Notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85d506400081: docs: add documentation describing API Notes (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D88446?vs=295

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1643 + } else { +// Handle AIX oversized Long Long bitfield under 32 bit compile mode. +if (StorageUnitSize > 32 && I get different results for using a long lon

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14381 + OpLoc, CurFPFeatureOverrides()); +switch (Opc) { +case BO_Assign: now the only thing that differs between the cases is the type. Yo

[PATCH] D88822: [clangd] Describe non-handling of most IWYU pragmas. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG95262ee2be75: [clangd] Describe non-handling of most IWYU pragmas. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88822/new/ htt

[clang-tools-extra] 95262ee - [clangd] Describe non-handling of most IWYU pragmas. NFC

Author: Sam McCall Date: 2020-10-05T20:50:26+02:00 New Revision: 95262ee2be75daffd05e9a8a985ca2c8e34c9af7 URL: https://github.com/llvm/llvm-project/commit/95262ee2be75daffd05e9a8a985ca2c8e34c9af7 DIFF: https://github.com/llvm/llvm-project/commit/95262ee2be75daffd05e9a8a985ca2c8e34c9af7.diff LO

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

tra added a comment. In D88786#2312365 , @MaskRay wrote: >> Could you provide an example where this is causing an issue? > > If the C++17 inline variable appears in two TUs. They have the same comdat > group. The first comdat group is prevailing and the s

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

efriedma added a comment. > Keeping loads and stores of pointers as pointers to the extent possible > doesn't seem like a bad idea, but I'm worried people will feel like this > gives a *semantic* guarantee that isn't really there. Fundamentally, LLVM > still doesn't currently have typed memory.

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri added a comment. So, we can't really teach SCEV about this: D88788 (not without the https://bugs.llvm.org/show_bug.cgi?id=47592 at lease) And we can't recover the situation post-inlining in instcombine: D88842 . It r

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri added a comment. In D88789#2312510 , @lebedev.ri wrote: > So, we can't really teach SCEV about this: D88788 > (not without the > https://bugs.llvm.org/show_bug.cgi?id=47592 at least) > And we can't recover the

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/test/Layout/aix-bitfield-alignment.cpp:118 + +typedef __attribute__((aligned(32))) short mySHORT; +struct D { We should have a similar test for an overaligned long or long long. CHANGES SINCE LAST ACTION https

[PATCH] D88844: [clangd] Add `score` extension to workspace/symbol response.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The protocol doesn't really incorporate r

  1   2   >