[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 295876. lanza added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/Basic/Attr.td

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

shafik added a comment. In D88665#2308366 , @martong wrote: >> In D88665#2307562 , @shafik wrote: >> >>> So was the bug we were saying there were falsely equivalent or falsely not >>> equivalent? >> >> I think the

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri updated this revision to Diff 295879. lebedev.ri retitled this revision from "[clang-tidy] Implement sonarsource-function-cognitive-complexity check" to "[clang-tidy] Implement readability-function-cognitive-complexity check". lebedev.ri added a comment. @aaron.ballman @alexfh it is m

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 295880. mibintc added a comment. I patched my workspace with D88498 from Sept 29. I fixed some nits and also enabled FENV_ACCESS when the command line option specifies frounding-math. This corresponds to Microsoft's document

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

tra added inline comments. Comment at: clang/test/SemaCUDA/device-var-init.cu:404 __host__ __device__ void hd_sema() { static int x = 42; } yaxunl wrote: > tra wrote: > > yaxunl wrote: > > > how does this work in device compilation? Is this equivalent to `st

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:487 + + // Walk both lists to get the full set of implied protocols + llvm::DenseSet AllImpliedProtocols; lanza wrote: > rjmccall wrote: > > You should add something like ", including all

[PATCH] D88734: [HIP] Align device binary

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:374 +auto BI = BundlesInfo[CurWriteBundleTarget]; +OS.seek(BI.Offset); OS.write(Input.getBuff

[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.

eugenis updated this revision to Diff 295888. eugenis added a comment. fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87717/new/ https://reviews.llvm.org/D87717 Files: clang/docs/ControlFlowIntegrity.rst Index: clang/docs/ControlFlow

[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66cf68ed4678: [docs] Update ControlFlowIntegrity.rst. (authored by eugenis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 66cf68e - [docs] Update ControlFlowIntegrity.rst.

Author: Evgenii Stepanov Date: 2020-10-02T12:01:05-07:00 New Revision: 66cf68ed46789217a8382bb419a0bda1c4e97650 URL: https://github.com/llvm/llvm-project/commit/66cf68ed46789217a8382bb419a0bda1c4e97650 DIFF: https://github.com/llvm/llvm-project/commit/66cf68ed46789217a8382bb419a0bda1c4e97650.di

[PATCH] D88730: [HIP] Fix default output file for -E

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/hip-output-file-name.hip:13-15 +// RUN: %clang -### -E -target x86_64-linux-gnu \ +// RUN: --cuda-gpu-arch=gfx803 --cuda-gpu-arch=gfx900 %s \ +/

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:93-96 +// Criteria only uses three bits, so uint8_t is used as an underlying type. +// We could make C a bitfield, but then we would not save an

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

aaron.ballman added a comment. In D36836#2308981 , @lattner wrote: > Hi all, > > The LLVM foundation board discussed this offline -- it looks like the > contributor is a bit confused about the LLVM project policies towards > copyright, license, patent st

[PATCH] D88730: [HIP] Fix default output file for -E

yaxunl added inline comments. Comment at: clang/test/Driver/hip-output-file-name.hip:13-15 +// RUN: %clang -### -E -target x86_64-linux-gnu \ +// RUN: --cuda-gpu-arch=gfx803 --cuda-gpu-arch=gfx900 %s \ +// RUN: 2>&1 | FileCheck -check-prefixes=DASH %s tra wrote

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri updated this revision to Diff 295902. lebedev.ri marked 10 inline comments as done. lebedev.ri added a comment. In D36836#2309243 , @aaron.ballman wrote: > In D36836#2308981 , @lattner wrote: > >> Hi all

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:367-368 + bool TraverseStmt(Stmt *Node) { +if (!Node) + return Base::TraverseStmt(Node); + aaron.ballman wrote: > If there's not

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

scott.linder created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. scott.linder requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88754 Files: clang/test/CodeGen/debug-info-block-expr.c Index: clang/test

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri updated this revision to Diff 295904. lebedev.ri added a comment. Maybe fine tune comments - we count block decls, not block statements/expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36836/new/ https://reviews.llvm.org/D3683

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:367-368 + bool TraverseStmt(Stmt *Node) { +if (!Node) + return Base::TraverseStmt(Node); + lebedev.ri wrote: > aaron.ballman

[PATCH] D88730: [HIP] Fix default output file for -E

tra added a comment. LGTM. Comment at: clang/test/Driver/hip-output-file-name.hip:13-15 +// RUN: %clang -### -E -target x86_64-linux-gnu \ +// RUN: --cuda-gpu-arch=gfx803 --cuda-gpu-arch=gfx900 %s \ +// RUN: 2>&1 | FileCheck -check-prefixes=DASH %s yaxunl wro

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri marked 4 inline comments as done. lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:381 +// FIXME: "each method in a recursion cycle" Increment is not implemented. +case Stmt::Conditiona

[PATCH] D88734: [HIP] Align device binary

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:374 +auto BI = BundlesInfo[CurWriteBundleTarget]; +OS.seek(BI.Offset); OS.write(Input.getBufferStart(), Input.getBufferSize())

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

bernhardmgruber added a comment. Thank you for the quick review! Can you please commit it for me as well? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88700/new/ https://reviews.llvm.org/D88700

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for your patience with the process. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:381 +// FIXME: "each method in a recursion cycle" Increment is

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. @aaron.ballman @JonasToth thank you for the review! @tonic @lattner thank you for helping resolve the misunderstading :) > ! In D36836#2309432 , @aaron.ballman > wrote: > LGTM, than

[clang] a594fd2 - [Driver] Move detectLibcxxIncludePath to ToolChain

Author: Petr Hosek Date: 2020-10-02T14:23:48-07:00 New Revision: a594fd28e373cb7cd348cf01f6a90e055bf6cf6d URL: https://github.com/llvm/llvm-project/commit/a594fd28e373cb7cd348cf01f6a90e055bf6cf6d DIFF: https://github.com/llvm/llvm-project/commit/a594fd28e373cb7cd348cf01f6a90e055bf6cf6d.diff LO

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa594fd28e373: [Driver] Move detectLibcxxIncludePath to ToolChain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D88452?vs

[clang-tools-extra] ace6440 - [clang-tidy] Implement readability-function-cognitive-complexity check

Author: Roman Lebedev Date: 2020-10-03T00:27:13+03:00 New Revision: ace644030e67506114d3ac9a221cf8eb5d10159c URL: https://github.com/llvm/llvm-project/commit/ace644030e67506114d3ac9a221cf8eb5d10159c DIFF: https://github.com/llvm/llvm-project/commit/ace644030e67506114d3ac9a221cf8eb5d10159c.diff

[PATCH] D88446: docs: add documentation describing API Notes

rsmith added inline comments. Comment at: clang/docs/APINotes.rst:233-235 + Note that the type is *not* parsed in the context where it will be used, + which means that macros are not available and nullability must be applied + explicitly (even in an ``NS_ASSUME_NONNULL_BEGIN``

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGace644030e67: [clang-tidy] Implement readability-function-cognitiv

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 295911. lanza added a comment. Clean clang-tidy warnings before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h clan

[clang] 14f6bfc - [clang] Implement objc_non_runtime_protocol to remove protocol metadata

Author: Nathan Lanza Date: 2020-10-02T17:35:50-04:00 New Revision: 14f6bfcb52e77867a6a84fcfd9e21bb5f1f5795c URL: https://github.com/llvm/llvm-project/commit/14f6bfcb52e77867a6a84fcfd9e21bb5f1f5795c DIFF: https://github.com/llvm/llvm-project/commit/14f6bfcb52e77867a6a84fcfd9e21bb5f1f5795c.diff

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14f6bfcb52e7: [clang] Implement objc_non_runtime_protocol to remov

[clang] dc6a0b0 - [HIP] Align device binary

Author: Yaxun (Sam) Liu Date: 2020-10-02T18:10:44-04:00 New Revision: dc6a0b0ec7e3d72a4cc849af4e4aa6c6a29a53d2 URL: https://github.com/llvm/llvm-project/commit/dc6a0b0ec7e3d72a4cc849af4e4aa6c6a29a53d2 DIFF: https://github.com/llvm/llvm-project/commit/dc6a0b0ec7e3d72a4cc849af4e4aa6c6a29a53d2.dif

[PATCH] D88734: [HIP] Align device binary

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGdc6a0b0ec7e3: [HIP] Align device binary (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 8fb2a23 - Don't reject calls to MinGW's unusual _setjmp declaration.

Author: Richard Smith Date: 2020-10-02T15:12:15-07:00 New Revision: 8fb2a235b0f22dedba72b8b559ba33171a8dcd09 URL: https://github.com/llvm/llvm-project/commit/8fb2a235b0f22dedba72b8b559ba33171a8dcd09 DIFF: https://github.com/llvm/llvm-project/commit/8fb2a235b0f22dedba72b8b559ba33171a8dcd09.diff

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

rsmith added a comment. In D88518#2308085 , @mstorsjo wrote: > This broke use of setjmp for mingw on x86_64. Thanks, should be fixed in rG8fb2a235b0f22dedba72b8b559ba33171a8dcd09 . Now

[PATCH] D88446: docs: add documentation describing API Notes

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/docs/APINotes.rst:233-235 + Note that the type is *not* parsed in the context where it will be used, + which means that macros are not available and nullability must be applied + expli

[PATCH] D88446: docs: add documentation describing API Notes

compnerd updated this revision to Diff 295924. compnerd marked an inline comment as done. compnerd added a comment. Address feedback from @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88446/new/ https://reviews.llvm.org/D88446 Files: cla

[PATCH] D88446: docs: add documentation describing API Notes

rsmith accepted this revision. rsmith added a comment. Thanks, looks good to me. Comment at: clang/docs/APINotes.rst:250-252 + Note that the type is *not* parsed in the context where it will be used, + which means that macros are not available and nullability must be applied

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

steven.zhang accepted this revision. steven.zhang added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88278/new/ https://reviews.llvm.org/D88278 ___ cfe-commits mailing list cfe-commits@

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGcbd420c5ed85: [CUDA][HIP] Fix bound arch for offload action for fat binary (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://

[clang] cbd420c - [CUDA][HIP] Fix bound arch for offload action for fat binary

Author: Yaxun (Sam) Liu Date: 2020-10-02T19:05:51-04:00 New Revision: cbd420c5ed8568774ace3ad8385b2346288e152c URL: https://github.com/llvm/llvm-project/commit/cbd420c5ed8568774ace3ad8385b2346288e152c DIFF: https://github.com/llvm/llvm-project/commit/cbd420c5ed8568774ace3ad8385b2346288e152c.dif

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

steven.zhang added a comment. I think some follow up is needed to optimize the code sequence for cr = vec_test_div if (rotate_and_mask(cr, 62)) ... For now, we will copy the cr to gpr, and shift it to 61-64 bit,then, extract the bit and then compare to 0. the shift is not needed. Please

[clang] 2cd75f7 - Diagnose invalid target ID for AMDGPU toolchain for assembler

Author: Yaxun (Sam) Liu Date: 2020-10-02T19:38:02-04:00 New Revision: 2cd75f738ec6b150719a9468372d77b7064ff340 URL: https://github.com/llvm/llvm-project/commit/2cd75f738ec6b150719a9468372d77b7064ff340 DIFF: https://github.com/llvm/llvm-project/commit/2cd75f738ec6b150719a9468372d77b7064ff340.dif

[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cd75f738ec6: Diagnose invalid target ID for AMDGPU toolchain for assembler (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 9a48411 - Revert "[Driver] Move detectLibcxxIncludePath to ToolChain"

Author: Petr Hosek Date: 2020-10-02T16:59:28-07:00 New Revision: 9a48411f35a122ac8755a8453887b919c77daf3f URL: https://github.com/llvm/llvm-project/commit/9a48411f35a122ac8755a8453887b919c77daf3f DIFF: https://github.com/llvm/llvm-project/commit/9a48411f35a122ac8755a8453887b919c77daf3f.diff LO

[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

sstefan1 added a comment. @nikic do you have a preference on any of the suggested names? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86021/new/ https://reviews.llvm.org/D86021 ___ cfe-commits mailing l

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

amccarth added a comment. I'm sorry. I haven't had to time to review the entire change yet, but I thought I'd share some early feedback now and take more of a look on Monday. The high level issues on my mind: I'm wondering whether this has been overcomplicated with the overlapped IO. If the

[clang] e25bf25 - [Driver] Move detectLibcxxIncludePath to ToolChain

Author: Petr Hosek Date: 2020-10-02T18:37:20-07:00 New Revision: e25bf2592060e7751f8b14522c97081ce2047175 URL: https://github.com/llvm/llvm-project/commit/e25bf2592060e7751f8b14522c97081ce2047175 DIFF: https://github.com/llvm/llvm-project/commit/e25bf2592060e7751f8b14522c97081ce2047175.diff LO

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 295949. jhuber6 added a comment. Herald added subscribers: llvm-commits, delcypher. Herald added a project: LLVM. Adding an extra substitution in lit to solve the problem of automatically populating the test files with incompatible architectures. CHANGES SI

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 reopened this revision. jhuber6 added a comment. This revision is now accepted and ready to land. Reopening for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 ___ cfe-commits mailing list

[clang] a0a8f83 - [PATCH] Fix typo (NFC)

Author: Evandro Menezes Date: 2020-10-02T21:19:14-05:00 New Revision: a0a8f83718454186686f9c11db72408cc36482e3 URL: https://github.com/llvm/llvm-project/commit/a0a8f83718454186686f9c11db72408cc36482e3 DIFF: https://github.com/llvm/llvm-project/commit/a0a8f83718454186686f9c11db72408cc36482e3.dif

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu updated this revision to Diff 295950. jasonliu added a comment. Herald added subscribers: llvm-commits, nemanjai. Herald added a project: LLVM. An update follows up with the idea in D88748 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new

[PATCH] D88771: [PATCH] Fix typo (NFC)

jiaolu created this revision. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a pro

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

jlebar added a comment. Hey, I'm leaving on a vacation tomorrow and didn't have a chance to get to this review today. Is that ok? I'm not bringing my work laptop, but I could look at it on my personal laptop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

mstorsjo added a comment. In D88518#2309538 , @rsmith wrote: > In D88518#2308085 , @mstorsjo wrote: > >> This broke use of setjmp for mingw on x86_64. > > Thanks, should be fixed in rG8fb2a235b0f22dedba72b8b559ba331

<    1   2