[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay updated this revision to Diff 295696. MaskRay added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88712/new/ https://reviews.llvm.org/D88712 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/asm-label.c

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

shafik added a comment. So was the bug we were saying there were falsely equivalent or falsely not equivalent? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88665/new/ https://reviews.llvm.org/D88665 __

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

rnk added a subscriber: zequanwu. rnk added a comment. I think the flag was originally intended to be an internal -cc1 flag not exposed to users. You should be able to work around your problem with `-Xclang -fno-pch-instantiate-templates`, btw. @zequanwu, can you patch this in locally and

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 295697. ffrankies removed a project: LLVM. ffrankies added a comment. Herald added a project: LLVM. Addressed changes requested by @Eugene.Zelenko and @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72218/new/ https://reviews.llvm.org

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 295698. ffrankies removed a project: clang. ffrankies added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Rebased code and fixed merge conflicts with D66564 - Added SingleWorkItemBarri

[PATCH] D88393: [cfe][M68K] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 295706. myhsu added a comment. Update licenses CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp clang/

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 added a comment. In D88680#2307564 , @rnk wrote: > I think the flag was originally intended to be an internal -cc1 flag not > exposed to users. You should be able to work around your problem with > `-Xclang -fno-pch-instantiate-templates`, btw

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Esme added a comment. In D88278#2306618 , @amyk wrote: > Overall I think this LGTM. > > Please correct me if I am wrong but I think the description of the functions > need to be updated to: > > int vec_test_swdiv(vector double v1, vector double v2); >

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Esme added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2584 +// Vector test software functions. +def : Pat<(i32 (int_ppc_vsx_xvtdivdp v2f64:$A, v2f64:$B)), steven.zhang wrote: > Vector test for software divide and sqrt I'll update it whe

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. No, you got it all wrong again. I don't want to explain this one more time so let's talk about some basics: //A value of an expression should have the same type and value-kind as the expression//. Can we get there? How? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. > A value of an expression should have the same type and value-kind as the > expression. F13121967: roflbot.jpg Unfortunately i'm pretty worried about our ability to actually achieve that in the near future; as of now we don't even obli

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

NoQ added a comment. Aha, ok, thanks, I now understand what the problem is because I was able to run the test before the patch and see how the patch changes the behavior. What do you think about flattening the enum type out entirely? I.e., instead of `(unsigned char) conj_$2{enum ScopedSugared}

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 295729. lanza added a comment. Update with John's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h clang/include/

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza requested review of this revision. lanza marked an inline comment as done. lanza added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:490 + llvm::UniqueVector FoundProtocols; + std::set DeclaredProtocols; + rjmccall wrote: > You should use llvm

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 _

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

llunak added a comment. > I tried pretty hard to get a small repro for these failures, but couldn't. Can you get at least some testcase, even if not small? You can use -E -frewrite-includes to create a single large file from all the input. Although the patch looks fine to me as such, I consider

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

rsmith added a comment. In D87962#2306043 , @aaron.ballman wrote: > That doesn't sound like the right approach to me -- Remarks are usually for > reporting backend decision-making to the frontend for things like > optimization passes. To be clear: that

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

rsmith added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-problematic-statics.rst:7-8 +Detects functions defined in headers that return the address of a static +local variable. These are not guaranteed to have the same addresss across +shared li

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. Thanks, that's a lot better. Just some minor suggestions. Comment at: clang/lib/CodeGen/CGObjC.cpp:477 + // If there are no non-runtime protocols then we can just stop now. + if (!NonRuntimePDs.size()) +return RuntimePds; `empty

[PATCH] D88427: [clangd] Remove Tweak::Intent, use CodeAction kind directly

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM; maybe mark as refactoring/NFC ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88427/new/ https://reviews.llvm.org/D88427 ___

[PATCH] D88640: [Format] Don't treat compound extension headers (foo.proto.h) as foo.cc main file.

hokein closed this revision. hokein marked an inline comment as done. hokein added a comment. committed in c1b209cc61290f1ce1243470b825e0994645cb7d . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D88446: docs: add documentation describing API Notes

hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. Thanks for pushing this forward! Current proposal seems to be only dealing with annotating ObjC for Swift, but API notes seem like a feature that would be useful for other languages as well.

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rjmccall added inline comments. Comment at: clang/include/clang/Basic/Diagnostic.h:1086-1090 /// Note that many of these will be created as temporary objects (many call /// sites), so we want them to be small and we never want their address taken. /// This ensures that compile

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 added a comment. > Can you get at least some testcase, even if not small? Yes, in a few days I can get you the test case. I'll have to figure out what our company policy is for sharing code and if I should obfuscate it so I don't get into trouble :) > MSVC does some kind of template

<    1   2