[clang] 1b60f63 - Revert "[OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def"

Author: Joseph Huber Date: 2020-09-30T15:12:21-04:00 New Revision: 1b60f63e4fd041550019b692dc7bf490dce2c75c URL: https://github.com/llvm/llvm-project/commit/1b60f63e4fd041550019b692dc7bf490dce2c75c DIFF: https://github.com/llvm/llvm-project/commit/1b60f63e4fd041550019b692dc7bf490dce2c75c.diff

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. Not strictly relevant here, but this does open up the idea of enforcing the style where an enum constant is prefixed by the initials of the enum name. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-hungarian-nota

[PATCH] D88296: [clang-format] De-duplicate includes with leading or trailing whitespace.

curdeius added a comment. Thanks for the review. I agree with you that a clang-format user should not expect a perfectly formatted code after a single iteration. Maybe it's actually a documentation issue and we should be clear about it? Just a guarantee of 1) stability of formatting and 2) asymp

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

steakhal added a comment. I'm getting lost :D In D88477#2304230 , @NoQ wrote: > And I believe that this part is already incorrect. Like, regardless of how we > do the dereference (the implicit lvalue-to-rvalue cast), or *whether* we do > it at all (nobo

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

curdeius added a comment. I agree with both of you. I shouldn't have used the word "regression" indeed. I just meant a change in behaviour. Sorry for that. I'll try to play around and propose a patch to enhance this feature :). If you have any pointers about how to check if everything fits on a s

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

Conanap updated this revision to Diff 295393. Conanap marked 6 inline comments as done. Conanap added a comment. Addressed comments and corrected incorrect behaviour on Power10 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86819/new/ https://reviews.llvm.org/D86819 Files: clang/inclu

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

This revision was automatically updated to reflect the committed changes. Closed by commit rGce5379f0f067: [NPM] Add target specific hook to add passes for New Pass Manager (authored by aeubanks). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] ce5379f - [NPM] Add target specific hook to add passes for New Pass Manager

Author: Arthur Eubanks Date: 2020-09-30T13:29:43-07:00 New Revision: ce5379f0f0675592fd10a522009fd5b1561ca72b URL: https://github.com/llvm/llvm-project/commit/ce5379f0f0675592fd10a522009fd5b1561ca72b DIFF: https://github.com/llvm/llvm-project/commit/ce5379f0f0675592fd10a522009fd5b1561ca72b.diff

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

aeubanks added a comment. In D88138#2304243 , @quic_aankit wrote: > @aeubanks Thanks for the review. Can you also commit the patch on my behalf? Committed in ce5379f0f0675592fd10a522009fd5b1561ca72b

[clang] ae4c400 - [NFC] Fix spacing in clang/test/Driver/aix-ld.c

Author: Hubert Tong Date: 2020-09-30T17:01:32-04:00 New Revision: ae4c400e02fc3f7cff11cc332e6b107353b3e6a2 URL: https://github.com/llvm/llvm-project/commit/ae4c400e02fc3f7cff11cc332e6b107353b3e6a2 DIFF: https://github.com/llvm/llvm-project/commit/ae4c400e02fc3f7cff11cc332e6b107353b3e6a2.diff L

[clang-tools-extra] 85fc5bf - [clangd] Remove dead variable. NFC

Author: Sam McCall Date: 2020-09-30T23:19:15+02:00 New Revision: 85fc5bf341395171e67490061f6fbc76b297b78d URL: https://github.com/llvm/llvm-project/commit/85fc5bf341395171e67490061f6fbc76b297b78d DIFF: https://github.com/llvm/llvm-project/commit/85fc5bf341395171e67490061f6fbc76b297b78d.diff LO

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. I'm trying to say that the value produced by the load should not be the same as the stored value, because these two values are of different types. When exactly does the first value change into the second value is a different story; the current grand vision around which the

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. (in the latest message by "load" i mean the first load that produces a pointer (i.e., an `ElementRegion`) as the result) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88477/new/ https://reviews.llvm.org/D88477 ___

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

boga95 marked an inline comment as done. boga95 added a comment. In D71524#2291925 , @steakhal wrote: > In D71524#2284386 , @Szelethus wrote: > >> I figured you're still working on this, sorry! I'd really like to ch

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962 + case Triple::Wasm: +return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash), + ~0); dschuff wrote: > I may add a couple more tes

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

aqjune added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +LoopMustProgress = true; A silly question: does

[clang] 21cf2e6 - Handle unknown OSes in DarwinTargetInfo::getExnObjectAlignment

Author: Akira Hatanaka Date: 2020-09-30T16:05:17-07:00 New Revision: 21cf2e6c263d7a50654653bce4e83ab463fae580 URL: https://github.com/llvm/llvm-project/commit/21cf2e6c263d7a50654653bce4e83ab463fae580 DIFF: https://github.com/llvm/llvm-project/commit/21cf2e6c263d7a50654653bce4e83ab463fae580.diff

[PATCH] D88546: [ARM] Update NEON testcase with missing target string in

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4f50e587f07: [ARM] Add missing target for Arm neon test case. (authored by rs). Changed prior to commit: https://reviews.llvm.org/D88546?vs=295219&id=295435#toc Repository: rG LLVM Github Monorepo

[clang] e4f50e5 - [ARM] Add missing target for Arm neon test case.

Author: Ranjeet Singh Date: 2020-10-01T00:32:33+01:00 New Revision: e4f50e587f077c246b7f29db0b7daddf583e2b64 URL: https://github.com/llvm/llvm-project/commit/e4f50e587f077c246b7f29db0b7daddf583e2b64 DIFF: https://github.com/llvm/llvm-project/commit/e4f50e587f077c246b7f29db0b7daddf583e2b64.diff

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/test/CodeGenCXX/builtin-zero-non-value-bits-codegen.cpp:46 +void test(Baz *baz) { + __builtin_zero_non_value_bits(baz); +} zoecarver wrote: > jfb wrote: > > It would b

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver updated this revision to Diff 295445. zoecarver added a comment. - Support constant arrays - Format changes with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87974/new/ https://reviews.llvm.org/D87974 Files: clang/include

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1652 +auto Element = CGF.Builder.CreateGEP(I8Ptr, Index); +CGF.Builder.CreateAlignedStore(Zero, Element, MaybeAlign()); + }; jfb wrote: > You should use `alignmentAtOffset` here

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1704 +->getArrayElementTypeNoTypeQual() +->isRecordType()) { + auto FieldElement = CGF.Builder.CreateStructGEP(Ptr, Index); Is it OK to possibly create hundr

[PATCH] D88630: [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR

loladiro created this revision. loladiro added a reviewer: tstellar. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. loladiro requested review of this revision. Otherwise clang installs all of its tools into `bin/` while LLVM installs its tools into (LLVM_TOOLS_INSTAL

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2304337 , @njames93 wrote: > Not strictly relevant here, but this does open up the idea of enforcing the > style where an enum constant is prefixed by the initials of the enum name. I like this idea. There is a case wh

[PATCH] D88393: [cfe][M68K] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 295468. myhsu added a comment. Fix formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 Files: clang/include/clang/Basic/Attr.td clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp

[PATCH] D88394: [Driver][M68K] (Patch 8/8) Add driver support for M68K

myhsu updated this revision to Diff 295469. myhsu added a reviewer: aaron.ballman. myhsu added a comment. Fix formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/CMa

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +LoopMustProgress = true; aqjune wrote: > A s

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

sepavloff added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2290 + // rounding mode. + if (VD->isFileVarDecl() || VD->isConstexpr() || + (!getLangOpts().CPlusPlus && VD->isStaticLocal())) { sepavloff wrote: > rsmith w

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

usaxena95 updated this revision to Diff 295473. usaxena95 added a comment. Addressed comments: Move the evaluate functions to anonymous namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88536/new/ https://reviews.llvm.org/D88536 Files: cl

<    1   2