[PATCH] D88445: Use "default member initializer" instead of "in-class initializer" for diagnostics

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the review! I've commit in 15fbae8ac303d8601ea95418d4818cb50d0765e1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88445/new/ https://r

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. A load from a region of type `T` should always yield a value of type `T` because that's what a load is. I'd rather have it as an assertion: if the region is typed, the type shouldn't be specified. If such assertion is hard to satisfy, we could allow the same canonical type

[PATCH] D88297: [clangd] Trivial setter support when moving items to fields

kadircet accepted this revision. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:466 +auto *ND = llvm::dyn_cast(CE->getCalleeDecl()); +if (!ND) + return llvm::None; njames93 wrote: > kadircet wrote: > > nit: combine wit

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

phosek added a comment. In D87822#2301293 , @sepavloff wrote: > In D87822#2301194 , @leonardchan > wrote: > >> Thanks for looking into it. We have that commit but it still seems to be >> failing for us with the sam

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

mibintc added inline comments. Comment at: clang/test/AST/const-fpfeatures-strict.c:39 + +// CHECK: @var_04 = {{.*}} %struct.S { float 0x3FF02000 } +// CHECK: @var_05 = {{.*}} %struct.S { float 0x3FF02000 } I think the initializer for var_04 is ev

[clang] 538762f - Better diagnostics for anonymous bit-fields with attributes or an initializer.

Author: Aaron Ballman Date: 2020-09-29T16:32:20-04:00 New Revision: 538762fef0b662048be2a261ebc12da249efa977 URL: https://github.com/llvm/llvm-project/commit/538762fef0b662048be2a261ebc12da249efa977 DIFF: https://github.com/llvm/llvm-project/commit/538762fef0b662048be2a261ebc12da249efa977.diff

[PATCH] D88333: Better diagnostics for anonymous bit-fields with attributes or an initializer

aaron.ballman closed this revision. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Thank you for the reviews, I've committed in 538762fef0b662048be2a261ebc12da249efa977 Comme

[clang] 155d2d5 - Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)"

Author: Chris Hamilton Date: 2020-09-29T22:46:14+02:00 New Revision: 155d2d5300551c6ac26eaeef259d73d62f939d0b URL: https://github.com/llvm/llvm-project/commit/155d2d5300551c6ac26eaeef259d73d62f939d0b DIFF: https://github.com/llvm/llvm-project/commit/155d2d5300551c6ac26eaeef259d73d62f939d0b.diff

[PATCH] D88265: Fix comma with half vectors.

ahatanak accepted this revision. ahatanak added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Sema/fp16vec-sema.c:33 + 1, hv0; // expected-warning 2 {{expression result unused}} // Implicit conversion between half vectors and float

[PATCH] D88507: [clangd][remote] Make sure relative paths are absolute with respect to posix style

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Ahh, good catch! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88507/new/ https://reviews.llvm.org/D88507 __

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx reopened this revision. chrish_ericsson_atx added a comment. This revision is now accepted and ready to land. Reverted due to another obscure test failure. Working to diagnose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

daltenty updated this revision to Diff 295105. daltenty added a comment. - Remove deps comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Drive

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

daltenty updated this revision to Diff 295107. daltenty added a comment. - Add blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix

[clang-tools-extra] 01a30fa - [clangd] Trivial setter support when moving items to fields

Author: Nathan James Date: 2020-09-29T21:51:15+01:00 New Revision: 01a30fa6787d8375e1df573150f9927561b0a0f1 URL: https://github.com/llvm/llvm-project/commit/01a30fa6787d8375e1df573150f9927561b0a0f1 DIFF: https://github.com/llvm/llvm-project/commit/01a30fa6787d8375e1df573150f9927561b0a0f1.diff

[PATCH] D88297: [clangd] Trivial setter support when moving items to fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01a30fa6787d: [clangd] Trivial setter support when moving items to fields (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

daltenty updated this revision to Diff 295111. daltenty marked an inline comment as done. daltenty added a comment. - Make dependant on just c++ mode - Add missing colons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm

[PATCH] D88265: Fix comma with half vectors.

arames updated this revision to Diff 295116. arames added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/fp16vec-s

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 295119. atmnpatel added a comment. NFC fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 295120. jhuber6 added a comment. Adding check for Windows file path. Updating some files after rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang

[PATCH] D88446: docs: add documentation describing API Notes

rsmith added a comment. Broadly, it seems reasonable to me for Clang to support this. I have no major concerns with the overall approach here, and it seems like you already have sufficient implementation experience with this approach to know that it's going to work out well in practice. I'm hap

[PATCH] D88265: Fix comma with half vectors.

arames added a comment. I do not have commit rights, so it would be great if you can land it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 ___ cfe-com

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps added a comment. In D84467#2264205 , @vsk wrote: > @alanphipps thanks for bearing with me. I think this is about ready to land. > I do ask that you back out any punctuation/whitespace changes in code/tests > that aren't directly modified in yo

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

rsmith created this revision. rsmith added reviewers: tambre, rjmccall. Herald added a project: clang. rsmith requested review of this revision. This happens in glibc's headers. It's important that we recognize these functions so that we can mark them as returns_twice. Repository: rG LLVM Gith

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rsmith added a comment. In D77491#2300013 , @rjmccall wrote: > Being permissive about recognizing builtins when the expected signature > requires a type that lookup can't find seems completely reasonable. We don't > really want to force library function

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments. Comment at: clang/test/Driver/aix-ld.c:406 // CHECK-LD32-NOSTDLIBXX-LCXX: "[[RESOURCE_DIR]]{{/|}}lib{{/|\\

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. I like this better as a fix for PR40692 anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88518/new/ https://reviews.llvm.org/D88

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1856229 , @rsmith wrote: > In D67678#1836953 , @dexonsmith > wrote: > >> In D67678#1836922 , @rsmith wrote: >> >>> If there's no timeline t

[clang] 1c604a9 - Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

Author: Richard Smith Date: 2020-09-29T15:53:17-07:00 New Revision: 1c604a9f5fd65c91f097c856fa6643373fc869e1 URL: https://github.com/llvm/llvm-project/commit/1c604a9f5fd65c91f097c856fa6643373fc869e1 DIFF: https://github.com/llvm/llvm-project/commit/1c604a9f5fd65c91f097c856fa6643373fc869e1.diff

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c604a9f5fd6: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel marked 3 inline comments as done. atmnpatel added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +MustProgress = tr

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Add class types to the retained types list to make sure they don't get dropped if the constructor is optimized out la

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 295149. atmnpatel added a comment. Fixing buildkite build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeG

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88522/new/ https://reviews.llvm.org/D88522 _

[clang] 984744a - Fix a variety of minor issues with ObjC method mangling:

Author: John McCall Date: 2020-09-29T19:51:53-04:00 New Revision: 984744a1314ce165378e7945bc45995302a8cb80 URL: https://github.com/llvm/llvm-project/commit/984744a1314ce165378e7945bc45995302a8cb80 DIFF: https://github.com/llvm/llvm-project/commit/984744a1314ce165378e7945bc45995302a8cb80.diff L

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

rjmccall added a comment. Committed (with substantial changes) as 984744a1314ce165378e7945bc45995302a8cb80 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/ https://revi

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4fc581d5fe: [DebugInfo] Add types from constructor homing to the retained types list. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 5c4fc58 - [DebugInfo] Add types from constructor homing to the retained types list.

Author: Amy Huang Date: 2020-09-29T17:00:45-07:00 New Revision: 5c4fc581d5fe8427f03ec90b0d745453398aa3ad URL: https://github.com/llvm/llvm-project/commit/5c4fc581d5fe8427f03ec90b0d745453398aa3ad DIFF: https://github.com/llvm/llvm-project/commit/5c4fc581d5fe8427f03ec90b0d745453398aa3ad.diff LOG

[clang] d04775e - Add remquo, frexp and modf overload functions to HIP header

Author: Yaxun (Sam) Liu Date: 2020-09-29T20:57:56-04:00 New Revision: d04775e16bba456f0be0aaa7478959c5bfa22c41 URL: https://github.com/llvm/llvm-project/commit/d04775e16bba456f0be0aaa7478959c5bfa22c41 DIFF: https://github.com/llvm/llvm-project/commit/d04775e16bba456f0be0aaa7478959c5bfa22c41.dif

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently CUDA/HIP toolchain uses "unknown" as bound arch for offload action for fat binary. This causes -mcpu or -march with "unknown" added in HIPToolChain::TranslateArgs or CUDAToolChain::Trans

[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

yaxunl updated this revision to Diff 295163. yaxunl marked an inline comment as done. yaxunl added a comment. fix bug CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88377/new/ https://reviews.llvm.org/D88377 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains/A

[clang] 6f01c53 - Remove further OpenBSD/sparc bits

Author: Brad Smith Date: 2020-09-29T22:17:12-04:00 New Revision: 6f01c53f26af7fb0393464079ec5e839a497d4da URL: https://github.com/llvm/llvm-project/commit/6f01c53f26af7fb0393464079ec5e839a497d4da DIFF: https://github.com/llvm/llvm-project/commit/6f01c53f26af7fb0393464079ec5e839a497d4da.diff LO

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#2292377 , @0x8000- wrote: > In D54943#2291969 , @JonasToth wrote: > >> @AlexanderLanin @0x8000- i created the branch `release-11-const` >> (https://github.com/JonasTot

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:128 const auto ValueFilter = [](const NamedDecl *D) { return isa(D); }; +const auto TypeFilter = [](const NamedDecl *D) { return !isa(D); }; hokein wrote: > why not using `isa(D)

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] 4e4f926 - Remove test AST/const-fpfeatures-diag.c

Author: Serge Pavlov Date: 2020-09-30T11:07:55+07:00 New Revision: 4e4f926e83cf77f0d36b821a3d2aa1de78338a82 URL: https://github.com/llvm/llvm-project/commit/4e4f926e83cf77f0d36b821a3d2aa1de78338a82 DIFF: https://github.com/llvm/llvm-project/commit/4e4f926e83cf77f0d36b821a3d2aa1de78338a82.diff

Re: [PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

The change https://reviews.llvm.org/rG4e4f926e83cf removes the problematic test. Sorry for troubles. Thanks, --Serge On Wed, Sep 30, 2020 at 2:55 AM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek added a comment. > > In D87822#2301293

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

tambre added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88518/new/ https://reviews.llvm.org/D88518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D88526: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: pkubaj, nemanjai, jasonliu, aaron.ballman. Herald added a project: clang. hubert.reinterpretcast requested review of this revision. Fix premature decision in the presence of type-dependent expression operands on

Re: Upcoming upgrade of LLVM buildbot

Hello everyone, Starting tomorrow we will be upgrading the staging and production LLVM build bot. To make the transition smooth we would not accept any change to zorg from tomorrow 11:00 AM PDT till the production bot is up and running the new version. Please feel free to talk to me if you will h

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

baloghadamsoftware added a comment. Yes, @NoQ is right. If the constraint manager cannot reason about a value, then then `ProgramState::assume()` will return the same state with the new assumption in the constraints. Whenever `ProgramState::assume()` returns `nullptr` it means that the assumpti

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:128 const auto ValueFilter = [](const NamedDecl *D) { return isa(D); }; +const auto TypeFilter = [](const NamedDecl *D) { return !isa(D); }; nridge wrote: > hokein wrote: > > why

<    1   2