[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

2020-09-28 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. We've hit a fairly subtle miscompile caused by this patch. glibc's setjmp.h looks like this (irrelevant parts removed): struct __jmp_buf_tag { /*...*/ }; extern int __sigsetjmp(struct __jmp_buf_tag __env[1], int); typedef struct __jmp_buf_tag sigjmp_buf[1]; #defin

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

2020-09-28 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 294895. njames93 added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tools-extra/clang-tidy/modernize/LoopConvert

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

2020-09-28 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 294897. njames93 marked an inline comment as done. njames93 added a comment. IsReverse= Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tools-extra/clan

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-09-28 Thread Simon Moll via Phabricator via cfe-commits
simoll added a comment. I'd like to hear your feedback on how to proceed with this patch. Here is what i would do: For this patch, we switch to ext_vector_type for bool vectors to not clash head on with GCC should GCC decide to allow vector_size bool with a different semantics in the future. F

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

2020-09-28 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto added a comment. Hi Folks, @awarzynski and @kiranchandramohan, Diana was working in an out-of-tree build. This is the patch: https://reviews.llvm.org/D87085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.

<    1   2   3