[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

NoQ added a comment. A VLA in a loop may have different size on each iteration of the loop. This looks very much related to https://bugs.llvm.org/show_bug.cgi?id=28450. > I do not know how these changes can appear You know the node. Conditional breakpoint on the node and step-by-step debugging

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov updated this revision to Diff 293949. dmantipov added a comment. IIUC compiler driver is not intended to be multithreaded. But OK, here is the version with llvm::call_once(...). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ ht

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov updated this revision to Diff 293955. dmantipov added a comment. Prefer a bit more meaningful variable names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87901/new/ https://reviews.llvm.org/D87901 Files: clang/lib/Driver/ToolChains/G

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2291688 , @rjmccall wrote: > In D80344#2291456 , @tentzen wrote: > >> Reordering is NOT okay for instructions 'directly' within a _try. 'directly' >> here means it's the code from

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX added a comment. In D87891#2291760 , @kadircet wrote: > The biggest problem I see is, this is not changing the fact that we are still > traversing the whole file: > > - You do one traversal over the whole file to find `FileLines` > - Then possibly

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

sammccall added a comment. In D87891#2291838 , @ArcsinX wrote: > Thanks for your reply, I will rethink this patch. FWIW I think if we drop most of the math in favor of using SourceManager's line translation, this doesn't add much complexity and is probab

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

steakhal added a comment. In D71524#2284386 , @Szelethus wrote: > I figured you're still working on this, sorry! I'd really like to chat about > my earlier comment D71524#1917251 , > as it kind of challenges the h

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. Okay. I think we're on the same page about representation now. If you can come up with a good replacement for "eha" in the intrinsic names, I think this is pretty much ready to go. Comment at: llvm/docs/LangRef.rst:11584 +These intrinsics make Bloc

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

MyDeveloperDay added a comment. I think if you have a proposal for changing the behavior lets see the patch and how it impacts the existing unit tests something tells me these tests are going to change? // A lambda passed as arg0 is always pushed to the next line. verifyFormat("SomeFunction

[PATCH] D88088: WIP [clang] improve accuracy of ExprMutAnalyzer

JonasToth updated this revision to Diff 293967. JonasToth added a comment. - improve the expression matcher, to catch the expression in general ternary-operator cases, too - considered unresolved operator calls to be a modification - fix method calls with templates in some instances Repository:

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:580 return false; -// No point guessing the same location we started with. -if (Tok.location() == Word.Location) sammccall wrote: > ArcsinX wrote: > > sammccall wrote: >

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 293970. JonasToth added a comment. rebase to current exprmutanalyzer - remove spurious formatting change - fix include and typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://review

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

steakhal added a comment. In D77062#1976414 , @Szelethus wrote: > I think what what be great to see here (and this seems to be the thing @NoQ > is fishing for) is not to change an if branch and avoid running into the > crash, but rather find out why `ass

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

steakhal added a comment. What are our options mitigating anything similar happening in the future? This way any change touching the `SymbolicRangeInferrer` and any related parts of the analyzer seems to be way too fragile. Especially, since we might want to add support for comparing SymSyms, ju

[clang-tools-extra] 64168c6 - [clangd] Disable suffix matching fallback for C during include insertion

Author: Kadir Cetinkaya Date: 2020-09-24T10:46:10+02:00 New Revision: 64168c6d996b6fdd017488785e0e9ce5ce05be54 URL: https://github.com/llvm/llvm-project/commit/64168c6d996b6fdd017488785e0e9ce5ce05be54 DIFF: https://github.com/llvm/llvm-project/commit/64168c6d996b6fdd017488785e0e9ce5ce05be54.dif

[PATCH] D88144: [clangd] Disable suffix matching fallback for C during include insertion

kadircet added a comment. In D88144#2290830 , @sammccall wrote: > (I do wonder whether it's safe to just drop the mapping table entirely now...) As discussed offline; It still helps with mapping symbols missing from our cppreference extraction back to um

[PATCH] D88144: [clangd] Disable suffix matching fallback for C during include insertion

This revision was automatically updated to reflect the committed changes. Closed by commit rG64168c6d996b: [clangd] Disable suffix matching fallback for C during include insertion (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] 98756d8 - [clangd] Fix comment. NFC

Author: Sam McCall Date: 2020-09-24T10:49:39+02:00 New Revision: 98756d865b696bece858ff0832ed3687b6b8ba4b URL: https://github.com/llvm/llvm-project/commit/98756d865b696bece858ff0832ed3687b6b8ba4b DIFF: https://github.com/llvm/llvm-project/commit/98756d865b696bece858ff0832ed3687b6b8ba4b.diff LO

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. Should I create more measurements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86295/new/ https://reviews.llvm.org/D86295 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. @AlexanderLanin @0x8000- i created the branch `release-11-const` (https://github.com/JonasToth/llvm-project/tree/release-11-const) in my fork. This branch is based on 11-rc3 and cherry picks the commits that correspond to this revision. I hope this is of any use f

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff updated this revision to Diff 293974. sepavloff marked an inline comment as done. sepavloff added a comment. Updated patch - improved Expr::getFPFeaturesInEffect, - added tests for _Complex, - added tests for constexpr, - added chech in HandleFloatToFloatCast, - implemented printing FPO

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2427 +FPOptions FPFeatures = Cast->getFPFeaturesInEffect(Info.Ctx.getLangOpts()); +RM = FPFeatures.getRoundingMode(); + } rjmccall wrote: > sepavloff wrote: > > rjmccall wrote: >

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

JonasToth added a comment. In D36836#2289639 , @lebedev.ri wrote: > Rebased. > > There is a number of official open-source LGPL-3 implementations already: > > - https://github.com/SonarSource/SonarTS/pull/378 > - https://github.com/SonarSource/sonar-java/p

[PATCH] D88204: [clangd] Drop path suffix mapping for std symbols

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. As mentioned in D88144

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. In D87774#2287927 , @sameeranjoshi wrote: > Thanks for working on it. > Few comments inline: > > 1. For an out-of-tree build, I see `check-flang` target failing with > > /unittests/Frontend/CompilerInstanceTest.cpp:17:10: fat

[PATCH] D88164: [clang][Sema] Use enumerator instead of hard-coded constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc842a95072: [clang][Sema] Use enumerator instead of hard-coded constant (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 8cc842a - [clang][Sema] Use enumerator instead of hard-coded constant

Author: Mikhail Maltsev Date: 2020-09-24T10:24:22+01:00 New Revision: 8cc842a95072aaa87b5067a12aa9ef5b3ac8e592 URL: https://github.com/llvm/llvm-project/commit/8cc842a95072aaa87b5067a12aa9ef5b3ac8e592 DIFF: https://github.com/llvm/llvm-project/commit/8cc842a95072aaa87b5067a12aa9ef5b3ac8e592.dif

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

kiranchandramohan added inline comments. Comment at: flang/lib/Frontend/TextDiagnosticPrinter.cpp:24 + +TextDiagnosticPrinter::TextDiagnosticPrinter( +raw_ostream &os, clang::DiagnosticOptions *diags) awarzynski wrote: > sameeranjoshi wrote: > > A silly quest

[clang-tools-extra] 00e05b1 - [clangd] Reorder a little bit of init code. NFC

Author: Sam McCall Date: 2020-09-24T11:57:31+02:00 New Revision: 00e05b12c76c396688cd8d4caac09a2e96851fd9 URL: https://github.com/llvm/llvm-project/commit/00e05b12c76c396688cd8d4caac09a2e96851fd9 DIFF: https://github.com/llvm/llvm-project/commit/00e05b12c76c396688cd8d4caac09a2e96851fd9.diff LO

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

theraven accepted this revision. theraven added a comment. This revision is now accepted and ready to land. Looks good to me, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 _

[clang] 4e53490 - [NFC][Docs] fix clang-docs compilation

Author: Jonas Toth Date: 2020-09-24T13:13:38+02:00 New Revision: 4e534900476d2a5c620e74ddb9c9e7d321e6d443 URL: https://github.com/llvm/llvm-project/commit/4e534900476d2a5c620e74ddb9c9e7d321e6d443 DIFF: https://github.com/llvm/llvm-project/commit/4e534900476d2a5c620e74ddb9c9e7d321e6d443.diff LO

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

nemanjai added a comment. This clearly changes behaviour and should thereby not have the `[NFC]` tag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D88216: [Analyzer] Fix handling of pointer-based iterator increments and decrements

baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: NoQ. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, w

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss added a comment. @chill ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. This is not what we want. The builtin behaves correctly. It is equivalent to the generic `__builtin_copysign` and it would be very surprising to a user if it reverses the operand

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. @sameeranjoshi Regarding ``, please see https://reviews.llvm.org/D88219. Sadly we missed that when adding that test, sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#2291969 , @JonasToth wrote: > @AlexanderLanin @0x8000- i created the branch `release-11-const` > (https://github.com/JonasToth/llvm-project/tree/release-11-const) in my fork. > > This branch is based on 11-rc3 an

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 294023. awarzynski added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 Files: clang/include/clang/Driver/Options.td flang/in

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

Rechi added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:184 +bool AddComma = false; +if (!Ctor->getNumCtorInitializers() && FirstToCtorInits) { + SourceLocation BodyPos = Ctor->getBody()->g

[PATCH] D88220: [C++20] Implement more implicit moves for return statements(Part of P1825R0)

nullptr.cpp created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nullptr.cpp requested review of this revision. In P1825R0, the first parameter of overload resolution selected function does not need to be an rvalue reference to the returned object's type.

[clang] f5314d1 - [Support] On Unix, let the CrashRecoveryContext return the signal code

Author: Alexandre Ganea Date: 2020-09-24T08:21:43-04:00 New Revision: f5314d15af4f4514103ea12c74cb208538b8bef5 URL: https://github.com/llvm/llvm-project/commit/f5314d15af4f4514103ea12c74cb208538b8bef5 DIFF: https://github.com/llvm/llvm-project/commit/f5314d15af4f4514103ea12c74cb208538b8bef5.dif

[PATCH] D88222: [AST] Use data-recursion when building ParentMap, avoid stack overflow.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. The following crashes on my system before this patch, but not after: void foo(int i) { switch (i) {

[clang-tools-extra] e39da8a - Recommit "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions"

Author: Yaxun (Sam) Liu Date: 2020-09-24T08:44:37-04:00 New Revision: e39da8ab6a286ac777d5fe7799f1eb782cf99938 URL: https://github.com/llvm/llvm-project/commit/e39da8ab6a286ac777d5fe7799f1eb782cf99938 DIFF: https://github.com/llvm/llvm-project/commit/e39da8ab6a286ac777d5fe7799f1eb782cf99938.dif

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

chill accepted this revision. chill added a comment. In D75044#2292302 , @danielkiss wrote: > @chill ping. Sorry, I thought about committing all PAC/BTI patches together, but there's no reason, is there? So, let's go ahead and commit the two dealing with

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA added a comment. In D88105#2292266 , @nemanjai wrote: > This clearly changes behaviour and should thereby not have the `[NFC]` tag. Looks like it accidentally includes https://reviews.llvm.org/D88130. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. @steakhal > I would not accept this patch unless this investigation is done. However, I'm > not inherently against this change. Actually I've done the investigation. You can find it here https://reviews.llvm.org/D77062#1977613 The bug is somewhere deep in the co

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov added a comment. @NoQ Comment at: clang/test/Analysis/Checkers/CPlusPlus11LockChecker.cpp:379-382 +void rm_bad1() { + rm1.lock(); // no-warning + rm1.lock(); // expected-warning{{This lock has already been acquired}} +} NoQ wrote: > ASDenysPetro

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check

whisperity added a comment. I'd like to resurrect the discussion about this. Unfortunately, the concept of `experimental-` group (in D76545 ) has fallen silent, too. We will present the results of this analysis soon at IEEE SCAM (Source Code Analysis and Manipul

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 294036. LuoYuanke added a comment. Updating D87981 : [X86] AMX programming model prototype. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

aganea added a comment. In D87187#2291806 , @dmantipov wrote: > IIUC compiler driver is not intended to be multithreaded. But OK, here is the > version with llvm::call_once(...). Thanks! There could be at least two cases I see, where the driver //could//

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

aaron.ballman added a comment. In D36836#2289639 , @lebedev.ri wrote: > Rebased. > > There is a number of official open-source LGPL-3 implementations already: > > - https://github.com/SonarSource/SonarTS/pull/378 > - https://github.com/SonarSource/sonar-ja

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. The remaining requests can be fulfilled when committing. I don't think this requires another review. Thanks. Comment at: clang/lib/Headers/altivec.h:7865 +#endif + retu

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson created this revision. arichardson added reviewers: JakeMerdichAMD, MyDeveloperDay, jrtc27. Herald added subscribers: cfe-commits, krytarowski, emaste. Herald added a project: clang. arichardson requested review of this revision. Some projects (e.g. FreeBSD) align pointers to the right

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

jrtc27 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return Right.Tok.isLiteral()

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return Right.Tok.isLite

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

jrtc27 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return Right.Tok.isLiteral()

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return Right.Tok.isLite

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

jrtc27 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return Right.Tok.isLiteral()

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson updated this revision to Diff 294049. arichardson marked 3 inline comments as done. arichardson added a comment. merge if with existing condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88227/new/ https://reviews.llvm.org/D88227

[PATCH] D88088: WIP [clang] improve accuracy of ExprMutAnalyzer

JonasToth added inline comments. Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:455 + const auto HasAnyNonConstIterator = + anyOf(allOf(hasMethod(allOf(hasName("begin"), unless(isConst(, + unless(hasMethod(allOf(hasName("begin"), isConst(),

[PATCH] D88088: WIP [clang] improve accuracy of ExprMutAnalyzer

JonasToth updated this revision to Diff 294050. JonasToth marked 9 inline comments as done. JonasToth added a comment. - adress review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88088/new/ https://reviews.llvm.org/D88088 Files: clang

[PATCH] D88195: Remove stale assert.

jyknight added inline comments. Comment at: clang/test/Modules/asm-goto.cpp:1 +// RUN: rm -rf %t +// RUN: %clang_cc1 -fmodules -fno-implicit-modules -x c++ -I%S/Inputs/asm-goto -emit-module %S/Inputs/asm-goto/module.modulemap -fmodule-name=a -o %t/a.pcm void wro

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

daltenty updated this revision to Diff 294053. daltenty added a comment. - Fix formating - Fix typos - Replace pattern with windows-friendly directory seperators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https://reviews.llvm.org/D881

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

lebedev.ri added a comment. In D36836#2292541 , @aaron.ballman wrote: > In D36836#2289639 , @lebedev.ri > wrote: > >> Rebased. >> >> There is a number of official open-source LGPL-3 implementations already: >> >>

[clang] 31a3c5f - [clang] use string tables for static diagnostic descriptions

Author: Nathan Froyd Date: 2020-09-24T10:54:28-04:00 New Revision: 31a3c5fb45b78bdaa78d94ffcc9258e839002016 URL: https://github.com/llvm/llvm-project/commit/31a3c5fb45b78bdaa78d94ffcc9258e839002016 DIFF: https://github.com/llvm/llvm-project/commit/31a3c5fb45b78bdaa78d94ffcc9258e839002016.diff

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG31a3c5fb45b7: [clang] use string tables for static diagnostic descriptions (authored by froydnj). Changed prior to commit: https://reviews.llvm.org/D81865?vs=288628&id=294063#toc Repository: rG LLVM

[PATCH] D87451: add new clang option -mno-xcoff-visibility

DiggerLin marked 5 inline comments as done. DiggerLin added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2768 // The type-visibility mode defaults to the value-visibility mode. if (Arg *typeVisOpt = Args.getLastArg(OPT_ftype_visibility)) { Opt

[PATCH] D88222: [AST] Use data-recursion when building ParentMap, avoid stack overflow.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks for fixing this! Comment at: clang/lib/AST/ParentMapContext.cpp:231 + template + void MarkChild(MapNodeTy MapNode, MapTy *Parents) { +if (ParentStack.empty()) -

[PATCH] D87451: add new clang option -mno-xcoff-visibility

DiggerLin updated this revision to Diff 294070. DiggerLin marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451 Files: clang/docs/ClangCommandLineReference.rst clang/include/cl

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

aaron.ballman edited reviewers, added: tonic, asl, hfinkel; removed: dberlin. aaron.ballman added a comment. In D36836#2292727 , @lebedev.ri wrote: > In D36836#2292541 , @aaron.ballman > wrote: > >> In D36836#22896

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https://reviews.llvm.org/D88182

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, efriedma, rsandifo-arm. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. c-rhodes requested review of this revision. This patch adds tests and support for operat

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

hubert.reinterpretcast added a comment. Looks to me that this (since it is approved) completely replaces D88130 . The patch description needs to be changed of course. Not sure if the committer wants to try splitting out the non-AIX test as an NFC patch. CHANGE

[PATCH] D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Thanks Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88179/new/ https://reviews.llvm.org/D88179

[clang] 296d883 - Sema: add support for `__attribute__((__swift_newtype__))`

Author: Saleem Abdulrasool Date: 2020-09-24T15:17:35Z New Revision: 296d8832a3b5fe97725be62c5bbc721cc0e2cd20 URL: https://github.com/llvm/llvm-project/commit/296d8832a3b5fe97725be62c5bbc721cc0e2cd20 DIFF: https://github.com/llvm/llvm-project/commit/296d8832a3b5fe97725be62c5bbc721cc0e2cd20.diff

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

tonic added a comment. Licensing questions are best sent to the bo...@llvm.org mailing address. Can you reach out there? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36836/new/ https://reviews.llvm.org/D36836

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 294074. mibintc added a comment. Responded to @rsmith's review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87528/new/ https://reviews.llvm.org/D87528 Files: clang/include/clang/Basic/DiagnosticASTKinds.td clang/include/clang/Basic/DiagnosticP

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG296d8832a3b5: Sema: add support for `__attribute__((__swift_newtype__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. Note, @sepavloff is working on overlapping concerns here, D87822 : [FPEnv] Evaluate constant expressions under non-default rounding modes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87528/new/ https://reviews.llvm.org/D87528

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2683 } + if (const BinaryOperator *BE = dyn_cast(E)) { +if (BE->getFPFeaturesInEffect(Info.Ctx.getLangOpts()).isFPConstrained()) { rsmith w

[PATCH] D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool

whisperity added a comment. Ping. Can this go in? Still using this on a local fork, and still feels nice to be able to specify just a single tool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84176/new/ https://reviews.llvm.org/D84176 ___ c

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

erichkeane created this revision. erichkeane added reviewers: rjmccall, rsmith. erichkeane requested review of this revision. As mentioned in the bug report, tryEmitPrivate chokes on the MaterializeTemporaryExpr in the reproducers, since it assumes that if there are elements, than it must be a Con

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

erichkeane added a comment. Note: @rsmith and @rjmccall were the last ones in this section based on Blame (by a wide margin!), so added both as reviewers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88236/new/ https://reviews.llvm.org/D88236 _

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

arichardson created this revision. arichardson added reviewers: JakeMerdichAMD, MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. While writing tests for D88227 , I noticed that mu

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson updated this revision to Diff 294090. arichardson added a comment. - Add a multi-variable-decl test (depends on D88239 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88227/new/ https://reviews.llvm.org

[PATCH] D88220: [C++20] Implement more implicit moves for return statements(Part of P1825R0)

Quuxplusone added a comment. I'd like to see some indication in the code comments, in the commit message, and/or in cxx_status.html, explaining //what// parts of P1825 are implemented and what parts remain unimplemented after this patch. (My ideal would be to ho

[PATCH] D88088: WIP [clang] improve accuracy of ExprMutAnalyzer

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:455 + const auto HasAnyNonConstIterator = + anyOf(allOf(hasMethod(allOf(has

[PATCH] D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Need to fix a check for the variable if it is declared in the inner OpenMP

[PATCH] D87953: [xray] Function coverage groups

kyulee added a comment. I think it looks good to me. @MaskRay Any further feedback on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 ___ cfe-commits mailin

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

MaskRay added a comment. @froydnj The committed version rG31a3c5fb45b78bdaa78d94ffcc9258e839002016 appears to be very different from the review. I guess next time your probably can upload the diff again if it is very diffiere

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

dblaikie added a comment. In D81865#2293059 , @MaskRay wrote: > @froydnj The committed version rG31a3c5fb45b78bdaa78d94ffcc9258e839002016 > appears > to be very different from the revi

[PATCH] D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LGTM, please feel free to land this as-is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84176/new/ https://reviews.llvm.org/D84176 __

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added a comment. In D86671#2284078 , @dougpuob wrote: > Hi @aaron.ballman > About changing `size_t nLength` to `cbLength`. I searched MSVC folders with > `size_t`, many names of variable start with `n`, or `i` in MFC related files. > So I

[PATCH] D87953: [xray] Function coverage groups

MaskRay added a comment. In D87953#2293024 , @kyulee wrote: > I think it looks good to me. @MaskRay Any further feedback on this? This looks good from my viewpoint. One thing remains unanswered (https://reviews.llvm.org/D87953#2284071) is how the overhea

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

MaskRay added a comment. In D81865#2293066 , @dblaikie wrote: > In D81865#2293059 , @MaskRay wrote: > >> @froydnj The committed version rG31a3c5fb45b78bdaa78d94ffcc9258e839002016 >>

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. In D81865#2293146 , @MaskRay wrote: > In D81865#2293066 , @dblaikie wrote: > >> In D81865#2293059 , @MaskRay wrote: >> >>> @froydnj The committed ver

[clang] a9fca98 - [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member.

Author: Alexey Bataev Date: 2020-09-24T13:14:13-04:00 New Revision: a9fca98ee4f653278d84713caecd152fef8494f5 URL: https://github.com/llvm/llvm-project/commit/a9fca98ee4f653278d84713caecd152fef8494f5 DIFF: https://github.com/llvm/llvm-project/commit/a9fca98ee4f653278d84713caecd152fef8494f5.diff

[PATCH] D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9fca98ee4f6: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

  1   2   3   >