[clang] 8e780a1 - Recommit [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

Author: Yaxun (Sam) Liu Date: 2020-09-23T16:55:00-04:00 New Revision: 8e780a1653e6f87755a447e921b8f929d8b70996 URL: https://github.com/llvm/llvm-project/commit/8e780a1653e6f87755a447e921b8f929d8b70996 DIFF: https://github.com/llvm/llvm-project/commit/8e780a1653e6f87755a447e921b8f929d8b70996.dif

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 293846. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Addressed the comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files: clang/include/clang/Basic/Attr.td cla

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

daltenty created this revision. daltenty added reviewers: stevewan, hubert.reinterpretcast, jasonliu, Xiangling_L. Herald added subscribers: cfe-commits, dberris. Herald added a project: clang. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

sammccall marked 7 inline comments as done. sammccall added a comment. Thanks! I've addressed most of the comments one way or the other, please LMK if it's not convincing! Meanwhile I'm going to split this up to land in parts. Comment at: clang-tools-extra/clangd/ClangdLSPServ

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

sammccall updated this revision to Diff 293863. sammccall marked 2 inline comments as done. sammccall added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88103/new/ https://reviews.llvm.org/D88103 Files: clang

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG140b7b6f09ca: [JSON] Allow emitting comments in json::OStream (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D88103?vs

[clang] d9717d8 - [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

Author: Craig Topper Date: 2020-09-23T14:54:39-07:00 New Revision: d9717d8ee7143f4f5b768dfb5e8629ecfa067e39 URL: https://github.com/llvm/llvm-project/commit/d9717d8ee7143f4f5b768dfb5e8629ecfa067e39 DIFF: https://github.com/llvm/llvm-project/commit/d9717d8ee7143f4f5b768dfb5e8629ecfa067e39.diff

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9717d8ee714: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default… (authored by craig.topper). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D8

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2288898 , @tentzen wrote: > In D80344#2286838 , @rjmccall wrote: > >> In D80344#228 , @tentzen wrote: >> >>> There is absolutely NO ex

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was automatically updated to reflect the committed changes. Closed by commit rG16619e7139bd: [JSON] Facility to track position within an object and report errors. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D88103?vs=293864&id=293870#toc Repository:

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was automatically updated to reflect the committed changes. Closed by commit rG38de1c33a837: [JSON] Display errors associated with Paths in context (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D88103?vs=293870&id=293879#toc Repository: rG LLVM Gith

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.c:215 // CHECK-LD64-NO-DEFAULT-LIBS: {{.*}}clang{{(.exe)?}}" "-cc1" "-triple" "powerpc64-ibm-aix7.1.0.0" +// CHECK-LD64-NO-STD-LIB: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK-LD64

[libunwind] b16d665 - [libunwind] Combine dl_iterate_phdr codepaths for DWARF and EHABI

Author: Ryan Prichard Date: 2020-09-23T15:40:39-07:00 New Revision: b16d6653c01cee37f51a98dd4092c4ef302c47a5 URL: https://github.com/llvm/llvm-project/commit/b16d6653c01cee37f51a98dd4092c4ef302c47a5 DIFF: https://github.com/llvm/llvm-project/commit/b16d6653c01cee37f51a98dd4092c4ef302c47a5.diff

[libunwind] 881aba7 - [libunwind] Optimize dl_iterate_phdr's findUnwindSectionsByPhdr

Author: Ryan Prichard Date: 2020-09-23T15:40:39-07:00 New Revision: 881aba7071c6e4cc2417e875ca5027ec7c0a92a3 URL: https://github.com/llvm/llvm-project/commit/881aba7071c6e4cc2417e875ca5027ec7c0a92a3 DIFF: https://github.com/llvm/llvm-project/commit/881aba7071c6e4cc2417e875ca5027ec7c0a92a3.diff

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

dblaikie added a comment. In D80531#2284388 , @kkleine wrote: > Hi @dblaikie . I did run `ninja check-all` and `/bin/llvm-lit -av > ../clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp` > on this very new rev

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

rnk accepted this revision. rnk added a comment. Looks good to me, I didn't review very in depth, but I see the test case that we need. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70378/new/ https://reviews.llvm.org/D70378 __

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jyknight added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4539 CharUnits CCAlign = getParamTypeAlignment(Ty); CharUnits TyAlign = getContext().getTypeAlignInChars(Ty); Xiangling_L wrote: > jasonliu wrote: > > Question: > > It looks

[clang-tools-extra] fa69b60 - [JSON] Add error reporting to fromJSON and ObjectMapper

Author: Sam McCall Date: 2020-09-24T01:20:09+02:00 New Revision: fa69b608063eecba76fb35d167b063cbfe532c28 URL: https://github.com/llvm/llvm-project/commit/fa69b608063eecba76fb35d167b063cbfe532c28 DIFF: https://github.com/llvm/llvm-project/commit/fa69b608063eecba76fb35d167b063cbfe532c28.diff LO

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa69b608063e: [JSON] Add error reporting to fromJSON and ObjectMapper (authored by sammccall). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: https://rev

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

sammccall updated this revision to Diff 293892. sammccall added a comment. This was landed as 4 commits, this diff is all 4 as committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88103/new/ https://reviews.llvm.org/D88103 Files: clang-tools

[PATCH] D68997: Allow searching for prebuilt implicit modules.

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jyknight added a comment. I'm happy with this now, but please update the commit message to match the updated change. Comment at: clang/include/clang/AST/ASTContext.h:2177-2179 /// This can be different than the ABI alignment in cases where it is - /// beneficial for perfor

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. > @rjmccall wrote: > I think you're missing what I'm asking. If LLVM accepts this feature, it > will become our collective responsibility as a project to keep it working. > You have a large external correctness test suite for this feature. It does > not sound like yo

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

efriedma added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4539 CharUnits CCAlign = getParamTypeAlignment(Ty); CharUnits TyAlign = getContext().getTypeAlignInChars(Ty); jyknight wrote: > Xiangling_L wrote: > > jasonliu wrote: > > > Q

[clang-tools-extra] 2bd5e3f - [clangd] Improve bad-RPC-payload error messages slightly

Author: Sam McCall Date: 2020-09-24T01:51:37+02:00 New Revision: 2bd5e3fb3cc032f90447067d38c48c75b23f32c5 URL: https://github.com/llvm/llvm-project/commit/2bd5e3fb3cc032f90447067d38c48c75b23f32c5 DIFF: https://github.com/llvm/llvm-project/commit/2bd5e3fb3cc032f90447067d38c48c75b23f32c5.diff LO

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2291385 , @asmith wrote: >> @rjmccall wrote: >> I think you're missing what I'm asking. If LLVM accepts this feature, it >> will become our collective responsibility as a project to keep it working. >> You have a la

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2291156 , @rjmccall wrote: > In D80344#2288898 , @tentzen wrote: > >> In D80344#2286838 , @rjmccall wrote: >> >>> In D80344#228

[PATCH] D88195: Remove stale assert.

void created this revision. void added reviewers: nickdesaulniers, jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. void requested review of this revision. Remove assert that "asm goto" cannot have outputs. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

cebowleratibm updated this revision to Diff 293917. cebowleratibm marked 2 inline comments as done. cebowleratibm added a comment. Reworked the prefixes and indentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 Files: clang/lib/CodeGen/

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Generally looks good to me! Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2287 + // don't have trivial or constexpr constructors, or can be created from + // aggregate

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jyknight added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4539 CharUnits CCAlign = getParamTypeAlignment(Ty); CharUnits TyAlign = getContext().getTypeAlignInChars(Ty); efriedma wrote: > jyknight wrote: > > Xiangling_L wrote: > > > j

[PATCH] D88195: Remove stale assert.

jyknight added inline comments. Comment at: clang/test/Modules/Inputs/asm-goto/a.h:4-6 + asm goto("xor $0, $0\n\t" + "test $0, $0\n\t" + "jne $l1\n\t" An empty asm string will suffice for the test. Comment at: clang/test/Mo

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA accepted this revision. ZarkoCA added a comment. Thanks for doing the formatting changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 6b136b1 - [Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

Author: Amy Kwan Date: 2020-09-23T22:55:25-05:00 New Revision: 6b136b19cbe4e96adea63b75f1f2f76ec25c708e URL: https://github.com/llvm/llvm-project/commit/6b136b19cbe4e96adea63b75f1f2f76ec25c708e DIFF: https://github.com/llvm/llvm-project/commit/6b136b19cbe4e96adea63b75f1f2f76ec25c708e.diff LOG:

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b136b19cbe4: [Power10] Implement custom codegen for the vec_replace_elt and… (authored by amyk). Changed prior to commit: https://reviews.llvm.o

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2291456 , @tentzen wrote: > In D80344#2291156 , @rjmccall wrote: > >> In D80344#2288898 , @tentzen wrote: >> >>> In D80344#2286838

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *RetValUnderCons

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 293938. void added a comment. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/a.h cla

[PATCH] D88195: Remove stale assert.

void added inline comments. Comment at: clang/test/Modules/asm-goto.cpp:1 +// RUN: rm -rf %t +// RUN: %clang_cc1 -fmodules -fno-implicit-modules -x c++ -I%S/Inputs/asm-goto -emit-module %S/Inputs/asm-goto/module.modulemap -fmodule-name=a -o %t/a.pcm jyknight wro

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX added a comment. I feel like I'm doing something totally wrong here :) Could someone give me an advice? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.llvm.org/D87891 __

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 293944. lanza added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/Basic/Attr.td cl

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. @theraven @rjmccall should be ready for review whenever you guys are ready! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___ cfe-commits

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

kadircet added a comment. Hey! Sorry for the late reply, this has been open in my tabs since day 1 just didn't get a chance to take a look at it. The biggest problem I see is, this is not changing the fact that we are still traversing the whole file: - You do one traversal over the whole file

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:565 unsigned Line = SM.getSpellingLineNumber(Loc); if (Line > WordLine) + return 1 + Line - WordLine; Since costs are only compared, we can simplify this: return (Line

<    1   2