[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#2289037 , @0x8000- wrote: > Master branch has too many false positives for tidy - would it be possible to > create a branch that contains this patch set on top of llvm-11.0-rc3? I would > then add this to our inte

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX updated this revision to Diff 293665. ArcsinX added a comment. std::pow => bitwise shift. Take care about integers overflow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.llvm.org/D87891 Files: clang-tools-ex

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. In D86694#2288660 , @aganea wrote: > I'm also in favor, I think this is good direction ahead. It'd be nice if > following issues were fixed -- in subsequent patches if you wish: > > - Stage1 `ninja check-scudo` fails many t

[PATCH] D88100: [analyzer][StdLibraryFunctionsChecker] Separate the signature from the summaries

martong added a comment. Thanks for the review! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88100/new/ https://reviews.llvm.org/D88100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D88092: [analyzer][StdLibraryFunctionsChecker] Fix getline/getdelim signatures

martong added a comment. In D88092#2289312 , @Szelethus wrote: > A joy of reviewing C++ code is that you get to marvel in all the great things > the language has, without having to pull fistfuls of hair out to get get to > that point. These patches are a

[clang] d63a945 - [analyzer][StdLibraryFunctionsChecker] Fix getline/getdelim signatures

Author: Gabor Marton Date: 2020-09-23T10:48:14+02:00 New Revision: d63a945a13048b66f06e222d8b0810d7db9592f6 URL: https://github.com/llvm/llvm-project/commit/d63a945a13048b66f06e222d8b0810d7db9592f6 DIFF: https://github.com/llvm/llvm-project/commit/d63a945a13048b66f06e222d8b0810d7db9592f6.diff

[PATCH] D88092: [analyzer][StdLibraryFunctionsChecker] Fix getline/getdelim signatures

This revision was automatically updated to reflect the committed changes. Closed by commit rGd63a945a1304: [analyzer][StdLibraryFunctionsChecker] Fix getline/getdelim signatures (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D880

[PATCH] D88100: [analyzer][StdLibraryFunctionsChecker] Separate the signature from the summaries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11d2e63ab006: [analyzer][StdLibraryFunctionsChecker] Separate the signature from the summaries (authored by martong). Repository: rG LLVM Github M

[clang] 11d2e63 - [analyzer][StdLibraryFunctionsChecker] Separate the signature from the summaries

Author: Gabor Marton Date: 2020-09-23T10:59:34+02:00 New Revision: 11d2e63ab0060c656398afd8ea26760031a9fb96 URL: https://github.com/llvm/llvm-project/commit/11d2e63ab0060c656398afd8ea26760031a9fb96 DIFF: https://github.com/llvm/llvm-project/commit/11d2e63ab0060c656398afd8ea26760031a9fb96.diff

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

curdeius added subscribers: MyDeveloperDay, curdeius. curdeius added a comment. Hi, I know it's an old revision, but I confirm that it provoked the bug https://bugs.llvm.org/show_bug.cgi?id=45141. The problem is in the `TokenAnnotator::mustBreakBefore` as @jaafar pointed out: if (!Next->isOneO

[PATCH] D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins

Conanap closed this revision. Conanap added a comment. Committed with Nemanja's comments addressed in the commit. Hash d7eb917a7cb793f49e16841fc24826b988dd5c8f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87394/new/

[PATCH] D88140: [clang-tidy] Check for sigaction in cert-sig30-c.

balazske created this revision. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. Herald added a project: clang. balazske requested review of this revision. The checker recognizes handlers assigned to members of a "struct sigaction" variable. If

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

RKSimon added inline comments. Comment at: clang/test/CodeGen/bittest-intrin.c:50 // X64: call i8 asm sideeffect "lock btrq $2, ($1)\0A\09setc ${0:b}", "=r,r,r,~{{.*}}"(i64* %{{.*}}, i64 {{.*}}) // X64: call i8 asm sideeffect "lock btsq $2, ($1)\0A\09setc ${0:b}", "=r,r,r,~{{

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https://reviews.llvm.org/D87449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

lebedev.ri updated this revision to Diff 293678. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. Rebased. There is a number of official open-source LGPL-3 implementations already: - https://github.com/SonarSource/SonarTS/pull/378 - https://github.com/SonarSource/sonar

[PATCH] D83472: [SystemZ/ZOS] Add header file to encapsulate use of

mgorny added inline comments. Comment at: llvm/include/llvm/Support/ExitCodes.h:19 + +#include "llvm/Config/config.h" + This is a private LLVM header and it's not installed. Therefore, this installed header references uninstalled headers and breaks standalone bu

[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! This looks great. I've mostly did the full review anyway but feel free to land in small patches just in case some compiler becomes upset and you need to revert. Mostly nits, and s

[clang] 301e233 - [CUDA][HIP] Fix static device var used by host code only

Author: Yaxun (Sam) Liu Date: 2020-09-23T08:18:19-04:00 New Revision: 301e23305d03cfb4004f845a1d9dfdc5e5931fd8 URL: https://github.com/llvm/llvm-project/commit/301e23305d03cfb4004f845a1d9dfdc5e5931fd8 DIFF: https://github.com/llvm/llvm-project/commit/301e23305d03cfb4004f845a1d9dfdc5e5931fd8.dif

[PATCH] D88115: [CUDA][HIP] Fix static device var used by host code only

This revision was automatically updated to reflect the committed changes. Closed by commit rG301e23305d03: [CUDA][HIP] Fix static device var used by host code only (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D88144: [clangd] Disable suffix matching fallback for C during include insertion

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Clangd currently doesn't respect language a

[PATCH] D88146: Dummy git message. Update from phabricator.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88146 Files: clang-tools-extra/clangd/Quality.cpp clang-tool

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 updated this revision to Diff 293706. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79500/new/ https://reviews.llvm.org/D79500 Files: clang-tool

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/Quality.h:129 + // Properties and utilites used to compute derived signals. These are ignored + // by a scoring function. Must be explicitly assigned. sammccall wrote: > Why is it better to

[PATCH] D88088: WIP [clang] improve accuracy of ExprMutAnalyzer

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:44 + InnerMatcher) { + // Unless the value is a derived class and is assigned to a + // reference to the base class. Other implicit casts should not Unless

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2172 +def SwiftNewType : InheritableAttr { + // `swift_wrapper` is a "deprecated" alias and kept for compatibility with + // shipped toolchains. New users should prefer the `swift_newtype` spell

[clang] 1d1c382 - Fix typos in ASTMatchers.h; NFC

Author: YangZhihui Date: 2020-09-23T09:09:11-04:00 New Revision: 1d1c382ed221f378fc866a524c7c673c239e94bc URL: https://github.com/llvm/llvm-project/commit/1d1c382ed221f378fc866a524c7c673c239e94bc DIFF: https://github.com/llvm/llvm-project/commit/1d1c382ed221f378fc866a524c7c673c239e94bc.diff LO

[PATCH] D87451: add new clang option -mno-xcoff-visibility

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: llvm/include/llvm/Target/TargetMachine.h:265 + /// corresponding to -mno-xcoff-visibility. + bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; } + dalte

[PATCH] D88003: Fix typos in ASTMatchers.h

aaron.ballman closed this revision. aaron.ballman added a comment. In D88003#2289168 , @YangZhihui wrote: > In D88003#2287580 , @aaron.ballman > wrote: > >> LGTM! > > I don't have commit access > maybe you can help

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

grokos added a comment. In D87946#2287744 , @jhuber6 wrote: > Seems like a hacky solution to just keep adding suffixed whenever we want a > new interface though. Yes, this used to be a point of contention within the community. We discussed the issue som

[PATCH] D87095: [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

t.p.northover added a comment. I had a look through this and everything seemed to be in place. I think the ABI versioning is probably sufficient to prevent surprises and land this now, to avoid churn in the rest of the code. If more is really needed, we could add a temporary warning ("incomplet

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. In D87946#2289959 , @grokos wrote: > Yes, this used to be a point of contention within the community. We discussed > the issue sometime ago and the majority of developers was in favor of this > approach (as opposed to e.g. having

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list cf

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert added inline comments. Comment at: openmp/libomptarget/src/interface.cpp:118 + __tgt_target_data_begin_mapper_loc(nullptr, device_id, arg_num, args_base, args, + arg_sizes, arg_types, nullptr); +} why not pass arg_mappers Comme

[clang-tools-extra] 158af0d - [clangd] Refactor code completion signal's utility properties.

Author: Utkarsh Saxena Date: 2020-09-23T16:12:18+02:00 New Revision: 158af0d3d165c0382a6a291e81ffecf0b18ffe77 URL: https://github.com/llvm/llvm-project/commit/158af0d3d165c0382a6a291e81ffecf0b18ffe77 DIFF: https://github.com/llvm/llvm-project/commit/158af0d3d165c0382a6a291e81ffecf0b18ffe77.diff

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 293725. jhuber6 added a comment. Fixed not passing mappers to new functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 closed this revision. usaxena95 added a comment. Closed with commit 158af0d3d165c0382a6a291e81ffecf0b18ffe77 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/powerpc-c99complex.c:7 + return x; +// PPC64LNX-LABEL: define { float, float } @foo1(float %x.{{.*}}, float %x.{{.*}}) #0 { +// PPC64LNX: ret { float, float } Nit: I don't think you

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert added inline comments. Comment at: openmp/libomptarget/src/interface.cpp:161 if (depNum + noAliasDepNum > 0) __kmpc_omp_taskwait(NULL, __kmpc_global_thread_num(NULL)); Remove this and call the nowait_mapper_loc version. Let's not duplicate log

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2287851 , @dmajor wrote: > The expensive-checks bots have been red for several days. Could you please > take a look or revert? Working on it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm created this revision. venkataramanan.kumar.llvm added reviewers: Florian, abique. Herald added subscribers: llvm-commits, cfe-commits, dang, dmgreen, hiraditya. Herald added projects: clang, LLVM. venkataramanan.kumar.llvm requested review of this revision. Initial suppo

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. Initial version I supported the following vector functions (VF 2 and 4 ). sin cos exp pow log Also added test cases similar to SVML under X86. I am not sure about other targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2172 +def SwiftNewType : InheritableAttr { + // `swift_wrapper` is a "deprecated" alias and kept for compatibility with + // shipped toolchains. New users should prefer the `swift_newtype` spelling.

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 293748. jhuber6 added a comment. Changing legacy nowait calls to use the new function interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/Code

[clang] e6d50b4 - recommit [HIP] Fix -gsplit-dwarf option

Author: Yaxun (Sam) Liu Date: 2020-09-23T11:20:29-04:00 New Revision: e6d50b4f22dc6bbf0b0b40cfdab172bf5c1694e1 URL: https://github.com/llvm/llvm-project/commit/e6d50b4f22dc6bbf0b0b40cfdab172bf5c1694e1 DIFF: https://github.com/llvm/llvm-project/commit/e6d50b4f22dc6bbf0b0b40cfdab172bf5c1694e1.dif

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

abique added a comment. Looks good to me. Regarding the tests, it seems that you check if auto-vectorization takes advantages of libmvec? Would it be interesting to have a test which declares a vector and call the builtin sin on it? Thank you very much for the changes! :) Co

[clang] e90343a - Fix regressioin in test dwp-separate-debug-file.cpp

Author: Yaxun (Sam) Liu Date: 2020-09-23T11:49:59-04:00 New Revision: e90343ada3bda55c697e7ae06dda3f8d8d6ded34 URL: https://github.com/llvm/llvm-project/commit/e90343ada3bda55c697e7ae06dda3f8d8d6ded34 DIFF: https://github.com/llvm/llvm-project/commit/e90343ada3bda55c697e7ae06dda3f8d8d6ded34.dif

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#2289410 , @JonasToth wrote: > In D54943#2289037 , @0x8000- > wrote: > >> Master branch has too many false positives for tidy - would it be possible >> to create a branch

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

mtrofin added a comment. In D88114#2288860 , @steven_wu wrote: > Ok, I guess we are on the same page. The idea sounds fine to me. > > I would suggest just check that the output matches the input file as much as > possible, rather than just check a label a

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

mtrofin updated this revision to Diff 293761. mtrofin added a comment. Added a C test, strenghtened the checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88114/new/ https://reviews.llvm.org/D88114 Files: clang/test/Frontend/embed-bitcode-noop

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

mtrofin updated this revision to Diff 293762. mtrofin added a comment. newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88114/new/ https://reviews.llvm.org/D88114 Files: clang/test/Frontend/embed-bitcode-noopt.c clang/test/

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd updated this revision to Diff 293763. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87652/new/ https://reviews.llvm.org/D87652 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Parse/Pa

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

nemanjai added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3165 +static bool isEltOfVectorTy(ASTContext &Context, CallExpr *Call, Sema &S, +QualType VectorEltTy, QualType EltTy) { I think this should actually take a

[clang] 819ff6b - Improve dynamic AST matching diagnostics for conversion errors

Author: Aaron Ballman Date: 2020-09-23T12:13:36-04:00 New Revision: 819ff6b945816dce144c8be577a3c245f702b59c URL: https://github.com/llvm/llvm-project/commit/819ff6b945816dce144c8be577a3c245f702b59c DIFF: https://github.com/llvm/llvm-project/commit/819ff6b945816dce144c8be577a3c245f702b59c.diff

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the review. I've commit in 819ff6b945816dce144c8be577a3c245f702b59c Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:8

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88114/new/ https://reviews.llvm.org/D88114 ___

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2290157 , @greened wrote: > In D83004#2287851 , @dmajor wrote: > >> The expensive-checks bots have been red for several days. Could you please >> take a look or revert? > > Workin

[clang] 437358b - [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

Author: Mircea Trofin Date: 2020-09-23T09:35:28-07:00 New Revision: 437358be7179d570de070bbb9b2e1154db727f6d URL: https://github.com/llvm/llvm-project/commit/437358be7179d570de070bbb9b2e1154db727f6d DIFF: https://github.com/llvm/llvm-project/commit/437358be7179d570de070bbb9b2e1154db727f6d.diff

[PATCH] D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG437358be7179: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode. (authored by mtrofin). Repository: rG LLVM Github Monor

[PATCH] D88164: [clang][Sema] Use enumerator instead of hard-coded constant

miyuki created this revision. miyuki added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. Sema::DiagnoseSwiftName uses the constant 12 instead of the corresponding enumerator ExpectedFunctionWithP

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 293780. awarzynski marked 17 inline comments as done. awarzynski added a comment. Move code from Fortran to Fortran::frontend namespace, address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk updated this revision to Diff 293779. amyk added a comment. - Updated the `isEltOfVectorTy()` to the correct semantics; making it take in a vector type and then getting the element type within the function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski added a comment. Thank you for reviewing! I think that I've addressed all your comments.. Please see the updated patch. Comment at: clang/include/clang/Driver/Options.td:874 +defm color_diagnostics : OptInFFlag<"color-diagnostics", "Enable", "Disable", " colors in

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

jfb added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1647 +QualType Ty) { + auto *I8Ptr = CGF.Builder.CreateBitCast(Ptr, CGF.Int8PtrTy); + auto *Zero = ConstantInt::get(CGF.Int8Ty, 0); I'd like to hear @

[clang] 2719287 - Add REQUIRES to embed-bitcode-noopt.ll

Author: Mircea Trofin Date: 2020-09-23T10:13:09-07:00 New Revision: 271928792e8016109fdd909889dc6bb582aa6f46 URL: https://github.com/llvm/llvm-project/commit/271928792e8016109fdd909889dc6bb582aa6f46 DIFF: https://github.com/llvm/llvm-project/commit/271928792e8016109fdd909889dc6bb582aa6f46.diff

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

craig.topper updated this revision to Diff 293789. craig.topper added a comment. Update more check lines to fully check the clobbers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88121/new/ https://reviews.llvm.org/D88121 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/bi

[clang] d882ca7 - [Driver] Check whether Gentoo-specific configuration directory exists

Author: Dmitry Antipov Date: 2020-09-23T20:25:23+03:00 New Revision: d882ca7f1f1dee7d812d6b1ae060b5f671ab9ebc URL: https://github.com/llvm/llvm-project/commit/d882ca7f1f1dee7d812d6b1ae060b5f671ab9ebc DIFF: https://github.com/llvm/llvm-project/commit/d882ca7f1f1dee7d812d6b1ae060b5f671ab9ebc.diff

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd882ca7f1f1d: [Driver] Check whether Gentoo-specific configuration directory exists (authored by dmantipov). Changed prior to commit: https://revi

[clang] 7d0bbe4 - Re-apply https://reviews.llvm.org/D87921, was reverted to triage a PPC bot failure.

Author: Sriraman Tallam Date: 2020-09-23T10:28:40-07:00 New Revision: 7d0bbe40901cf60558c619c3174d71d7c53ca144 URL: https://github.com/llvm/llvm-project/commit/7d0bbe40901cf60558c619c3174d71d7c53ca144 DIFF: https://github.com/llvm/llvm-project/commit/7d0bbe40901cf60558c619c3174d71d7c53ca144.dif

[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2538 const SmallVectorImpl &CandidateBiarchTriples) { + if (!D.getVFS().exists(D.SysRoot + GentooConfigDir)) +return false; Thanks. This should reduce the number of stat sysc

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, mgorny. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The plan is to us

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov added a comment. What's next with this? Should I add more reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ https://reviews.llvm.org/D87187 ___ cfe-commits mailing list cfe-co

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

rnk added a comment. I think we can go forward with the reviewers we have. I have one more concern. Are the other reviewers happy? Comment at: clang/lib/Driver/Distro.cpp:206 +const llvm::Triple &TargetOrHost) { + static Distro::DistroType

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88121/new/ https://reviews.llvm.org/D88121 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for your patience and for addressing all the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83500/new/ https://reviews

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

AlexanderLanin added a comment. > Could you please provide me a full reproducer (optimally without dependencies > on includes/libraries)? I can certainly do that based on my old version from ~9 months ago or preferably if you provide me some branch somewhere (github?). I have trouble applying

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx created this revision. chrish_ericsson_atx added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. chrish_ericsson_atx requested review of this revision. Check applied to unbounded (incomplete) arrays and pointers to spot c

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 293817. akhuang marked an inline comment as done. akhuang added a comment. Add comments to tests, and add a test for non instantiated trivial ctor and one for lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14054 + if (IndexNegated) { +index.setIsUnsigned(false); index = -index; This call to index.setIsUnsigned(false) is the only unreviewed part of this change in this f

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

bsaleil added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-vsx.c:1840 +// CHECK: %6 = call <4 x float> @llvm.copysign.v4f32(<4 x float> %5, <4 x float> %4) + vec_cpsgn(a, b); +} Could you also add a call to `__builtin_vsx_xvcpsgnsp` and the sam

[clang] 59691dc - [AMDGPU] Make ds fp atomics overloadable

Author: Stanislav Mekhanoshin Date: 2020-09-23T11:39:50-07:00 New Revision: 59691dc8740c7eada7fcf5552e0d2377780c6fb7 URL: https://github.com/llvm/llvm-project/commit/59691dc8740c7eada7fcf5552e0d2377780c6fb7 DIFF: https://github.com/llvm/llvm-project/commit/59691dc8740c7eada7fcf5552e0d2377780c6f

[PATCH] D87947: [AMDGPU] Make ds fp atomics overloadable

This revision was automatically updated to reflect the committed changes. Closed by commit rG59691dc8740c: [AMDGPU] Make ds fp atomics overloadable (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. @davidxl I'm wondering if it is a good time for you to start reviewing the patches. Please let me know if you need more time. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/ https://reviews.llvm.org/D86193 __

[PATCH] D87953: [xray] Function coverage groups

ianlevesque updated this revision to Diff 293826. ianlevesque added a comment. Remove extraneous parameter validations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 Files: clang/include/clang/Basic/Cod

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall added a comment. To give a bit of context here: the end-goal here is hot-reload of compile_commands.json. (This covers our *two* top bugs: #192 and #83). I'm very happy with the hot-reloading of config files (.clangd etc) and I think it's a good fit to generalize. In particular, confi

[PATCH] D88144: [clangd] Disable suffix matching fallback for C during include insertion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (I do wonder whether it's safe to just drop the mapping table entirely now...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88144/new/ ht

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

dblaikie added a comment. In D87673#2275940 , @sammccall wrote: > Thanks, this seems better than crashing. > The practical result isn't wonderful: the two are going to fight over index > files to some extent. But this can happen with different clangd vers

[clang] af1d3e6 - Allow init_priority values <= 100 and > 65535 within system headers.

Author: Aaron Ballman Date: 2020-09-23T15:26:50-04:00 New Revision: af1d3e655991e5f0c86df372b8583a60d20268e0 URL: https://github.com/llvm/llvm-project/commit/af1d3e655991e5f0c86df372b8583a60d20268e0 DIFF: https://github.com/llvm/llvm-project/commit/af1d3e655991e5f0c86df372b8583a60d20268e0.diff

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

aaron.ballman added a comment. In D31413#2279498 , @aaron.ballman wrote: > In D31413#2279404 , @ldionne wrote: > >> In D31413#2279182 , @aaron.ballman >> wrote: >> >>> Yes,

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

sammccall added a comment. In D87673#2290838 , @dblaikie wrote: > In D87673#2275940 , @sammccall wrote: > >> Thanks, this seems better than crashing. >> The practical result isn't wonderful: the two are going to fig

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

dblaikie added a comment. In D87673#2290926 , @sammccall wrote: > In D87673#2290838 , @dblaikie wrote: > >> In D87673#2275940 , @sammccall >> wrote: >> >>> Thanks, this seem

[PATCH] D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. No need to make final copy from the firsptrivate/lastprivate copy to the original item if the item is

[PATCH] D88164: [clang][Sema] Use enumerator instead of hard-coded constant

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88164/new/ https://reviews.llvm.org/D88164 __

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#2290713 , @AlexanderLanin wrote: >> Could you please provide me a full reproducer (optimally without >> dependencies on includes/libraries)? > > I can certainly do that based on my old version from ~9 months ago or

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

RKSimon accepted this revision. RKSimon added a comment. LGTM as well cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88121/new/ https://reviews.llvm.org/D88121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM aside from a small wording nit with the documentation. The parser changes I asked about can be done in a follow-up to this patch. Comment at:

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L marked 9 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Sema/Sema.h:488 +AlignPackInfo(AlignPackInfo::Mode M, int Num, bool IsAIX) +: PackAttr(true), AlignMode(M), PackNumber(Num), AIXStack(IsAIX) {} + -

[PATCH] D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Conanap marked an inline comment as done. Closed by commit rG88cdbeab417c: [PowerPC] Implement Vector signed/unsigned __int128 overloads for the… (authored by Conanap).

[PATCH] D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7117f84770: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge]… (authored by amyk, committed by Conanap). Changed prior

[clang] 2e7117f - [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM

Author: Amy Kwan Date: 2020-09-23T16:49:40-04:00 New Revision: 2e7117f847708d2fd1ff2d2961c3439470532b80 URL: https://github.com/llvm/llvm-project/commit/2e7117f847708d2fd1ff2d2961c3439470532b80 DIFF: https://github.com/llvm/llvm-project/commit/2e7117f847708d2fd1ff2d2961c3439470532b80.diff LOG:

[clang] 88cdbea - [PowerPC] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

Author: Albion Fung Date: 2020-09-23T16:49:40-04:00 New Revision: 88cdbeab417cc716d1da2de2a508d24622f4a4bc URL: https://github.com/llvm/llvm-project/commit/88cdbeab417cc716d1da2de2a508d24622f4a4bc DIFF: https://github.com/llvm/llvm-project/commit/88cdbeab417cc716d1da2de2a508d24622f4a4bc.diff L

  1   2   >