[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

2020-09-11 Thread Douglas Chen via Phabricator via cfe-commits
dougpuob updated this revision to Diff 291371. dougpuob added a comment. Fixed crash on Windows when run regression test (llvm-lit for `readability-identifier-naming.cpp` file). This is because over range parameter made ctor of std::string copying out of range memory from source. The over range

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

2020-09-11 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Does the static lib built in this case include any dllexport attributes (that can cause issues if linking it statically into another DLL)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

2020-09-11 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. This should be ok, I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D87547 __

Re: [clang] a8503b8 - [NFC] Remove unused static function

2020-09-11 Thread Kristóf Umann via cfe-commits
Yup, unless you this breaks something, I'd really prefer to keep it. On Sat, 12 Sep 2020, 03:24 David Blaikie, wrote: > LLVM_DUMP_METHOD is meant to be used for annotating functions that might > be useful to execute from a debugger to dump data structures, etc - so it's > expected that they'd be

<    1   2   3