[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp added a comment. I don't have commit access, can anyone help me commit this with `"Yang Fan "` ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

asbirlea added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:312 switch (II->getIntrinsicID()) { default: llvm_unreachable("doesn't pass 'hasAnalyzableMemoryWrite' predicate"); case Intrinsic::lifetime_end: The c

[PATCH] D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets.

snehasish updated this revision to Diff 290867. snehasish added a comment. Update test based on review comments. - Use diag::err instead of warn. - Drop linux-gnu from the triple for the default test. - Check for the presence of the diagnostic message. Repository: rG LLVM Github Monorepo CHA

[PATCH] D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets.

snehasish marked 3 inline comments as done. snehasish added a comment. Thanks for the quick review @MaskRay, PTAL. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4892 +} else { + D.Diag(diag::warn_drv_unsupported_opt_for_target) + << A->getAsString(Args) <<

[PATCH] D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4892 +} else { + D.Diag(diag::warn_drv_unsupported_opt_for_target) + << A->getAsString(Args) << TripleStr; snehasish wrote: > MaskRay wrote: > > This should be an e

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. One more notification. Please, somebody look at this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. After reviewing the code of this snippet, I think it would be very difficult to make a regression test case for the crash, as far as what I know about Z3 and SMT solvers. First of all, all calls to `Solver->check()` will return `true` for sat, `false` for unsat, an

[libclc] 060c8e0 - libclc/spirv: Add various functions

Author: Daniel Stone Date: 2020-09-10T01:59:10-04:00 New Revision: 060c8e083dd637866854acb6a0823c45b2ef68ef URL: https://github.com/llvm/llvm-project/commit/060c8e083dd637866854acb6a0823c45b2ef68ef DIFF: https://github.com/llvm/llvm-project/commit/060c8e083dd637866854acb6a0823c45b2ef68ef.diff

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

sylvestre.ledru added a comment. I guess it isn't possible to write tests for this? Does it have an impact on cross compile ? Also, please fix the clang-format warning! Comment at: clang/lib/Driver/Distro.cpp:227 + if (!HostTriple.isOSLinux() && onRealFS) +Type = Distro:

[PATCH] D87374: [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest` and `MutationsTest`

eduucaldas updated this revision to Diff 290880. eduucaldas added a comment. Herald added a subscriber: mgorny. - [SyntaxTree] Extract `SynthesisTest` from `MutationsTest` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87374/new/ https://reviews.llv

<    1   2