[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a reviewer: jdoerfert. Herald added a project: clang. compnerd requested review of this revision. Introduce a new attribute that is used to indicate the error handling convention used by a function. This is use

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 _

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added a comment. @efriedma Would you please chime in specially with respect to @MaskRay 's comment about the clang test involving assembly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 _

[PATCH] D87332: [profile] Add %t LLVM_PROFILE_FILE option to substitute $TMPDIR

vsk updated this revision to Diff 290590. vsk added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Document the new option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87332/new/ https://reviews.llvm.org/D8733

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

JDevlieghere added a comment. In D87243#2261687 , @kastiglione wrote: > If an LLVM install disabled `LLVM_ENABLE_WARNINGS`, should other builds > inherit that? I would think no, but is there a precedent for that that to be > the case? Yes, most of the `

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

rjmccall added a comment. Oh, there are a ton of typos in this documentation. Comment at: clang/include/clang/Basic/AttrDocs.td:3396 +the imported API, and dynamically will always pass a valid address initialized +to a null pointer. + Please split this sentence

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione updated this revision to Diff 290597. kastiglione edited the summary of this revision. kastiglione added a comment. Add LLVM_ENABLE_WARNINGS to LLVMConfig.cmake.in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 ___ cfe-commits mailing list cfe-commits@l

[libunwind] 88bf133 - [libunwind] Replace chain-of-ifdefs for dl_iterate_phdr

Author: Ryan Prichard Date: 2020-09-08T15:49:35-07:00 New Revision: 88bf133c99c3124842c182a019306f83f2c1b856 URL: https://github.com/llvm/llvm-project/commit/88bf133c99c3124842c182a019306f83f2c1b856 DIFF: https://github.com/llvm/llvm-project/commit/88bf133c99c3124842c182a019306f83f2c1b856.diff

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd updated this revision to Diff 290601. compnerd added a comment. - correct typos - apply clang-format changes - `const` correct a few declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 Fi

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. A concern that has come up while rewriting this for the listed concerns is forward declared protocols that are defined as `non_runtime`. @protocol NonRuntimeProto; @interface Implementer : Root @end @implementation Implementer ... @end This compiles jus

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith updated this revision to Diff 290610. keith retitled this revision from "clang: Add -fprofile-prefix-map" to "clang: Add -fcoverage-prefix-map". keith edited the summary of this revision. keith added a comment. Rename from fcoverage-prefix-map to fprofile-prefix-map Repository: rG LLVM

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

myhsu created this revision. myhsu added reviewers: rsmith, bogner, xur. Herald added subscribers: cfe-commits, wenlei, dang, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. myhsu requested review of this revision. Following up https://reviews.llvm.org/D87337 . This patch add the

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290619. bc-lee added a comment. Add more tests and rename options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files: clang/docs/ClangFormatStyleOptions.rst clan

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1970 + but this behavior is changed by another option, + ``JavaStaticImportAfterImport``. MyDeveloperDay wrote: > Can you add a test that shows if the sorting is still in the gro

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. I don't think it'll actually error out at link time: protocol objects get emitted eagerly on use, cross-module linking is just a code-size optimization. This actually has caused longstanding problems. Anyway, I think it's fine to require forward declarations to have t

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

rjmccall accepted this revision. rjmccall added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 ___ cfe-commits mailing list cfe-commits@

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

phosek added a comment. It's not clear why couldn't we support per-target runtime directory? It uses the standard multiarch layout, so in you'd end up using a directory like `[path/to/resource-dir]/lib/armv6m-unknown-eabi/libclang_rt.builtins.a`. I'd find this more preferable for consistency wi

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. We have tried to trigger the crash with the original project where the crash was encountered. But the problem is we cannot trigger the crash with the project, and we have lost all the previous records about this crash. Besides, both I and the bug reporter himself ar

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 ___

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85762/new/ https://reviews.llvm.org/D85762 ___

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. > I don't think it'll actually error out at link time: protocol objects get > emitted eagerly on use, cross-module linking is just a code-size > optimization. This actually has caused longstanding problems. But if it's just a forward declaration there's nothing to emit. T

<    1   2