[PATCH] D76604: [Analyzer] Model `size()` member function of containers

baloghadamsoftware updated this revision to Diff 290413. baloghadamsoftware added a comment. Fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76604/new/ https://reviews.llvm.org/D76604 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp clang/lib/StaticAnalyzer/Check

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:456 + SVal RetVal) const { + const auto *ContReg = Cont.getAsRegion(); + if (!ContReg) Szelethus wrote: > martong wro

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

jhenderson added a comment. In D78938#2259342 , @BRevzin wrote: > In D78938#2258557 , @jhenderson > wrote: > >> Not that I have anything particularly against this, but won't this likely >> rot fairly rapidly? It's

[PATCH] D87225: [clangd] When finding refs for a template specialization, do not return refs to other specializations

hokein added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1150 // DeclRelation::Underlying. -DeclRelationSet Relations = DeclRelation::TemplatePattern | +DeclRelationSet Relations = DeclRelation::TemplateInstantiation |

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

hokein added a comment. +@kadircet, he is tracking on this -- we had some discussion internally last week, but we don't reply on that thread yet (sorry). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87256/new/ https://reviews.llvm.org/D87256 ___

[clang] 2168dbf - getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver

Author: Shivanshu Goyal Date: 2020-09-08T10:21:18+02:00 New Revision: 2168dbf4cc766dfb552076d9b1e84b00122b7993 URL: https://github.com/llvm/llvm-project/commit/2168dbf4cc766dfb552076d9b1e84b00122b7993 DIFF: https://github.com/llvm/llvm-project/commit/2168dbf4cc766dfb552076d9b1e84b00122b7993.dif

[PATCH] D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2168dbf4cc76: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl… (authored by shivanshu3, co

[PATCH] D87257: [clang] Traverse init-captures while indexing

hokein added a comment. In D87257#2260022 , @nridge wrote: > I did try to add a test to `clang/test/Index/Core/index-source.cpp`, however > the output of `c-index-test` does not seem to be changed by adding this > reference. Could you check `clang/test/

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

NoQ added inline comments. Comment at: clang/test/Analysis/Checkers/CPlusPlus11LockChecker.cpp:379-382 +void rm_bad1() { + rm1.lock(); // no-warning + rm1.lock(); // expected-warning{{This lock has already been acquired}} +} I repeat, this is a false positive.

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 290435. awarzynski added a comment. Add missing update in lit.cfg.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089 Files: clang/include/clang/Driver/Driver.h c

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2325d6b42f09: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ ht

[clang] 46f4439 - [SyntaxTree] Ignore implicit leaf `CXXConstructExpr`

Author: Eduardo Caldas Date: 2020-09-08T09:44:23Z New Revision: 46f4439dc9bf9b8cfee0001b6752c3d074c83b00 URL: https://github.com/llvm/llvm-project/commit/46f4439dc9bf9b8cfee0001b6752c3d074c83b00 DIFF: https://github.com/llvm/llvm-project/commit/46f4439dc9bf9b8cfee0001b6752c3d074c83b00.diff LOG

[clang] 134455a - [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor

Author: Eduardo Caldas Date: 2020-09-08T09:44:23Z New Revision: 134455a07c1f1de4cff62a6afb4ccd98b98343ec URL: https://github.com/llvm/llvm-project/commit/134455a07c1f1de4cff62a6afb4ccd98b98343ec DIFF: https://github.com/llvm/llvm-project/commit/134455a07c1f1de4cff62a6afb4ccd98b98343ec.diff LOG

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

This revision was automatically updated to reflect the committed changes. Closed by commit rG46f4439dc9bf: [SyntaxTree] Ignore implicit leaf `CXXConstructExpr` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https:

[clang] 2325d6b - [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

Author: Eduardo Caldas Date: 2020-09-08T09:44:23Z New Revision: 2325d6b42f096bf93d2ab0bed7096759e5c96ce8 URL: https://github.com/llvm/llvm-project/commit/2325d6b42f096bf93d2ab0bed7096759e5c96ce8 DIFF: https://github.com/llvm/llvm-project/commit/2325d6b42f096bf93d2ab0bed7096759e5c96ce8.diff LOG

[PATCH] D87229: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG134455a07c1f: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor (authored by eduucaldas). Repository: rG LLVM Github Monor

[PATCH] D87249: [SyntaxTree] Fix crash on functions with default arguments.

eduucaldas updated this revision to Diff 290439. eduucaldas added a comment. Test init declarator with default arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87249/new/ https://reviews.llvm.org/D87249 Files: clang/lib/Tooling/Syntax/Bui

[clang] f5087d5 - [SyntaxTree] Fix crash on functions with default arguments.

Author: Eduardo Caldas Date: 2020-09-08T09:49:30Z New Revision: f5087d5c7248104b6580c7b079ed5f227332c2ef URL: https://github.com/llvm/llvm-project/commit/f5087d5c7248104b6580c7b079ed5f227332c2ef DIFF: https://github.com/llvm/llvm-project/commit/f5087d5c7248104b6580c7b079ed5f227332c2ef.diff LOG

[PATCH] D87249: [SyntaxTree] Fix crash on functions with default arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5087d5c7248: [SyntaxTree] Fix crash on functions with default arguments. (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

hokein updated this revision to Diff 290445. hokein added a comment. fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86936/new/ https://reviews.llvm.org/D86936 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/Tr

[PATCH] D87250: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412)

This revision was automatically updated to reflect the committed changes. Closed by commit rG58970eb7d1dd: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412) (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D872

[clang] 58970eb - [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412)

Author: Simon Pilgrim Date: 2020-09-08T11:59:38+01:00 New Revision: 58970eb7d1ddd067e98f49fdcfb04373086245bc URL: https://github.com/llvm/llvm-project/commit/58970eb7d1ddd067e98f49fdcfb04373086245bc DIFF: https://github.com/llvm/llvm-project/commit/58970eb7d1ddd067e98f49fdcfb04373086245bc.diff

[PATCH] D87278: [Ignore Expressions] Fix performance regression by inlining `Ignore*SingleStep`

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. We also add a `const` versions of `IgnoreExprNodes` Repository: rG LLVM Github Monorepo https:

[PATCH] D87189: [CMake] Remove dead FindPythonInterp code

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. I love this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87189/new/ https://reviews.llvm.org/D87189

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev updated this revision to Diff 290453. kbobyrev added a comment. Also check if deinition comes from unwwanted file (e.g. omit forward declarations). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85426/new/ https://reviews.llvm.org/D85426

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev planned changes to this revision. kbobyrev added a comment. WIP. Need to get around background indexing tricks to make it work. Failed Tests (3): Clangd Unit Tests :: ./ClangdTests/BackgroundIndexTest.Config Clangd Unit Tests :: ./ClangdTests/BackgroundIndexTest.IndexTwoFiles

[clang] ae85da8 - [Codegen][X86] Begin moving X86 specific codegen tests into X86 subfolder.

Author: Simon Pilgrim Date: 2020-09-08T13:01:24+01:00 New Revision: ae85da86ad8fbd022129650d0b2a6b615709a790 URL: https://github.com/llvm/llvm-project/commit/ae85da86ad8fbd022129650d0b2a6b615709a790 DIFF: https://github.com/llvm/llvm-project/commit/ae85da86ad8fbd022129650d0b2a6b615709a790.diff

[PATCH] D87189: [CMake] Remove dead FindPythonInterp code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86bd8f82cc74: [CMake] Remove dead FindPythonInterp code (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 290460. fodinabor marked 9 inline comments as done. fodinabor added a comment. Incorporating review comments: - renaming option to -Wno-error=unknown and adding warning in description - emit warnings instead of fully ignoring the issues Documentation and u

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 290461. fodinabor added a comment. Remove test entry form .clang-format :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 Files: clang/include/clang/Format/Format.

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

martong added a comment. > But if the string is invalidated (or the new length is completely unknown), > **do not remove** the length from the state; instead, set it to > SymbolConjured. Where exactly do you implement the above? > When strlen(R) is used for the first time on a region R, prod

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2384-2385 if (SuperRegions.count(MR)) { Entries = F.remove(Entries, MR); + Entries = F.add(Entries, MR, UnknownVal()); continue; martong wrote:

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov added a comment. @steakhal > the readability of the reports should be improved. Absolutely agree. Let's do this in the next patches :) @NoQ You've recommended to extend PthreadLockChecker with STL mutexes. I think I've done. Could you make a quick look, please? ==

[PATCH] D87282: [SYCL] Assume SYCL device functions are convergent

bader created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan, yaxunl. Herald added a project: clang. bader requested review of this revision. SYCL device compiler (similar to other SPMD compilers) assumes that functions are convergent by default to avoid invalid transform

[PATCH] D87138: [analyzer][NFC] Introduce refactoring of PthreadLockChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGe67405141836: [analyzer] [NFC] Introduce refactoring of PthreadLockChecker (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87138/n

[clang] e674051 - [analyzer] [NFC] Introduce refactoring of PthreadLockChecker

Author: Denys Petrov Date: 2020-09-08T16:04:19+03:00 New Revision: e67405141836fcd88183863758eeb42f32e847a6 URL: https://github.com/llvm/llvm-project/commit/e67405141836fcd88183863758eeb42f32e847a6 DIFF: https://github.com/llvm/llvm-project/commit/e67405141836fcd88183863758eeb42f32e847a6.diff

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

martong accepted this revision. martong added a comment. LGTM! Thanks for the clarification and the example you gave. (I agree with @steakhal and I wish if we could get rid of the many lines not-descriptive plist stuff, but that is rather unrelated) CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. This basically looks good to me. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:482-483 +// of the container (the difference between its `begin()`

[clang-tools-extra] 156b127 - Add a new altera check for structure packing and alignment.

Author: Frank Derry Wanye Date: 2020-09-08T09:35:14-04:00 New Revision: 156b127945a8c923d141e608b7380427da024376 URL: https://github.com/llvm/llvm-project/commit/156b127945a8c923d141e608b7380427da024376 DIFF: https://github.com/llvm/llvm-project/commit/156b127945a8c923d141e608b7380427da024376.d

[PATCH] D66564: [clang-tidy] new altera struct pack align check

aaron.ballman closed this revision. aaron.ballman added a comment. I've committed on your behalf in 156b127945a8c923d141e608b7380427da024376 . Thank you for the new check! CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 9c9974c - [clang] Limit the maximum level of fold-expr expansion.

Author: Haojian Wu Date: 2020-09-08T15:40:09+02:00 New Revision: 9c9974c3ccb6468cc83f759240293538cf123fcd URL: https://github.com/llvm/llvm-project/commit/9c9974c3ccb6468cc83f759240293538cf123fcd DIFF: https://github.com/llvm/llvm-project/commit/9c9974c3ccb6468cc83f759240293538cf123fcd.diff LO

[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c9974c3ccb6: [clang] Limit the maximum level of fold-expr expansion. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

DavidTruby accepted this revision. DavidTruby added a comment. LGTM and seems to work from the flang side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 ___ cfe

[clang-tools-extra] 9933188 - StructPackAlignCheck: Fix a -Winconsistent-missing-override warning

Author: Nico Weber Date: 2020-09-08T10:02:00-04:00 New Revision: 9933188c90615c9c264ebb69117f09726e909a25 URL: https://github.com/llvm/llvm-project/commit/9933188c90615c9c264ebb69117f09726e909a25 DIFF: https://github.com/llvm/llvm-project/commit/9933188c90615c9c264ebb69117f09726e909a25.diff LO

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

Xiangling_L added a comment. In D86790#2255371 , @jyknight wrote: > Do you have open questions on whether some callsites passing "false" here, > should be switched to true? Given what's here, I would say that it definitely > does not makes sense to add t

[clang] 2d9d270 - Revert 3e782bf809 "[Sema][MSVC] warn at dynamic_cast when /GR- is given"

Author: Hans Wennborg Date: 2020-09-08T16:10:18+02:00 New Revision: 2d9d270e77918dfc19ad9b3150ee7d40eeb8ca79 URL: https://github.com/llvm/llvm-project/commit/2d9d270e77918dfc19ad9b3150ee7d40eeb8ca79 DIFF: https://github.com/llvm/llvm-project/commit/2d9d270e77918dfc19ad9b3150ee7d40eeb8ca79.diff

[clang-tools-extra] 32ae37b - [clang-tidy] Fix dynamic build failures after 156b127945a8c923d141e608b7380427da024376

Author: Haojian Wu Date: 2020-09-08T16:26:48+02:00 New Revision: 32ae37b038b16a1ff9c81428ae4f003377439a22 URL: https://github.com/llvm/llvm-project/commit/32ae37b038b16a1ff9c81428ae4f003377439a22 DIFF: https://github.com/llvm/llvm-project/commit/32ae37b038b16a1ff9c81428ae4f003377439a22.diff LO

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 290483. dougpuob added a comment. This is a test with `arc diff master --update D86671` command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 Files: clang-tools-e

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

steakhal added a comment. In D86445#2260744 , @martong wrote: >> But if the string is invalidated (or the new length is completely unknown), >> **do not remove** the length from the state; instead, set it to >> SymbolConjured. > > Where exactly do you im

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1970 + but this behavior is changed by another option, + ``JavaStaticImportAfterImport``. Can you add a test that shows if the sorting is still in the groups, i.e. I can

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij commandeered this revision. stuij added a reviewer: dnsampaio. stuij added a comment. Commandeering as I've made some changes to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij marked 6 inline comments as done. stuij added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:396 +/// according to the field declaring type width. +CODEGENOPT(ForceNoAAPCSBitfieldWidth, 1, 0) + ostannard wrote: > dnsampaio wrote:

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff updated this revision to Diff 290487. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85960/new/ https://reviews.llvm.org/D85960 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Exp

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

JakeMerdichAMD added inline comments. Comment at: clang/include/clang/Format/Format.h:1708 + /// \endcode + bool JavaStaticImportAfterImport; + MyDeveloperDay wrote: > Can we consider changing the name or the option to make it clearer what its > for? > > `Sor

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff marked 3 inline comments as done. sepavloff added a comment. In D85960#2259703 , @riccibruno wrote: >> This change allow a CallExpr to have optional FPOptionsOverride object, > > Should this be `CastExpr` instead? Yes, thank you for the catch.

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay abandoned this revision. MyDeveloperDay added a comment. Better solution here D86581: [clang-format] Handle shifts within conditions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 __

[PATCH] D86581: [clang-format] Handle shifts within conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc81dd3d159ab: [clang-format] Handle shifts within conditions (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://

[clang] c81dd3d - [clang-format] Handle shifts within conditions

Author: mydeveloperday Date: 2020-09-08T16:40:04+01:00 New Revision: c81dd3d159ab03d46e4280c458d3c29e56648218 URL: https://github.com/llvm/llvm-project/commit/c81dd3d159ab03d46e4280c458d3c29e56648218 DIFF: https://github.com/llvm/llvm-project/commit/c81dd3d159ab03d46e4280c458d3c29e56648218.diff

[PATCH] D86581: [clang-format] Handle shifts within conditions

MyDeveloperDay added a comment. @Saldivarcher this should be landed now, please validate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 ___ cfe-commits mailing l

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

yaxunl added a comment. ping. this is needed by https://reviews.llvm.org/D84364 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84362/new/ https://reviews.llvm.org/D84362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: JakeMerdichAMD, krasimir, arichardson, curdeius. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=47461 The following change D80940: [cl

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan updated this revision to Diff 290502. ebevhan added a comment. Updated method name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn updated this revision to Diff 290504. fhahn marked an inline comment as done. fhahn added a comment. Change to codegen option, adjust description for option, limit to trivially copyable types in C++, add corresponding test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added inline comments. Comment at: clang/include/clang/Driver/Options.td:4287-4290 +def fpass_by_value_noalias: Flag<["-"], "fpass-by-value-noalias">, + HelpText<"Allows assuming no references to passed by value escape before " + "transferring execution to the ca

[clang-tools-extra] 71133e8 - [clang-tidy] Fix linking for FrontendOpenMP

Author: Heejin Ahn Date: 2020-09-08T09:22:22-07:00 New Revision: 71133e8b5bceaf68a2cee59af371df570a1aed79 URL: https://github.com/llvm/llvm-project/commit/71133e8b5bceaf68a2cee59af371df570a1aed79 DIFF: https://github.com/llvm/llvm-project/commit/71133e8b5bceaf68a2cee59af371df570a1aed79.diff LO

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 290511. rahmanl marked an inline comment as done. rahmanl added a comment. - Merge remote-tracking branch 'origin/master' into arcpatch-D85408 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://re

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

kadircet added a comment. As discussed offline, this is trading off some accuracy between getting `-I` correct vs `-std` and it is unclear whether that's beneficial or harmful. It is easy to come up with examples for both and we were split 50/50 between each. In the end all of this is a heuristi

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added a comment. Thanks for the review @MaskRay. Is this ready to land now? Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1047 + getObjFileLowering().getBBAddrMapSection(*MF.getSection()); + if (!BBAddrMapSection) +return; MaskRay wro

[PATCH] D87278: [Ignore Expressions] Fix performance regression by inlining `Ignore*SingleStep`

riccibruno accepted this revision. riccibruno added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87278/new/ https://reviews.llvm.org/D87278 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

MyDeveloperDay added a comment. Note to self, other things could cause the same issue try // comment { try /* comment */ { Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87291/new/ https://reviews.llvm.org/D87291 ___

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I like the simplification:) However, I still feel puzzled by the large chunk of assembly test in `clang/test/CodeGen/basic-block-sections.c`. I hope another reviewer or the code owner can sa

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

jfb added a comment. On C++20 mode rotting: it won't if someone sets up a bot. If it rots, then it's easier to un-rot with Barry's patch. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:805-817 + return IsASCII ? "^" : (const char *)u8"\u2548"; case LineChar::Ra

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

jkorous added subscribers: dexonsmith, akyrtzi. jkorous added a comment. Hi @usaxena95 and @sammccall, I am wondering about couple high-level things. Do you guys intend to open-source also the training part of the model pipeline or publish a model trained on generic-enough training set so it co

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein added a comment. friendly ping @rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] e6bb4c8 - [X86] SSE4_A should only imply SSE3 not SSSE3 in the frontend.

Author: Craig Topper Date: 2020-09-08T10:50:59-07:00 New Revision: e6bb4c8e7b3e27f214c9665763a2dd09aa96a5ac URL: https://github.com/llvm/llvm-project/commit/e6bb4c8e7b3e27f214c9665763a2dd09aa96a5ac DIFF: https://github.com/llvm/llvm-project/commit/e6bb4c8e7b3e27f214c9665763a2dd09aa96a5ac.diff

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

JDevlieghere added a comment. You need to add `LLVM_ENABLE_WARNINGS` to `LLVMConfig.cmake.in` so that the standalone builds know what value was set in the LLVM build. I think with the current patch the other projects won't inherit the value and just default to `ON`? Repository: rG LLVM Gith

[clang] d95ef00 - Update clang/test/Driver/darwin-infer-simulator-sdkroot.c

Author: Azharuddin Mohammed Date: 2020-09-08T11:27:18-07:00 New Revision: d95ef009bd502a1c2c82952d4fa6fd1db836cef9 URL: https://github.com/llvm/llvm-project/commit/d95ef009bd502a1c2c82952d4fa6fd1db836cef9 DIFF: https://github.com/llvm/llvm-project/commit/d95ef009bd502a1c2c82952d4fa6fd1db836cef9

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. If an LLVM install disabled `LLVM_ENABLE_WARNINGS`, should other builds inherit that? I would think no, but is there's a precedent for that that to be the case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

bsaleil added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14298 llvm::Function *F = CGM.getIntrinsic(ID, ResultType); -return Builder.CreateCall(F, {X, Y}); +return Builder.CreateCall(F, {Y, X}); } Could you add a test case in `cl

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies added a comment. In D66564#2260836 , @aaron.ballman wrote: > I've committed on your behalf in 156b127945a8c923d141e608b7380427da024376 > . Thank > you for the new check! No

[PATCH] D87321: Fix -gz=zlib options for linker

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. gcc translates -gz=zlib to --compress-debug-options=zlib for both assembler and linker but clang only does this for assembler. The l

[PATCH] D87321: Fix -gz=zlib options for linker

MaskRay added inline comments. Comment at: clang/test/Driver/gz.c:1 +// RUN: %clang -### -target x86_64-unknown-linux-gnu -g -gz=none %s 2>&1 | \ +// RUN:FileCheck -check-prefix=NONE %s This can be merged into `compress.c` You may delete some `-c` from compre

[PATCH] D87321: Fix -gz=zlib options for linker

MaskRay added inline comments. Comment at: clang/test/Driver/hip-gz-options.hip:6 +// RUN: %clang -### --offload-arch=gfx906 %s -nogpulib -nogpuinc \ +// RUN: -ggdb -gz=zlib 2>&1 | FileCheck %s + MaskRay wrote: > -ggdb is unrelated Sorry it is related. CHANGE

[PATCH] D87321: Fix -gz=zlib options for linker

MaskRay added inline comments. Comment at: clang/test/Driver/hip-gz-options.hip:6 +// RUN: %clang -### --offload-arch=gfx906 %s -nogpulib -nogpuinc \ +// RUN: -ggdb -gz=zlib 2>&1 | FileCheck %s + -ggdb is unrelated CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

amosnier added a comment. In D87253#2261205 , @kadircet wrote: > As discussed offline, this is trading off some accuracy between getting `-I` > correct vs `-std` and it is unclear whether that's beneficial or harmful. It > is easy to come up with example

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

nridge added a comment. In D87253#2261837 , @amosnier wrote: > How can I make sure I will receive updates on this issue (or any prolongation > of it)? By commenting on this review, you're automatically subscribed to it, so should get an email notificati

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:138-139 SVal ThisVal = State->getSVal(ThisPtr); + if (Init->isBaseInitializer() || Init->isDelegatingInitializer()) +return ThisVal; For base initializer

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. Note that we now also have to compute the PostDominatorTree, which adds an extra bit of compile-time overhead. By adjusting the pipeline a bit more, we can re-use ADCE's PDTs in most cases, which gives a `-0.18%` geomean improvement for -O3 D87322

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2429 if (SymbolRef Sym = Len.getAsSymbol()) { if (SR.isDead(Sym)) +Entries = F.remove(Entries, MR); martong wrote: > steakhal wrote: > > NoQ wrote: > >

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4583 if (!InitE) return getDefaultInitValue(VD->getType(), Val); The initializer might also be null because the variable is type-dependent (eg, `X x;`), in which case assuming def

[PATCH] D86445: [analyzer][RFC] Simplify MetadataSymbol representation and resolve a CStringChecker FIXME

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2429 if (SymbolRef Sym = Len.getAsSymbol()) { if (SR.isDead(Sym)) +Entries = F.remove(Entries, MR); NoQ wrote: > martong wrote: > > steakhal wrote: > >

[PATCH] D87324: [HIP] Add gfx1030 and gfx1031

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. yaxunl requested review of this revision. https://reviews.llvm.org/D87324 Files: clang/lib/Basic/Cuda.cpp clang/test/Driver/hip-offload-arch.hip Index: clang/test/Driver/hip-offload-arch.hip ==

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

compnerd added a comment. The change itself is fine, but what about downstream projects which define the option? Will that trigger a warning? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 __

[PATCH] D87324: [HIP] Add gfx1030 and gfx1031

ashi1 accepted this revision. ashi1 added a comment. LGTM, looks like its already in clang/include/clang/Basic/Cuda.h and clang/lib/Basic/Targets/AMDGPU.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87324/new/ https://reviews.llvm.org/D87324 __

[clang] f4ac79a - Sema: extract a check for `isCFError` (NFC)

Author: Saleem Abdulrasool Date: 2020-09-08T20:07:47Z New Revision: f4ac79a364f2de7270a3238b176e17b40b036305 URL: https://github.com/llvm/llvm-project/commit/f4ac79a364f2de7270a3238b176e17b40b036305 DIFF: https://github.com/llvm/llvm-project/commit/f4ac79a364f2de7270a3238b176e17b40b036305.diff

[clang] 041da0d - [HIP] Add gfx1031 and gfx1030

Author: Yaxun (Sam) Liu Date: 2020-09-08T16:38:34-04:00 New Revision: 041da0d828e39d849c99adf1391aaa9291f4310f URL: https://github.com/llvm/llvm-project/commit/041da0d828e39d849c99adf1391aaa9291f4310f DIFF: https://github.com/llvm/llvm-project/commit/041da0d828e39d849c99adf1391aaa9291f4310f.dif

[PATCH] D87324: [HIP] Add gfx1030 and gfx1031

This revision was automatically updated to reflect the committed changes. Closed by commit rG041da0d828e3: [HIP] Add gfx1031 and gfx1030 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87324/new/ ht

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. If another project defines `LLVM_ENABLE_WARNINGS` before loading `HandleLLVMOptions`, it seems correct to me that the first one is used. This change ensures the default value of ON is setup at the last possible opportunity, before `LLVM_ENABLE_WARNINGS` is read and

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringChecker.cpp:32-34 +auto CStringChecker::createOutOfBoundErrorMsg(StringRef FunctionDescription, + AccessKind Access) +-> ErrorMessage {

  1   2   >