[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

hokein added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:429 + auto *T = getTemplate(); + T->Ctx->Deallocate(T); +} sammccall wrote: > sammccall wrote: > > this is a no-op, and thus not worth stashing a pointer to Ctx for! >

[clang] 70523ec - [Sparc] Select the UltraSPARC instruction set with the external assembler

Author: Brad Smith Date: 2020-09-07T02:49:05-04:00 New Revision: 70523ecfaca692bf5d0192e466c34ae7514624ea URL: https://github.com/llvm/llvm-project/commit/70523ecfaca692bf5d0192e466c34ae7514624ea DIFF: https://github.com/llvm/llvm-project/commit/70523ecfaca692bf5d0192e466c34ae7514624ea.diff LO

[clang] b3205e2 - [scan-view] Explicitly use utf-8 in send_string

Author: Tomas Rix Date: 2020-09-07T09:26:38+02:00 New Revision: b3205e2ace4378600dedba0cc5a42b481c4e22c9 URL: https://github.com/llvm/llvm-project/commit/b3205e2ace4378600dedba0cc5a42b481c4e22c9 DIFF: https://github.com/llvm/llvm-project/commit/b3205e2ace4378600dedba0cc5a42b481c4e22c9.diff LOG

[PATCH] D83984: Explicitly use utf-8 in send_string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3205e2ace43: [scan-view] Explicitly use utf-8 in send_string (authored by Tomas Rix , committed by serge-sans-paille). Repositor

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille added a comment. Commited on your behalf using what I expect to be your official email address :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

jhenderson added a comment. Not that I have anything particularly against this, but won't this likely rot fairly rapidly? It's not like LLVM is even on C++17 let alone C++20 yet, so trying to make it work like the latter when it's just going to break again seems a bit like wasted effort to me.

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

martong added a comment. In D87081#2256636 , @balazske wrote: > This checker will make an additional assumption on `fread` and `fwrite` with > the ReturnValueCondition. There is nothing new in that. This assumption described by the `.Case` has been here

[clang] 04ea680 - [cmake] Fix build of attribute plugin example on Windows

Author: Kristina Bessonova Date: 2020-09-07T10:04:32+02:00 New Revision: 04ea680a8ccc4f9a4d7333cd712333960348c35b URL: https://github.com/llvm/llvm-project/commit/04ea680a8ccc4f9a4d7333cd712333960348c35b DIFF: https://github.com/llvm/llvm-project/commit/04ea680a8ccc4f9a4d7333cd712333960348c35b.

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rsmith added inline comments. Comment at: clang/lib/Headers/intrin.h:435 #if defined(__i386__) || defined(__x86_64__) -static __inline__ void __DEFAULT_FN_ATTRS -__movsb(unsigned char *__dst, unsigned char const *__src, size_t __n) { +void __DEFAULT_FN_ATTRS __movsb(unsigned cha

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04ea680a8ccc: [cmake] Fix build of attribute plugin example on Windows (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

Szelethus added a comment. The patch looks great, in fact, it demonstrates how well thought out your summary crafting machinery is. In D87081#2258579 , @martong wrote: > However, in a similar case with the CallAndMessage Checker, we decided to > list th

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

Szelethus added a comment. The tests look great, thanks! I still lack the confidence to accept, unfortunately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85351/new/ https://reviews.llvm.org/D85351 ___ cfe-commits mailing list cfe-commits@

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Thanks for the patch, You need to generate a fill context diff (see Contributing to LLVM) ensure the diff is clang-formatted itself (can't quite tell if it is or not)

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

MyDeveloperDay added subscribers: sammccall, JDevlieghere, aaron.ballman. MyDeveloperDay added a comment. > Regarding not touching the LLVM support library: I'd love to find a way, but > as clang-format uses the >> operator We need to find some reviewers who look after a wider area of LLVM, if y

[PATCH] D87028: [clang-format] Improve heuristic for detecting function declarations

MyDeveloperDay added a comment. Thanks for the patch, I think this looks like a comprehensive improvement, a new nits only Comment at: clang/lib/Format/TokenAnnotator.cpp:2427 + // inside a function this should always be treated as a variable. + return CouldBeTypeList && Lin

[PATCH] D87028: [clang-format] Improve heuristic for detecting function declarations

arichardson added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2427 + // inside a function this should always be treated as a variable. + return CouldBeTypeList && Line.Level == 0; } MyDeveloperDay wrote: > how hard would it be to do the TO

[clang] 56fa7d1 - [clang-format] Fix formatting of _Atomic() qualifier

Author: Alex Richardson Date: 2020-09-07T10:09:18+01:00 New Revision: 56fa7d1dc6a8d23111ff84171036f333cf9cddf2 URL: https://github.com/llvm/llvm-project/commit/56fa7d1dc6a8d23111ff84171036f333cf9cddf2 DIFF: https://github.com/llvm/llvm-project/commit/56fa7d1dc6a8d23111ff84171036f333cf9cddf2.dif

[PATCH] D86950: [clang-format] Check that */& after typename macros are pointers/references

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd01eec14bc0: [clang-format] Check that */& after typename macros are pointers/references (authored by arichardson). Repository: rG LLVM Github Mo

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG56fa7d1dc6a8: [clang-format] Fix formatting of _Atomic() qualifier (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D86959?vs=289509&id=290211#toc Repository: rG LLVM Gith

[clang] e7bd058 - [clang-format] Allow configuring list of macros that map to attributes

Author: Alex Richardson Date: 2020-09-07T10:09:17+01:00 New Revision: e7bd058c7e2cb2c675a4b78ec770ea725bff8c64 URL: https://github.com/llvm/llvm-project/commit/e7bd058c7e2cb2c675a4b78ec770ea725bff8c64 DIFF: https://github.com/llvm/llvm-project/commit/e7bd058c7e2cb2c675a4b78ec770ea725bff8c64.dif

[PATCH] D86930: [clang-format] Handle typename macros inside cast expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG8aa3b8da5db2: [clang-format] Handle typename macros inside cast expressions (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86930/ne

[clang] 9a22eba - [clang-format] Parse __underlying_type(T) as a type

Author: Alex Richardson Date: 2020-09-07T10:09:18+01:00 New Revision: 9a22eba15091ea849fa78c09ac4c9f7260071790 URL: https://github.com/llvm/llvm-project/commit/9a22eba15091ea849fa78c09ac4c9f7260071790 DIFF: https://github.com/llvm/llvm-project/commit/9a22eba15091ea849fa78c09ac4c9f7260071790.dif

[clang] cd01eec - [clang-format] Check that */& after typename macros are pointers/references

Author: Alex Richardson Date: 2020-09-07T10:09:18+01:00 New Revision: cd01eec14bc045a8616604cadf94dba025090ba5 URL: https://github.com/llvm/llvm-project/commit/cd01eec14bc045a8616604cadf94dba025090ba5 DIFF: https://github.com/llvm/llvm-project/commit/cd01eec14bc045a8616604cadf94dba025090ba5.dif

[clang] 05147d3 - [clang-format] Correctly parse function declarations with TypenameMacros

Author: Alex Richardson Date: 2020-09-07T10:09:18+01:00 New Revision: 05147d33091720e2df929d6fea3b0fd2a657ac61 URL: https://github.com/llvm/llvm-project/commit/05147d33091720e2df929d6fea3b0fd2a657ac61 DIFF: https://github.com/llvm/llvm-project/commit/05147d33091720e2df929d6fea3b0fd2a657ac61.dif

[clang] 8aa3b8d - [clang-format] Handle typename macros inside cast expressions

Author: Alex Richardson Date: 2020-09-07T10:09:17+01:00 New Revision: 8aa3b8da5db2ae73bf536b630915eb9f0ddc15cb URL: https://github.com/llvm/llvm-project/commit/8aa3b8da5db2ae73bf536b630915eb9f0ddc15cb DIFF: https://github.com/llvm/llvm-project/commit/8aa3b8da5db2ae73bf536b630915eb9f0ddc15cb.dif

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7bd058c7e2c: [clang-format] Allow configuring list of macros that map to attributes (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D86960: [clang-format] Parse __underlying_type(T) as a type

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a22eba15091: [clang-format] Parse __underlying_type(T) as a type (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86960/new/ https:

[PATCH] D87007: [clang-format] Correctly parse function declarations with TypenameMacros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05147d330917: [clang-format] Correctly parse function declarations with TypenameMacros (authored by arichardson). Repository: rG LLVM Github Monor

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

hans added a comment. Cool! Comment at: clang-tools-extra/CMakeLists.txt:4 +option(CLANG_TIDY_ENABLE_STATIC_ANALYZER + "Include static analyzer checks in clang-tidy" ON) + Should this default to CLANG_ENABLE_STATIC_ANALYZER instead of ON? Co

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. @balazske seems to be very involved, he might have some closing words -- from my end, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D86880: [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a7a2cd7474e: [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits (authored by eduucaldas). Changed prior to commit: https://

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

This revision was automatically updated to reflect the committed changes. Closed by commit rG81aa66f65f50: Extract infrastructure to ignore intermediate expressions into… (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86778/n

[clang-tools-extra] 1a7a2cd - [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits

Author: Eduardo Caldas Date: 2020-09-07T09:32:30Z New Revision: 1a7a2cd7474e6d321120ffe7ca9c52163eb228f0 URL: https://github.com/llvm/llvm-project/commit/1a7a2cd7474e6d321120ffe7ca9c52163eb228f0 DIFF: https://github.com/llvm/llvm-project/commit/1a7a2cd7474e6d321120ffe7ca9c52163eb228f0.diff LOG

[clang] 81aa66f - Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

Author: Eduardo Caldas Date: 2020-09-07T09:32:30Z New Revision: 81aa66f65f504af18982baa078a5f3f7d2aa88fa URL: https://github.com/llvm/llvm-project/commit/81aa66f65f504af18982baa078a5f3f7d2aa88fa DIFF: https://github.com/llvm/llvm-project/commit/81aa66f65f504af18982baa078a5f3f7d2aa88fa.diff LOG

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290223. eduucaldas added a comment. Add more tests, not extract `IgnoreImplicitConstructorSingleStep` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290224. eduucaldas marked an inline comment as done. eduucaldas added a comment. Add FIXME for `CXXFunctionalCastExpr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700

[PATCH] D87229: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87229 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/S

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

vsavchenko accepted this revision. vsavchenko added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https://reviews.llvm.org/D84415 ___ cfe-commits mailing list cfe-comm

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290227. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/Synta

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290228. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/Synta

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:552 [[::n::S s1]]; [[n::S s2]]; } gribozavr2 wrote: > Do we have tests for calling constructors with arguments? > > `n::S s3(1, 2, 3);` > `n::S s3{1, 2, 3};` >

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 290229. tambre marked 3 inline comments as done. tambre added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/include/

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 290232. tambre marked an inline comment as done. tambre added a comment. Remove now obsolete FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/includ

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. Thanks for the review. All tests still pass, should be good for another round. Comment at: clang/lib/Sema/SemaDecl.cpp:9672-9673 + if (unsigned BuiltinID = II->getBuiltinID()) { +const auto *LinkageDecl = +dyn_cast(NewFD->getDecl

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

Szelethus added a comment. I'm in favor of most, if not all of the changes, though I will admit that this patch seems pretty cluttered, you are doing a lot of refactoring under the same hood. You're moving, adding, removing and changing helper functions and their invocations. Would be possible

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

steakhal added a comment. OK, after a few hours of debugging, the test code simplifies to this: // RUN: %clang_analyze_cc1 -std=c++11 -analyzer-checker=core,cplusplus,alpha.cplusplus.IteratorRange -analyzer-config aggressive-binary-operation-simplification=true %s -verify void foo(int x)

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

Szelethus added a reviewer: NoQ. Szelethus added a comment. Herald added a subscriber: Charusso. NoQ in particular has been working hard on the common infrastructure in between the static analyzer and clang-tidy, I'll add him :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87118/new/

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0478720157f6: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further… (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] 0478720 - [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

Author: Raphael Isemann Date: 2020-09-07T12:31:30+02:00 New Revision: 0478720157f6413fad7595b8eff9c70d2d99b637 URL: https://github.com/llvm/llvm-project/commit/0478720157f6413fad7595b8eff9c70d2d99b637 DIFF: https://github.com/llvm/llvm-project/commit/0478720157f6413fad7595b8eff9c70d2d99b637.dif

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

riccibruno added a comment. And what if deserialization is forced? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80878/new/ https://reviews.llvm.org/D80878 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan updated this revision to Diff 290245. ebevhan added a comment. Added promotion mechanism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Fro

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290246. bc-lee added a comment. Modify the comment of Format.h to sync ClangFormatStyleOptions.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files: clang/docs/Cl

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware updated this revision to Diff 290248. baloghadamsoftware added a comment. Wrong diff uploaded previously. (Accidentally compared to //master// instead of the prerequisite.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76590/new/ https://reviews.llvm.org/D76590 File

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:36 + void handleAssignment(CheckerContext &C, const Expr *CE, SVal Cont, +Optional = None) c

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev updated this revision to Diff 290256. kbobyrev added a comment. "Fail" early. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85426/new/ https://reviews.llvm.org/D85426 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp Index: cl

[clang] a8a9153 - [X86] Replace EmitX86AddSubSatExpr with EmitX86BinaryIntrinsic generic helper. NFCI.

Author: Simon Pilgrim Date: 2020-09-07T13:33:48+01:00 New Revision: a8a91533dd65041ced68ed5b9348b5d023837488 URL: https://github.com/llvm/llvm-project/commit/a8a91533dd65041ced68ed5b9348b5d023837488 DIFF: https://github.com/llvm/llvm-project/commit/a8a91533dd65041ced68ed5b9348b5d023837488.diff

[PATCH] D87101: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

RKSimon added a comment. In D87101#2256557 , @spatel wrote: > I noticed one other LLVM codegen test that might want to be updated to use > the IR intrinsics to be more relevant -- > llvm-project/llvm/test/CodeGen/X86/combine-abs.ll. That can be done with

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290259. eduucaldas added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/To

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290260. eduucaldas added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/To

[PATCH] D87229: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor

eduucaldas updated this revision to Diff 290261. eduucaldas added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87229/new/ https://reviews.llvm.org/D87229 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/To

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:48-50 +// Ignores the implicit `CXXConstructExpr` for copy/move constructors generated +// by the compiler, as well as in implicit conversions like the one wrapping `1` +// in `X x = 1;`. --

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan updated this revision to Diff 290267. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_point_

[PATCH] D86631: [Fixed Point] Add fixed-point to floating point cast types and consteval.

ebevhan updated this revision to Diff 290266. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86631/new/ https://reviews.llvm.org/D86631 Files: clang/include/clang/AST/OperationKinds.def clang/lib/AST/Expr.cpp

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. In D80878#2258942 , @riccibruno wrote: > And what if deserialization is forced? That's a good point. That should indeed continue to work with the

[clang] 23f700c - Revert "[clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations."

Author: Raphael Isemann Date: 2020-09-07T14:50:13+02:00 New Revision: 23f700c785a141355fa6d022552aafc73135bf5d URL: https://github.com/llvm/llvm-project/commit/23f700c785a141355fa6d022552aafc73135bf5d DIFF: https://github.com/llvm/llvm-project/commit/23f700c785a141355fa6d022552aafc73135bf5d.dif

[clang] 2853ae3 - [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

Author: Simon Pilgrim Date: 2020-09-07T13:54:12+01:00 New Revision: 2853ae3c1b8174e3660424ffac45922601f700ee URL: https://github.com/llvm/llvm-project/commit/2853ae3c1b8174e3660424ffac45922601f700ee DIFF: https://github.com/llvm/llvm-project/commit/2853ae3c1b8174e3660424ffac45922601f700ee.diff

[PATCH] D87101: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2853ae3c1b81: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851) (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86097/new/ https://reviews.llvm.org/D86097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

Szelethus added a comment. I can only imagine how long it took for you to write all this, because reading it wasn't that short either. Thank you so much! It really gave me a perspective on how you see this problem, as well as what is actually happening (and should happen) in the checker. In D8

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:396 +/// according to the field declaring type width. +CODEGENOPT(ForceNoAAPCSBitfieldWidth, 1, 0) + dnsampaio wrote: > ostannard wrote: > > Why is this a negative option, w

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor added a subscriber: grimar. fodinabor added a comment. Thank you so far for the feedback! maybe you can give further guidance on the comments on the comments :) As of the git history it seems that @grimar did some work on YAML error handling.. Comment at: clang/tool

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus added inline comments. Comment at: clang/docs/ReleaseNotes.rst:453 + equal or known to be non-equal. + +- Added :ref:`on-demand parsing ` capability to Cross Translation ASDenysPetrov wrote: > I've added the patch "Reasoning about comparison expressio

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus updated this revision to Diff 290280. Szelethus marked 4 inline comments as done. Szelethus added a comment. Added a line about D78933 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86533/new/ https://reviews.llvm.org/D86533 Files: clang/do

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov updated this revision to Diff 290281. dmantipov added a comment. Add trivial {/etc,/usr/lib}/os-release parser and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ https://reviews.llvm.org/D87187 Files: clang/include

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

steakhal added a comment. In D86874#2256249 , @martong wrote: >> Calculation of the RegionRawOffsetV2 >> >> >> Let's see how does these subscript expressions used during the calculation >> of the `RegionRawOffsetV2`: >

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

grimar added a comment. I am not familar with `clang-format`, but have a few comments inlined about the rest. I think the new `setIgnoreUnknown` YAMLlib API is probably OK generally. I'd perhaps call it differently, e.g. `setAllowUnknownKeys` though. Also, I think you need to add a unit testing

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

steakhal added a comment. In D86874#2259105 , @Szelethus wrote: > I can only imagine how long it took for you to write all this, because > reading it wasn't that short either. Thank you so much! It really gave me a > perspective on how you see this probl

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added inline comments. Comment at: llvm/include/llvm/Support/CfgTraits.h:51 + + operator bool() const { return ptr != nullptr; } + dblaikie wrote: > `operator bool` should be `explicit` Done. Comment at: llvm/include/llvm/Support/CfgT

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. Ping @OikawaKirie . How should we proceed? I would happily participate in creating a minimal repro for this, but I need at least one crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83660/new/ https://reviews.llvm.org

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

steakhal added a comment. I have checked only your test, but the readability of the reports should be improved. You frequently refer to previous events, such as `This lock has already been unlocked`, `This lock has already been acquired`, etc. It isn't clear to the reader where do you refer to.

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

steakhal added a comment. Perfectly clear, thank you. However, I would still rely on the others to accept this :| BTW why does the `plist-macros-with-expansion.cpp.plist` change? It makes the diff somewhat noisy :s CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86135/new/ https://revi

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

JakeMerdichAMD added a comment. I can see the use of this, but I am also wary that ignoring style options will lead to people producing different results on different versions of clang-format. This is both because having set-or-unset an option will naturally lead to different code and also that

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

martong created this revision. martong added reviewers: Szelethus, balazske, NoQ, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald ad

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin added a comment. In D78938#2258557 , @jhenderson wrote: > Not that I have anything particularly against this, but won't this likely rot > fairly rapidly? It's not like LLVM is even on C++17 let alone C++20 yet, so > trying to make it work like th

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin added inline comments. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:805-817 + return IsASCII ? "^" : (const char *)u8"\u2548"; case LineChar::RangeMid: - return IsASCII ? "|" : u8"\u2503"; + return IsASCII ? "|" : (const char *)u8"\u2503";

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

steakhal added a comment. I completely agree with you. I plan to further refactor the CStringChecker, but the related patches are pretty much stuck :D I think this workaround is fine for now. You might as well extend the corresponding parts of the CStringChecker to make the modelling more preci

[PATCH] D87138: [analyzer][NFC] Introduce refactoring of PthreadLockChecker

steakhal accepted this revision. steakhal added a comment. Seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87138/new/ https://reviews.llvm.org/D87138 ___ cfe-commits mailing list cfe-comm

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

JakeMerdichAMD requested changes to this revision. JakeMerdichAMD added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1705 + /// \endcode + bool JavaStaticImportAfterImport; + 3 things here: 1.

[PATCH] D87240: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

martong created this revision. martong added reviewers: Szelethus, balazske, NoQ, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald ad

[PATCH] D87240: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This is exactly how I imagines weak dependencies to work. LGTM on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87240/new/ https:/

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. Did you upload this incorrectly again, context is missing and seems to be a relative diff from a previous version of this patch? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

Szelethus added a comment. In D86135#2259325 , @steakhal wrote: > Perfectly clear, thank you. However, I would still rely on the others to > accept this :| > > BTW why does the `plist-macros-with-expansion.cpp.plist` change? It makes the > diff somewhat

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman added a comment. In D85611#2230481 , @aaron.ballman wrote: > In D85611#2218144 , @aaron.ballman > wrote: > >> Ping > > Ping x2 I realize it's performance review time for some folks and their schedul

[clang] d012805 - [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

Author: Gabor Marton Date: 2020-09-07T17:47:01+02:00 New Revision: d01280587d97eb02d37da37666afd3e4d57c9336 URL: https://github.com/llvm/llvm-project/commit/d01280587d97eb02d37da37666afd3e4d57c9336 DIFF: https://github.com/llvm/llvm-project/commit/d01280587d97eb02d37da37666afd3e4d57c9336.diff

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd01280587d97: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions (authored by martong). Changed prior to commit: https://reviews.llvm.org/D84415?vs=289970&id=290296#toc Reposit

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2027 + + .. code-block:: java + true: MyDeveloperDay wrote: > The ClangFormatStyleOptions.rst is generated using > doc/tools/dump_format_style.py which reads Format.h and genera

[clang] 8248c2a - [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

Author: Gabor Marton Date: 2020-09-07T17:56:26+02:00 New Revision: 8248c2af94975912b14e7e0cb414fcbb82c77123 URL: https://github.com/llvm/llvm-project/commit/8248c2af94975912b14e7e0cb414fcbb82c77123 DIFF: https://github.com/llvm/llvm-project/commit/8248c2af94975912b14e7e0cb414fcbb82c77123.diff

[PATCH] D87240: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8248c2af9497: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies (authored by martong). Changed prior to commit: https://reviews

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

martong added a comment. In D87081#2258637 , @Szelethus wrote: > The patch looks great, in fact, it demonstrates how well thought out your > summary crafting machinery is. > > In D87081#2258579 , @martong wrote: >

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps marked an inline comment as done. alanphipps added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:4359 + /// condition (i.e. no "&&" or "||"). + static bool isLeafCondition(const Expr *C); + vsk wrote: > alanphipps wrote: > > vsk wr

  1   2   >