[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov created this revision. dmantipov added reviewers: mgorny, aganea. dmantipov added a project: clang. Herald added a subscriber: cfe-commits. dmantipov requested review of this revision. When running regular ('clang++ foo.cc') native compilation on Linux target in a typical configuration,

[PATCH] D86207: Set InvalidDecl directly when deserializing a Decl

This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG16975a638df3: Set InvalidDecl directly when deserializing a Decl (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87065: Thread safety analysis: Document how try-acquire is handled

This revision was automatically updated to reflect the committed changes. Closed by commit rG8544defdcb09: Thread safety analysis: Document how try-acquire is handled (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87065/new

[clang] 8544def - Thread safety analysis: Document how try-acquire is handled

Author: Aaron Puchert Date: 2020-09-05T14:26:43+02:00 New Revision: 8544defdcb09c25c5958e5f5b5762e9b9046 URL: https://github.com/llvm/llvm-project/commit/8544defdcb09c25c5958e5f5b5762e9b9046 DIFF: https://github.com/llvm/llvm-project/commit/8544defdcb09c25c5958e5f5b5762e9b9046.diff

[clang] 16975a6 - Set InvalidDecl directly when deserializing a Decl

Author: Aaron Puchert Date: 2020-09-05T14:26:43+02:00 New Revision: 16975a638df3cda95c677055120b23e689d96dcd URL: https://github.com/llvm/llvm-project/commit/16975a638df3cda95c677055120b23e689d96dcd DIFF: https://github.com/llvm/llvm-project/commit/16975a638df3cda95c677055120b23e689d96dcd.diff

[PATCH] D66564: [clang-tidy] new altera struct pack align check

aaron.ballman added a comment. In D66564#2256482 , @ffrankies wrote: > In D66564#2256424 , @Eugene.Zelenko > wrote: > >> In D66564#2256423 , @ffrankies >> wrote: >> >>> @Eu

[PATCH] D87064: Thread safety analysis: Test and document release_generic_capability

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/docs/ThreadSafetyAnalysis.rst:804 + #define RELEASE_GENERIC(...) \ +THREAD_ANNOTATION_ATTRIBUTE__(release_generic_capability(__VA_ARGS__)) + This is not something

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:208 +{"wchar_t", "wc"}, +{"short", "s"}, +{"signed", "i"}, dougpuob wrote: > aaron.ballman wrot

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

MyDeveloperDay added a comment. This has caught me out from time to time, but the presence of such an option can lead to users mixing clang-format versions which could lead to flip/flopping of changes, so I'm not 100% sure it won't drive bad behaviour. However breaking based on the option can b

[PATCH] D87189: [CMake] Remove dead FindPythonInterp code

tambre created this revision. tambre added reviewers: compnerd, phosek. Herald added subscribers: llvm-commits, libcxx-commits, Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers, libc++, LLVM. Herald added a reviewer: libc++. tambre requested review of this revision. LLVM

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor added a comment. I see the possible issue with the possible version mismatches and that is why I'd make people opt-in for this option, to still being able to format their files (e.g. if using out-dated built-in versions like in Visual Studio - I know you can specify your own binary) b

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. aaronpuchert requested review of this revision. Public members are always in scope, protected members in derived classes with sufficient access.

[clang] b2ce79e - Thread safety analysis: ValueDecl in Project is non-null

Author: Aaron Puchert Date: 2020-09-05T17:26:12+02:00 New Revision: b2ce79ef66157dd752e3864ece57915e23a73f5d URL: https://github.com/llvm/llvm-project/commit/b2ce79ef66157dd752e3864ece57915e23a73f5d DIFF: https://github.com/llvm/llvm-project/commit/b2ce79ef66157dd752e3864ece57915e23a73f5d.diff

[clang] 9dcc82f - Thread safety analysis: Consider global variables in scope

Author: Aaron Puchert Date: 2020-09-05T17:26:12+02:00 New Revision: 9dcc82f34ea9b623d82d2577b93aaf67d36dabd2 URL: https://github.com/llvm/llvm-project/commit/9dcc82f34ea9b623d82d2577b93aaf67d36dabd2 DIFF: https://github.com/llvm/llvm-project/commit/9dcc82f34ea9b623d82d2577b93aaf67d36dabd2.diff

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dcc82f34ea9: Thread safety analysis: Consider global variables in scope (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84604/new/

[clang] d3a779f - Restore size of TemplateParameterList after D44352

Author: Aaron Puchert Date: 2020-09-05T18:01:33+02:00 New Revision: d3a779fe21500457e95c8c4e963638b93e3bcc71 URL: https://github.com/llvm/llvm-project/commit/d3a779fe21500457e95c8c4e963638b93e3bcc71 DIFF: https://github.com/llvm/llvm-project/commit/d3a779fe21500457e95c8c4e963638b93e3bcc71.diff

[clang-tools-extra] da6b3aa - Attempt to fix Sphinx build failure, NFC

Author: Aaron Puchert Date: 2020-09-05T18:25:27+02:00 New Revision: da6b3aa4c6bb29a150628ad489274466c6b8ace0 URL: https://github.com/llvm/llvm-project/commit/da6b3aa4c6bb29a150628ad489274466c6b8ace0 DIFF: https://github.com/llvm/llvm-project/commit/da6b3aa4c6bb29a150628ad489274466c6b8ace0.diff

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 290099. dougpuob added a comment. Improved suggestions of code review. (All suggestions from aaron.ballman) 1. Changed variables named with `Decl` to `InputDecl`. 2. Changed `TypeName.length()` --> `!TypeName.empty()`. 3. Added partial Microsft data types to

[clang] 0c64282 - scan-build-py: fix multiprocessing error

Author: Lawrence D'Anna Date: 2020-09-05T11:10:14-07:00 New Revision: 0c642828612dbde30decff6fb080af4de9a173bd URL: https://github.com/llvm/llvm-project/commit/0c642828612dbde30decff6fb080af4de9a173bd DIFF: https://github.com/llvm/llvm-project/commit/0c642828612dbde30decff6fb080af4de9a173bd.dif

[PATCH] D87051: scan-build-py: fix multiprocessing error

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c642828612d: scan-build-py: fix multiprocessing error (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87051/new/ https://review

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 290104. tianshilei1992 added a comment. Update one test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/te

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks correct to me. Thanks a lot. This hack was surprisingly crude and i'm very glad that we now consistently use expressions in our Environment. Comment at: clang/lib/Stati

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee created this revision. bc-lee added a reviewer: MyDeveloperDay. bc-lee added projects: clang, clang-format. Herald added a subscriber: cfe-commits. bc-lee requested review of this revision. Some Java style guides and IDEs group Java static imports after non-static imports. This patch allow