[PATCH] D86649: Fix for assertion failure on PR46865

wristow added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3098 // have been value-dependent too), so diagnose that. -assert(!VD->mightBeUsableInConstantExpressions(Info.Ctx)); +assert(!VD->isUsableInConstantExpressions(Info.Ctx)); if (!Info.check

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

rsmith added a comment. LGTM I've not checked all the types are correct (someone should double-check that prior to commit), but it looks like GCC provides these `__builtin_*` functions, so we should too. The addition of the non-`__builtin_` versions should improve our diagnostics but otherwise

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante marked 8 inline comments as done. Mordante added a comment. Thanks again for your feedback. Once we agree on what to do with the Likelihood state in the output I'll finish the changes and submit a new patch. Comment at: clang/include/clang/Basic/AttrDocs.td:1697 +It i

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added a comment. In D86559#2250106 , @staffantj wrote: > In D86559#2250034 , @aaron.ballman > wrote: > >> In D86559#2243575 , @staffantj >> wrote: >> >>> This is n

[PATCH] D86965: Do not emit "-tune-cpu generic" for PS4 platform

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. Couple of nits and LGTM. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2078 - // Default to "generic" unless -march is present. + // Default to "generic" unless

[clang] b1f3948 - Do not emit "-tune-cpu generic" for PS4 platform

Author: Douglas Yung Date: 2020-09-01T12:37:47-07:00 New Revision: b1f394862053867cdc6b2300e725e053504519d5 URL: https://github.com/llvm/llvm-project/commit/b1f394862053867cdc6b2300e725e053504519d5 DIFF: https://github.com/llvm/llvm-project/commit/b1f394862053867cdc6b2300e725e053504519d5.diff

[PATCH] D86965: Do not emit "-tune-cpu generic" for PS4 platform

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1f394862053: Do not emit "-tune-cpu generic" for PS4 platform (authored by dyung). Changed prior to commit: https://reviews.llvm.org/D86965?vs=28

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

staffantj added a comment. In D86559#2250344 , @Mordante wrote: > In D86559#2250106 , @staffantj wrote: > >> In D86559#2250034 , @aaron.ballman >> wrote: >> >>> In D86559#22

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. Sorry for not noticing this review earlier. We can't make this change. Module map files are still useful and still used even when modules are disabled -- they power the undeclared in

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > efriedma wrote: > > Do we want to make sparc and sp

[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

sammccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5092 "expression not permitted as operand of fold expression">; +def err_fold_expression_expansion_exceeded: Error< + "fold expression expansion level %0 exceeded maximum of %1">; --

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg abandoned this revision. andrewjcg added a comment. Ahh, I see, make sense. The motivating issue was due to an apparent bug where realpaths in umbrella dir support for module map files get leaked into dep files for includes starting with `..` (e.g. `#include "../foo.h"`) in non-modula

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } ro wrote: > efriedma wrote: > > This probably should be refactored so the target-independent code generates

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

craig.topper updated this revision to Diff 289273. craig.topper added a comment. Use an alias. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86820/new/ https://reviews.llvm.org/D86820 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-x86-flags.c Index: clang/test/

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

rsmith added a comment. Looking specifically for attributes in the 'then' and 'else' cases of an `if` seems like a fine first pass at this, but I think this is the wrong way to lower these attributes in the longer term: we should have a uniform treatment of them that looks for the most recent p

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } efriedma wrote: > ro wrote: > > efriedma wrote: > > > This probably should be refactored so the target-independent

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:578 +static std::pair +getLikelihood(const Stmt *Stmt) { + if (const auto *AS = dyn_cast(Stmt)) rsmith wrote: > Sema doesn't care about any of this; can you move this code to CodeGen an

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; brad wrote: > ro wrote: > > efriedma wrote: > > > Do we want to m

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } ro wrote: > efriedma wrote: > > ro wrote: > > > efriedma wrote: > > > > This probably should be refactored so

[clang] 8ca00c5 - Thread safety analysis: More consistent warning message

Author: Aaron Puchert Date: 2020-09-01T23:16:05+02:00 New Revision: 8ca00c5cdc0b86a433b80db633f3ff46e6547895 URL: https://github.com/llvm/llvm-project/commit/8ca00c5cdc0b86a433b80db633f3ff46e6547895 DIFF: https://github.com/llvm/llvm-project/commit/8ca00c5cdc0b86a433b80db633f3ff46e6547895.diff

[PATCH] D84603: Thread safety analysis: More consistent warning message

This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG8ca00c5cdc0b: Thread safety analysis: More consistent warning message (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org/D84603?

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > brad wrote: > > ro wrote: > > > efriedma wrote:

[PATCH] D86980: [Docs] Remove outdated OS limitation

yln created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. yln requested review of this revision. Thread Sanitizer is supported on macOS. rdar://68159753 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86980 Files: clang/docs/UsersManua

[PATCH] D86980: [Docs] Remove outdated OS limitation

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86980/new/ https://reviews.llvm.org/D86980 __

[PATCH] D86980: [Docs] Remove outdated OS limitation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG478eb98cd25c: [Docs] Remove outdated OS limitation (authored by yln). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 478eb98 - [Docs] Remove outdated OS limitation

Author: Julian Lettner Date: 2020-09-01T14:44:17-07:00 New Revision: 478eb98cd25cb0ebc01fc2c3889ae94d3f1797d3 URL: https://github.com/llvm/llvm-project/commit/478eb98cd25cb0ebc01fc2c3889ae94d3f1797d3 DIFF: https://github.com/llvm/llvm-project/commit/478eb98cd25cb0ebc01fc2c3889ae94d3f1797d3.diff

[PATCH] D60939: [Concepts] Delayed Constraint Substitution

rsmith added a comment. I wonder if there's a cleaner way to model this: Suppose we add a new `Expr` subclass for an expression with delayed template argument substitution, which would capture a list of `TemplateArgument`s and an inner `Expr*` into which those template arguments have not yet be

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; efriedma wrote: > ro wrote: > > brad wrote: > > > ro wrote: > > >

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:488 +BUILTIN(__builtin_calloc, "v*zz", "F") +BUILTIN(__builtin_exit, "vi", "Fr") BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:") Should we be adding `atexit()` as well?

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

rsmith added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:488 +BUILTIN(__builtin_calloc, "v*zz", "F") +BUILTIN(__builtin_exit, "vi", "Fr") BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:") aaron.ballman wrote: > Should we be adding `atexit()`

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:488 +BUILTIN(__builtin_calloc, "v*zz", "F") +BUILTIN(__builtin_exit, "vi", "Fr") BUILTIN(__builtin_fprintf, "iP*cC*.", "Fp:1:") rsmith wrote: > aaron.ballman wrote: > > Shoul

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > efriedma wrote: > > ro wrote: > > > brad wrote: > > >

[clang] 0c2d872 - [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn

Author: Amy Kwan Date: 2020-09-01T17:16:43-05:00 New Revision: 0c2d872d5dec3eba10a8245bbcb3eebcf405ef9f URL: https://github.com/llvm/llvm-project/commit/0c2d872d5dec3eba10a8245bbcb3eebcf405ef9f DIFF: https://github.com/llvm/llvm-project/commit/0c2d872d5dec3eba10a8245bbcb3eebcf405ef9f.diff LOG:

[PATCH] D86795: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c2d872d5dec: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D8

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. reverse ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:185 +getHungarianNotationTypePrefix(const std::string &TypeName, + const NamedDecl *Decl) { + if (0 == TypeName.length()) {

[clang] 663f4f7 - [clang] consistently use getLangOpts()

Author: Nick Desaulniers Date: 2020-09-01T15:56:53-07:00 New Revision: 663f4f7edc2476231fa5bfc04519d5fd51a10112 URL: https://github.com/llvm/llvm-project/commit/663f4f7edc2476231fa5bfc04519d5fd51a10112 DIFF: https://github.com/llvm/llvm-project/commit/663f4f7edc2476231fa5bfc04519d5fd51a10112.di

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

ab added a comment. Hmm, is there a more general way to disable warnings? I'm not familiar with these parts, so I'll defer to you folks =] Comment at: clang/lib/CodeGen/TargetInfo.cpp:2515-2516 + if (!CallerHasFeat && !CalleeHasFeat) { +// Darwin doesn't enable AVX/AVX51

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cd6b0c3b5db: [clang] Do not consider the template arguments of bases to be bases themselves (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 7cd6b0c - [clang] Do not consider the template arguments of bases to be bases themselves

Author: Nathan Ridge Date: 2020-09-01T19:18:03-04:00 New Revision: 7cd6b0c3b5db61be94ed7f494d5036b2c30aaf3f URL: https://github.com/llvm/llvm-project/commit/7cd6b0c3b5db61be94ed7f494d5036b2c30aaf3f DIFF: https://github.com/llvm/llvm-project/commit/7cd6b0c3b5db61be94ed7f494d5036b2c30aaf3f.diff

[clang-tools-extra] ca842c8 - [clangd] Handle templates more consistently in type hierarchy

Author: Nathan Ridge Date: 2020-09-01T19:18:37-04:00 New Revision: ca842c825a1caf10aacb1dc63664d565b1f2f4eb URL: https://github.com/llvm/llvm-project/commit/ca842c825a1caf10aacb1dc63664d565b1f2f4eb DIFF: https://github.com/llvm/llvm-project/commit/ca842c825a1caf10aacb1dc63664d565b1f2f4eb.diff

[PATCH] D86861: [clangd] Handle templates more consistently in type hierarchy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca842c825a1c: [clangd] Handle templates more consistently in type hierarchy (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:513 BUILTIN(__builtin_printf, "icC*.", "Fp:0:") +BUILTIN(__builtin_putchar, "ii", "F") +BUILTIN(__builtin_puts, "icC*", "nF") rsmith wrote: > aaron.ballman wrote: > > Shoul

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers updated this revision to Diff 289312. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - rebase on master, precommitted getLangOpts() change, dropped p7.cpp test change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:513 BUILTIN(__builtin_printf, "icC*.", "Fp:0:") +BUILTIN(__builtin_putchar, "ii", "F") +BUILTIN(__builtin_puts, "icC*", "nF") nickdesaulniers wrote: > rsmith wrote: > > aar

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert updated this revision to Diff 289316. aaronpuchert added a comment. Rebase on top of D84603 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84604/new/ https://reviews.llvm.org/D84604 Files: clang/lib

[PATCH] D86508: [clang] implement+test remaining C90 __builtin_ functions

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:513 BUILTIN(__builtin_printf, "icC*.", "Fp:0:") +BUILTIN(__builtin_putchar, "ii", "F") +BUILTIN(__builtin_puts, "icC*", "nF") nickdesaulniers wrote: > nickdesaulniers wrote

[PATCH] D84455: [Concepts] Fix a deserialization crash.

aaronpuchert added a comment. > in some cases (e.g. implicit deduction guide templates synthesized from the > constructor), hasTypeConstraint returns true, and getTypeConstraint returns a > nullptr. If that's the case, can we reproduce this with a parsed AST? I've only seen this error on deser

[PATCH] D86993: Document Clang's expectations of the C standard library.

rsmith created this revision. rsmith added reviewers: fhahn, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. rsmith requested review of this revision. As suggested in https://reviews.llvm.org/D86815 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D86993: Document Clang's expectations of the C standard library.

rsmith updated this revision to Diff 289329. rsmith added a comment. Add missing word. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86993/new/ https://reviews.llvm.org/D86993 Files: clang/docs/Toolchain.rst Index: clang/docs/Toolchain.rst ===

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. reverse ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D86930: [clang-format] Handle typename macros inside cast expressions

dougpuob added a comment. I am a beginner to compiler, interesting in how to write Unit Test case for change so I ran it, but found difference with my expection. You mentioned Before: x = (STACK_OF(uint64_t)) & a; After: x = (STACK_OF(uint64_t))&a; Your input test data is identical with the ex

[PATCH] D67935: Add `#pragma clang deprecated`, used to deprecate macros

erik.pilkington requested review of this revision. erik.pilkington added a comment. @aaron.ballman: Did you happen to get any feedback on macro attributes? There are a growing number of macros that we'd like to be able to deprecate, and having a workable solution would be useful for us. Reposi

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

zequanwu added a comment. Hi, this change hits a false positive case in chromium build: https://bugs.chromium.org/p/chromium/issues/detail?id=1124085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85778/new/ https://reviews.llvm.org/D85778 ___

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

rsmith added a comment. In D85778#2248714 , @nikic wrote: > Just for the record, the additional analysis has a measurable compile-time > impact (0.3% at O0): > https://llvm-compile-time-tracker.com/compare.php?from=e7f53044e7263cdbbb4fed9abf086b88ba486bb

[clang] 0ffbbce - Don't take the expression range into account when looking for widening

Author: Richard Smith Date: 2020-09-01T17:42:12-07:00 New Revision: 0ffbbce78de60f4f4d03d6ef97fe2f3bb4275e08 URL: https://github.com/llvm/llvm-project/commit/0ffbbce78de60f4f4d03d6ef97fe2f3bb4275e08 DIFF: https://github.com/llvm/llvm-project/commit/0ffbbce78de60f4f4d03d6ef97fe2f3bb4275e08.diff

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

rsmith added a comment. In D85778#2251160 , @zequanwu wrote: > Hi, this change seems like hits a false positive case in chromium build: > https://bugs.chromium.org/p/chromium/issues/detail?id=1124085 That's not a false positive. The code is (simplified):

[PATCH] D85778: More accurately compute the ranges of possible values for +, -, *, &, %.

zequanwu added a comment. In D85778#2251173 , @rsmith wrote: > In D85778#2251160 , @zequanwu wrote: > >> Hi, this change seems like hits a false positive case in chromium build: >> https://bugs.chromium.org/p/chrom

[PATCH] D86993: Document Clang's expectations of the C standard library.

rjmccall added a comment. Wording looks good. Should we alsso document our assumptions about what functions exist in the standard library — the functions that we'll always use even in freestanding builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver

shivanshu3 created this revision. shivanshu3 added reviewers: aeubanks, kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. shivanshu3 requested review of this revision. Herald added a subscriber: ormris. MSVC's cl.exe has a few command line arguments which start with

[PATCH] D82777: Clang Driver: Use Apple ld64's new @response-file support.

arphaman added a comment. got it, we'll do what we can to release it as soon as possible in Xcode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82777/new/ https://reviews.llvm.org/D82777 ___ cfe-commits

<    1   2