[PATCH] D86861: [clangd] Handle templates more consistently in type hierarchy

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, danielkiss, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. If the tree includes

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

Szelethus added a comment. Herald added a subscriber: danielkiss. I'm not thrilled by this solution. As I understand it, the assertion was put there to enforce our ability to create a new assumption, and its great that we had it, because we managed to catch a fault in that. Seems like this patch

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

nullptr.cpp added a comment. Herald added a subscriber: danielkiss. In D86691#2241886 , @martong wrote: > In D86691#2241604 , @nullptr.cpp > wrote: > >> In D86691#2241401 ,

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added reviewers: venkatra, efriedma. ro added a comment. Herald added a subscriber: danielkiss. Ping? It's been a week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

Szelethus added a comment. Herald added a subscriber: danielkiss. In D86736#2244365 , @martong wrote: >> For any other loops, in order to know whether we should analyze another >> iteration, among other things, we evaluate it's condition. Which is a >> p

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

baloghadamsoftware added a comment. Herald added a subscriber: danielkiss. In D85351#2215547 , @Szelethus wrote: > Shouldn't we create a new test care for this, instead of expanding an > existing one? Btw, this looks great, but I lack the confidence to ac

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

Szelethus added a comment. In D85351#2247037 , @baloghadamsoftware wrote: > In D85351#2215547 , @Szelethus wrote: > >> Shouldn't we create a new test care for this, instead of expanding an >> existing one? Btw, th

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

xazax.hun added inline comments. Herald added a subscriber: danielkiss. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:556 +const LocationContext *LC = C.getLocationContext(); +InnerPointerVal = C.getSValBuilder().conjureSymbolVal( +CallExpr, L

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:231 return ObjCOrBuiltinID == tok::NUM_OBJC_KEYWORDS; } rjmccall wrote: > Do we need to support reverting builtins anymore? We don't. It'd be possible to set the built

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 288911. tambre marked 2 inline comments as done. tambre added a comment. Remove builtin reverting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/include

[PATCH] D85031: [builtins] Unify the softfloat division implementation

sepavloff added a comment. The new comments are much better, thank you! I think this version may be committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85031/new/ https://reviews.llvm.org/D85031 ___

[PATCH] D85032: [builtins] Make divXf3 handle denormal results

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85032/new/ https://reviews.llvm.org/D85032 __

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

sameeranjoshi accepted this revision. sameeranjoshi added a comment. Thank you for changes. I was able to build successfully out-of-tree. Please update the `README.md` with the necessary changes. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D86870: [analyzer] Add more tests for ArrayBoundCheckerV2

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, xazax.hun, Szelethus, martong. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang

[PATCH] D86873: [analyzer][NFC] Refactor ArrayBoundCheckerV2

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, xazax.hun, martong, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, Szelethus, martong, balazske, baloghadamsoftware. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, arphaman, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald a

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

martong added a comment. In D86736#2247035 , @Szelethus wrote: > In D86736#2244365 , @martong wrote: > >>> For any other loops, in order to know whether we should analyze another >>> iteration, among other things,

[clang] 1b743a9 - [analyzer] Add modeling for unique_ptr move constructor

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-08-31T14:36:11+02:00 New Revision: 1b743a9efa0884ed3a48ebea97b6ef6cb7d73164 URL: https://github.com/llvm/llvm-project/commit/1b743a9efa0884ed3a48ebea97b6ef6cb7d73164 DIFF: https://github.com/llvm/llvm-project/commit/1b743a9efa0884ed3a48ebea9

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b743a9efa08: [analyzer] Add modeling for unique_ptr move constructor (authored by vrnithinkumar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86373/new/

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

hans added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:895 + if (!Self.getLangOpts().RTTIData) { +bool isMSVC = Self.getDiagnostics().getDiagnosticOptions().getFormat() == + DiagnosticOptions::MSVC; zequanwu wrote: > hans wrote:

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

steakhal resigned from this revision. steakhal added a comment. Herald added a subscriber: steakhal. I don't have much to say, but to keep up the good work xD I will follow this and the rest of your patches @Szelethus. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

hans added a comment. Would it be enough for users to specify /clang:-mtune instead? How does icc spell its option? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86820/new/ https://reviews.llvm.org/D86820 ___ cfe-commits mailing list cfe-com

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov updated this revision to Diff 288930. ASDenysPetrov added a comment. Added //shared// semantics checks and correspondent tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85984/new/ https://reviews.llvm.org/D85984 Files: clang/include/clang/StaticAnalyzer/Checkers/Ch

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko updated this revision to Diff 288932. atrosinenko added a comment. Clarify rounding-related part of function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85031/new/ https://reviews.llvm.org/D85031 Files: compiler-rt/lib/builtins/di

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

aaron.ballman added a comment. In D33825#2246369 , @jfb wrote: > MSC54-CPP refers to POF, which as I pointed out above isn't relevant anymore. > I'd much rather have a diagnostic which honors the state of things after > http://wg21.link/p0270. I agree,

[PATCH] D86841: [clang] Add noprogress attribute deduction for infinite loops

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.h:211 llvm::ArrayRef Attrs, const llvm::DebugLoc &StartLoc, -const llvm::DebugLoc &EndLoc); +const llvm::DebugLoc &EndLoc, const bool NoProgress = false);

[PATCH] D85032: [builtins] Make divXf3 handle denormal results

atrosinenko updated this revision to Diff 288935. atrosinenko added a comment. Re-upload after amending parent diff + add minor clarification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85032/new/ https://reviews.llvm.org/D85032 Files: compil

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a suggestion for a comment, thank you! Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:205 + /// Warn when calling a functio

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 288938. dougpuob added a comment. Improved suggestions of code review. 1. Moved release notes to right place. [Eugene.Zelenko] 2. Added new casting types to doc(readability-identifier-naming.rst) [Eugene.Zelenko] 3. Moved partial code to a new function, Id

[PATCH] D85031: [builtins] Unify the softfloat division implementation

scanon added inline comments. Comment at: compiler-rt/lib/builtins/fp_div_impl.inc:99 + // 0 < x0(b) < 1 + // abs(x0(b) - 1/b) <= 3/4 - 1/sqrt(2) + sepavloff wrote: > atrosinenko wrote: > > sepavloff wrote: > > > This estimation is absent from the original

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

This revision was automatically updated to reflect the committed changes. Closed by commit rG14dd0737822b: [Clang-Tidy] New check `bugprone-redundant-branch-condition` (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D81272?vs=285656&id=288940#toc Repository:

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5fd7486d6c0: [clang-tidy] New check readability-prefer-member-initializer (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D71199?vs=285657&id=288939#toc Repository:

[clang-tools-extra] f5fd748 - [clang-tidy] New check readability-prefer-member-initializer

Author: Adam Balogh Date: 2020-08-31T15:59:29+02:00 New Revision: f5fd7486d6c0debb465de3e927fcc31884874280 URL: https://github.com/llvm/llvm-project/commit/f5fd7486d6c0debb465de3e927fcc31884874280 DIFF: https://github.com/llvm/llvm-project/commit/f5fd7486d6c0debb465de3e927fcc31884874280.diff L

[clang-tools-extra] 14dd073 - [Clang-Tidy] New check `bugprone-redundant-branch-condition`

Author: Adam Balogh Date: 2020-08-31T16:00:59+02:00 New Revision: 14dd0737822ba476803320a2ff37a1012174d312 URL: https://github.com/llvm/llvm-project/commit/14dd0737822ba476803320a2ff37a1012174d312 DIFF: https://github.com/llvm/llvm-project/commit/14dd0737822ba476803320a2ff37a1012174d312.diff L

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Driver/ToolChains/ZOS.h:25 + + bool isPICDefault() const override { return false; } + bool isPIEDefault() const override { return false; }

[PATCH] D86218: Teach the swift calling convention about _Atomic types

This revision was automatically updated to reflect the committed changes. Closed by commit rG41634497d4fd: Teach the swift calling convention about _Atomic types (authored by aschwaighofer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ h

[clang] 4163449 - Teach the swift calling convention about _Atomic types

Author: Arnold Schwaighofer Date: 2020-08-31T07:07:25-07:00 New Revision: 41634497d4fd21f28d08ac6f538ca4045f386c95 URL: https://github.com/llvm/llvm-project/commit/41634497d4fd21f28d08ac6f538ca4045f386c95 DIFF: https://github.com/llvm/llvm-project/commit/41634497d4fd21f28d08ac6f538ca4045f386c95

[PATCH] D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9a6e62ddff2: [CodeGen] Make sure the EH cleanup for block captures is conditional when the… (authored by erik.pilkington). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.o

[clang] a9a6e62 - [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context

Author: Erik Pilkington Date: 2020-08-31T10:12:17-04:00 New Revision: a9a6e62ddff21c597b82f0f6d26bca6a1a473a6f URL: https://github.com/llvm/llvm-project/commit/a9a6e62ddff21c597b82f0f6d26bca6a1a473a6f DIFF: https://github.com/llvm/llvm-project/commit/a9a6e62ddff21c597b82f0f6d26bca6a1a473a6f.dif

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1006 +return IntRangeVector{std::pair{b, *e}}; + return IntRangeVector{}; +} balazske wrote: > This return of empty vector and possibilit

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

martong updated this revision to Diff 288946. martong added a comment. - Add assert in getRanges Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86531/new/ https://reviews.llvm.org/D86531 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunction

[clang-tools-extra] 22808d6 - [clang-tidy] Buildbot failure fix for commit rGf5fd7486d6c0

Author: Adam Balogh Date: 2020-08-31T16:32:10+02:00 New Revision: 22808d693ef7f8cf61ceff506a320249a0bdb5ef URL: https://github.com/llvm/llvm-project/commit/22808d693ef7f8cf61ceff506a320249a0bdb5ef DIFF: https://github.com/llvm/llvm-project/commit/22808d693ef7f8cf61ceff506a320249a0bdb5ef.diff L

[PATCH] D85031: [builtins] Unify the softfloat division implementation

sepavloff added inline comments. Comment at: compiler-rt/lib/builtins/fp_div_impl.inc:109 + +#if NUMBER_OF_HALF_ITERATIONS > 0 + // Starting with (n-1) half-width iterations scanon wrote: > sepavloff wrote: > > atrosinenko wrote: > > > sepavloff wrote: > > > > I

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre created this revision. tambre added a reviewer: phosek. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. tambre requested review of this revision. When LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is set to ON the clang_rt.builtins will not have an architecture prefix and

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

martong added a comment. Just realized. There maybe cases when we'd like to give XMax to an arg constraint, but the type of the arg is Y (X may be a looked up type). One example for such is getchar, where the return type is Int, but we have a range constraint {0, UCharRangeMax}. Consequently, i

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

tambre updated this revision to Diff 288956. tambre added a comment. Add missing dash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D86877 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/ToolChains/

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

martong updated this revision to Diff 288957. martong added a comment. - Revert "Add assert in getRanges" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86531/new/ https://reviews.llvm.org/D86531 Files: clang/lib/StaticAnalyzer/Checkers/StdLibrar

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

jdoerfert added a comment. LG, @ABataev ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

martong updated this revision to Diff 288958. martong added a comment. - Rebase to correct base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86531/new/ https://reviews.llvm.org/D86531 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctions

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

eduucaldas updated this revision to Diff 288963. eduucaldas added a comment. Herald added a subscriber: mgorny. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86778/new/ https://reviews.llvm.org/D86778 Files: clang/include/clang/

[PATCH] D86880: [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. eduucaldas requested review of this revision. This change groups - Rename: `ignoreParenBaseCasts` -> `IgnoreParenBaseCasts` for uniformity - Re

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/IgnoreExpr.h:15 +namespace clang { +namespace { +/// Given an expression E and functions Fn_1,...,Fn_n : Expr * -> Expr *, ---

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

eduucaldas updated this revision to Diff 288965. eduucaldas added a comment. Fix lint problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86778/new/ https://reviews.llvm.org/D86778 Files: clang/include/clang/AST/IgnoreExpr.h clang/lib/AST/C

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 ___ c

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

gamesh411 added a comment. `CReduce` did not manage to produce any meaningful result after a week worth of runtime (more than ~2000 lines of code still remaining after reduction). We could track this down by tracing the ExprEngine code that assigns the Undefined SVal but that seems a huge effor

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

erik.pilkington created this revision. erik.pilkington added a reviewer: arphaman. Herald added subscribers: dang, ributzka, dexonsmith, jkorous. erik.pilkington requested review of this revision. This effectively disables https://reviews.llvm.org/D50968 on Darwin, and provides a command line fla

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar updated this revision to Diff 288972. vrnithinkumar added a comment. - Addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86027/new/ https://reviews.llvm.org/D86027 Files: clang/lib/StaticAnalyzer/Checkers/Sma

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar updated this revision to Diff 288974. vrnithinkumar added a comment. - Fixing minor spacing issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86027/new/ https://reviews.llvm.org/D86027 Files: clang/lib/StaticAnalyzer/Checkers/Sma

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar marked an inline comment as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:556 +const LocationContext *LC = C.getLocationContext(); +InnerPointerVal = C.getSValBuilder().conjureSymbolVal( +

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86027/new/ https://reviews.llvm.org/D86027

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

eduucaldas updated this revision to Diff 288978. eduucaldas marked an inline comment as done. eduucaldas added a comment. Answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86778/new/ https://reviews.llvm.org/D86778 Files: clang/inclu

[PATCH] D86820: [X86] Add a /tune: option for clang-cl

craig.topper added a comment. In D86820#2247336 , @hans wrote: > Would it be enough for users to specify /clang:-mtune instead? How does icc > spell its option? I didn't know you could spell it as /clang:-mtune. ICC has /tune: according to this docu

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

steakhal added a comment. In D85424#2247598 , @gamesh411 wrote: > `CReduce` did not manage to produce any meaningful result after a week worth > of runtime (more than ~2000 lines of code still remaining after reduction). > We could track this down by tra

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 288984. eduucaldas added a comment. Use `IgnoreExpr.h` infrastructure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cp

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

bruno added a comment. > Yes the wrapper is definitely problematic. I'm checking how the diagnostic > itself is handled correctly and start from there when I have time. For now > would it be better to separate this into multiple patches and get the > diagnostic improvement in first? Yep, tha

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 288987. eduucaldas added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/Sy

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 288988. eduucaldas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:48-58 +static Expr *IgnoreImplicitCXXConstructExpr(Expr *E) { + if (auto *C = dyn_cast(E)) { +auto NumArgs = C->getNumArgs(); +if (NumArgs == 1 |

[clang] bc3d4d9 - [analyzer] Add bool operator modeling for unque_ptr

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-08-31T19:25:33+02:00 New Revision: bc3d4d9ed783a3051125075f1a58ad619d8ea454 URL: https://github.com/llvm/llvm-project/commit/bc3d4d9ed783a3051125075f1a58ad619d8ea454 DIFF: https://github.com/llvm/llvm-project/commit/bc3d4d9ed783a3051125075f1

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc3d4d9ed783: [analyzer] Add bool operator modeling for unque_ptr (authored by vrnithinkumar). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma added a comment. > While the fix proper is trivial: just two lines in > lib/Driver/ToolChains/CommonArgs.cpp, finding the right place has been > nightmarishly difficult: I'd have expected handling of a Solaris/SPARC CPU > default in either of Solaris or SPARC specific files, but not de

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. GCC on Linux defines `__sparc_v9__` even with `-m32`. I don't know what Solaris does but please don't break other operating systems just because Solaris has broken headers that confl

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

jrtc27 added a comment. And notably _doesn't_ define the V8 macros, which this patch then reintroduces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-co

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx updated this revision to Diff 288995. chrish_ericsson_atx added a comment. Corrected formatting (per git-clang-format) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86796/new/ https://reviews.llvm.org/D86796 Files: clang/incl

[PATCH] D83984: Explicitly use utf-8 in send_string

trixirt added a comment. Yes, this break on py2, and py3 the change is a noop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984 ___ cfe-commits mailing list cfe-com

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:895 + if (!Self.getLangOpts().RTTIData) { +bool isMSVC = Self.getDiagnostics().getDiagnosticOptions().getFormat() == + DiagnosticOptions::MSVC; hans wrote: > zequanwu wr

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

yln added inline comments. Comment at: llvm/docs/CommandGuide/lit.rst:102 + + Alias for ``-v``/``--verbose`` (for backwards compatibility). .. option:: -a, --show-all blank line Comment at: llvm/utils/lit/lit/OutputSettings.py:34 +ONLY_FAILING

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:1703 - Controls whether Clang emits a label for each basic block. Further, with - values "all" and "list=arg", each basic block or a subset of basic blocks - can be placed in its own unique section. + Co

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

MaskRay added inline comments. Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:78 } else { + auto Prefix = Ctx.getAsmInfo()->getPrivateLabelPrefix(); CachedMCSymbol = Ctx.getOrCreateSymbol(Twine(Prefix) + "BB" + Expand `auto` https://llvm.org

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:552 [[::n::S s1]]; [[n::S s2]]; } Do we have tests for calling constructors w

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:48-58 +static Expr *IgnoreImplicitCXXConstructExpr(Expr *E) { + if (auto *C = dyn_cast(E)) { +auto NumArgs

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

phosek added a comment. This was discussed when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` was introduced and there was a pushback against changing the driver behavior depending on the value of that option, so if we're going to reverse that decision for BareMetal, I think that deserves a broader disc

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://reviews.llvm.org/D84988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

Re: [clang] 589ce5f - [DebugInfo] Move constructor homing case in shouldOmitDefinition.

On Mon, Aug 24, 2020 at 9:32 PM Voss, Matthew via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Amy, > > Looks like there's some test failures on the PS4 Linux bot as a result of > this commit. Could you take a look? If the failure persists for a while, I > may need to revert this to unclo

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko updated this revision to Diff 289022. atrosinenko added a comment. Update after the latest comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85031/new/ https://reviews.llvm.org/D85031 Files: compiler-rt/lib/builtins/divdf3.c

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko added a comment. Thank you very much for review! I have amended this diff based on the latest comment by @scanon. So, I will land D85031 and then D85032: [builtins] Make divXf3 handle denormal results if there are

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85473/new/ https://reviews.llvm.org/D85473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

leonardchan added a comment. *ping* @aaron.ballman. Would you be able to sign off on this? Otherwise, I'll probably commit this in the next few days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85924/new/ https://reviews.llvm.org/D85924 ___

[PATCH] D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`

kiranchandramohan added a comment. What is the plan for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85619/new/ https://reviews.llvm.org/D85619 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

kiranchandramohan added a comment. What is the plan for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79677/new/ https://reviews.llvm.org/D79677 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rjmccall added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:3387 Bits = (Bits << 1) | unsigned(II->isPoisoned()); -Bits = (Bits << 1) | unsigned(II->hasRevertedBuiltin()); +Bits <<= 1; // Previously used to indicate reverted builtin. Bits =

[PATCH] D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments. Comment at: clang/lib/Driver/ToolChains/ZOS.cpp:15 + +using namespace clang::driver; +using namespace clang::driver:

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

vsapsai created this revision. vsapsai added reviewers: bruno, rsmith, Bigcheese. Herald added subscribers: llvm-commits, ributzka, dexonsmith, jkorous, hiraditya. Herald added projects: clang, LLVM. vsapsai requested review of this revision. Measure amount of high-level or fixed-cost operations

[clang] d563d7a - [analyzer][NFC] Add `override` keyword missing from D86027

Author: Hubert Tong Date: 2020-08-31T17:57:22-04:00 New Revision: d563d7a7313cf47dcb24c6370a035bd803965b4e URL: https://github.com/llvm/llvm-project/commit/d563d7a7313cf47dcb24c6370a035bd803965b4e DIFF: https://github.com/llvm/llvm-project/commit/d563d7a7313cf47dcb24c6370a035bd803965b4e.diff L

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

fghanim added a comment. In D79677#2248197 , @kiranchandramohan wrote: > What is the plan for this patch? To commit it ... eventually :) Once it (and the rest in the series) get reviewed. As it stands, I cannot commit this patch without the rest in the

RE: [clang] 589ce5f - [DebugInfo] Move constructor homing case in shouldOmitDefinition.

Hi David and Amy, This change works for PS4. Build + test passes. Thanks, Matthew From: David Blaikie Sent: Monday, August 31, 2020 1:22 PM To: Voss, Matthew Cc: Amy Huang ; cfe-commits@lists.llvm.org Subject: Re: [clang] 589ce5f - [DebugInfo] Move constructor homing case in shouldOmitDefinit

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 289044. tianshilei1992 added a comment. Rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp Index:

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu updated this revision to Diff 289047. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://reviews.llvm.org/D84988 Files: clang/include/clang/Lex/Lexer.h clang/include/clang/Lex/Preprocess

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rsmith added a comment. In D77491#2246948 , @rjmccall wrote: > I'd still like @rsmith to sign off here as code owner. Generally, I'm happy with this direction. What happens for builtins with the "t" (custom typechecking) flag, for which the signature is

Buildbot numbers for the week of 08/09/2020 - 08/15/2020

Hello everyone, Below are some buildbot numbers for the week of 08/09/2020 - 08/15/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

  1   2   >