[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG97ccf93b3615: [SystemZ][z/OS] Add z/OS Target and define macros (authored by abhina.sreeskantharajan, committed by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:483 +llvm::raw_ostream &OS) { + BR.markInteresting(ThisRegion); + OS << "Smart

[PATCH] D86293: [analyzer] Add modeling of Eq operator in smart ptr

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks amazing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86293/new/ https://reviews.llvm.org/D86293 _

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille accepted this revision. serge-sans-paille added a comment. Sure, thanks for your patience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 ___ c

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Nit: Maybe we should mention `complex` support on nvptx devices. The rest looks good to me. Others might want to add stuff but we can merge this right away (IMHO) Repository: rG LLVM

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

MaskRay added inline comments. Comment at: clang/tools/driver/driver.cpp:537 + // When running in integrated-cc1 mode, the CrashRecoveryContext returns + // the same code as if the program crashed. On Unix, that is codes >128. + IsCrash |= CommandRes > 128; ---

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille added a comment. I'll need a contact email to preserve authorship information, can you send me one at `sguel...@redhat.com`? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 __

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

NoQ added a comment. No-no, recursive locks are much more complicated than that, please do them separately. You'll have to discriminate between a real double lock / double unlock bug and an actual valid use of the recursive mutex in order to emit any warnings at all. That's completely different

[PATCH] D86544: [SyntaxTree] Add support for call expressions

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:333 +/// call-arguments: +/// delimited_list(expression, ',', ) +/// Note: This construct is a simpli

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

rsmith added a comment. Have you considered using the `ext_vector_type` attribute instead of `vector_size` for this? That would have a couple of advantages: - It's not a GCC attribute, so there's no risk that GCC would give different meaning to the same syntax (such as using one byte per vector

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev updated this revision to Diff 287776. ABataev added a comment. + complex types for NVPTX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/Rele

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev added a comment. In D86562#2237215 , @jdoerfert wrote: > Nit: Maybe we should mention `complex` support on nvptx devices. Ok, will add. > The rest looks good to me. Others might want to add stuff That was the intention. > but we can merge this

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev updated this revision to Diff 28. ABataev added a comment. Misprint fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

MaskRay added inline comments. Comment at: clang/docs/LTOVisibility.rst:39 +During the LTO link, all classes with public LTO visibility will be refined +to hidden LTO visibility when the ``-lto-whole-program-visibility`` lld linker +option is applied (``-plugin-opt=whole-program-

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

dblaikie accepted this revision. dblaikie added a comment. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 ___ cfe-commits mailing list cfe-co

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

kkwli0 added a comment. `present` map type and motion modifier `default(firstprivate)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562 ___ cfe-commits mailing lis

[clang] 9500a72 - Revert "[Coverage] Enable emitting gap area between macros"

Author: Zequan Wu Date: 2020-08-25T15:28:42-07:00 New Revision: 9500a7209163d6bfce7d554cb71a7c189ca5de58 URL: https://github.com/llvm/llvm-project/commit/9500a7209163d6bfce7d554cb71a7c189ca5de58 DIFF: https://github.com/llvm/llvm-project/commit/9500a7209163d6bfce7d554cb71a7c189ca5de58.diff LOG

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev added a comment. In D86562#2237388 , @kkwli0 wrote: > `present` map type and motion modifier > `default(firstprivate)` Present was added after 11.0 branching. Not aure about default(firstprivate) Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

kkwli0 added a comment. `default(firstprivate)` was added in https://reviews.llvm.org/rG78443666bc18a6957d279a0f58319c8a3e57771a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. This looks good to me. I can't claim to have read the test case in detail. Some style suggestions inline around the vector, but they're not blocking. Comme

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

pcc added a comment. I think that the part of the description beginning "This can be used when..." is somewhat misleading since you could pretty much say the same thing about specifying `-fvisibility=hidden -fwhole-program-vtables` at compile time. I think it would be better to focus on the spe

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. The duplication from libc++ doesn't feel good but I can see how it happened. Dependency breaking etc. Comment at: clang/lib/Headers/openmp_wrappers/complex

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 updated this revision to Diff 287795. Bdragon28 added reviewers: MaskRay, dim. Bdragon28 added a comment. Herald added a subscriber: kbarton. Add some tests for the new target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ http

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8839e278ffca: [Modules] Improve error message when cannot find parent module for submodule… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 8839e27 - [Modules] Improve error message when cannot find parent module for submodule definition.

Author: Volodymyr Sapsai Date: 2020-08-25T16:31:27-07:00 New Revision: 8839e278ffcadc62b333423de07756488cae980f URL: https://github.com/llvm/llvm-project/commit/8839e278ffcadc62b333423de07756488cae980f DIFF: https://github.com/llvm/llvm-project/commit/8839e278ffcadc62b333423de07756488cae980f.di

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai marked an inline comment as done. vsapsai added a comment. Thanks for the review. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:700 + "no module named '%0' %select{found|in '%2'}1, " + "expected parent module to be defined before the submodule">; def er

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

jdoerfert added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/complex_cmath.h:58 + +template __DEVICE__ _Tp norm(const std::complex<_Tp> &__c) { + if (std::isinf(__c.real())) JonChesterfield wrote: > Doesn't matter hugely given inlining, but I'

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev added a comment. In D86562#2237399 , @kkwli0 wrote: > `default(firstprivate)` was added in > https://reviews.llvm.org/rG78443666bc18a6957d279a0f58319c8a3e57771a Yest, it was before clang 11 was branched, so need to add to the list of the changes

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10042 void ActOnFinishedFunctionDefinitionInOpenMPDeclareVariantScope( - FunctionDecl *FD, FunctionDecl *BaseFD); + Decl *D, SmallVectorImpl &Bases); JonChesterfield wrote:

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert marked 5 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10042 void ActOnFinishedFunctionDefinitionInOpenMPDeclareVariantScope( - FunctionDecl *FD, FunctionDecl *BaseFD); + Decl *D, SmallVectorImpl &Base

[PATCH] D82777: Clang Driver: Use Apple ld64's new @response-file support.

jyknight added a comment. BTW, to the apple folks here, it'd sure be awesome if this could be backported into XCode 12's clang. :) (c.f. FB7037642). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82777/new/ https://reviews.llvm.org/D82777

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

MaskRay added inline comments. Comment at: clang/test/Driver/freebsd.c:32 +// CHECK-PPC64LE: "--eh-frame-hdr" "-dynamic-linker" "{{.*}}ld-elf{{.*}}" "-o" "a.out" "{{.*}}crt1.o" "{{.*}}crti.o" "{{.*}}crtbegin.o" "-L[[SYSROOT]]/usr/lib" "{{.*}}.o" "-lgcc" "--as-needed" "-lgcc_s"

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher created this revision. Saldivarcher added a reviewer: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Saldivarcher requested review of this revision. In some situation shifts can be treated as a template, and is thus formatted as one. So, by doing

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added inline comments. Comment at: clang/test/Driver/freebsd.c:32 +// CHECK-PPC64LE: "--eh-frame-hdr" "-dynamic-linker" "{{.*}}ld-elf{{.*}}" "-o" "a.out" "{{.*}}crt1.o" "{{.*}}crti.o" "{{.*}}crtbegin.o" "-L[[SYSROOT]]/usr/lib" "{{.*}}.o" "-lgcc" "--as-needed" "-lgcc_s

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson marked an inline comment as done. tejohnson added a comment. In D75655#2237474 , @pcc wrote: > I think that the part of the description beginning "This can be used when..." > is somewhat misleading since you could pretty much say the same thing

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson updated this revision to Diff 287808. tejohnson marked an inline comment as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 Files: clang/docs/LT

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 updated this revision to Diff 287811. Bdragon28 added a comment. Use correct target for FreeBSD driver test. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425 Files: clan

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Thanks and sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 __

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

emaste added inline comments. Comment at: clang/lib/Basic/Targets.cpp:361-362 return new LinuxTargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); case llvm::Triple::NetBSD: List was previously

[PATCH] D86427: Fix some spelling errors

plotfi added a comment. In D86427#2235630 , @YangZhihui wrote: > how can I add the Author property in the patch > Thanks Is your email `yangzh.f...@cn.fujitsu.com` associated with a github account? If it is, this is all I need. Repository: rG LLVM G

[PATCH] D86427: Fix some spelling errors

YangZhihui added a comment. In D86427#2237668 , @plotfi wrote: > In D86427#2235630 , @YangZhihui > wrote: > >> how can I add the Author property in the patch >> Thanks > > Is your email `yangzh.f...@cn.fujitsu.com

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG72bdb41a06a2: [Docs] Document --lto-whole-program-visibility (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://revie

[clang] 72bdb41 - [Docs] Document --lto-whole-program-visibility

Author: Teresa Johnson Date: 2020-08-25T19:44:54-07:00 New Revision: 72bdb41a06a27b5453bf966a0ffecfa6f5fae1a6 URL: https://github.com/llvm/llvm-project/commit/72bdb41a06a27b5453bf966a0ffecfa6f5fae1a6 DIFF: https://github.com/llvm/llvm-project/commit/72bdb41a06a27b5453bf966a0ffecfa6f5fae1a6.diff

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson marked 18 inline comments as done. tejohnson added a comment. I think I've addressed all the comments. Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:48 +// Size of memory mapped to a single shadow location. +static const uint64_t DefaultShadowGranul

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson updated this revision to Diff 287832. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85948/new/ https://reviews.llvm.org/D85948 Files: clang/include

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu updated this revision to Diff 287835. zequanwu added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/incl

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas updated this revision to Diff 287842. eduucaldas marked 8 inline comments as done. eduucaldas added a comment. Answer code review, squash commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86544/new/ https://reviews.llvm.org/D86544 F

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1070 +Builder.markChildToken( +std::next(Builder.findToken(S->getCallee()->getEndLoc())), +syntax::NodeRole::OpenParen); gribozavr2 wrote: > Could you add an

<    1   2