[PATCH] D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/p10-vector-divide.ll:59 + +define <4 x i32> @test_vdivesw(<4 x i32> %a, <4 x i32> %b) { +; CHECK-LABEL: test_vdivesw: NeHuang wrote: > nit: do we also need `_intrinsic` in the name as the test ca

[clang-tools-extra] 15673d7 - [clangd] Index refs to main-file symbols as well

Author: Nathan Ridge Date: 2020-08-18T00:30:07-04:00 New Revision: 15673d748acd8f26bdeee18c0aa18f44c775d738 URL: https://github.com/llvm/llvm-project/commit/15673d748acd8f26bdeee18c0aa18f44c775d738 DIFF: https://github.com/llvm/llvm-project/commit/15673d748acd8f26bdeee18c0aa18f44c775d738.diff

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

This revision was automatically updated to reflect the committed changes. Closed by commit rG15673d748acd: [clangd] Index refs to main-file symbols as well (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D83536?vs=285920&id=286194#toc Repository: rG LLVM Github Monore

[clang] 00d7b7d - [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

Author: Nathan Ridge Date: 2020-08-18T00:32:34-04:00 New Revision: 00d7b7d014f90caef6f9c778614b09356bf0 URL: https://github.com/llvm/llvm-project/commit/00d7b7d014f90caef6f9c778614b09356bf0 DIFF: https://github.com/llvm/llvm-project/commit/00d7b7d014f90caef6f9c778614b09356bf0.diff

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

This revision was automatically updated to reflect the committed changes. nridge marked an inline comment as done. Closed by commit rG00d7b7d014f9: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter (authored by nridge). Changed prior to commit: https://reviews.llvm.or

[PATCH] D86047: [clangd] Target member of dependent base made visible via a using-decl

nridge updated this revision to Diff 286198. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86047/new/ https://reviews.llvm.org/D86047 Files: clang-tools-ext

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

CodaFi updated this revision to Diff 286201. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85981/new/ https://reviews.llvm.org/D85981 Files: clang/include/clang/Serialization/ModuleManager.h clang/lib/Serialization/ModuleManager.cpp Index: cla

[PATCH] D85981: [clang][Modules] Use File Names Instead of inodes As Loaded Module Keys

CodaFi added a comment. Figured it out for myself. The test is forming paths that are using non-canonical path separators. Naively using those as keys means that the subsequent canonicalization done by the ASTWriter renders the keys useless for lookups into these structures. I'm going to switch

[PATCH] D85808: [remarks] Optimization remarks hotness filtering from profile summary

weiwang updated this revision to Diff 286203. weiwang added a comment. update: 1. reorganize code splitting with parent diff. 2. format and style change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 Fil

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 286204. weiwang added a comment. move some unrelated change into parent diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/Driver

[PATCH] D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls

sepavloff added inline comments. Comment at: compiler-rt/test/builtins/Unit/divdf3_test.c:29-34 +// qNaN / any = qNaN +if (test__divdf3(makeQNaN64(), 3., UINT64_C(0x7ff8))) + return 1; +// NaN / any = NaN +if (test__divdf3(makeNaN64(UINT64_C(0x123

<    1   2