[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp:27-31 + createHTMLDiagnosticConsumer( + DiagOpts, C, std::string(llvm::sys::path::parent_path(Prefix)), PP, CTU); + createPlistMultiFileDiagnosticConsumer(DiagOpts, C, Prefix, PP,

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

nikic added a comment. The regression here seems to be because operations on an empty GraphDiff don't optimize out. Not going through GraphDiff but using the same basic logic (https://github.com/llvm/llvm-project/commit/4c6a5de8131183ff88f52cc3dda67180e31501a1 -- going through a separate method

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285273. eduucaldas marked 11 inline comments as done. eduucaldas added a comment. Answer review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 Files: cla

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2805 -TEST_P(SyntaxTreeTest, UserDefinedBinaryOperator) { +TEST_P(SyntaxTreeTest, UserDefinedOperator_Assignment) { if (!GetParam().isCXX()) { gribozavr2 wrote: > UserD

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5 and default - Part 1

saiislam added a comment. Time for check-clang has increased from ~51 sec to ~107 sec after this patch. Putting it here before committing/closing the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/ https://reviews.llvm.org/D84844

[clang] eaa341f - [OpenMP] Ensure testing for versions 4.5 and default - Part 1

Author: Saiyedul Islam Date: 2020-08-13T07:37:10Z New Revision: eaa341fbea961894759355256d25d785509002ef URL: https://github.com/llvm/llvm-project/commit/eaa341fbea961894759355256d25d785509002ef DIFF: https://github.com/llvm/llvm-project/commit/eaa341fbea961894759355256d25d785509002ef.diff LOG

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5 and default - Part 1

This revision was automatically updated to reflect the committed changes. Closed by commit rGeaa341fbea96: [OpenMP] Ensure testing for versions 4.5 and default - Part 1 (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/

[clang] c286d6f - [Parser] Suppress -Wempty-translation-unit if this is a header file

Author: Sam McCall Date: 2020-08-13T09:43:27+02:00 New Revision: c286d6fdeeb2b103777d3ae8c9de84937cb51efe URL: https://github.com/llvm/llvm-project/commit/c286d6fdeeb2b103777d3ae8c9de84937cb51efe DIFF: https://github.com/llvm/llvm-project/commit/c286d6fdeeb2b103777d3ae8c9de84937cb51efe.diff LO

[PATCH] D85789: [Parser] Suppress -Wempty-translation-unit if this is a header file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc286d6fdeeb2: [Parser] Suppress -Wempty-translation-unit if this is a header file (authored by sammccall). Repository: rG LLVM Github Monorepo CH

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1546-1548 +unsigned operator "" _r(const char*); +template +unsigned operator "" _t(); eduucaldas wrote: > Same setup for `FloatUserDefinedLiteral`. I think it is justified

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added a comment. We'll split this file in a future change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro added a comment. Ping^2? It's been two weeks now and with having to specify `-DCLANG_DEFAULT_LINKER=/usr/bin/ld ` as a workaround, many tests `FAIL` on Solaris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84029/new/ https://reviews.llvm.org

[PATCH] D85819: [SyntaxTree] Split tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1211fd1ec03: [SyntaxTree] Split tests for expressions (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D85819?vs=28527

[clang] d1211fd - [SyntaxTree] Split tests for expressions

Author: Eduardo Caldas Date: 2020-08-13T08:18:14Z New Revision: d1211fd1ec037f88c2cc855bc850200948c76940 URL: https://github.com/llvm/llvm-project/commit/d1211fd1ec037f88c2cc855bc850200948c76940 DIFF: https://github.com/llvm/llvm-project/commit/d1211fd1ec037f88c2cc855bc850200948c76940.diff LOG

[clang] 833c2b6 - [SyntaxTree] Rename tests following `TestSuite_TestCase` + nits

Author: Eduardo Caldas Date: 2020-08-13T08:18:14Z New Revision: 833c2b6be26bcdf90aac2f6de6e345bcd858149e URL: https://github.com/llvm/llvm-project/commit/833c2b6be26bcdf90aac2f6de6e345bcd858149e DIFF: https://github.com/llvm/llvm-project/commit/833c2b6be26bcdf90aac2f6de6e345bcd858149e.diff LOG

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 285282. simoll added a comment. - Fixed type printing & added type printing test. - Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/Language

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

gamesh411 added a comment. Aside from infrastructural questions which I am not qualified ( nor particularly knowledgeable :3 ) to address, this looks good to me. Comment at: clang/lib/StaticAnalyzer/Checkers/STLAlgorithmModeling.cpp:77 + unsigned ArgNum = 999; + --

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

lebedev.ri updated this revision to Diff 285283. lebedev.ri added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix (overstepping) clang test being affected by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = aar

[PATCH] D85883: [clangd] Add ClangdServer::customAction() extension point

sammccall created this revision. sammccall added reviewers: adamcz, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This lets basic AST-consu

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 285285. c-rhodes marked an inline comment as not done. c-rhodes added a comment. Address @rsandifo-arm comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85736/new/ https://reviews.llvm.org/D85736 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

martong updated this revision to Diff 285289. martong marked 2 inline comments as done. martong added a comment. - Handle minimum buffer sizes - Fix copy paste error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84248/new/ https://reviews.llvm.org/

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:2040 + +if (ConstStructTimevalPtrTy && StructTimespecPtrTy) + // int nanosleep(const struct timespec *rqtp, struct timespec *rmtp); balazske wrot

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

whisperity added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:289 + for (QualType CastToTy: CastToTyVec) { +if (CastFromTy->isPointerType()) + CastToTy = C.getASTContext().getPointerType(CastToTy); NoQ wrote: > Hmm

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

c-rhodes marked 4 inline comments as done. c-rhodes added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1941 +// Adjust the alignment for fixed-length SVE predicates. +if (VT->getVectorKind() == VectorType::SveFixedLengthPredicateVector) + Align = 16; ---

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84248/new/ https://reviews.llvm.org/D84248

[PATCH] D85883: [clangd] Add ClangdServer::customAction() extension point

kadircet added a comment. mostly looks good to me, as discussed offline I would rather expose AST within a thread, both to keep the API changes to a minimum in the future and possibly indicating the "view-ness" of the exposed structs like AST more explicitly. Repository: rG LLVM Github Monor

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85031/new/ https://reviews.llvm.org/D85031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D85032: [builtins] Make divXf3 handle denormal results

atrosinenko added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85032/new/ https://reviews.llvm.org/D85032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware updated this revision to Diff 285309. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81272/new/ https://reviews.llvm.org/D81272 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-too

[clang-tools-extra] 32626bc - [clangd] Add ClangdServer::customAction() extension point

Author: Sam McCall Date: 2020-08-13T12:26:32+02:00 New Revision: 32626bcc0b9b1180db7eebc46c45faff7905bd05 URL: https://github.com/llvm/llvm-project/commit/32626bcc0b9b1180db7eebc46c45faff7905bd05 DIFF: https://github.com/llvm/llvm-project/commit/32626bcc0b9b1180db7eebc46c45faff7905bd05.diff LO

[PATCH] D85883: [clangd] Add ClangdServer::customAction() extension point

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG32626bcc0b9b: [clangd] Add ClangdServer::customAction() extension point (authored by sammccall). Changed prior to commit:

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:46 +CheckFactories.registerCheck( +"misc-redundant-condition"); CheckFactories.registerCheck( -

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 285326. baloghadamsoftware added a comment. Updated according to the latest comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cp

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/STLAlgorithmModeling.cpp:77 + unsigned ArgNum = 999; + gamesh411 wrote: > 999 seems a bit arbitrary here, consider usin

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added a comment. @NoQ Thank you for the review. Please also review D85752 after my update and tell me what I have to change there if it is not acceptable yet. This patch depends on that one.

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

baloghadamsoftware added a comment. @NoQ Could you please take a look on this one? It is a fix of my earlier work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85351/new/ https://reviews.llvm.org/D85351 ___

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 285329. MForster added a comment. Rebase before submission Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/c

[PATCH] D62574: Add support for target-configurable address spaces.

Anastasia added a comment. In D62574#2210503 , @ebevhan wrote: > I think this works now. It should probably be given a few more reviewers to > have a look. Do you have some suggestions, @Anastasia ? Great! I will look at this again within a week or so. I

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss updated this revision to Diff 285332. danielkiss added a comment. Always emit xpac* instructions as discussed in D84502 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 Files: llvm/include/llvm/Cod

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a comment. The patch looks great. I guess the only remaining discussion remains as to whether this should be in `libAnalysis`, or somewhere else. Here is my take: Since clang-tidy, CSA, and some other parts of the compiler (like uninitialized variable warnings) are static analyz

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Tests c: I'm still not a huge fan of the warning message. Now it describes //what kind// of constraint was violated, but not //how// (too large? too small?). Also, while I res

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

paulwalker-arm updated this revision to Diff 285336. paulwalker-arm added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71767/new/ https://reviews.llvm.org/D71767 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/lib/CodeGen/

[PATCH] D85883: [clangd] Add ClangdServer::customAction() extension point

sammccall added a comment. Oops sorry, misread "mostly lgtm" and committed. Changed to use the "InputsAndAST" struct to provide the rest of the info. Happy to address any further comments... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85883/new/

[clang-tools-extra] 41d0edd - [clangd] Express dumpAST in tests as a customAction()

Author: Sam McCall Date: 2020-08-13T14:27:32+02:00 New Revision: 41d0edd54e29e994fa7d40961a38e8fca27addac URL: https://github.com/llvm/llvm-project/commit/41d0edd54e29e994fa7d40961a38e8fca27addac DIFF: https://github.com/llvm/llvm-project/commit/41d0edd54e29e994fa7d40961a38e8fca27addac.diff LO

[PATCH] D85883: [clangd] Add ClangdServer::customAction() extension point

kadircet added a comment. no I am totally fine with the change. I just wanted to give Adam some time to take a look too :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85883/new/ https://reviews.llvm.org/D85883 __

[PATCH] D85883: [clangd] Add ClangdServer::customAction() extension point

sammccall added a comment. Yup sorry @adamcz, I was just confused. Likewise, happy to change to a different structure or revert entirely if you have concerns. 41d0edd54e29e994fa7d40961a38e8fca27addac eliminates dumpAST based

[PATCH] D85896: [SyntaxTree] Split `TreeTest.cpp`

eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. We extract the test infrastructure into `TreeTestBase.h` and split the tests into `MutationsTest.cpp` and `BuildTreeTest.cpp` Repository:

[PATCH] D85897: [SyntaxTree] Split `TreeTest.cpp`

eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. We extract the test infrastructure into `TreeTestBase.h` and split the tests into `MutationsTest.cpp` and `BuildTreeTest.cpp` Repository:

[PATCH] D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85898 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp clang/unittests

[PATCH] D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

eduucaldas updated this revision to Diff 285342. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85898/new/ https://reviews.llvm.org/D85898 Files: clang/unittests/Tooling/Syntax/MutationsTest.cpp clang/unittests/Too

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:46 +CheckFactories.registerCheck( +"misc-redundant-condition"); CheckFactories.registerCheck( baloghadamsoftware wrote: > aaron.ballman wrote: >

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = ---

[PATCH] D85897: [SyntaxTree] Split `TreeTest.cpp`

eduucaldas added a comment. We can further split `BuildTreeTest.cpp` for instance in `BuildStatementTest.cpp` and `BuildDeclTest.cpp`, I can't see many arguments towards that though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85897/new/ https:

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

JesperAntonsson added a comment. Hi, In our local Jenkins machinery, the UndefOfModuleMacro test fails on master when built with gcc. Pasting the crash dump below. Any ideas? BR /Jesper 12:24:39 FAIL: Clangd Unit Tests :: ./ClangdTests/SymbolCollectorTest.UndefOfModuleMacro (31492 of 65755)

[PATCH] D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.h:14 #include "clang/AST/ASTConsumer.h" -#include "clang/AST/Decl.h" -#include "clang/AST/Stmt.h" #include "clang/Basic/LLVM.h" #include "clang/Fr

[PATCH] D85450: Support the standards-based dates for __has_c_attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm accepting these changes on my own authority as code owner; if there are issues, I'll deal with them post-commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85450/

[clang] 9936b96 - Support the standards-based dates for __has_c_attribute

Author: Aaron Ballman Date: 2020-08-13T08:47:40-04:00 New Revision: 9936b96d5333af4e6dff55025943366bb5f07272 URL: https://github.com/llvm/llvm-project/commit/9936b96d5333af4e6dff55025943366bb5f07272 DIFF: https://github.com/llvm/llvm-project/commit/9936b96d5333af4e6dff55025943366bb5f07272.diff

[PATCH] D85450: Support the standards-based dates for __has_c_attribute

aaron.ballman closed this revision. aaron.ballman added a comment. Changes committed in 9936b96d5333af4e6dff55025943366bb5f07272 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85450/new/ https://reviews.llvm.org/D8545

[PATCH] D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.h:14 #include "clang/AST/ASTConsumer.h" -#include "clang/AST/Decl.h" -#include "clang/AST/Stmt.h" #inclu

[PATCH] D85897: [SyntaxTree] Split `TreeTest.cpp`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:16 +namespace clang { +namespace syntax_test { namespace { Ditto, please use namesp

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

Szelethus added reviewers: NoQ, vsavchenko. Szelethus accepted this revision. Szelethus added a comment. Lets make sure we invite the wider community to see whats going on. Otherwise, LGTM! It seems like this patch adds two new additions at once -- infrastructure for when the arg constraint siz

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

Szelethus added a comment. Shouldn't we create a new test care for this, instead of expanding an existing one? Btw, this looks great, but I lack the confidence to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85351/new/ https://reviews.llv

[clang] a5b8757 - Introduce ns_error_domain attribute.

Author: Michael Forster Date: 2020-08-13T15:05:12+02:00 New Revision: a5b8757506b07e3091fe243b6c1e004220d3cba3 URL: https://github.com/llvm/llvm-project/commit/a5b8757506b07e3091fe243b6c1e004220d3cba3 DIFF: https://github.com/llvm/llvm-project/commit/a5b8757506b07e3091fe243b6c1e004220d3cba3.dif

[PATCH] D84005: Introduce ns_error_domain attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5b8757506b0: Introduce ns_error_domain attribute. (authored by MForster, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

balazske added a comment. There is a TODO comment at the error message, it needs improvement. The current form is still something for developers, not for end users. For final version I would accept textual descriptions (as mentioned above), not names like "BufferSize" and words like "ArgN" insi

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:46 +CheckFactories.registerCheck( +"misc-redundant-condition"); CheckFactories.registerCheck( aaron.ballman wrote: > baloghadamsoftware wro

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

Szelethus added a comment. Ah, okay, silly me. Didn't catch that. Then the message is OK for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79431/new/ https://reviews.llvm.org/D79431 ___ cfe-commits

[clang] d17437d - [SyntaxTree] Split `TreeTest.cpp`

Author: Eduardo Caldas Date: 2020-08-13T13:30:57Z New Revision: d17437d2bd8e83baee96f2860276d615d216dfbc URL: https://github.com/llvm/llvm-project/commit/d17437d2bd8e83baee96f2860276d615d216dfbc DIFF: https://github.com/llvm/llvm-project/commit/d17437d2bd8e83baee96f2860276d615d216dfbc.diff LOG

[clang] 9c2e708 - [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

Author: Eduardo Caldas Date: 2020-08-13T13:30:57Z New Revision: 9c2e708f0dc547d386ea528450a33ef4bd2a750b URL: https://github.com/llvm/llvm-project/commit/9c2e708f0dc547d386ea528450a33ef4bd2a750b DIFF: https://github.com/llvm/llvm-project/commit/9c2e708f0dc547d386ea528450a33ef4bd2a750b.diff LOG

[PATCH] D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c2e708f0dc5: [SyntaxTree] Clean `#includes` in `TreeTestBase.h` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D8589

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

fanbo-meng requested changes to this revision. fanbo-meng added a comment. This revision now requires changes to proceed. Can you modify `clang/test/Frontend/trigraphs.cpp` and `clang/test/Lexer/cxx1z-trigraphs.cpp` ? These tests are assuming trigraphs are disabled by `-std=gnu++11 -fms-compatib

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz added a comment. This is quite strange. I can't reproduce this with gcc 7.5.0, 9.3.0 or 10.0.1. Which version are you using? There are bugs around clangd + modules + diagnostics. I'm fixing one in https://reviews.llvm.org/D85753 (not in it's final form yet), but it doesn't seem to be th

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

vsavchenko updated this revision to Diff 285358. vsavchenko added a comment. Simplify the main test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https://reviews.llvm.org/D85817 Files: clang/include/clang/StaticAnalyzer/Core/PathSensi

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

vsavchenko updated this revision to Diff 285360. vsavchenko added a comment. Add "no crash" comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https://reviews.llvm.org/D85817 Files: clang/include/clang/StaticAnalyzer/Core/PathSens

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

abhina.sreeskantharajan updated this revision to Diff 285362. abhina.sreeskantharajan added a comment. Thanks Hubert and Fanbo for reviewing. I updated the comment to Hubert's suggestion, and updated both testcases as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84005: Introduce ns_error_domain attribute.

thakis added a comment. Looks like this breaks check-clangd on Windows: http://45.33.8.238/win/21943/step_9.txt Please take a look, and revert while you investigate if the fix takes a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong added reviewers: NoQ, vsavchenko. martong added subscribers: vsavchenko, NoQ. martong added a comment. @NoQ, @vsavchenko My apologies, somehow I forgot to add you as reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https:

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

martong added a comment. @NoQ, @vsavchenko My apologies, somehow I forgot to add you as reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84248/new/ https://reviews.llvm.org/D84248 ___ cfe-commits

[clang] 82057e3 - clang: Fix minor grammar-o in diag added in c354b2e3b

Author: Nico Weber Date: 2020-08-13T10:06:40-04:00 New Revision: 82057e3f39e624dbaa5bbd7497c359f704347f6f URL: https://github.com/llvm/llvm-project/commit/82057e3f39e624dbaa5bbd7497c359f704347f6f DIFF: https://github.com/llvm/llvm-project/commit/82057e3f39e624dbaa5bbd7497c359f704347f6f.diff LO

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

abhina.sreeskantharajan marked 3 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2791 + Opts.Trigraphs = + (!Opts.GNUMode && !Opts.MSVCCompat && !Opts.CPlusPlus17) || T.isOSzOS(); Opts.Trigraph

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:46 +CheckFactories.registerCheck( +"misc-redundant-condition"); CheckFactories.registerCheck( baloghadamsoftware wrote: > aaron.ballman wrote: >

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware updated this revision to Diff 285366. baloghadamsoftware added a comment. Since no better idea cam to my mind, in this version I check whether `modernize-use-default-member-init` is enabled. If it is, then we issue a warning and suggest a fix that uses default member initializ

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:113 + +// Set of clang-tidy checks that are not suitable to be run through clangd, +// either due to crashes o

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = ---

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = aa

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

bjope added a comment. In D80525#2215641 , @adamcz wrote: > This is quite strange. I can't reproduce this with gcc 7.5.0, 9.3.0 or > 10.0.1. Which version are you using? > > There are bugs around clangd + modules + diagnostics. I'm fixing one in > https:

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

aaron.ballman added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:120 + // clangd doesn't replay those when using a preamble. + "-llvm-header-guard"); + static const std::string CrashingChecks = ---

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

bjope added a comment. Might be that it is some other commit that cause the problem. Looking a bit closer at the jenkins history it seems like the tests passed once after this patch was added. But the next time it failed. That second time the "[Diagnoostics] Reworked -Wstring-concatenation" com

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz added a comment. In D80525#2215755 , @bjope wrote: > In D80525#2215641 , @adamcz wrote: > >> This is quite strange. I can't reproduce this with gcc 7.5.0, 9.3.0 or >> 10.0.1. Which version are you using? >>

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

lebedev.ri updated this revision to Diff 285371. lebedev.ri added a comment. Drop unneeded header include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85787/new/ https://reviews.llvm.org/D85787 Files: clang/test/CodeGenCXX/nrvo.cpp llvm/lib/

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:46 +CheckFactories.registerCheck( +"misc-redundant-condition"); CheckFactories.registerCheck( aaron.ballman wrote: > baloghadamsoftware wro

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz added a comment. Looks like it's an issue with not clearing the module cache. I'll revert this change to fix the build, then re-submit with proper fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80525/new/ https://reviews.llvm.org/D80525

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

vsavchenko added a comment. Off-topic: I really think that we should have some sort of DSL for that kind of stuff. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:2013 +if (Pthread_tTy) { + Pthread_tPtrTy = ACtx.getPointerType(*Pthread_tT

[PATCH] D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/test/Lexer/cxx1z-trigraphs.cpp:24 +// notri-warning@6 {{trigraph converted}} tri-warning@6 {{trigraph converted}} +// notri-warning@12 {{backslash and newline separated by space}} tri-warning@12 {{backslash and newl

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. In D84005#2215685 , @thakis wrote: > Looks like this breaks check-clangd on Windows: > http://45.33.8.238/win/21943/step_9.txt Update from an offline conversation: This may actually be rather an issue with the test, which was i

[PATCH] D85312: [ADT] Move FixedPoint.h from Clang to LLVM.

ebevhan added a comment. Thanks for reviewing! I'm not really sure who to add as reviewers for D85314 , though, and no one has replied to the RFC on the mailing list yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 9cbfdde - [analyzer] Fix crash with pointer to members values

Author: Valeriy Savchenko Date: 2020-08-13T18:03:59+03:00 New Revision: 9cbfdde2ea060d7e51fd2637f63eaa74b8d92848 URL: https://github.com/llvm/llvm-project/commit/9cbfdde2ea060d7e51fd2637f63eaa74b8d92848 DIFF: https://github.com/llvm/llvm-project/commit/9cbfdde2ea060d7e51fd2637f63eaa74b8d92848.d

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cbfdde2ea06: [analyzer] Fix crash with pointer to members values (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https:/

[PATCH] D85907: [clangd] Revert "[clangd] Fix crash-bug in preamble indexing when using modules."

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This reverts commit 4061d9e42c

  1   2   3   >