[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

vrnithinkumar created this revision. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. vrnithinkumar requested review of this revision. Fixing tests Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85796 Files: clang/include/clang/StaticAnalyzer/Co

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added a comment. Looks good in general. Mostly C++ style comments below. Comment at: clang/include/clang/Basic/TargetID.h:30 +/// Returns canonical processor name or empty if the processor name is invalid. +llvm::StringRef getProcessorFromTargetID(const llvm::Triple &T, +

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM from me if XRay actually does work on non-x86_64 macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85773/new/ https://reviews.llvm.org

[clang] b9af72b - [Diagnostics] Reworked -Wstring-concatenation

Author: Dávid Bolvanský Date: 2020-08-12T02:18:01+02:00 New Revision: b9af72bffe5f2769f3a7858a785981f89137a0ce URL: https://github.com/llvm/llvm-project/commit/b9af72bffe5f2769f3a7858a785981f89137a0ce DIFF: https://github.com/llvm/llvm-project/commit/b9af72bffe5f2769f3a7858a785981f89137a0ce.dif

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Reworked ;) Now it should ignore structs properly. ut 11. 8. 2020 o 22:03 Arthur O'Dwyer napísal(a): > > Dávid: Please just disable it for initializers of structs. That seems to be > the common denominator in all the false positives I've observed on this > thread. > > > On Tue, Aug 11, 2020 at

[PATCH] D85798: Split Preprocessor/init.c test. NFC.

tra created this revision. tra added a reviewer: MaskRay. Herald added subscribers: sanjoy.google, mstorsjo, jfb, atanasyan, bixia, jrtc27, kbarton, krytarowski, nemanjai. Herald added a project: clang. tra requested review of this revision. Herald added a subscriber: wuzish. Some parts of the te

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:210 GetClangTidyOptions(*TFS.view(/*CWD=*/llvm::None), File); + if (!Opts.ClangTidyOpts.Checks) { +// If the user hasn't configured clang-tidy checks at all, including

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

NoQ added a comment. Thanks!! I'm having second thoughts on re-using the existing builder. Most other `runCheckers...()` methods are building their own. Given how confusing this entire node builder business is, i believe we should not deviate from known working patterns. Please forgive me if

[PATCH] D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on.

akhuang created this revision. akhuang added reviewers: dblaikie, aprantl, MaskRay. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. akhuang requested review of this revision. This adds a cc1 flag to enable constructor homing but doesn't turn on debug info if it wasn't e

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, rjmccall, rsmith, pcc, hansec. leonardchan added a project: clang. Herald added subscribers: dang, dschuff. leonardchan requested review of this revision. Herald added a subscriber: aheejin. This implements the flag

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

craig.topper added a comment. In D83273#2195033 , @nickdesaulniers wrote: > In D83273#2194869 , @echristo wrote: > >> That said, it's a 10% compile time regression for compiling something like >> the linux kernel

[PATCH] D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h

OikawaKirie updated this revision to Diff 284952. OikawaKirie marked an inline comment as done. OikawaKirie added a comment. Now it has a link to the `getEndPath`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85105/new/ https://reviews.llvm.org/D85105 Files: clang/include/clang/Stat

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

jdoerfert updated this revision to Diff 284954. jdoerfert added a comment. Reintroduce requires-target into tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85777/new/ https://reviews.llvm.org/D85777 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

mgorny added a comment. In D74051#2211869 , @tstellar wrote: > In D74051#2017115 , @mgorny wrote: > >> Nevermind, I figured out good enough workaround. > > What was the workaround? Unpack `llvm/utils/{UpdateTestChe

[PATCH] D85755: [OPENMP]Do not add TGT_OMP_TARGET_PARAM flag to non-captured mapped arguments.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I don't follow this logic but that is not going to change right now. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85755/new/ https:/

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

jdoerfert added a comment. I think the test fail because D85735 was not part of the build. Works locally just fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85777/new/ https://reviews.llvm.org/D85777 ___

[PATCH] D85710: Code generation support for lvalue bit-field conditionals.

rjmccall added a comment. I always imagined that we'd implement this by just inverting the emission: emit the RHS of the assignment and then pass a callback down to a function that descended into conditional operators and called the callback when it hit a leaf. Having an LValue case that's an

[clang] 31e5f71 - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-08-11T20:22:11-07:00 New Revision: 31e5f7120bdd2f76337686d9d169b1c00e6ee69c URL: https://github.com/llvm/llvm-project/commit/31e5f7120bdd2f76337686d9d169b1c00e6ee69c DIFF: https://github.com/llvm/llvm-project/commit/31e5f7120bdd2f76337686d9d169b1c00e6ee69c.diff LO

[PATCH] D85806: [WebAssembly] Don't depend on the flags set by handleTargetFeatures in initFeatureMap.

craig.topper created this revision. craig.topper added a reviewer: tlively. Herald added subscribers: jfb, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. craig.topper requested review of this revision. Herald added a subscriber: aheejin. Properly set "simd128" in the fe

[PATCH] D84886: Create LoopNestPass

TaWeiTu added a comment. @ychen Again, thanks for your comment! 1. Currently, `LoopInterchange` returns immediately if the loop is not a top-level one. The main purpose of the loop nest pass is to prevent situations like this and possibly save compiling time of uninteresting calls to `run`. 2.

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. Are you planning to add support for the actual OpenMP selectors as well? All the other traits, scoring, etc. I left a comment below that points you to the right place as we have almost all

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert updated this revision to Diff 284961. jdoerfert added a comment. Update for @alokmishra.besu via arcanist as the webinterface doesn't allow patches over 2MB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.or

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84457/new/ https://reviews.llvm.org/D84457 ___

[PATCH] D85807: [Target] Cache the command line derived feature map in TargetOptions.

craig.topper created this revision. craig.topper added reviewers: echristo, erichkeane, nickdesaulniers. Herald added a project: clang. craig.topper requested review of this revision. We can use this to remove some calls to initFeatureMap from Sema and CodeGen when a function doesn't have a target

[PATCH] D85543: Limit Max Vector alignment on COFF targets to 8192

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85543/new/ https://reviews.llvm.org/D85543 ___ cfe-commits mailing list cfe

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

nridge accepted this revision. nridge added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/ExprCXX.h:4582 +if (isLeftFold()) + return getEllipsisLoc(); +return getLHS()->getBeginLoc(); Can this c

[PATCH] D85808: [remarks] Optimization remarks hotness filetering from profile summary

weiwang created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, hiraditya, eraman, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added projects: clang, LLVM. weiwang requested review of this revisi

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. weiwang requested review of this revision. Propagate driver commandline remarks options to link. Pass-through happens when: 1. LTO is enabled; 2. Single arch target is specified; 3. Th

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang added reviewers: wenlei, hoyFB. weiwang added a comment. This is the the 2nd of 3 dependent patches: 1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809 2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810 3. [remarks] Optimization

[PATCH] D85808: [remarks] Optimization remarks hotness filetering from profile summary

weiwang added reviewers: wenlei, hoyFB. weiwang added a comment. This is the the 3rd of 3 dependent patches: 1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809 2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810 3. [remarks] Optimization

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang abandoned this revision. weiwang added a comment. Diff has been split into 3 smaller ones: 1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809 2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810 3. [remarks] Optimization remarks h

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

This revision was automatically updated to reflect the committed changes. Closed by commit rG97ce7fd89fcc: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+" (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D85099?vs=284543&id=284972#toc Repository:

[clang] 97ce7fd - [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

Author: Johannes Doerfert Date: 2020-08-12T01:04:16-05:00 New Revision: 97ce7fd89fcc92d84c1938108388f735d55d372c URL: https://github.com/llvm/llvm-project/commit/97ce7fd89fcc92d84c1938108388f735d55d372c DIFF: https://github.com/llvm/llvm-project/commit/97ce7fd89fcc92d84c1938108388f735d55d372c.d

[PATCH] D85150: [OpenMP] Ensure testing for versions 4.5 and default - Part 2

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85150/new/ https://reviews.llvm.org/D85150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85214/new/ https://reviews.llvm.org/D85214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

<    1   2   3