[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. In D80791#2206853 , @nsz wrote: > i think that cannot work. > > the implementation is free to inject arbitrary code into > user code so if the user does not tell the implementation > that it wants the entire tu to be bti safe then no

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

paulwalker-arm added a comment. @cameron.mcinally this is the patch I mentioned the other day, which contains the nodes where once I've written suitable tests I'll push separate patches for. Anything else is fair game. This patch implements VSELECT but that was just to investigate what we tal

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrorReturnChecker.cpp:63 + const BinaryOperator *BinOp, + const llvm::APSInt

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas updated this revision to Diff 284387. eduucaldas marked 6 inline comments as done and 2 inline comments as done. eduucaldas added a comment. Answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85439/new/ https://reviews.llvm.or

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz updated this revision to Diff 284390. adamcz added a comment. assert() -> ASSERT_TRUE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85532/new/ https://reviews.llvm.org/D85532 Files: clang-tools-extra/clangd/unittests/CMakeLists.txt clan

[clang] 7406eb4 - [Hexagon] Avoid creating an empty target feature

Author: Krzysztof Parzyszek Date: 2020-08-10T10:37:24-05:00 New Revision: 7406eb4f6afd8df9bd4dbb918f5e7005ba71d58c URL: https://github.com/llvm/llvm-project/commit/7406eb4f6afd8df9bd4dbb918f5e7005ba71d58c DIFF: https://github.com/llvm/llvm-project/commit/7406eb4f6afd8df9bd4dbb918f5e7005ba71d58c

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

alexfh accepted this revision. alexfh added a comment. LG with a couple of comments. Do you need someone to land the patch for you? Comment at: clang-tools-extra/clang-tidy/add_new_check.py:139 const auto *MatchedDecl = Result.Nodes.getNodeAs("x"); - if (MatchedDecl->getNam

[clang] f9500cc - [SyntaxTree] Expand support for `NestedNameSpecifier`

Author: Eduardo Caldas Date: 2020-08-10T15:47:20Z New Revision: f9500cc487573c55ea37b4ee6e9162d115753a48 URL: https://github.com/llvm/llvm-project/commit/f9500cc487573c55ea37b4ee6e9162d115753a48 DIFF: https://github.com/llvm/llvm-project/commit/f9500cc487573c55ea37b4ee6e9162d115753a48.diff LOG

[clang-tools-extra] e2d61ae - Correctly set CompilingPCH in PrecompilePreambleAction.

Author: Adam Czachorowski Date: 2020-08-10T17:49:23+02:00 New Revision: e2d61ae5733316a14783b36c84b8e7681b0e3d59 URL: https://github.com/llvm/llvm-project/commit/e2d61ae5733316a14783b36c84b8e7681b0e3d59 DIFF: https://github.com/llvm/llvm-project/commit/e2d61ae5733316a14783b36c84b8e7681b0e3d59.d

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2d61ae57333: Correctly set CompilingPCH in PrecompilePreambleAction. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

ArcsinX added a comment. In D85193#2204685 , @aaron.ballman wrote: > Should the `StructuredIndex` still be incremented even in the case of an > error, as done around line 1589 and 1647? Yes, it looks like we need to increment `StructuredIndex`. > Do we

[PATCH] D83325: [Sema] Iteratively strip sugar when removing address spaces.

ebevhan updated this revision to Diff 284395. ebevhan retitled this revision from "[Sema] Be more thorough when unpacking the AS-qualified pointee for a pointer conversion." to "[Sema] Iteratively strip sugar when removing address spaces.". ebevhan edited the summary of this revision. ebevhan add

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. In D71726#2182667 , @tra wrote: >> If a target would like to treat single and double fp atomics as unsupported, >> it can override the default behavior in its own TargetInfo. I really don't think this should be a target option a

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. Oh, one more note, C11 has -- and clang already supports -- `_Atomic long double x; x += 4;` via lowering to a cmpxchg loop. Now that we have an LLVM IR representation for atomicrmw fadd/fsub, clang should be lowering the _Atomic += to that, too. (Doesn't need to be in

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

cameron.mcinally added a comment. In D71767#2206947 , @paulwalker-arm wrote: > @cameron.mcinally this is the patch I mentioned the other day, which contains > the nodes where once I've written suitable tests I'll push separate patches > for. Thanks, Pa

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

nsz added a comment. In D80791#2206933 , @chill wrote: > In D80791#2206853 , @nsz wrote: > >> i think that cannot work. >> >> the implementation is free to inject arbitrary code into >> user code so if the user does

[PATCH] D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF

JVApen added subscribers: Rakete, djasper, klimek, mlekena, MyDeveloperDay, owenpan, sammccall, shenhan. JVApen added a comment. Any chance we can still get this in LLVM 11? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60996/new/ https://reviews.llvm.org/D6

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

paulwalker-arm added a comment. In D71767#2207158 , @cameron.mcinally wrote: > In D71767#2206947 , @paulwalker-arm > wrote: > >> @cameron.mcinally this is the patch I mentioned the other day, which >> contains th

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. I would prefer to avoid the situation where the markings of two otherwise identical files were different, depending on how the files were produced, no matter if it was a common or a special case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://r

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3843 /// The declaration that this binding binds to part of. + // FIXME: Currently not set during deserialization of the BindingDecl; + // only set when the corresponding DecompositionDecl is visited

[PATCH] D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82609/new/ https://reviews.llvm.org/D82609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] 4061d9e - [clangd] Fix crash-bug in preamble indexing when using modules.

Author: Adam Czachorowski Date: 2020-08-10T18:42:57+02:00 New Revision: 4061d9e42cff621462931ac7df9666806c77a237 URL: https://github.com/llvm/llvm-project/commit/4061d9e42cff621462931ac7df9666806c77a237 DIFF: https://github.com/llvm/llvm-project/commit/4061d9e42cff621462931ac7df9666806c77a237.d

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4061d9e42cff: [clangd] Fix crash-bug in preamble indexing when using modules. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80525/new/

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 284425. dgoldman added a comment. Rebase + lint fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extr

[PATCH] D85666: [clang-tidy] IncludeInserter: allow <> in header name

alexfh created this revision. alexfh added reviewers: aaron.ballman, hokein. Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: clang. alexfh requested review of this revision. Herald added a subscriber: wuzish. This adds a pair of overloads for

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:1011-1015 + if (Header.front() == '<' && Header.back() == '>') { +IsSystemInclude = true; +Header.pop_back(); +Header.erase(0, 1); + } alexfh wrot

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

This revision was automatically updated to reflect the committed changes. Closed by commit rG70d583ad1287: [clangd] Have template template arguments target their referenced template decl (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] 70d583a - [clangd] Have template template arguments target their referenced template decl

Author: Nathan Ridge Date: 2020-08-10T13:27:23-04:00 New Revision: 70d583ad12872ef8714b15f1d1e982f1db6d9a15 URL: https://github.com/llvm/llvm-project/commit/70d583ad12872ef8714b15f1d1e982f1db6d9a15 DIFF: https://github.com/llvm/llvm-project/commit/70d583ad12872ef8714b15f1d1e982f1db6d9a15.diff

[clang] a3036b3 - Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record

Author: Alexandre Ganea Date: 2020-08-10T13:36:30-04:00 New Revision: a3036b386383f1c1e9d32c2c8dba995087959da3 URL: https://github.com/llvm/llvm-project/commit/a3036b386383f1c1e9d32c2c8dba995087959da3 DIFF: https://github.com/llvm/llvm-project/commit/a3036b386383f1c1e9d32c2c8dba995087959da3.dif

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

steakhal added a comment. In D81254#2122449 , @ASDenysPetrov wrote: > @NoQ, thanks for the examples. > > I didn't get the first one. How do you get to the "//In reality we don't > know//", if we don't touch `a[index1]`: If `index1` and `index2` has the

[PATCH] D85312: [ADT] Move FixedPoint.h from Clang to LLVM.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. The patch seems straightforward. Other than moving code and trimming `llvm::` from types, not sure if there's anything else I should expect. LGTM. Repository: rG LLVM Github Monor

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

eugenis added a comment. While we are here, how about setting a few more attributes? argmemonly, readonly/writeonly, willreturn come to mind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85573/new/ https://reviews.llvm.org/D85573

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

eugenis added a comment. nocapture on the pointer argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85573/new/ https://reviews.llvm.org/D85573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85676: [NewPM] collapsing nested pass mangers of the same type

ychen created this revision. ychen added reviewers: asbirlea, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. ychen requested review of this revision. This is one of the reason for extra invalidations in D84959

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

tra added a comment. Sam, just a FYI that the patch has a couple of unintended consequences. We now end up with various things instantiated as device-side __constant__ objects when they were not before, when we compile with -std=c++17 (especially with libc++): https://godbolt.org/z/KbTM9M That

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D71726#2207148 , @jyknight wrote: > In D71726#2182667 , @tra wrote: > >>> If a target would like to treat single and double fp atomics as >>> unsu

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. @kuhnel do you want to take a look or is it okay if I just submit the change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D85599: [PowerPC] Remove isTerminator for TRAP instruction

ZhangKang added a comment. In D85599#2206033 , @efriedma wrote: > Fixing a MachineVerifier issue by patching clang is generally wrong; if the > IR is valid, the backend should do something sane with it. If the IR isn't > valid, the IR Verifier should co

[PATCH] D85599: [Clang] Consider __builtin_trap() and __builtin_debugtrap() as terminator

ZhangKang updated this revision to Diff 284424. ZhangKang added a comment. Herald added a subscriber: hiraditya. Remoeve isTerminator for TRAP instruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85599/new/ https://reviews.llvm.org/D85599 Fi

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 284463. yaxunl marked 2 inline comments as done. yaxunl added a comment. Revised by James' comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D68720: Support -fstack-clash-protection for x86

sberg added inline comments. Herald added a subscriber: dang. Comment at: clang/include/clang/Driver/Options.td:1778 + HelpText<"Enable stack clash protection">; +def fnostack_clash_protection : Flag<["-"], "fnostack-clash-protection">, Group, + HelpText<"Disable stack clash p

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

cameron.mcinally added a comment. MIN/MAX and DIVs are up my alley. I'll try those. Will check out VREDUCE if I get through the others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71767/new/ https://reviews.llvm.org/D71767 _

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

aaron.ballman added a comment. In D85193#2207052 , @ArcsinX wrote: > In D85193#2204685 , @aaron.ballman > wrote: > >> Should the `StructuredIndex` still be incremented even in the case of an >> error, as done arou

[PATCH] D68720: Support -fstack-clash-protection for x86

xbolva00 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1778 + HelpText<"Enable stack clash protection">; +def fnostack_clash_protection : Flag<["-"], "fnostack-clash-protection">, Group, + HelpText<"Disable stack clash protection">;

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

efriedma added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84992/new/ https://reviews.llvm.org/D84992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

yaxunl added a comment. In D80858#2207699 , @tra wrote: > Sam, just a FYI that the patch has a couple of unintended consequences. > > We now end up with various things instantiated as device-side __constant__ > objects when they were not before, when we c

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284476. nickdesaulniers added a comment. This revision is now accepted and ready to land. - rebase, move Codegen tests to _cc1, move -g1 test to driver test, use more regex for ![0-9]+, manually test --target=x86_64-apple-macosx10.15.0 which has a di

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284477. nickdesaulniers added a comment. - squash and reupload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/test/AST/ast-dump-enum-bool.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump=json %s | FileCheck %s + rsmith wrote: > aaron.ballman wrote

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Hi @dblaikie , sorry for messing up the upload, I think it's good now, but to see the latest change, you'll need to look at the diff between the 2 prior versions (https://reviews.llvm.org/D80242?vs=284053&id=284477#toc). I reverted this on Friday. It looks like

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. refixing in https://reviews.llvm.org/D80242 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85565/new/ https://reviews.llvm.org/D85565

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2503 + llvm::Align Alignment = + CGM.getNaturalTypeAlignment(ETy).getAsAlign(); + AI->addAttrs(llvm::AttrBuilder().addAlignmentAttr(Alignment)); Is

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

Mordante updated this revision to Diff 284478. Mordante added a comment. Addresses the review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/ https://reviews.llvm.org/D85612 Files: clang/lib/Sema/SemaCast.cpp clang/test/AST/ast-dump-enum-bool.cpp clang/test/Cod

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

tra added a comment. > We can restrict externalization to constant variables with explicit > 'constant' attributes only, which should fix this issue. SGTM. If it does not have explicit device-side attribute, it's never going to need to cross host/device boundary. I guess this applies to vars wi

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

kamaub added a comment. Hello, sorry but can you please revert this commit and recommit it when you have a fix or work around that doesn't break our bots: It breaks http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/11228 which builds with `-Werror` Please also note that it in

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2503 + llvm::Align Alignment = + CGM.getNaturalTypeAlignment(ETy).getAsAlign(); + AI->addAttrs(llvm::AttrBuilder().addAlignmentAttr(Alignment)); rj

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

Mordante marked an inline comment as done. Mordante added a comment. I added `void g()` since that's valid code which also caused an assertion failure. So the issue isn't in the error recovery but in determining the required IntRange. It seems the code doesn't take http://eel.is/c++draft/expr.c

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Logs look quite old. http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/11291/steps/build-stage2-unified-tree/logs/stdio are newest logs? Maybe I can tune the warning more to avoid false positives. po 10. 8. 2020 o 21:46 Kamau Bridgeman via Phabricator napísal(a): > > kamaub ad

[PATCH] D85685: [WIP] Support dwarf fission for wasm object files

dschuff created this revision. dschuff added reviewers: sbc100, aardappel. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, aprantl. Herald added projects: clang, LLVM. dschuff requested review of this revision. Herald added a subscriber: aheejin. Initial support for dwarf

[PATCH] D85573: [CGAtomic] Mark atomic libcall functions `nounwind`

guiand added a comment. I don't think we can necessarily guarantee `argmemonly/readonly/writeonly`, particularly since these library calls can take a lock somewhere inside. I'll definitely add `nocapture` and `willreturn` though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85337: [AMDGPU] gfx1031 target

rampitec marked 2 inline comments as done. rampitec added inline comments. Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1844 LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1030), + LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1031), LLVM_READOBJ_ENUM_ENT(E

[PATCH] D85686: [CUDA][HIP] Do not externalize implicit constant static variable

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. https://reviews.llvm.org/D85686 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaExpr.cpp clang/test/CodeGenCUDA/static-device-var-no-rdc.cu In

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

yaxunl added a comment. In D80858#2207898 , @tra wrote: >> We can restrict externalization to constant variables with explicit >> 'constant' attributes only, which should fix this issue. > > SGTM. If it does not have explicit device-side attribute, it's n

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1, i64

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84992/new/ https://reviews.llvm.org/D84992 ___

[PATCH] D85686: [CUDA][HIP] Do not externalize implicit constant static variable

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ASTContext.cpp:11196 return !getLangOpts().GPURelocatableDeviceCode && - (D->hasAttr() || D->hasAttr()) && + (D->hasAttr() || +

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

tra added a comment. > The fix is here https://reviews.llvm.org/D85686 Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80858/new/ https://reviews.llvm.org/D80858 ___ cfe-commits mailing list cf

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struc

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1, i64

[PATCH] D85312: [ADT] Move FixedPoint.h from Clang to LLVM.

rjmccall accepted this revision. rjmccall added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85312/new/ https://reviews.llvm.org/D85312 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] 62223ff - [Diagnostics] Avoid false positives with -Wstring-concatenation

Author: Dávid Bolvanský Date: 2020-08-10T23:05:01+02:00 New Revision: 62223ff1376b540dc9612239fdfb11b376d796d3 URL: https://github.com/llvm/llvm-project/commit/62223ff1376b540dc9612239fdfb11b376d796d3 DIFF: https://github.com/llvm/llvm-project/commit/62223ff1376b540dc9612239fdfb11b376d796d3.dif

[PATCH] D83325: [Sema] Iteratively strip sugar when removing address spaces.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83325/new/ https://reviews.llvm.org/D83325 _

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

tra added a subscriber: echristo. tra added a comment. In D84068#2204713 , @arsenm wrote: >> If we ship them with clang, who/where/how builds them? >> If they come from ROCm packages, how would those packages add stuff into >> *clang* install directory? R

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

dmajor added a comment. In the Firefox repo this warning is firing on a number of strings that were broken up by clang-format (or humans) for line length, for example https://searchfox.org/mozilla-central/rev/ab81b8552f4aa9696a2524f97fdfeb59d4dc31c1/security/certverifier/ExtendedValidation.cpp#1

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert added inline comments. Comment at: clang/test/OpenMP/master_taskloop_reduction_codegen.cpp:164 // CHECK:store i32 [[SUB12]], i32* [[DOTCAPTURE_EXPR_9]], -// CHECK:[[TMP65:%.*]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* %{{.+}}, i32 [[TMP0]], i32 1, i6

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80735/new/ https://reviews.llvm.org/D80735 ___ c

[PATCH] D85575: [ARM] Speed up arm-cortex-cpus.c test

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c8ae4086031: [ARM] Speed up arm-cortex-cpus.c test (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85575/new/ https://reviews.llvm.org/D85

[clang] 9c8ae40 - [ARM] Speed up arm-cortex-cpus.c test

Author: Artem Belevich Date: 2020-08-10T14:27:19-07:00 New Revision: 9c8ae40860311e94de0a898101818f706228e958 URL: https://github.com/llvm/llvm-project/commit/9c8ae40860311e94de0a898101818f706228e958 DIFF: https://github.com/llvm/llvm-project/commit/9c8ae40860311e94de0a898101818f706228e958.diff

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %s +// NO_DEBUG_UNUSED_TYPES: "-debug-info-kind={{limited

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %s +// NO_DEBUG_UNUSED_TYPES: "-debug-info-kind={{

[clang] b2c9b63 - [Diagnostics] Move -Wstring-concatenation to -Wextra

Author: Dávid Bolvanský Date: 2020-08-10T23:36:33+02:00 New Revision: b2c9b631bb48087c988d798adc5465499b155a9a URL: https://github.com/llvm/llvm-project/commit/b2c9b631bb48087c988d798adc5465499b155a9a DIFF: https://github.com/llvm/llvm-project/commit/b2c9b631bb48087c988d798adc5465499b155a9a.dif

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

I moved it to -Wextra due to false positives. > Should there be some exception for line length Yeah, but sure how to define the threshold or so. :/ po 10. 8. 2020 o 23:21 dmajor via Phabricator napísal(a): > > dmajor added a comment. > > In the Firefox repo this warning is firing on a number of

[PATCH] D85596: [Docs] Link to --print-supported-cpus option

nickdesaulniers added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:346 - Aliases of --print-supported-cpus + Aliases of :option:`--print-supported-cpus` Would you mind adding a `.` for punctuation while you're here? Repository: rG LLVM

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie accepted this revision. dblaikie added a comment. Looks good, thanks! Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %s +// NO

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

It looks to me as if all of the false-positives so far have been *not arrays but structs*. struct X { int a; const char *b; int c; }; X x = { 41, "forty" "two", 43 }; // false-positive here The distinguishing feature here is that if you did insert a comma as suggested by the compiler, then the r

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

For your cases, we currently do not warn. If possible, fetch the latest Clang trunk and re-evaluate on Firefox. po 10. 8. 2020 o 23:46 Arthur O'Dwyer napísal(a): > > It looks to me as if all of the false-positives so far have been not arrays > but structs. > > struct X { int a; const char *b; in

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Something like this: const char *Sources[] = { "// \\tparam aaa Bbb\n", "// \\tparam\n" "// aaa Bbb\n", "// \\tparam \n" "// aaa Bbb\n", "// \\tparam aaa\n" "// Bbb\n" }; annoys me :/ Any idea/heuristic how to avoid warning here? po 10. 8. 2020 o 23:48 Dávi

Re: [clang] 4dcbb9c - [clang] Add -fno-delayed-template-parsing to the added unit tests in DeclPrinterTest.cpp

Would be helpful to document in the commit message why a change is being made. On Wed, Aug 5, 2020 at 6:13 AM Bruno Ricci via cfe-commits wrote: > > > Author: Bruno Ricci > Date: 2020-08-05T14:13:05+01:00 > New Revision: 4dcbb9cef71afa549afe8f6b4d335b1c996f8079 > > URL: > https://github.com/llvm

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

To decrease the number of false-positives, you could emit the warning only if *exactly one* comma was missing. const char *likely_a_bug[] = { "a", "b", "c" "d", "e", "f", "g", "h", "i" }; const char *likely_not_a_bug[] = { "a", "b" "c", "d" "e", "f" "g" }; const char *oops_still_a_bug[

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

This revision was automatically updated to reflect the committed changes. nickdesaulniers marked an inline comment as done. Closed by commit rG4f2ad15db535: [Clang] implement -fno-eliminate-unused-debug-types (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 4f2ad15 - [Clang] implement -fno-eliminate-unused-debug-types

Author: Nick Desaulniers Date: 2020-08-10T15:08:48-07:00 New Revision: 4f2ad15db535873dda9bfe248a2771023b64a43c URL: https://github.com/llvm/llvm-project/commit/4f2ad15db535873dda9bfe248a2771023b64a43c DIFF: https://github.com/llvm/llvm-project/commit/4f2ad15db535873dda9bfe248a2771023b64a43c.di

Re: [PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

For your godbolt example, you hit the heuristic to not warn, if literals count is <= 2. (motivated by many false positives; and I didnt see a true positive case, so..) >> you could emit the warning only if exactly one comma was missing. This could work. ut 11. 8. 2020 o 0:04 Arthur O'Dwyer napí

[PATCH] D85692: python bindings: fix DeprecationWarning

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, echristo, srhines. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. nickdesaulniers requested review of this revision. Fixes observed warning running `ninja check-all`: llvm-project/clan

[PATCH] D85692: python bindings: fix DeprecationWarning

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85692/new/ https://reviews.llvm.org/D85692

[clang] 05d74db - python bindings: fix DeprecationWarning

Author: Nick Desaulniers Date: 2020-08-10T15:25:23-07:00 New Revision: 05d74dbc3bb1d943a029e4abea211288c920f559 URL: https://github.com/llvm/llvm-project/commit/05d74dbc3bb1d943a029e4abea211288c920f559 DIFF: https://github.com/llvm/llvm-project/commit/05d74dbc3bb1d943a029e4abea211288c920f559.di

[PATCH] D85692: python bindings: fix DeprecationWarning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d74dbc3bb1: python bindings: fix DeprecationWarning (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D85635: [clangd] Compute the interactive code range for semantic highlighting.

nridge added a comment. Do you mean "inactive" (instead of "interactive") in the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85635/new/ https://reviews.llvm.org/D85635 ___ cfe-commits m

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. In D85545#2208266 , @arthur.j.odwyer wrote: > To decrease the number of false-positives, you could emit the warning only > if *exactly one* comma was missing. > > const char *likely_a_bug[] = { "a", "b", "c" "d", "e", "f", "g",

[PATCH] D85686: [CUDA][HIP] Do not externalize implicit constant static variable

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11196 return !getLangOpts().GPURelocatableDeviceCode && - (D->hasAttr() || D->hasAttr()) && + (D->hasAttr() || + (D->hasAttr() && --

<    1   2   3   >