[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

nridge updated this revision to Diff 284264. nridge added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Run script to update AST matcher docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85621/new/ https://rev

[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

nridge added a comment. In D85621#2205803 , @hokein wrote: > Please run `clang/docs/tools/dump_ast_matchers.py` script to update the > `LibASTMatchersReference.html` file. Done. Note, it looks like this script needs to be run with python 2. Should we do

[clang] b1c7f84 - [clang] Allow DynTypedNode to store a TemplateArgumentLoc

Author: Nathan Ridge Date: 2020-08-10T03:09:18-04:00 New Revision: b1c7f84643ffa63e72733b7089cea89723b82afc URL: https://github.com/llvm/llvm-project/commit/b1c7f84643ffa63e72733b7089cea89723b82afc DIFF: https://github.com/llvm/llvm-project/commit/b1c7f84643ffa63e72733b7089cea89723b82afc.diff

[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1c7f84643ff: [clang] Allow DynTypedNode to store a TemplateArgumentLoc (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 626d0f5 - [Concepts] Dump template arguments for immediately declared constraint.

Author: Haojian Wu Date: 2020-08-10T09:11:55+02:00 New Revision: 626d0f5818b223f04904c510eaa682db7a41c2dd URL: https://github.com/llvm/llvm-project/commit/626d0f5818b223f04904c510eaa682db7a41c2dd DIFF: https://github.com/llvm/llvm-project/commit/626d0f5818b223f04904c510eaa682db7a41c2dd.diff LO

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

This revision was automatically updated to reflect the committed changes. Closed by commit rG626d0f5818b2: [Concepts] Dump template arguments for immediately declared constraint. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D852

[PATCH] D85523: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` was undefined after definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5965fbf81b25: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang-tools-extra] 5965fbf - [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` was undefined after definition.

Author: Aleksandr Platonov Date: 2020-08-10T10:24:38+03:00 New Revision: 5965fbf81b25217c40b09b48bd808a8f4a5d4e89 URL: https://github.com/llvm/llvm-project/commit/5965fbf81b25217c40b09b48bd808a8f4a5d4e89 DIFF: https://github.com/llvm/llvm-project/commit/5965fbf81b25217c40b09b48bd808a8f4a5d4e89.

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

nridge updated this revision to Diff 284271. nridge added a comment. Add Selection test Also simplify the FindTarget test case a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85503/new/ https://reviews.llvm.org/D85503 Files: clang-tools-ext

[PATCH] D85345: [BuildLibCalls] Add noundef to standard I/O functions

aqjune added a comment. In D85345#2205745 , @jdoerfert wrote: > In D85345#2205712 , @aqjune wrote: > >> What about undef or poison is given to malloc? If it should raise UB, the >> size argument and returned pointe

[PATCH] D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc

njames93 added a comment. In D85621#2205856 , @nridge wrote: > In D85621#2205803 , @hokein wrote: > >> Please run `clang/docs/tools/dump_ast_matchers.py` script to update the >> `LibASTMatchersReference.html` file.

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ThreadPrimitivesChecker.cpp:46 + +REGISTER_SET_WITH_PROGRAMSTATE(LockedMutexes, SVal) + vsavchenko wrote: > vsavchenko wrote: > > You should also cleanup and remove dead symbols fr

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 added a comment. LGTM after my comments are addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D85295: [SyntaxTree] Implement the List construct.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:194 +/// A Tree that represents a syntactic list of elements. +/// """ A list of elements

[PATCH] D84781: [SyntaxTree] Use PointerUnion instead of inheritance for alternative clauses in NNS

gribozavr2 added a comment. Seeing the API, I like the inheritance-based approach better. It seems more uniform. Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:219 + syntax::EmptyNode *, syntax::Leaf *, syntax::DecltypeSpecifier *, + syntax::SimpleTemplateSpecifier *

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber added a comment. Btw: what is the general rule for Phabricator reviews here when to tick the `Done` checkbox of a comment? What is the semantic of this checkbox? Is the ticked state the same for everyone? Thank you for the help! Comment at: clang-tools-extra

[PATCH] D84886: Create LoopNestPass

TaWeiTu added a comment. Ping. @ychen Thank you for your comment! I've added some unittests. Please let me know if there's anything unclear about the intended usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.o

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske updated this revision to Diff 284283. balazske added a comment. Preserve original error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84520/new/ https://reviews.llvm.org/D84520 Files: clang/lib/StaticAnalyzer/Checkers/Derefere

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske marked an inline comment as done. balazske added a comment. Do the null pointer and invalid pointer dereference belong to the same checker, that is called //NullDereference//? Comment at: clang/test/Analysis/misc-ps-region-store.m:1160 struct list_pr8141 *items; -

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas updated this revision to Diff 284284. eduucaldas added a comment. Move to using inheritance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85439/new/ https://reviews.llvm.org/D85439 Files: clang/include/clang/AST/NestedNameSpecifier.h

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas updated this revision to Diff 284285. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85439/new/ https://reviews.llvm.org/D85439 Files: clang/include/clang/AST/NestedNameSpecifier.h clang/lib/Tooling/Synt

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 284286. MForster added a comment. Add an -ast-print test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Now NNS are based on inheritance! Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:849-850 + const auto TL = NNSLoc.getTypeLoc().castAs(); + if (!RecursiveASTVisitor::TraverseDecltypeTypeLoc(TL

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.h:143 + std::function ContextProvider = nullptr, + bool CollectMainFileRefs = true); ~BackgroundIndex(); // Blocks while the current task finishes. please set the d

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 284288. MForster added a comment. Fix mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/At

[PATCH] D84005: Introduce ns_error_domain attribute.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/test/AST/ast-print-attr.c:20 + +2@interface NSString +@end Stray "2". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new

[PATCH] D84348: [SyntaxTree] Use simplified grammar rule for `NestedNameSpecifier` grammar nodes

eduucaldas closed this revision. eduucaldas added a comment. commit hash 8abb5fb68f81b0e42d824bf080b1cef9a61559d6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https:

[PATCH] D85295: [SyntaxTree] Implement the List construct.

eduucaldas updated this revision to Diff 284292. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. Answer code-review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85295/new/ https://reviews.llvm.org/D85295 Files: clang/in

[PATCH] D85295: [SyntaxTree] Implement the List construct.

eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:249 + + /// Return whether *under valid code* the list can be empty. + /// gribozavr2 wrote: > "Whether this list can be empty in syntactically and semantically correct > c

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. In D80791#2196598 , @nsz wrote: > the assumption is that the intended branch protection is implied via cmdline > flags for the tu and function attributes are only used in source code for > some hack. I don't share this assumption.

[PATCH] D85635: [clangd] Compute the interactive code range for semantic highlighting.

hokein created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

whisperity added a comment. In D84520#2206077 , @balazske wrote: > Do the null pointer and invalid pointer dereference belong to the same > checker, that is called //NullDereference//? I think both SA and Tidy auto-appends the checker's name into the emi

[PATCH] D85525: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` is not a literal.

ArcsinX updated this revision to Diff 284296. ArcsinX added a comment. - Rebase - Add T.getLiteralData() check - Newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85525/new/ https://reviews.llvm.org/D85525 Files: clang-tools-extra/clang-tidy

[clang] a90c78a - [SyntaxTree] Implement the List construct.

Author: Eduardo Caldas Date: 2020-08-10T10:32:28Z New Revision: a90c78ac52615d256142ecd64fbedabb612dc73f URL: https://github.com/llvm/llvm-project/commit/a90c78ac52615d256142ecd64fbedabb612dc73f DIFF: https://github.com/llvm/llvm-project/commit/a90c78ac52615d256142ecd64fbedabb612dc73f.diff LOG

[PATCH] D85295: [SyntaxTree] Implement the List construct.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa90c78ac5261: [SyntaxTree] Implement the List construct. (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D85295?vs=284

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder updated this revision to Diff 284308. tbaeder added a comment. Add a test that checks that clang accepts `-Wa,--generate-missing-build-notes=yes` and `-Wa,--generate-missing-build-notes=no` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D8484

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/AST/NestedNameSpecifier.h:20 #include "clang/Basic/SourceLocation.h" +#include "llvm/ADT//DenseMapInfo.h" #include "llvm/ADT/FoldingSet.h" C

[PATCH] D85637: [clangd] Fix the background index is not disabled when using remote-index.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https

[PATCH] D85337: [AMDGPU] gfx1031 target

jhenderson added inline comments. Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1844 LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1030), + LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1031), LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_XNACK), ra

[PATCH] D85599: [Clang] Consider __builtin_trap() and __builtin_debugtrap() as terminator

ZhangKang updated this revision to Diff 284250. ZhangKang added a comment. Fix the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85599/new/ https://reviews.llvm.org/D85599 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtin

[PATCH] D85599: [Clang] Consider __builtin_trap() and __builtin_debugtrap() as terminator

efriedma added a comment. Fixing a MachineVerifier issue by patching clang is generally wrong; if the IR is valid, the backend should do something sane with it. If the IR isn't valid, the IR Verifier should complain. Here, I'd say the IR is valid; adding a special case to the IR rules here wou

[PATCH] D85637: [clangd] Fix the background index is not disabled when using remote-index.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Oh, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85637/new/ https://reviews.llvm.org/D85637 __

[clang-tools-extra] 3d2cf72 - [clangd] Fix the background index is not disabled when using remote-index.

Author: Haojian Wu Date: 2020-08-10T14:02:22+02:00 New Revision: 3d2cf72943295d167062b54e663e2f5236df2c5d URL: https://github.com/llvm/llvm-project/commit/3d2cf72943295d167062b54e663e2f5236df2c5d DIFF: https://github.com/llvm/llvm-project/commit/3d2cf72943295d167062b54e663e2f5236df2c5d.diff LO

[PATCH] D85637: [clangd] Fix the background index is not disabled when using remote-index.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d2cf7294329: [clangd] Fix the background index is not disabled when using remote-index. (authored by hokein). Repository: rG LLVM Github Monorepo

[PATCH] D85525: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` is not a literal.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb8d3b72234: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang-tools-extra] dcb8d3b - [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` is not a literal.

Author: Aleksandr Platonov Date: 2020-08-10T15:12:03+03:00 New Revision: dcb8d3b72234ea557df2af1141ad30bf1670a03a URL: https://github.com/llvm/llvm-project/commit/dcb8d3b72234ea557df2af1141ad30bf1670a03a DIFF: https://github.com/llvm/llvm-project/commit/dcb8d3b72234ea557df2af1141ad30bf1670a03a.

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 284324. eduucaldas added a comment. Implement `canBeEmpty`, `getDelimiterToken`, `getTerminationKind` for `NestedNameSpecifier` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz updated this revision to Diff 284329. adamcz marked 3 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85532/new/ https://reviews.llvm.org/D85532 Files: clang-tools-e

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/ModulesTests.cpp:28 +)cpp"); + TU.ExtraArgs.push_back("-fmodules"); + TU.ExtraArgs.push_back("-fmodule-name=M"); kadircet wrote: > this one is not needed right? I suppose not. ==

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:362 + switch (this->kind()) { + case NodeKind::NestedNameSpecifier: { +return clang::tok::coloncolon; Please drop the braces within 'case' unl

[PATCH] D85016: [clang-format] Add space between method modifier and a tuple return type in C#

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5f104a809983: [clang-format] Add space between method modifier and a tuple return type in C# (authored by lbk, committed by Jonathan Coe

[clang] 5f104a8 - [clang-format] Add space between method modifier and a tuple return type in C#

Author: Łukasz Krawczyk Date: 2020-08-10T14:00:33+01:00 New Revision: 5f104a809983aa3b90f75fb411a9c8472545d270 URL: https://github.com/llvm/llvm-project/commit/5f104a809983aa3b90f75fb411a9c8472545d270 DIFF: https://github.com/llvm/llvm-project/commit/5f104a809983aa3b90f75fb411a9c8472545d270.dif

[PATCH] D84636: [RFC] Make the default LibCall implementations from compiler-rt builtins library more customizable

aaron.ballman added inline comments. Comment at: compiler-rt/lib/builtins/arm-libcall-overrides.h:8 +//===--===// + +#define AEABI_RTABI __attribute__((__pcs__("aapcs"))) It looks like you're mis

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/unittests/Frontend/ASTUnitTest.cpp:144 + CInvok, PCHContainerOps, Diags, FileMgr, false, CaptureDiagsKind::None, 1, + TU_Comple

[PATCH] D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid.

hokein created this revision. hokein added a reviewer: nridge. Herald added a project: clang. hokein requested review of this revision. The CXXFoldExpr's range is invalid if the cxxfoldexpr is formed via the Concept's TypeContraints (because the parentheses are not written in the source code). We

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

aaron.ballman added a reviewer: echristo. aaron.ballman added a subscriber: echristo. aaron.ballman added a comment. Adding @echristo for the debugging info question. In D84602#2200274 , @atrosinenko wrote: > I suspect there might be some terminology clas

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

whisperity added inline comments. Comment at: clang/test/Analysis/z3-refute-enum-crash.cpp:5 +// +// Requires z3 only for refutation. Works with both constraint managers. + You can have multiple `RUN` lines in the same test file, which will result in the tests p

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D80514#2206019 , @bernhardmgruber wrote: > Btw: what is the general rule for Phabricator reviews here when to tick the > `Done` check

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thanks for the patch! Looks generally good. A few comments inline. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:74-76 +static const char

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. Continues to LGTM with your changes, but I did spot one tiny nit (no further reviews needed from me). Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5346 + if (!isNSStringType(VD->getType(), S.Context)) { +

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 284342. eduucaldas added a comment. Answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/T

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

DavidTruby accepted this revision. DavidTruby added a comment. This revision is now accepted and ready to land. LGTM - please wait for someone more familiar with clang-tidy to review as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85218/new/

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 284343. MForster marked an inline comment as done. MForster added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic

[PATCH] D85440: [SyntaxTree] Implement `NNS` using the `List` base API

eduucaldas updated this revision to Diff 284344. eduucaldas added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85440/new/ https://reviews.llvm.org/D85440 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Synt

[clang] fdbd599 - [SyntaxTree] Implement `NestedNameSpecifier` using the `List` base API

Author: Eduardo Caldas Date: 2020-08-10T13:43:21Z New Revision: fdbd5996533dad25f00687f27ce8e7a8b7573ba3 URL: https://github.com/llvm/llvm-project/commit/fdbd5996533dad25f00687f27ce8e7a8b7573ba3 DIFF: https://github.com/llvm/llvm-project/commit/fdbd5996533dad25f00687f27ce8e7a8b7573ba3.diff LOG

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

aaron.ballman added a comment. Thank you for starting the implementation work on these attributes! Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodDocs];

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov updated this revision to Diff 284353. ASDenysPetrov added a comment. Aded enum FuncIdKind to define function Ids. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85431/new/ https://reviews.llvm.org/D85431 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td cl

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ef801aa6bc0: [AIX] Static init frontend recovery and backend support (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D84534?vs=283712&id=284355#toc Repository: rG LLVM G

[clang] 6ef801a - [AIX] Static init frontend recovery and backend support

Author: Xiangling Liao Date: 2020-08-10T10:10:49-04:00 New Revision: 6ef801aa6bc01fc49a8e83ddb217470b5e2337dd URL: https://github.com/llvm/llvm-project/commit/6ef801aa6bc01fc49a8e83ddb217470b5e2337dd DIFF: https://github.com/llvm/llvm-project/commit/6ef801aa6bc01fc49a8e83ddb217470b5e2337dd.diff

[PATCH] D84226: [AST][RecoveryExpr] Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 284358. hokein added a comment. - rebase; - add comments for CreateDependentBinOp, and make it private based on Richard's comment; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.o

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL updated this revision to Diff 284357. ShuhongL added a comment. Fixed indent and updated error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85315/new/ https://reviews.llvm.org/D85315 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz updated this revision to Diff 284360. adamcz marked 2 inline comments as done. adamcz added a comment. final(?) review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80525/new/ https://reviews.llvm.org/D80525 Files: clang-tools-ex

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1523 + TU.ExtraArgs.push_back("-fmodule-map-file=/module.map"); + TU.OverlayRealFileSystem = true; + sammccall wrote: > I'm a bit torn on this - this is obviou

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

Eugene.Zelenko added inline comments. Comment at: clang/docs/ReleaseNotes.rst:70 motivating use case for these types is to limit 'bit' usage, these types don't - automatically promote to 'int' when operations are done between two ``ExtInt(N)`` - types, instead math occurs

[PATCH] D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath

hokein added a comment. In D85025#2201042 , @rsmith wrote: > Looks reasonable to me. I expect you'll find more places that need to learn > how to handle dependent types in C, but this looks like a solid start. Thanks! Yeah, we'd need to a detailed plan t

[clang] b129c9d - Author: Shuhong Liu

Author: Shuhong Liu Date: 2020-08-10T10:27:04-04:00 New Revision: b129c9d81aff8ece71eb29df1e5f31136a48c040 URL: https://github.com/llvm/llvm-project/commit/b129c9d81aff8ece71eb29df1e5f31136a48c040 DIFF: https://github.com/llvm/llvm-project/commit/b129c9d81aff8ece71eb29df1e5f31136a48c040.diff L

[PATCH] D84636: [RFC] Make the default LibCall implementations from compiler-rt builtins library more customizable

atrosinenko added a comment. Another note to myself: add `AUX_DECLS(__LibCallName)` to every generic implementation file. They were forgotten unintentionally. Comment at: compiler-rt/lib/builtins/arm-libcall-overrides.h:8 +//===-

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestFS.h:51 + // This is useful for testing module support. + bool OverlayRealFileSystem = false; }; also ForModules here? Comm

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz updated this revision to Diff 284365. adamcz marked an inline comment as done. adamcz added a comment. more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85532/new/ https://reviews.llvm.org/D85532 Files: clang-tools-extra/

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1697 +It's not allowed to annotate a statement with both ``likely`` and +``unlikely``. It's not recommended to annotate both branches of an ``if`` +statement with an attribute.

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz added inline comments. Comment at: clang/unittests/Frontend/ASTUnitTest.cpp:146 + auto File = AU->getFileManager().getFileRef("Textual.h", false, false); + assert(File); + // Verify that we do not crash here. kadircet wrote: > ASSERT_TRUE again You can

Re: [clang] b129c9d - Author: Shuhong Liu

@shuhong@ibm.com: I'm not sure what process you followed to commit this, but the commit message does not seem right. It might make sense to revert this and commit again with the proper message to make annotations from `git blame` work better. -- HT On Mon, Aug 10, 2020 at 10:33 AM Shuhong Liu

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

riccibruno updated this revision to Diff 284364. riccibruno marked 2 inline comments as done. riccibruno edited the summary of this revision. riccibruno added a comment. Refer to the binding in the diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

hokein added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint())); TRY_TO(TraverseConceptReference(*TC)); nridge wr

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz added inline comments. Comment at: clang/unittests/Frontend/ASTUnitTest.cpp:146 + auto File = AU->getFileManager().getFileRef("Textual.h", false, false); + assert(File); + // Verify that we do not crash here. adamcz wrote: > kadircet wrote: > > ASSERT_T

[PATCH] D85613: [clang] Look through bindings when checking whether a default argument references a local entity.

riccibruno added inline comments. Comment at: clang/test/CXX/dcl.decl/dcl.meaning/dcl.fct.default/p7.cpp:51 + extern void h8a(int = sizeof(z)); // ok + extern void h8b(int = w); // expected-error {{default argument references local variable 'w'}} rsm

Re: [PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

The 08/10/2020 10:03, Momchil Velikov via Phabricator wrote: > chill added a comment. > > In D80791#2196598 , @nsz wrote: > > > the assumption is that the intended branch protection is implied via > > cmdline flags for the tu and function attributes are o

[clang] c7b683c - [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

Author: Michael Liao Date: 2020-08-10T11:01:46-04:00 New Revision: c7b683c126b849dab5c81e7deecfc1e61f8563a0 URL: https://github.com/llvm/llvm-project/commit/c7b683c126b849dab5c81e7deecfc1e61f8563a0 DIFF: https://github.com/llvm/llvm-project/commit/c7b683c126b849dab5c81e7deecfc1e61f8563a0.diff

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7b683c126b8: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side… (authored by hliao). Repository: rG LLVM Github Monorepo

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:839-840 + // Skip host-only functions in the CUDA device compilation and device-only + // functions in the host compilation. + if (CGM.getLangOpts().CUDA && tra wrote: > hliao wrote: >

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 284375. balazske marked an inline comment as done. balazske added a comment. - Renames. - Changed behavior if function call is compared to returned value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz updated this revision to Diff 284376. adamcz marked 2 inline comments as done. adamcz added a comment. var rename, comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80525/new/ https://reviews.llvm.org/D80525 Files: clang-tools-extra/

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.h:71 + // required for use of modules. + // FIXME: Intercept the write of implicitly build module to disk and update + // TestFS with that content to avoid using real file system in tests.

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

xazax.hun added a comment. In D85528#2205799 , @NoQ wrote: > I expect at least one LIT test //without// `-analyzer-config > crosscheck-with-z3=true` Agreed. I think the code snippet I proposed would be a great test to include with this revision. Repos

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov updated this revision to Diff 284373. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Added recursive_mutex support. Please, look at a test file on TODOs. I want to cover those cases in the future. Could you advise me something on it? CHANGES SIN

[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

ShuhongL closed this revision. ShuhongL added a comment. Landed by commit: rGb129c9d81aff8ece71eb29df1e5f31136a48c040 (Sorry, I didn't properly align the tags in commit message and hence this revision was not automatically clo

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

eduucaldas added a comment. There are some refinements to do, to generate a complete syntax tree. Namely tag decltype-name-specifier and simple-template-specifier children with roles, to allow for accessors. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:838-842 + //

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. @NoQ just one more ping. You accepted it and then I just revised it again. Could you, please, take a minute and look at it. I'd close it with a great pleasure. It's been hanging too long. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://re

[PATCH] D71767: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 2/2].

paulwalker-arm updated this revision to Diff 284380. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71767/new/ https://reviews.llvm.org/D71767 Files: clang/lib/Driver/ToolChains

  1   2   3   >