[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane added a comment. In D82562#2191512 , @dmajor wrote: > @erichkeane, could you help me understand what is the action item of these > warnings? > > In Firefox we don't require AVX so our compilations generally don't enable > the feature. (A very

[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

saiislam abandoned this revision. saiislam added a comment. Abandoning in favor of D84844 and D85150 i.e. adding default version testing along with version 4.5 testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

RE: [PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

Committed dca23ed; should be fixed now. -Eli From: Azhar Mohammed Sent: Monday, August 3, 2020 11:01 AM To: Eli Friedman ; Eli Friedman via Phabricator ; Eli Friedman Cc: sander.desma...@arm.com; sjoerd.mei...@arm.com; t.p.northo...@gmail.com; cameron.mcina...@nyu.edu; blitzrak...@gmail.com;

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

This revision was automatically updated to reflect the committed changes. Closed by commit rG7209f83112db: Allow .dSYM's to be directly placed in an alternate directory (authored by dsanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84572/new/

[clang] 7209f83 - Allow .dSYM's to be directly placed in an alternate directory

Author: Daniel Sanders Date: 2020-08-03T13:18:52-07:00 New Revision: 7209f83112db4dbe15d8328705f9d2aff0624fbd URL: https://github.com/llvm/llvm-project/commit/7209f83112db4dbe15d8328705f9d2aff0624fbd DIFF: https://github.com/llvm/llvm-project/commit/7209f83112db4dbe15d8328705f9d2aff0624fbd.diff

[PATCH] D84540: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as notail on x86-64

This revision was automatically updated to reflect the committed changes. Closed by commit rG41b1e97b12c1: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 41b1e97 - [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as

Author: Akira Hatanaka Date: 2020-08-03T13:25:25-07:00 New Revision: 41b1e97b12c1407e40d8e5081bf1f9cf183934b0 URL: https://github.com/llvm/llvm-project/commit/41b1e97b12c1407e40d8e5081bf1f9cf183934b0 DIFF: https://github.com/llvm/llvm-project/commit/41b1e97b12c1407e40d8e5081bf1f9cf183934b0.diff

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. vabridgers requested review of this revision. This change squelches the warning for a cast from integer to fixed point conversions. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb327922101b: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHA

[clang] cb32792 - [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

Author: Thomas Lively Date: 2020-08-03T13:54:00-07:00 New Revision: cb327922101b28ea70ec68d7f026da0e5e388eed URL: https://github.com/llvm/llvm-project/commit/cb327922101b28ea70ec68d7f026da0e5e388eed DIFF: https://github.com/llvm/llvm-project/commit/cb327922101b28ea70ec68d7f026da0e5e388eed.diff

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. ping @rjmccall. Any update on a timeline for this review process? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___ cfe-commits m

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5 and default - Part 1

jdoerfert added a comment. I think this is good. Let's see if there are objections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/ https://reviews.llvm.org/D84844 ___ cfe-commits mailing list cf

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

njames93 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14047 +static bool isComparisonOpSamePrecedence(BinaryOperatorKind Opc) { + switch (Opc) { Quuxplusone wrote: > Same precedence as what? > I think this should just be called `isRelationalO

[clang] 7cf4603 - Reland D61689 Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED) with integrated assembler

Author: Fangrui Song Date: 2020-08-03T15:12:01-07:00 New Revision: 7cf4603faee366a6e5860b6fdbedadd91872e231 URL: https://github.com/llvm/llvm-project/commit/7cf4603faee366a6e5860b6fdbedadd91872e231 DIFF: https://github.com/llvm/llvm-project/commit/7cf4603faee366a6e5860b6fdbedadd91872e231.diff

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

aeubanks added a comment. I'm looking at enabling the -enable-npm-optnone flag and FullUnroll.ll fails. I understand that loop unrolling should be forced when some metadata is present, but the FullUnroll.ll test seems to check for a lot more than that. It checks for (roughly) two unconditional

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

bjope added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2660 return; + if (SrcType->isIntegerType() && DestType->isFixedPointType()) +return; Is this really the intention with the patch? It does match the "summary" above, but isn't the war

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

bjope added inline comments. Comment at: clang/test/Sema/warn-bad-function-cast.c:49 +#ifdef FIXED_POINT + (void)(_Fract) if1(); // no warning +#endif bjope wrote: > bjope wrote: > > This should be added before the line saying `/* All following casts issue > >

[PATCH] D85071: [VE] Extend integer arguments and return values smaller than 64 bits

This revision was automatically updated to reflect the committed changes. Closed by commit rG045e79e77c25: [VE] Extend integer arguments and return values smaller than 64 bits (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85071/ne

[clang] 045e79e - [VE] Extend integer arguments and return values smaller than 64 bits

Author: Kazushi (Jam) Marukawa Date: 2020-08-04T08:07:05+09:00 New Revision: 045e79e77c252f2c73c640e820e977ef52836d50 URL: https://github.com/llvm/llvm-project/commit/045e79e77c252f2c73c640e820e977ef52836d50 DIFF: https://github.com/llvm/llvm-project/commit/045e79e77c252f2c73c640e820e977ef52836

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 282757. njames93 added a comment. - Rebased trunk - Cleaned up test cases - Added support for specifying to include as system include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.l

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

hctim added a comment. Hi folks, looks like this patch broke `check-clang` under ASan/MSan, would you mind taking a look? Thanks. FAIL: Clang :: Driver/darwin-dsymutil.c (6208 of 24675) TEST 'Clang :: Driver/darwin-dsymutil.c' FAILED Script: --

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

anakryiko accepted this revision. anakryiko added a comment. LGTM. One question: why didn't we run into the need for SeqNumVal trick with field-based relocations? We seem to need it for all other types (including type ID-based), but not for field-based? Repository: rG LLVM Github Monorepo C

[clang-tools-extra] 3b44b6c - [clang-tidy][NFC] Use correct size call for reserve

Author: Nathan James Date: 2020-08-04T00:31:19+01:00 New Revision: 3b44b6c900d1b71e6a6590e376d11dc303ac5159 URL: https://github.com/llvm/llvm-project/commit/3b44b6c900d1b71e6a6590e376d11dc303ac5159 DIFF: https://github.com/llvm/llvm-project/commit/3b44b6c900d1b71e6a6590e376d11dc303ac5159.diff

[clang] 1beb00d - Fix use-after-scope in 7209f83112db caught by the sanitizer bots

Author: Daniel Sanders Date: 2020-08-03T16:55:00-07:00 New Revision: 1beb00db1f5197efb73f839da681b8e439f37628 URL: https://github.com/llvm/llvm-project/commit/1beb00db1f5197efb73f839da681b8e439f37628 DIFF: https://github.com/llvm/llvm-project/commit/1beb00db1f5197efb73f839da681b8e439f37628.diff

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar updated this revision to Diff 282771. vrnithinkumar marked 10 inline comments as done. vrnithinkumar edited the summary of this revision. vrnithinkumar added a comment. - Addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:86 + if (const auto *DR = dyn_cast(DerefRegion)) { +auto SmartPtrName = DR->getDecl()->getName(); +OS << " '" << SmartPtrName << "'"; NoQ wrote: > Plea

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. yonghong-song added a project: clang. Herald added subscribers: llvm-commits, cfe-commits, JDevlieghere, hiraditya. Herald added a project: LLVM. yonghong-song requested review of this revision. This patch simplifi

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers updated this revision to Diff 282775. vabridgers added a comment. improve the commit message detail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157 Files: clang/lib/Sema/SemaCast.cpp clang/te

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers marked 5 inline comments as done. vabridgers added a comment. I updated the commit header with more details since the first submission was obviously too terse. @bjope, I believe the update should address your comments. Comment at: clang/lib/Sema/SemaCast.cpp:2660

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers updated this revision to Diff 282776. vabridgers marked 2 inline comments as done. vabridgers added a comment. remove -DFIXED_POINT from lit test, since it's not needed in this casting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/n

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers added inline comments. Comment at: clang/test/Sema/warn-bad-function-cast.c:49 +#ifdef FIXED_POINT + (void)(_Fract) if1(); // no warning +#endif bjope wrote: > bjope wrote: > > bjope wrote: > > > This should be added before the line saying `/* All fol

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

ast added a comment. Is it a cleanup or is it a fix for some bug? If latter there should be a new test for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85174/new/ https://reviews.llvm.org/D85174 __

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. Tested locally. Previously failing tests are now passing. All recorded relocations look correct. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. Bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45849 This is caused by gap area not emitted if either `AfterLoc` or `BeforeLoc` is a macro loca

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullDereference.h:21 +namespace ento { +namespace nullDereference { + Namespaces are traditionally snake_case rather than camelCase. Comment at: clang/lib/StaticAnalyzer/C

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 282798. NoQ marked an inline comment as done. NoQ added a reviewer: vsavchenko. NoQ added a comment. Herald added a subscriber: steakhal. And rebase. Addressed comments. With @Szelethus's refactoring work the patch actually looks much cleaner than it used to.

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.h:36 const Preprocessor &PP, \ const cross_tu::CrossTranslationUnitContext &CTU); +#include "clang/Analysis/PathDi

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

yonghong-song added a comment. In D83242#2192130 , @anakryiko wrote: > LGTM. One question: why didn't we run into the need for SeqNumVal trick with > field-based relocations? We seem to need it for all other types (including > type ID-based), but not for

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

yonghong-song added a comment. In D85174#2192269 , @ast wrote: > Is it a cleanup or is it a fix for some bug? If latter there should be a new > test for it? This is also to fix the CSE issue where two builtins are CSE'ed if one has type "struct t" and t

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

yonghong-song updated this revision to Diff 282801. yonghong-song added a comment. add a test case in clang where testing type existence of a named struct and the typedef of that named struct will result in different IR intrinsic func arguments which will prevent CSE which may lose one of ditype

[PATCH] D85124: [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

nridge accepted this revision. nridge added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/AST/ast-dump-concepts.cpp:18 // CHECK: TemplateTypeParmDecl {{.*}} referenced Concept {{.*}} 'binary_concept' - // CHECK-NEXT: |-ConceptS

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

nridge updated this revision to Diff 282804. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85108/new/ https://reviews.llvm.org/D85108 Files: clang-tools-extra/clangd/unittests/FindTargetTests.cpp

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

bjope added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2660 return; + if (SrcType->isIntegerType() && DestType->isFixedPointType()) +return; vabridgers wrote: > bjope wrote: > > Is this really the intention with the patch? > > > > It does

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

nridge updated this revision to Diff 282805. nridge added a comment. Rebase to avoid dependency on D84136 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85108/new/ https://reviews.llvm.org/D85108 Files: clang-too

[clang-tools-extra] 4ede396 - [clang] Include trailing-requires-clause in FunctionDecl's source range

Author: Nathan Ridge Date: 2020-08-04T02:52:01-04:00 New Revision: 4ede3968498174f35f8456cd4bf95d14811d40d1 URL: https://github.com/llvm/llvm-project/commit/4ede3968498174f35f8456cd4bf95d14811d40d1 DIFF: https://github.com/llvm/llvm-project/commit/4ede3968498174f35f8456cd4bf95d14811d40d1.diff

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ede39684981: [clang] Include trailing-requires-clause in FunctionDecl's source range (authored by nridge). Repository: rG LLVM Github Monorepo C

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge updated this revision to Diff 282807. nridge added a comment. Rebase on top of D85108 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://reviews.llvm.org/D84136 Files: clang-tools-extra/clan

<    1   2