[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:187 + /// The hash used for module cache paths. + std::string ModuleHash; + In the previous version of this patch, this value was derived from the stem of `ModuleCachePath`. Howev

[clang] 731292e - Updated the -I option description.

Author: Andrei Lebedev Date: 2020-07-31T15:39:12-07:00 New Revision: 731292e5f30074c282d5ea1ebb86bb7adbc9e90e URL: https://github.com/llvm/llvm-project/commit/731292e5f30074c282d5ea1ebb86bb7adbc9e90e DIFF: https://github.com/llvm/llvm-project/commit/731292e5f30074c282d5ea1ebb86bb7adbc9e90e.diff

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added a comment. Thanks. Looking. In D81242#2183383 , @tejohnson wrote: > I just noticed that generateParamAccessSummary is taking a bit over 5% of the > ThinLTO thin link step in an internal build (and will soon be more than 5% as > I found

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps added a comment. Thank you for your comments on the review! I will respond soon; also have been swamped this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84467/new/ https://reviews.llvm.org/D84467 ___

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added a comment. In D81242#2183383 , @tejohnson wrote: > Is the stack safety analysis meant to be always on with ThinLTO? During compilation most of the time it should be off. However during linking I assume that most build FS->paramAccesses()

[PATCH] D81242: [StackSafety] Run ThinLTO

tejohnson added a comment. In D81242#2188441 , @vitalybuka wrote: > In D81242#2183383 , @tejohnson wrote: > >> Is the stack safety analysis meant to be always on with ThinLTO? > > During compilation most of the time

Re: [clang] 740a164 - PR46377: Fix dependence calculation for function types and typedef

Heads-up: This causes Chromium's build to fail with clang-cl: /usr/local/google/home/thakis/src/chrome/src/third_party/llvm/clang/lib/AST/ASTContext.cpp:4823: clang::QualType clang::ASTContext::getPackExpansionType(clang::QualType, llvm::Optional, bool): Assertion `(!ExpectPackInType || Pattern->c

Re: [clang] 740a164 - PR46377: Fix dependence calculation for function types and typedef

Sorry, the repro link should've pointed to https://bugs.chromium.org/p/chromium/issues/detail?id=1110981#c22 which has a nicer stack. On Fri, Jul 31, 2020 at 7:22 PM Nico Weber wrote: > Heads-up: This causes Chromium's build to fail with > > clang-cl: > /usr/local/google/home/thakis/src/chrome/s

[PATCH] D81213: [RISCV] Support experimental v extension v0.9.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG721d93fc5aa8: Support experimental v extension v0.9. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 721d93f - Support experimental v extension v0.9.

Author: Hsiangkai Wang Date: 2020-08-01T07:42:06+08:00 New Revision: 721d93fc5aa8c9f9fc9b86a9d3d1a58c6790213e URL: https://github.com/llvm/llvm-project/commit/721d93fc5aa8c9f9fc9b86a9d3d1a58c6790213e DIFF: https://github.com/llvm/llvm-project/commit/721d93fc5aa8c9f9fc9b86a9d3d1a58c6790213e.diff

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2430 + +These overloads support destinations and sources which are a mix of the +following qualifiers: Comment at: clang/docs/LanguageExtensions.rst:2454 +and might be

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:408-412 +SmallString<128> Msg; +llvm::raw_svector_ostream Out(Msg); +TagDetails.trackValidExpr(BR); +TagDetails.explainSmartPtrAction(Out); +

[PATCH] D85034: [analyzer] Simplified functions SVal::getAsSymbolicExpression and similar ones

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. *standing ovation* This was long overdue, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85034/new/ https://reviews.llvm.org/D85034 __

[clang] 234f51a - Don't crash if we deserialize a pack expansion type whose pattern

Author: Richard Smith Date: 2020-07-31T17:19:44-07:00 New Revision: 234f51a65a45b79402996ac6f0abcbb5793814bf URL: https://github.com/llvm/llvm-project/commit/234f51a65a45b79402996ac6f0abcbb5793814bf DIFF: https://github.com/llvm/llvm-project/commit/234f51a65a45b79402996ac6f0abcbb5793814bf.diff

Re: [clang] 740a164 - PR46377: Fix dependence calculation for function types and typedef

Thanks, was just an overzealous assertion. Should be fixed in llvmorg-12-init-1765-g234f51a65a4. On Fri, 31 Jul 2020 at 16:23, Nico Weber wrote: > Sorry, the repro link should've pointed to > https://bugs.chromium.org/p/chromium/issues/detail?id=1110981#c22 which > has a nicer stack. > > On Fri,

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:408-412 +SmallString<128> Msg; +llvm::raw_svector_ostream Out(Msg); +TagDetails.trackValidExpr(BR); +TagDetails.explainSmartPtrAction(Out); +retur

[PATCH] D85026: [analyzer] Minor refactoring of SVal::getSubKind function

NoQ accepted this revision. NoQ added a comment. That's a fair point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85026/new/ https://reviews.llvm.org/D85026 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:408-412 +SmallString<128> Msg; +llvm::raw_svector_ostream Out(Msg); +TagDetails.trackValidExpr(BR); +TagDetails.explainSmartPtrAction(Out); +retur

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:408-412 +SmallString<128> Msg; +llvm::raw_svector_ostream Out(Msg); +TagDetails.trackValidExpr(BR); +TagDetails.explainSmartPtrAction(Out); +

[PATCH] D84812: [clang-tidy][NFC] Added convienence methods for getting optional options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fd2049e38da: [clang-tidy][NFC] Added convienence methods for getting optional options (authored by njames93). Changed prior to commit: https://re

[clang-tools-extra] 1fd2049 - [clang-tidy][NFC] Added convienence methods for getting optional options

Author: Nathan James Date: 2020-08-01T01:45:34+01:00 New Revision: 1fd2049e38daf0992f63883d68609b85dfb9cb26 URL: https://github.com/llvm/llvm-project/commit/1fd2049e38daf0992f63883d68609b85dfb9cb26 DIFF: https://github.com/llvm/llvm-project/commit/1fd2049e38daf0992f63883d68609b85dfb9cb26.diff

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. It would be good to split this into (at least) two patches. The first should do the minimal testable amount of work to get instruction selection working, and follow-on patches can add the other parts, like additions to the object file format. Part of the reason for that

LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping @njames93. Does this look ok to you? If so, could you please help me with the commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing l

<    1   2