[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert updated this revision to Diff 278175. jdoerfert added a comment. Add warning and negative test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 Files: clang/include/clang/AST/OpenMPClause.h cla

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 278174. gamesh411 added a comment. fix documentation header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan added a comment. In D82663#2144551 , @rjmccall wrote: > In D82663#2144219 , @ebevhan wrote: > > > In D82663#2142426 , @rjmccall > > wrote: > > > > > Would it be sens

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 278176. gamesh411 marked an inline comment as done. gamesh411 added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files: clang-tools-extra/clang-tidy

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:87 + ` check. + Finds functions registered by ``atexit`` and ``at_quick_exit`` that are calling + exit functions ``_Exit``, ``exit``, ``quick_exit`` or ``longjmp``. Euge

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 278178. gamesh411 marked an inline comment as done. gamesh411 added a comment. add missing newline in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Fi

[PATCH] D83698: Port Target option flags to new option parsing system

dang updated this revision to Diff 278179. dang added a comment. Remove -triple that got duplicated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698 Files: clang/include/clang/Driver/Options.td clang/lib

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:87 + ` check. + Finds functions registered by ``atexit`` and ``at_quick_exit`` that are calling + exit functions ``_Exit``, ``exit``, ``quick_exit`` or ``longjmp``. Eugene.Ze

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:87 + ` check. + Finds functions registered by ``atexit`` and ``at_quick_exit`` that are calling + exit functions ``_Exit``, ``exit``, ``quick_exit`` or ``longjmp``. game

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 278181. gamesh411 added a comment. tidy up release notes, make all new check entries uniform Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files: clang-tools-extr

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 278184. gamesh411 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp clang-tools-

[PATCH] D83516: [PowerPC][Power10] 128-bit Binary Integer Operation instruction definitions and MC Tests

amyk accepted this revision. amyk added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83516/new/ https://reviews.llvm.org/D83516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 added a comment. @Eugene.Zelenko I have just rebase-d, and seen that the release notes page itself was bumped to clang-tidy 12. I have added my check as a new check there. Should I also add the other subsections (like improvements in existing checks, and new check aliases), or authors

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

Eugene.Zelenko added a comment. In D83717#2153245 , @gamesh411 wrote: > @Eugene.Zelenko I have just rebase-d, and seen that the release notes page > itself was bumped to clang-tidy 12. I have added my check as a new check > there. Should I also add the o

[PATCH] D83696: [OPENMP]Fix PR46688: cast the type of the allocated variable to the initial one.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. We might need to pick this for 11. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83696/new/ https://reviews.llvm.org/D83696 _

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Szelethus added a comment. While this patch spans across a lot of files, it is actually rather straightforward. I'm stunned to see that we never really had a proper dynamic size support, especially that this patch has been out there for a good long time :) Oh well, better learn that now than ne

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 marked 2 inline comments as done. gamesh411 added a comment. In D83717#2153246 , @Eugene.Zelenko wrote: > In D83717#2153245 , @gamesh411 wrote: > > > @Eugene.Zelenko I have just rebase-d, and seen that th

[PATCH] D83696: [OPENMP]Fix PR46688: cast the type of the allocated variable to the initial one.

ABataev added a comment. In D83696#2153258 , @jdoerfert wrote: > LGTM. We might need to pick this for 11. Yes, just like the fix for user-defined reduction from https://reviews.llvm.org/D83334 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus marked an inline comment as done. walrus added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2011 + Expr *Init = D->getInit(); + if (D->getInitStyle() == VarDecl::CallInit && !isa(Init)) +OS << "("; kadircet wrote: > what abo

[PATCH] D83334: [OPENMP]Fix PR46593: Reduction initializer missing construnctor call.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Typo in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83334/new/ https://reviews.llvm.org/D83334

[PATCH] D83832: [OpenMP] Provide a flag to disable safety checks for GPU optimizations

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I think this is good. It's dangerous, but it's also undocumented and has unsafe in the name. I should be able to use this to sidestep limitations in the amdgpu function poin

[PATCH] D83681: [clang] Provide a more specific diagnostic for a misplaced lambda capture-default.

riccibruno added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:937 + return Invalid([&] { +Diag(Tok.getLocation(), diag::err_capture_default_first); + }); aaron.ballman wrote: > Would it make sense to provide a fix-it to move the

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

vrnithinkumar created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

yonghong-song updated this revision to Diff 278190. yonghong-song retitled this revision from "[RFC][BPF] support expr with typedef type for FIELD_EXISTENCE reloc" to "[clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc". yonghong-song edited the summary of this revision.

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

vrnithinkumar marked an inline comment as done. vrnithinkumar added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:131 +} \ No newline at end of file I will fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D83681: [clang] Provide a more specific diagnostic for a misplaced lambda capture-default.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Parse/ParseExprCXX.cpp:937 + return Invalid([&] { +Diag(Tok.getLocation(), diag::err_capture_default_first); + });

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

yonghong-song added a comment. The llvm change is here: https://reviews.llvm.org/D83878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D83242 ___ cfe-commits mailing

[PATCH] D83772: [Windows] Fix limit on command line size

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks! I know it was more work, but I think unifying the command line generation to work the same in both cases will avoid future surprises. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen updated this revision to Diff 278197. khchen added a comment. address @lenary's comment, good catch!! thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124 Files: clang/lib/Basic/Targets/RISCV.c

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:965 + template + void swap(unique_ptr &x, unique_ptr &y) noexcept { +x.swap(y)

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. I am happy with this. I think we should get it landed so we can backport it to the LLVM 11 branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D83788: Removed unused variable in clang

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. No problem, thanks for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-comm

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

kadircet added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2011 + Expr *Init = D->getInit(); + if (D->getInitStyle() == VarDecl::CallInit && !isa(Init)) +OS << "("; walrus wrote: > kadircet wrote: > > what about having a `Pre` and

[PATCH] D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() {

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

xazax.hun added inline comments. Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:962 + operator bool() const; + unique_ptr &operator=(unique_ptr &&p); +}; vrnithinkumar wrote: > added this to support use case like `Q = std::move(P)` This o

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:92 TextGenerator Note; - llvm::Any Metadata; + AnyGenerator Metadata = [](const ast_matchers::MatchFinder::MatchResult &) { +return llvm::Any(

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9566 +MEHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + CapturedVarSet, /*PresentModifierOnly=*/true); In today's OpenMP/LLVM cal

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

vrnithinkumar updated this revision to Diff 278207. vrnithinkumar edited the summary of this revision. vrnithinkumar added a comment. Untrack all changing regions in checkRegionChanges Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83836/new/ https:

[PATCH] D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

Szelethus added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() { FILE *F1 = tmpfile(); if (!F1) r

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:189-190 +// or rvalue references. +// In case of an InstanceCall don't invalidate the this-region since +// it is fu

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9566 +MEHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + CapturedVarSet, /*PresentModifierOnly=*/true); jdenny wrote: > In today'

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Szelethus added a comment. Please do not bypass the previous comments that hadn't reached a conclusion -- littering inlines about miscellaneous stuff at this stage does more harm then good, and derails the discussion. Its not the first time I took a look, and I made some progress today again, b

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9566 +MEHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + CapturedVarSet, /*PresentModifierOnly=*/true); ABataev wrote: > jdenny wr

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 278216. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/CMakeLists.txt

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2152747 , @labath wrote: > I wouldn't mind separate (internal) cache variable, though I am somewhat > surprised by this problem. A (non-cache) variable set in one of the parent > scopes should still take precedence over

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Hmm, there is actually a case the old behavior may have been papering over: case-insensitive filesystems. If the real file is foo.cc and we query Foo.cc, then the trie would (inefficient

[clang] d6e79e3 - [OpenMP][Docs] Update `present` map type modifier status

Author: Joel E. Denny Date: 2020-07-15T11:17:00-04:00 New Revision: d6e79e3dd6df63425eb098f482be2c9744ad48eb URL: https://github.com/llvm/llvm-project/commit/d6e79e3dd6df63425eb098f482be2c9744ad48eb DIFF: https://github.com/llvm/llvm-project/commit/d6e79e3dd6df63425eb098f482be2c9744ad48eb.diff

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added a comment. In D83501#2148671 , @dgoldman wrote: > I implemented goto-definition from Foo() --> Foo impl in Xrefs, on the > symbolcollector side I don't think there's anything to do? This can't be done purely in xrefs as the AST may not b

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9566 +MEHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + CapturedVarSet, /*PresentModifierOnly=*/true); jdenny wrote: > ABataev w

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff updated this revision to Diff 278221. sepavloff added a comment. Fixed unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 Files: llvm/include/llvm/Support/Program.h llvm/lib/Support/Win

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

NoQ added inline comments. Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:964-965 + + template + void swap(unique_ptr &x, unique_ptr &y) noexcept { +x.swap(y); You seem to be relying on the fact that global `std::swap` is implemented

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 278218. c-rhodes edited the summary of this revision. c-rhodes added a comment. Herald added a subscriber: dang. Added `-msve-vector-bits=` flag. If specified the `__ARM_FEATURE_SVE_BITS__EXPERIMENTAL` macro is defined and a language option `ArmSveVectorBit

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:97 +// If a region is removed all of the subregions needs to be removed too. +static ProgramStateRef removeTrackedRegions(ProgramStateRef State, nit: *need to b

[clang] ef30a00 - [NFC] Add float aggregate ABI test for PowerPC

Author: Qiu Chaofan Date: 2020-07-16T00:11:09+08:00 New Revision: ef30a00a57c78a91571a66555f2531af0f1f51e5 URL: https://github.com/llvm/llvm-project/commit/ef30a00a57c78a91571a66555f2531af0f1f51e5 DIFF: https://github.com/llvm/llvm-project/commit/ef30a00a57c78a91571a66555f2531af0f1f51e5.diff L

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX updated this revision to Diff 278230. ArcsinX added a comment. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83621/new/ https://reviews.llvm.org/D83621 Files: clang/lib/Tooling/FileMatchTrie.cpp clang/unittests/Tooling

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

xazax.hun added inline comments. Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:964-965 + + template + void swap(unique_ptr &x, unique_ptr &y) noexcept { +x.swap(y); NoQ wrote: > You seem to be relying on the fact that global `std::sw

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added a comment. Thanks, this looks pretty good, I think there are a couple of adjustments... Comment at: clang-tools-extra/clangd/XRefs.cpp:276 getDeclAtPosition(AST, CurLoc, Relations, NodeKind)) { // Special case: void foo() ^override: jump to the over

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:99 // load vd, (rs1), vm class VUnitStrideLoad I believe that with the changes introduced in the encoding of the loads and stores we can do without the `mop` parameter in mos

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX marked 3 inline comments as done. ArcsinX added a comment. As far as I do not have commit access, could you please commit for me? Aleksandr Platonov Comment at: clang/lib/Tooling/FileMatchTrie.cpp:111 + // As far as we do not support file symlinks we compare +

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap updated this revision to Diff 278235. Conanap marked 7 inline comments as done. Conanap added a comment. Formatting fixes, fixed test case return type, updated builtins' signatures to correct signatures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 278237. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files: clang-tools

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:63 +trace::Span Tracer("Remote index server Lookup"); +SPAN_ATTACH(Tracer, "LookupRequest", Request->ShortDebugString()); clangd::LookupRequest Req; s

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks for the changes @c-rhodes, the use of a LANGOPT for this makes sense to me. With my nits addressed, I'm happy with the patch if @aaron.ballman is. Comment at: c

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev planned changes to this revision. kbobyrev added a comment. Wrap marshalling into a class, think about filtering vs failing? I think filtering should be done on the clangd-indexer side and marshalling should deal with **valid** symbols only and shouldn't have to filter them. Repositor

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand updated this revision to Diff 277992. guiand added a comment. Update tests again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/ https://reviews.llvm.org/D82317 Files: clang/test/ARCMT/objcmt-instancetype.m clang/test/ARCMT/obj

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:198 void SmartPtrModeling::handleSwap(const CallEvent &Call, CheckerContext &C) const { I think it would be good to add some

[PATCH] D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

NoQ accepted this revision. NoQ added a comment. In D83120#2152919 , @Szelethus wrote: > Unless @NoQ has anything else to add :) @balazske seems innocent indeed! :) :) :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added a comment. I applied this patch locally and ran the fuzzer tests. I get a segfault: $ clang++ -fsanitize=fuzzer -g -m32 SimpleHashTest.cpp $ gdb --args ./a.out -seed=1 ... (gdb) run ... Program received signal SIGSEGV, Segmentation fault. 0x in ?? () (gdb

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

rjmccall added a comment. In D82663#2153176 , @ebevhan wrote: > In D82663#2144551 , @rjmccall wrote: > > > In D82663#2144219 , @ebevhan wrote: > > > > > In D82663#2142426

[PATCH] D83892: Port CodeGen option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83698 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83892 Files: clang/include/clang

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 278249. c-rhodes added a comment. - Add a note to docs explaining this feature is a WIP. - `s/__ARM_FEATURE_SVE_BITS__EXPERIMENTAL/__ARM_FEATURE_SVE_BITS_EXPERIMENTAL`. - `s/validIntegerConstantExpr/verifyValidIntegerConstantExpr`. - Removed unrelated change.

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes marked 6 inline comments as done. c-rhodes added inline comments. Comment at: clang/test/Sema/arm-feature-sve-bits-macro.c:3 + +#include + aaron.ballman wrote: > c-rhodes wrote: > > aaron.ballman wrote: > > > This should not be using a system include (u

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: kristof.beyls. When a device function calls a host function or vice versa, this is wrong-sided reference. Currently clang immediately diagnose it. This is different from nvcc behavior, where it is diagnosed only

[clang] 268025e - Fix "unused variable" warning from recent GCC.

Author: Richard Smith Date: 2020-07-15T11:33:25-07:00 New Revision: 268025e2636c023fc39eed80cc4589f7ce9db786 URL: https://github.com/llvm/llvm-project/commit/268025e2636c023fc39eed80cc4589f7ce9db786 DIFF: https://github.com/llvm/llvm-project/commit/268025e2636c023fc39eed80cc4589f7ce9db786.diff

[PATCH] D83897: [X86] Add a generic 32-bit CPU with sse2 with modern tuning flags to be used as the default for the 32-bit targets instead of pentium4

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, echristo, andreadb. Herald added subscribers: jfb, hiraditya. Herald added a project: LLVM. Currently our default 32-bit CPU on Linux and Windows is "pentium4" which comes with pentium4 tuning settings and almost n

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer updated this revision to Diff 278262. asoffer added a comment. Add comments describing why we provide defaults for Metadata generation and design of withMetadata function template. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83820/new/ h

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer marked 4 inline comments as done. asoffer added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:92 TextGenerator Note; - llvm::Any Metadata; + AnyGenerator Metadata = [](const ast_matchers::MatchFinder::MatchResult &) { +return

[clang] 9dc327d - [OPENMP]Fix PR46688: cast the type of the allocated variable to the initial one.

Author: Alexey Bataev Date: 2020-07-15T14:54:19-04:00 New Revision: 9dc327d1b74637dac6dc432fb66f88711af16a55 URL: https://github.com/llvm/llvm-project/commit/9dc327d1b74637dac6dc432fb66f88711af16a55 DIFF: https://github.com/llvm/llvm-project/commit/9dc327d1b74637dac6dc432fb66f88711af16a55.diff

[PATCH] D83696: [OPENMP]Fix PR46688: cast the type of the allocated variable to the initial one.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dc327d1b746: [OPENMP]Fix PR46688: cast the type of the allocated variable to the initial one. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 41d0af0 - [OPENMP]Fix PR46593: Reduction initializer missing construnctor call.

Author: Alexey Bataev Date: 2020-07-15T15:14:22-04:00 New Revision: 41d0af00740ac5140f11c7f37157fc6e6dd1b016 URL: https://github.com/llvm/llvm-project/commit/41d0af00740ac5140f11c7f37157fc6e6dd1b016 DIFF: https://github.com/llvm/llvm-project/commit/41d0af00740ac5140f11c7f37157fc6e6dd1b016.diff

[PATCH] D83334: [OPENMP]Fix PR46593: Reduction initializer missing construnctor call.

This revision was automatically updated to reflect the committed changes. Closed by commit rG41d0af00740a: [OPENMP]Fix PR46593: Reduction initializer missing construnctor call. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D83334?vs=277448&id=278276#toc Repository:

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

tra added subscribers: jlebar, rsmith. tra added a comment. > This is different from nvcc behavior, where it is diagnosed only if the > function is really emitted: That by itself is not a sufficient reason for relaxing the checks. Clang is stricter/more principled in diagnosing other questional

[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

bsaleil added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:28 + return vec_mul(vulla, vullb); +} + Are the tests for `vec_mul` with `v4i32` missing ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

ast added a comment. lgtm. curious what happens when type is defined within args, like: __builtin_preserve_field_info(*(struct { int a; } *)0, 2); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D83242 _

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

ymandel added a comment. Looks like your changes to the .cpp and test files were reverted... Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:93 + // Not all transformations will want or need to attach metadata and therefore + // sholud not be requierd to do

[PATCH] D83398: [OPENMP50]Perform data mapping analysis only for explicitly mapped data.

ABataev updated this revision to Diff 278284. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83398/new/ https://reviews.llvm.org/D83398 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_map_messages.c

[PATCH] D83897: [X86] Add a generic 32-bit CPU with sse2 with modern tuning flags to be used as the default for the 32-bit targets instead of pentium4

echristo added a comment. Did you want to just change the pentium4 tuning? Otherwise naming things is hard and this feels awkward, but I don't have any better ideas :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83897/new/ https://reviews.llvm.org/D83897 __

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Hey, quick question about this change: I'm seeing .cache directories appear off of subdirectories too, not just my project root: Untracked files: 31 #» .cache/

[PATCH] D83901: [clang] Disable a few formatting options for test/

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, jdoerfert, lebedev.ri, MyDeveloperDay. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Hopefully this will make the bot a little less noisy. Rationale for each: `AlignTrailingComments`: We don

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 278291. lildmh added a comment. Update diff and pass test. Please accept CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

anakryiko added a comment. This is awesome. I'll apply patches locally and will play with them tonight to see if everything works in libbpf as well. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D83242

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

yonghong-song added a comment. In D83242#2154145 , @ast wrote: > lgtm. > curious what happens when type is defined within args, like: > __builtin_preserve_field_info(*(struct { int a; } *)0, 2); -bash-4.4$ clang -target bpf -O2 -g -S t1.c t1.c:3:40: er

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9566 +MEHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + CapturedVarSet, /*PresentModifierOnly=*/true); ABataev wrote: > jdenny wr

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. @grokos Could you upstream this patch and the runtime patch neck to neck? Upstreaming one of them will break the OpenMP offloading. It will be nice if you can test this patch locally with the runtime patch. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9566 +MEHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + CapturedVarSet, /*PresentModifierOnly=*/true); jdenny wrote: > ABataev w

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

vsapsai added a comment. Didn't get into details but overall GenModuleActionWrapper approach looks pretty complicated. Haven't tried to accomplish the same myself, so cannot say if such complexity is warranted or not. What happens with fixits in modules when you don't have GenModuleActionWrappe

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

sammccall added a comment. In D83099#2154185 , @davidvancleve wrote: > Hey, quick question about this change: > > I'm seeing .cache directories appear off of subdirectories too, not just my > project root: > > 1. Untracked files: 31 #» .cache/ 32 #»

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 7 inline comments as done. dgoldman added a comment. In D83501#2153605 , @sammccall wrote: > In D83501#2148671 , @dgoldman wrote: > > > I implemented goto-definition from Foo() --> Foo impl in Xrefs,

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

zixuw added a comment. In D82118#2154280 , @vsapsai wrote: > Didn't get into details but overall GenModuleActionWrapper approach looks > pretty complicated. Haven't tried to accomplish the same myself, so cannot > say if such complexity is warranted or n

<    1   2   3   >