[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

amyk updated this revision to Diff 276881. amyk added a comment. Rebased patch, and addressed review comments of having a single `CHECK`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82467/new/ https://reviews.llvm.org/D82467 Files: clang/lib/H

[clang] a5569f0 - Push parameters into the local instantiation scope before instantiating

Author: Richard Smith Date: 2020-07-09T17:24:20-07:00 New Revision: a5569f089844209dbea2e3241460173d7b6b1420 URL: https://github.com/llvm/llvm-project/commit/a5569f089844209dbea2e3241460173d7b6b1420 DIFF: https://github.com/llvm/llvm-project/commit/a5569f089844209dbea2e3241460173d7b6b1420.diff

[clang] 7462793 - Move default argument instantiation to SemaTemplateInstantiateDecl.cpp.

Author: Richard Smith Date: 2020-07-09T17:24:19-07:00 New Revision: 7462793be771712092de4c31fef1b04ac365ccea URL: https://github.com/llvm/llvm-project/commit/7462793be771712092de4c31fef1b04ac365ccea DIFF: https://github.com/llvm/llvm-project/commit/7462793be771712092de4c31fef1b04ac365ccea.diff

[clang] f721e05 - PR46648: Do not eagerly instantiate default arguments for a generic

Author: Richard Smith Date: 2020-07-09T17:24:20-07:00 New Revision: f721e0582b158c60c56d2601235b6d60758f4d7a URL: https://github.com/llvm/llvm-project/commit/f721e0582b158c60c56d2601235b6d60758f4d7a DIFF: https://github.com/llvm/llvm-project/commit/f721e0582b158c60c56d2601235b6d60758f4d7a.diff

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.is

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea updated this revision to Diff 276890. asbirlea added a comment. This revision is now accepted and ready to land. Updated to include the part of the patch that's moving the Updates to a CFGDiff object. Splitting off from the clean-up work merging the two branches when BUI is null. This p

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea updated this revision to Diff 276891. asbirlea added a comment. Nit: re-add `const`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77341/new/ https://reviews.llvm.org/D77341 Files: llvm/include/llvm/IR/Dominators.h llvm/include/llvm/S

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto &C : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any(&IR)); + ShouldRun &= C(Pass.name(), Pass.is

[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

rjmccall added a comment. I agree that avoiding the copy is best. However, at the very least, if that function isn't going to handle the aggregate case correctly, it should assert that it isn't in it. Otherwise this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D83514: [Lexer] Fix missing coverage line after #endif

zequanwu updated this revision to Diff 276899. zequanwu added a comment. Herald added subscribers: usaxena95, kadircet, jkorous. Fix clangd unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83514/new/ https://reviews.llvm.org/D83514 Files: clang-tools-extra/clangd/SemanticHigh

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

oontvoo created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: shafik. Herald added a project: clang. This helps avoiding hacks downstream. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83529 Files: clang/include/clang/AST/Stmt.h c

[clang] 00c9a50 - CrashTracer: clang at clang: llvm::BitstreamWriter::ExitBlock

Author: Oliver Hunt Date: 2020-07-09T20:27:33-07:00 New Revision: 00c9a504aeed2603bd8bc9b89d753534e929c8e8 URL: https://github.com/llvm/llvm-project/commit/00c9a504aeed2603bd8bc9b89d753534e929c8e8 DIFF: https://github.com/llvm/llvm-project/commit/00c9a504aeed2603bd8bc9b89d753534e929c8e8.diff L

[PATCH] D83509: CrashTracer: clang at clang: llvm::BitstreamWriter::ExitBlock

jfb added a comment. I don't remember if this will auto-close, since I forgot to add the Phabricator ID to the commit message. In any case it's in: 00c9a504aeed2603bd8bc9b89d753534e929c8e8 Repository: rG LLVM Github Monor

[clang] ceb76d2 - [CMake][Fuchsia] Move runtimes to outer scope

Author: Petr Hosek Date: 2020-07-09T21:07:44-07:00 New Revision: ceb76d2fe73d39f2230bf55d47b8fd68849d47d7 URL: https://github.com/llvm/llvm-project/commit/ceb76d2fe73d39f2230bf55d47b8fd68849d47d7 DIFF: https://github.com/llvm/llvm-project/commit/ceb76d2fe73d39f2230bf55d47b8fd68849d47d7.diff LO

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1246 + +// AIX `power` alignment does not apply the preferred alignment for +// non-union classes if the source of the alignment (the current base in Move the

[PATCH] D82574: Merge TableGen files used for clang options

dang added a comment. Yes I committed this a while ago, I duplicated all the functionality in Options.td. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new/ https://reviews.llvm.org/D82574 ___ c

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

nridge updated this revision to Diff 276911. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83371/new/ https://reviews.llvm.org/D83371 Files: clang-tools-ext

[clang-tools-extra] 98d763a - [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

Author: Nathan Ridge Date: 2020-07-10T01:58:34-04:00 New Revision: 98d763ad051f5eab89fa46167516fc8a84f471d0 URL: https://github.com/llvm/llvm-project/commit/98d763ad051f5eab89fa46167516fc8a84f471d0 DIFF: https://github.com/llvm/llvm-project/commit/98d763ad051f5eab89fa46167516fc8a84f471d0.diff

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG98d763ad051f: [clangd] Factor out some helper functions related to heuristic resolution in… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:196 switch (E->getStmtClass()) { case Stmt::CXXDependentScopeMemberExprClass: { const auto *ME = llvm::cast(E); hokein wrote: > I'm doubting whether we will miss some oth

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 276916. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-ext

[PATCH] D83511: [clangd] Config: If.PathExclude

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp:73 + Frag.If.PathMatch.emplace_back("b.*"); + Frag.If.PathExclude.emplace_back(".*r"); + EXPECT_F

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276919. eduucaldas marked 9 inline comments as done. eduucaldas added a comment. Use right function to get TokSpelling, answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://review

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1210 + 12_t; // call: operator<'1', '2'> "" _x() | kind: integer + 1.2_t; // call: operator<'1', '2'> "" _x() | kind: float } gribozavr2 wrote: > call -> calls? (as in,

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f24331fd91: Add diagnostic option backing field for -fansi-escape-codes (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https

[clang] 50f2433 - Add diagnostic option backing field for -fansi-escape-codes

Author: Daniel Grumberg Date: 2020-07-10T07:26:56+01:00 New Revision: 50f24331fd91e70de6bf6c3efe45272ddfc711fd URL: https://github.com/llvm/llvm-project/commit/50f24331fd91e70de6bf6c3efe45272ddfc711fd DIFF: https://github.com/llvm/llvm-project/commit/50f24331fd91e70de6bf6c3efe45272ddfc711fd.dif

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:723 + syntax::UserDefinedLiteralExpression * + buildUserDefinedLiteral(UserDefinedLiteral *S) { +switch (S->getLiteralOperatorKind()) {

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. anyway, I'm fine with this change, feel free to submit it as-is (or do any refinements), don't really want the naming to block this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

<    1   2   3