[PATCH] D81728: [InstCombine] Add target-specific inst combining

2020-07-01 Thread Chris Lattner via Phabricator via cfe-commits
lattner requested changes to this revision. lattner added a comment. This revision now requires changes to proceed. This looks like a great direction, but please make sure to minimize public implementation details. We don't want the vast majority of instcombine to be visible outside of its libr

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

2020-07-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82940/new/ https://reviews.llvm.org/D82940 _

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

2020-07-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This (or a follow-up) broke tests on windows: http://45.33.8.238/win/18877/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82185/new/ https://revie

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-07-01 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 274736. dang added a comment. Remove the need for the merger and extractor to be macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang/Driver

[PATCH] D82944: [clangd] Switch FindSymbolsTests to use TestTU

2020-07-01 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This gets rid of the dependency on ClangdServer and a bunch of extra infrastructure coming with it. Als

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

2020-07-01 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss added a comment. @j0le patch is landed but I just realised the review is still blocked by @compnerd. So it won't be closed I think, that is my bad. https://github.com/llvm/llvm-project/commit/070acb1d1e51ffd289a46b8f93e993635d0053b7 CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-01 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham updated this revision to Diff 274739. simon_tatham added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Here's a completely different patch, which adds all the missing dependencies on `OMP.h.inc` in the `clang` subdirectory in one go. Repository:

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

2020-07-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 274743. kbobyrev added a comment. Remove unused variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

2020-07-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 274741. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436 Files: clang-to

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

2020-07-01 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. Let me take a look. Reduced test case: class C {} b; void should_not_crash_with_switch_in_lambda() { switch (1) default:; auto f = [] { switch (1) default:; }; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

2020-07-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:281 + Range.startCharacter = Symbol.range.start.character; + Range.endLine = Symbol.range.end.line; + Range.endCharacter = Symbol.range.end.character; sammccall wrote: > How u

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

2020-07-01 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 274742. baloghadamsoftware added a comment. Rebased on `master` which now contains the handling of pointers as iterators. All tests passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files:

<    1   2   3