[PATCH] D82284: [AST][RecoveryAST] Preseve invalid return stmt, and suppress the diagnostics for missing return stmt in constexpr func.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82284 Files: clang/lib/Sema/SemaStmt.cpp clang/test/AST/ast-dump-recovery.cpp clang/test/SemaCXX/constant-expression-cxx11.cpp

[PATCH] D81932: [clang-tidy] Improved accuracy of check list updater script

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Excellent, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81932/new/ https://reviews.llvm.org/D81932 _

[clang] 46ea465 - Return false if the identifier is not in the global module index.

Author: Vassil Vassilev Date: 2020-06-22T08:03:11Z New Revision: 46ea465b5b741fb0bf6e2cedd5cd6bf7026cd3c6 URL: https://github.com/llvm/llvm-project/commit/46ea465b5b741fb0bf6e2cedd5cd6bf7026cd3c6 DIFF: https://github.com/llvm/llvm-project/commit/46ea465b5b741fb0bf6e2cedd5cd6bf7026cd3c6.diff LO

[PATCH] D82169: Don't install clang-import-test

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Makes sense to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82169/new/ https://reviews.llvm.org/D82169 _

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

sdesmalen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1345 +: Intrinsic<[llvm_nxv4f32_ty], +[llvm_nxv4f32_ty, + llvm_nxv8bf16_ty, nit: keep this on one line. Repository: rG LLVM Github Monor

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1811 +def int_aarch64_sve_cvt_bf16f32 : Builtin_SVCVT<"svcvt_bf16_f32_m", llvm_nxv8bf16_ty, llvm_nxv

[PATCH] D81077: If the identifier is unknown, return false.

This revision was automatically updated to reflect the committed changes. Closed by commit rG46ea465b5b74: Return false if the identifier is not in the global module index. (authored by v.g.vassilev). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 028571d - [clang][Driver] Correct tool search path priority

Author: David Spickett Date: 2020-06-22T09:41:13+01:00 New Revision: 028571d60843cb87e2637ef69ee09090d4526c62 URL: https://github.com/llvm/llvm-project/commit/028571d60843cb87e2637ef69ee09090d4526c62 DIFF: https://github.com/llvm/llvm-project/commit/028571d60843cb87e2637ef69ee09090d4526c62.diff

[clang] f570d58 - Revert "[clang][Driver] Correct tool search path priority"

Author: David Spickett Date: 2020-06-22T14:18:54+01:00 New Revision: f570d5810485fa6fb2e1009f795a899d79bd429f URL: https://github.com/llvm/llvm-project/commit/f570d5810485fa6fb2e1009f795a899d79bd429f DIFF: https://github.com/llvm/llvm-project/commit/f570d5810485fa6fb2e1009f795a899d79bd429f.diff

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

danielkiss added a comment. j0le, I will commit later this week for you. compnerd do you have any comment for this version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 ___ cfe-commits mailing lis

[PATCH] D82184: [MSP430] Update register names

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f6620f66303: [MSP430] Update register names (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82184/new/ https://r

[clang] 01f9388 - [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter

Author: Denys Petrov Date: 2020-06-22T13:44:27+03:00 New Revision: 01f9388d95aca2cc86ed6b2794e199ef55d16e91 URL: https://github.com/llvm/llvm-project/commit/01f9388d95aca2cc86ed6b2794e199ef55d16e91 DIFF: https://github.com/llvm/llvm-project/commit/01f9388d95aca2cc86ed6b2794e199ef55d16e91.diff

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

kristof.beyls added a comment. Herald added a project: LLVM. This looks fine to me; I just have a number of nit picks. The only part where I don't understand the code logic is around the comment starting with "If this is the final byte of a multi-byte sequence". Comment at: ll

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2105944 , @zhuhan0 wrote: > This broke a test `clang/test/Tooling/clang-check-offload.cpp` for a critical > Linux distro at Facebook. With this change, the test adds a `-include > __clang_hip_runtime_wrapper` argument. T

[PATCH] D82184: [MSP430] Update register names

atrosinenko updated this revision to Diff 272391. atrosinenko added a comment. Fix compile error when building with older compilers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82184/new/ https://reviews.llvm.org/D82184 Files: clang/lib/Basic/

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

junparser added a comment. In D82029#2100675 , @modocache wrote: > Excellent, thank you! The test failures on the diff appear to be legitimate, > they reproduce for me when I apply this patch to my local checkout and run > `ninja check-clang`. Could you

[clang] cba56e0 - [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

Author: Loïc Joly Date: 2020-06-22T12:56:29+02:00 New Revision: cba56e026c7beb91a2716276151c5b4360032834 URL: https://github.com/llvm/llvm-project/commit/cba56e026c7beb91a2716276151c5b4360032834 DIFF: https://github.com/llvm/llvm-project/commit/cba56e026c7beb91a2716276151c5b4360032834.diff LOG

[PATCH] D82259: Deprecate error prone temporary directory APIs

sammccall added a comment. In D82259#2106279 , @davezarzycki wrote: > Sure, we can honor XDG_CACHE_DIR. Maybe as a followup, somebody can wire up > Darwin's cache directory (which is retrievable via a BSD specific `confstr()` > API with `_CS_DARWIN_USER

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett added a comment. Committed but made a mistake with arc so it landed with the wrong diff number. In any case a failure on MacOS was reported so reverted while I investigate that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki updated this revision to Diff 272406. miyuki added a comment. 1. Rebased and fixed failures 2. Added a test for AArch64 codegen of lane copying intrinsics 3. Addressed reviewers' comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80928/new/ https://reviews.llvm.org/D80928 Fi

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki marked 5 inline comments as done. miyuki added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066 if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" || + Name == "vcvt_f32_f64" || Name == "vcvt_f64_f32" || LukeGeeson wrote:

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, efriedma, stuij, fpetrogalli, david-arm. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLVM. Bfloat16 support

[clang] b30c166 - Implement constexpr BinaryOperator for vector types

Author: Erich Keane Date: 2020-06-22T07:05:43-07:00 New Revision: b30c16670e428d09a0854a8f418e46a3e705e4d1 URL: https://github.com/llvm/llvm-project/commit/b30c16670e428d09a0854a8f418e46a3e705e4d1 DIFF: https://github.com/llvm/llvm-project/commit/b30c16670e428d09a0854a8f418e46a3e705e4d1.diff L

[clang] 8f6620f - [MSP430] Update register names

Author: Anatoly Trosinenko Date: 2020-06-22T13:24:03+03:00 New Revision: 8f6620f663031da2bb35b788239f4b607271af84 URL: https://github.com/llvm/llvm-project/commit/8f6620f663031da2bb35b788239f4b607271af84 DIFF: https://github.com/llvm/llvm-project/commit/8f6620f663031da2bb35b788239f4b607271af84.

[clang] c2b22c5 - Fixed ASTMatchers registry and regen ast docs

Author: Nathan James Date: 2020-06-22T10:56:20+01:00 New Revision: c2b22c57fc1394f2566d20369ae29877eb7df1a1 URL: https://github.com/llvm/llvm-project/commit/c2b22c57fc1394f2566d20369ae29877eb7df1a1 DIFF: https://github.com/llvm/llvm-project/commit/c2b22c57fc1394f2566d20369ae29877eb7df1a1.diff

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai added a comment. I would like to get a 2nd opinion before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D82284: [AST][RecoveryAST] Preseve invalid return stmt, and suppress the diagnostics for missing return stmt in constexpr func.

sammccall added a comment. This is a nice coverage improvement but diagnostic changes don't seem to particularly be improvements... not opposed to landing as-is but want to consider if we can mitigate these... Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:1798

[clang-tools-extra] 2306329 - [clang-tidy] Improved accuracy of check list updater script

Author: Nathan James Date: 2020-06-22T11:07:24+01:00 New Revision: 23063296b539feb405fb3ce61711a3c1cc1c94d0 URL: https://github.com/llvm/llvm-project/commit/23063296b539feb405fb3ce61711a3c1cc1c94d0 DIFF: https://github.com/llvm/llvm-project/commit/23063296b539feb405fb3ce61711a3c1cc1c94d0.diff

[PATCH] D82184: [MSP430] Update register names

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. Looks good to me! FP was an old register name from mspgcc time. MSP430 EABI does not use frame pointer at all (seems to be a bug in the ABI, as I do not understand how we could support VLAs or alloc

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

martong created this revision. martong added reviewers: Szelethus, balazske, NoQ, xazax.hun, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald ad

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

steven.zhang accepted this revision. steven.zhang added a comment. This revision is now accepted and ready to land. LGTM now and thank you for doing this. Please hold on for 2-3 days in case others have comments. And thank you for pointing a potential issue of the folding of fneg + fma. We will

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske updated this revision to Diff 272361. balazske added a comment. - Rebase - Using condition type for `evalBinOp` - Comments updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81061/new/ https://reviews.llvm.org/D81061 Files: clang/lib

[PATCH] D81932: [clang-tidy] Improved accuracy of check list updater script

This revision was automatically updated to reflect the committed changes. Closed by commit rG23063296b539: [clang-tidy] Improved accuracy of check list updater script (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81932/new/ h

[PATCH] D82259: Deprecate error prone temporary directory APIs

davezarzycki added a comment. Sure, we can honor XDG_CACHE_DIR. Maybe as a followup, somebody can wire up Darwin's cache directory (which is retrievable via a BSD specific `confstr()` API with `_CS_DARWIN_USER_CACHE_DIR`). I'm not sure about other platforms. I'll wait for more feedback before u

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

krisb added inline comments. Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:155 SmallString<128> Dir(computeSysRoot()); llvm::sys::path::append(Dir, "include"); addSystemInclude(DriverArgs, CC1Args, Dir.str()); Seems the driver stops adding `msp430-e

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl updated this revision to Diff 272378. avl added a comment. 1. deleted code doing more strict tailcall marking. 2. left removal of "AllCallsAreTailCalls". 3. added check for non-capturing calls while tracking alloca. 4. re-titled the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82279: Handle invalid types in the nullPointerConstant AST matcher

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:2618 + )"; + EXPECT_TRUE(matches(kTest, expr(nullPointerConstant(; } steveire wrote: > While this test

[PATCH] D82092: [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter

This revision was automatically updated to reflect the committed changes. Closed by commit rG01f9388d95ac: [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter (authored by ASDenysPetrov). Changed prior to commit: https://reviews.llvm.org/D82092?vs=272007&id=272379#toc R

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

This revision was automatically updated to reflect the committed changes. Closed by commit rGcba56e026c7b: [ASTMatcher] Correct memoization bug ignoring direction (descendants or… (authored by loic-joly-sonarsource, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 632088c - [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter

Author: Denys Petrov Date: 2020-06-22T14:19:13+03:00 New Revision: 632088c7e84a7ff625c8c67cdc392849b1358f5d URL: https://github.com/llvm/llvm-project/commit/632088c7e84a7ff625c8c67cdc392849b1358f5d DIFF: https://github.com/llvm/llvm-project/commit/632088c7e84a7ff625c8c67cdc392849b1358f5d.diff

[clang] e935a54 - [Analyzer][StreamChecker] Add note tags for file opening.

Author: Balázs Kéri Date: 2020-06-22T11:15:35+02:00 New Revision: e935a540ea29d5de297595801aed1fb70fabfbf6 URL: https://github.com/llvm/llvm-project/commit/e935a540ea29d5de297595801aed1fb70fabfbf6 DIFF: https://github.com/llvm/llvm-project/commit/e935a540ea29d5de297595801aed1fb70fabfbf6.diff L

[clang] 2580635 - Let HIP default include respect -nogpuinc and -nogpulib

Author: Yaxun (Sam) Liu Date: 2020-06-22T08:39:12-04:00 New Revision: 2580635bd2f3c0527353e4d7823326cd9f92ff7c URL: https://github.com/llvm/llvm-project/commit/2580635bd2f3c0527353e4d7823326cd9f92ff7c DIFF: https://github.com/llvm/llvm-project/commit/2580635bd2f3c0527353e4d7823326cd9f92ff7c.dif

[clang] be9c581 - [analyzer] Remove forbidden characters from a filename for a graph dump on Windows

Author: Denys Petrov Date: 2020-06-22T17:27:20+03:00 New Revision: be9c5818351bf99a193edbc82e4dc25ab5206a44 URL: https://github.com/llvm/llvm-project/commit/be9c5818351bf99a193edbc82e4dc25ab5206a44 DIFF: https://github.com/llvm/llvm-project/commit/be9c5818351bf99a193edbc82e4dc25ab5206a44.diff

Re: [clang] 028571d - [clang][Driver] Correct tool search path priority

Hi, https://reviews.llvm.org/D79988 is apparently a "Restricted Differential Revision" and I don't have permissions to do that. This being an open source project, this is not something we do. I'm guessing it's not intentional? This also breaks check-clang on macOS: http://45.33.8.238/mac/15950/st

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 272416. dang added a comment. Add a `KeyPathPrefix` field to factor out common key path prefixes, for example all `CodeGenOpts`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar added a comment. "Ping". I hope this can be considered for 10.0.1. If nothing else I think reviewing the test cases has a lot of value - there are some real issues with the current checks and fixits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe9c5818351b: [analyzer] Remove forbidden characters from a filename for a graph dump on… (authored by ASDenysPetrov). Changed prior to commit: https://reviews.llvm.org/D82103?vs=272204&id=272427#toc R

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le added a comment. In D75453#2094938 , @danielkiss wrote: > Sorry for the delay, it is okay to say "ping" after a while :) > LGTM Hi Daniel, no problem, thanks for comming back to this review after that long time. I will say "ping" next time :) Can

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong abandoned this revision. martong added a comment. Since D80016 we are able to look up types in the TU, so this patch is no longer needed. We'd like to be as precise with the function signatures as possible. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

martong abandoned this revision. martong added a comment. This patch is no longer needed because I am going to upstream the POSIX functions in groups, otherwise the patch would be hideously large. The groups are: file handling, networking, pthread_, mq_, dbm_, regex related, sched_, time, signa

[PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

sdesmalen updated this revision to Diff 272342. sdesmalen added a comment. - Updated RUN line in tests to fix test failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82187/new/ https://reviews.llvm.org/D82187 Files: clang/include/clang/Basic/AArch64SVEACLETypes.def clang/inclu

[PATCH] D79430: [analyzer] StdLibraryFunctionsChecker: Add LazyRanges to support type dependent Max

martong abandoned this revision. martong added a comment. Since D80016 we are able to look up types in the TU, so we can get the maximum value from the found type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7943

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe935a540ea29: [Analyzer][StreamChecker] Add note tags for file opening. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D81407?vs=271291&id=272355#toc Repository: rG LLVM Gi

[PATCH] D82162: [clang-tidy] RenamerClangTidy wont emit fixes in scratch space

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82162/new/ https://reviews.llvm.org/D82162

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

njames93 updated this revision to Diff 272433. njames93 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80202/new/ https://reviews.llvm.org/D80202 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp Index: clang/lib/ASTMatcher

[PATCH] D82259: Deprecate error prone temporary directory APIs

davezarzycki updated this revision to Diff 272434. davezarzycki added a comment. 1. Respect Darwin and XDG cache directories. 2. Drop atypical reverse DNS in the path. 3. Make clang more robust if the default module path cannot be determined. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82302 Files: clang/include/clang/Tooling/Syntax/Nodes.h Index: clang/include/clang/Tooling/Syntax/Nodes.h ==

[clang] 6cb80fb - Revert "[MSP430] Update register names"

Author: Anton Korobeynikov Date: 2020-06-22T13:37:22+03:00 New Revision: 6cb80fbe405264471e9bc5b6ea19694e51ae1b11 URL: https://github.com/llvm/llvm-project/commit/6cb80fbe405264471e9bc5b6ea19694e51ae1b11 DIFF: https://github.com/llvm/llvm-project/commit/6cb80fbe405264471e9bc5b6ea19694e51ae1b11.

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. Ping. I made the change suggested by @erichkeane . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D82281: [clang-tidy] llvm-twine-local ignores parameters

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82281/new/ https://reviews.llvm.org/D82281

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

aaron.ballman added a comment. In D81769#2106574 , @jaafar wrote: > "Ping". I hope this can be considered for 10.0.1. If nothing else I think > reviewing the test cases has a lot of value - there are some real issues with > the current checks and fixits.

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

klimek added a reviewer: sammccall. klimek added a comment. +Sam for additional sanity checking. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:902 // Maps (matcher, node) -> the match result for memoization. - typedef std::map MemoizationMap; + typedef std::map> Mem

[PATCH] D82306: [Sema][CodeComplete][ObjC] Don't split the first selector fragment

dgoldman created this revision. dgoldman added reviewers: sammccall, doug.gregor. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, dexonsmith, ilya-biryukov. Herald added a project: clang. Standardize the formatting of selector fragments to include the ':', e.g. for `- (void)

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas updated this revision to Diff 272445. eduucaldas added a comment. update comments, rollback references, and add them as proposition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82302/new/ https://reviews.llvm.org/D82302 Files: clang/

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

lxfind added a comment. All tests are passing now. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/ https://reviews.llvm.org/D82029 ___ cfe-commits mailing list cfe-commit

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

atrosinenko marked 3 inline comments as done. atrosinenko added a comment. Thank you for the comments. Will send an update soon. Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:155 SmallString<128> Dir(computeSysRoot()); llvm::sys::path::append(Dir, "include"); addS

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

erichkeane added a comment. The test needs work (check/check-not lines+ filecheck), otherwise I think this should be alright, particularly if no one else has commented in a while. I'd like to have you upload an updated test validating what you think should be happening before approving though.

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos marked an inline comment as done. nigelp-xmos added inline comments. Comment at: clang/test/CodeGen/xcore-unused-inline.c:4 + +inline void dead_function(void) {} erichkeane wrote: > What is this test validating? It should likely have a check line of s

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval reopened this revision. clementval added a comment. This revision is now accepted and ready to land. Missing dependencies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81736/new/ https://reviews.llvm.org/D81736 ___

[PATCH] D82259: Deprecate error prone temporary directory APIs

compnerd added a comment. Thanks @davezarzycki! Minor nit: git-clang-format the patch please, there was at least one linter warning in the changed code. I do wonder if we can get away with the removal of the API though doing that in a follow up is pretty reasonable to me. I think that one min

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Comment at: clang/utils/TableGen/SveEmitter.cpp:1092 + OS << "#if !defined(__ARM_FEATURE_BF16_SCALAR_ARITHMETIC)\n"; + OS << "#error \"__ARM_FEATURE

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82310 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas marked 3 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:268 +/// Expression for boolean literals. C++ [lex.bool] +class BoolLiteralExpression final : public Expression { Homogenize th

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel marked 2 inline comments as done. aardappel added a comment. I'll likely fork `userstack.ll` since the majority of lines need changes. Comment at: lld/wasm/Driver.cpp:385 +StringRef s = arg->getValue(); +if (s == "wasm32") + config->is64 = false;

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added a comment. Hi @HsiangKai, thanks for the patch. So far everything looks good aside from a couple of minor nits. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1638 + + if (getLexer().getKind() == AsmToken::EndOfStatement) { +Operands.push_b

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

njames93 updated this revision to Diff 272470. njames93 added a comment. Fix checks failing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80202/new/ https://reviews.llvm.org/D80202 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp Index: clang/li

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn updated this revision to Diff 272471. john.brawn retitled this revision from "[Driver] When forcing a crash call abort to get the correct diagnostic" to "[Driver] When forcing a crash print the bug report message". john.brawn edited the summary of this revision. john.brawn added a comm

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + true; + false; +} C99 has bool literals, but the program should include stdbool.h. I feel like it is better to make the predicate something like "hasBoolType()" a

[PATCH] D82259: Deprecate error prone temporary directory APIs

aprantl added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3176 + if (llvm::sys::path::cache_directory(Result)) { +llvm::sys::path::append(Result, "clang"); +llvm::sys::path::append(Result, "ModuleCache"); I would prefer to separate this

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

fpetrogalli requested changes to this revision. fpetrogalli added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ldnf1.c:2-4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHME

[clang] ef597ed - [sve][acle] Add SVE BFloat16 extensions.

Author: Francesco Petrogalli Date: 2020-06-22T16:53:02Z New Revision: ef597eda8efc2e6ee35eceda10bb5ba7c6109696 URL: https://github.com/llvm/llvm-project/commit/ef597eda8efc2e6ee35eceda10bb5ba7c6109696 DIFF: https://github.com/llvm/llvm-project/commit/ef597eda8efc2e6ee35eceda10bb5ba7c6109696.dif

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

baloghadamsoftware updated this revision to Diff 272469. baloghadamsoftware retitled this revision from "[Analyzer][WIP] Handle pointer implemented as iterators in iterator checkers" to "[Analyzer] Handle pointer implemented as iterators in iterator checkers". baloghadamsoftware edited the summar

[PATCH] D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82206/new/ https://reviews.llvm.org/D82206

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82312 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/B

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

tra added a comment. In D78655#2105058 , @yaxunl wrote: > - lambdas with any lambda-capture (which must therefore have an enclosing > function) inherit the enclosing function's HDness. Nit: *any* capture does not necessarily imply existence of the enclo

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

lxfind created this revision. lxfind added reviewers: lewissbaker, modocache, junparser. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we ever assign co_await to a temporary variable, such as foo(co_await expr), we generate AST that looks like this: MaterializedTempora

[PATCH] D82313: [OpenCL] Reject block arguments

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. OpenCL 2.0 does not allow block arguments, primarily because it is difficult to support function pointers on the various architectures that OpenCL targets. Clang was still accepting them. Rename

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

fpetrogalli updated this revision to Diff 272480. fpetrogalli added a comment. Formatting changes. NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82141/new/ https://reviews.llvm.org/D82141 Files: clang/include/clang/Basic/arm_sve.td clang/

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Great! Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:68 + else +CmdArgs.push_back("-m wasm32"); + All the other drivers seem to do `CmdArgs.pu

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: llvm/lib/Support/PrettyStackTrace.cpp:36 +static const char *BugReportMsg = +"PLEASE submit a bug report to " BUG_REPORT_URL This variable is mutable. Please use `const char BugReportMsg[]` CHANGES SINCE LAST ACT

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. Herald added a reviewer: jdoerfert. Hi, I do not have access to commit, could anybody help me to commit it? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef597eda8efc: [sve][acle] Add SVE BFloat16 extensions. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82141/new/ https://reviews.l

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval requested review of this revision. clementval added a comment. @jdoerfert @jdenny I had to add a bunch of dependencies so that the file is generated correctly when needed. Do you have any feedback on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 37fb860 - Add support of __builtin_expect_with_probability

Author: Zhi Zhuang Date: 2020-06-22T10:21:28-07:00 New Revision: 37fb860301272d8138d289da5b606115b3fe5a13 URL: https://github.com/llvm/llvm-project/commit/37fb860301272d8138d289da5b606115b3fe5a13 DIFF: https://github.com/llvm/llvm-project/commit/37fb860301272d8138d289da5b606115b3fe5a13.diff LO

[clang-tools-extra] 6ae0f5f - [clang-tidy] RenamerClangTidy wont emit fixes in scratch space

Author: Nathan James Date: 2020-06-22T18:26:18+01:00 New Revision: 6ae0f5f3e1d465e6a663a50f2cc077671bc6d097 URL: https://github.com/llvm/llvm-project/commit/6ae0f5f3e1d465e6a663a50f2cc077671bc6d097 DIFF: https://github.com/llvm/llvm-project/commit/6ae0f5f3e1d465e6a663a50f2cc077671bc6d097.diff

[clang-tools-extra] 9a8b041 - [clang-tidy] llvm-twine-local ignores parameters

Author: Nathan James Date: 2020-06-22T18:25:45+01:00 New Revision: 9a8b0411448062e7231a0ee26bd14a3d1c097e9e URL: https://github.com/llvm/llvm-project/commit/9a8b0411448062e7231a0ee26bd14a3d1c097e9e DIFF: https://github.com/llvm/llvm-project/commit/9a8b0411448062e7231a0ee26bd14a3d1c097e9e.diff

[clang] 3a4feb1 - [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

Author: Mikhail Maltsev Date: 2020-06-22T17:35:43Z New Revision: 3a4feb1d53df68bed7748a0625b593ba4b5dae32 URL: https://github.com/llvm/llvm-project/commit/3a4feb1d53df68bed7748a0625b593ba4b5dae32 DIFF: https://github.com/llvm/llvm-project/commit/3a4feb1d53df68bed7748a0625b593ba4b5dae32.diff LO

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

kmclaughlin added a comment. In D79167#2098774 , @efriedma wrote: > Is it possible to write tests for this that don't result in a "max" or "min" > operation? Or does that fail for some other reason? > > Otherwise LGTM. Thanks for reviewing this, @efrie

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

kmclaughlin updated this revision to Diff 272483. kmclaughlin added a comment. Added tests to llvm-ir-to-intrinsic.ll which check the results of compare instructions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79167/new/ https://reviews.llvm.org/D79167 Files: llvm/lib/CodeGen/Sele

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 272492. eduucaldas added a comment. removing automatically added include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82318/new/ https://reviews.llvm.org/D82318 Files: clang/include/clang/Tooling/Syntax/

  1   2   >