[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:406 +const ExplodedNode *StreamChecker::getAcquisitionSite(const ExplodedNode *N, + Sy

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

njames93 added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:495-498 +bool HasChecks = false; +for (const auto &Source : Sources) + HasChecks |= Source.first.Checks.hasValue(); +if (!HasChecks) `if (llvm::none_of(Sourc

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

njames93 added a comment. I'm of the idea that rather than having `ClangdTidyOptionsProvider` inherit form `tidy::ClangTidyOptionsProvider`, just have it as its own class. We don't need the interface offered by clang tidy here. It would solve the `must be threadsafe` comment issue as well as re

[clang] 12c8e36 - [Clang][Sema] Use of incorrect __has_feature vs __has_builtin

Author: Guillaume Chatelet Date: 2020-06-18T09:00:12Z New Revision: 12c8e3632edda3bc640867ba326b52b5b2220a57 URL: https://github.com/llvm/llvm-project/commit/12c8e3632edda3bc640867ba326b52b5b2220a57 DIFF: https://github.com/llvm/llvm-project/commit/12c8e3632edda3bc640867ba326b52b5b2220a57.diff

[clang] 1d7b4a7 - [SveEmitter] Add builtins for tuple creation (svcreate2/svcreate3/etc)

Author: Sander de Smalen Date: 2020-06-18T10:07:09+01:00 New Revision: 1d7b4a7e5e4a25605ec9926da1fb461840a1f216 URL: https://github.com/llvm/llvm-project/commit/1d7b4a7e5e4a25605ec9926da1fb461840a1f216 DIFF: https://github.com/llvm/llvm-project/commit/1d7b4a7e5e4a25605ec9926da1fb461840a1f216.di

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

klimek added a comment. In D80961#2099262 , @steveire wrote: > In D80961#2095254 , @klimek wrote: > > > 1. the scare quotes around "standing objections" reads like you're not > > respecting the opinions of others h

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.c:7 +#warning defined as expected +// expected-warning@-1 {{defined as expected}} +#endif gchatelet wrote: > efriedma wrote: > > melver

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet marked 3 inline comments as done. gchatelet added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.c:7 +#warning defined as expected +// expected-warning@-1 {{defined as expected}} +#endif efriedma wrote: > melver wrote: > > It appear

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

atrosinenko updated this revision to Diff 271610. atrosinenko added a comment. fix unit test: add another "-lgcc" and (hopefully) fix path separators on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D816

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 271613. fhahn added a comment. Rebased after recent parent patches landed. Will commit shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72781/new/ https://reviews.llvm.org/D72781 Files: clang/include/cla

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

atrosinenko updated this revision to Diff 271612. atrosinenko added a comment. 1. Since different quite unrelated patches failed on Jun 5 with quite the same messages, just rebase onto current `master` expecting build failure to go away 2. Ping Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D81463: [SveEmitter] Add builtins for tuple creation (svcreate2/svcreate3/etc)

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d7b4a7e5e4a: [SveEmitter] Add builtins for tuple creation (svcreate2/svcreate3/etc) (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

RKSimon edited reviewers, added: efriedma; removed: eli.friedman. RKSimon added a comment. Any frontend people got any comments on this? I'm keen to see constexpr vector support added but know next to nothing about the frontend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:406 +const ExplodedNode *StreamChecker::getAcquisitionSite(const ExplodedNode *N, + SymbolRef StreamSym, balazske wro

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

fhahn updated this revision to Diff 271617. fhahn added a comment. Rebased after recent changes landed upstream. Will commit shortly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72782/new/ https://reviews.llvm.org/D72782 Files: clang/include/cl

[PATCH] D81946: [WIP][RISCV] Enable multilib support even without a detected GCC install

simoncook added a comment. Thanks for this Ed. I've tried building a toolchain with it and noticed a couple of things: 1. Printing the set of multilibs doesn't provide a default, I think that should still be defined and printed with `-print-multi-libs` 2. There's a slight path finding issue if

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271620. eduucaldas marked 7 inline comments as done. eduucaldas added a comment. - cleanup for upstreaming - better coverage for unqualified-id - Better coverage for qualified-id - Finish implementing unqualified-id. Repository: rG LLVM Github Monorepo

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked an inline comment as not done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; gribozavr2 wrote: > Should there be getters for various parts

[clang] 934bcaf - [Matrix] Add __builtin_matrix_column_load to Clang.

Author: Florian Hahn Date: 2020-06-18T10:47:55+01:00 New Revision: 934bcaf10b57fc199d9b15722ea50f65a791ca4e URL: https://github.com/llvm/llvm-project/commit/934bcaf10b57fc199d9b15722ea50f65a791ca4e DIFF: https://github.com/llvm/llvm-project/commit/934bcaf10b57fc199d9b15722ea50f65a791ca4e.diff

[clang] 108560e - Try to remove the acle_sve_adda.s file that's breaking tests

Author: Hans Wennborg Date: 2020-06-18T11:59:53+02:00 New Revision: 108560e58c41fc70341d763b941a0d6c24c4d3a9 URL: https://github.com/llvm/llvm-project/commit/108560e58c41fc70341d763b941a0d6c24c4d3a9 DIFF: https://github.com/llvm/llvm-project/commit/108560e58c41fc70341d763b941a0d6c24c4d3a9.diff

[clang] 4ea8e27 - [SveEmitter] Add builtins to insert/extract subvectors from tuples (svget/svset)

Author: Sander de Smalen Date: 2020-06-18T11:06:16+01:00 New Revision: 4ea8e27a642c6f97ca69cd39bbe44f7366870f6c URL: https://github.com/llvm/llvm-project/commit/4ea8e27a642c6f97ca69cd39bbe44f7366870f6c DIFF: https://github.com/llvm/llvm-project/commit/4ea8e27a642c6f97ca69cd39bbe44f7366870f6c.di

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271630. eduucaldas added a comment. Fix mistake on getting SourceRange for template-id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/T

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10792 def err_builtin_matrix_pointer_arg: Error< - "%select{first|second}0 argument must be a pointer to a valid matrix element type">; + "%0 argu

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG934bcaf10b57: [Matrix] Add __builtin_matrix_column_load to Clang. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72781/new/ https://revi

[PATCH] D81464: [SveEmitter] Add builtins to insert/extract subvectors from tuples (svget/svset)

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ea8e27a642c: [SveEmitter] Add builtins to insert/extract subvectors from tuples (svget/svset) (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:187 +/// A sequence of these specifiers make a `nested-name-specifier` +class NameSpecifier final : public Tree { Could you provide examples or a grammar quote in the comme

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

guiand added a comment. Adding the function attribute turns out to have other challenges. Specifically, we don't want to have transforms remove a `frozen` from a parameter and then have to go through and update all the other parameters. This might happen if the function is marked with `frozen_a

[PATCH] D81886: [AMDGPU] Add gfx1030 target

rampitec marked an inline comment as done. rampitec added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:266-267 names. + ``gfx1030`` ``amdgcn`` dGPU - xnack

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

efriedma added a comment. So I guess we've discussed the following alternatives so far: 1. Attach the "frozen" attribute everywhere; this makes the textual IR generated by clang messy, and likely bloats memory usage (not sure by how much). 2. Invert the meaning of the attribute; this makes reaso

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

eugenis added a comment. In D81678#2099444 , @efriedma wrote: > So I guess we've discussed the following alternatives so far: > > 1. Attach the "frozen" attribute everywhere; this makes the textual IR > generated by clang messy, and likely bloats memory u

[clang] b5e082e - [Matrix] Add __builtin_matrix_column_store to Clang.

Author: Florian Hahn Date: 2020-06-18T11:39:02+01:00 New Revision: b5e082e7289197bf82c9a28c6336b51d7999b419 URL: https://github.com/llvm/llvm-project/commit/b5e082e7289197bf82c9a28c6336b51d7999b419 DIFF: https://github.com/llvm/llvm-project/commit/b5e082e7289197bf82c9a28c6336b51d7999b419.diff

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff updated this revision to Diff 271648. sepavloff added a comment. Updated patch according to reviewer's notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 Files: clang/docs/UsersManual.rst c

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai created this revision. Kai added reviewers: uweigand, yusra.syeda, kbarton, eli.friedman, MaskRay, hubert.reinterpretcast, cor3ntin, ldionne, tahonermann, simoll, kaz7, stuij. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya. Herald added projects: clang, LLVM. Adds

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5e082e72891: [Matrix] Add __builtin_matrix_column_store to Clang. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72782/new/ https://rev

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -t

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

Xiangling_L updated this revision to Diff 271661. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Address comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81972/new/ https://reviews.llvm.org/D81972 Files: clang/lib/CodeGen/CGDeclCXX.cpp Index: clan

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

riccibruno updated this revision to Diff 271659. riccibruno added a comment. - Remove a left-over FIXME in the tests. - Use a `%select` in the diagnostic. - Pack `AdditionalSourceLocationData` into two `unsigned`s. - Simplify the chain walking code in `checkUsage`. - Mark the patch as needing revi

[clang] d8c612b - Make matrix-type-builtins.m pass also on platforms where the type is 'unsigned long long'

Author: Hans Wennborg Date: 2020-06-18T14:06:55+02:00 New Revision: d8c612b7eabcc7ec399fad533d5beefa4ae08ac9 URL: https://github.com/llvm/llvm-project/commit/d8c612b7eabcc7ec399fad533d5beefa4ae08ac9 DIFF: https://github.com/llvm/llvm-project/commit/d8c612b7eabcc7ec399fad533d5beefa4ae08ac9.diff

[clang] ada4c9d - [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

Author: Lucas Prates Date: 2020-06-18T13:17:07+01:00 New Revision: ada4c9dc4a63160b6b3cfd5965884c6cce2a405c URL: https://github.com/llvm/llvm-project/commit/ada4c9dc4a63160b6b3cfd5965884c6cce2a405c DIFF: https://github.com/llvm/llvm-project/commit/ada4c9dc4a63160b6b3cfd5965884c6cce2a405c.diff

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

Szelethus added a comment. Balázs, could you please add the checker option within this patch? If we find that the option works well (removes a lot of useless reports) I'd be happy to help implement that uniqueing pass. CmdLineOption, Comment at: clang/lib/StaticAnalyzer/Ch

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 271664. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Adjust the patch corresponding to D81972 ; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D741

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff updated this revision to Diff 271665. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 Files: clang/docs/UsersManual.rst clang/include/clang/Driver/Job.

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

stuij added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -targe

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

atrosinenko updated this revision to Diff 271670. atrosinenko added a comment. Fix test once again (replace more literal slashes with regex). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 Files: clang/i

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 271668. Xiangling_L added a comment. Fix the previous bad version; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/ItaniumMangle.cpp clang/lib/

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

atrosinenko updated this revision to Diff 271671. atrosinenko added a comment. Rebase onto working upstream commit to (hopefully) make tests pass for my patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81408/new/ https://reviews.llvm.org/D81408

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a few small nits, but please wait a bit for @njames93 in case they have final thoughts. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagn

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

This revision was automatically updated to reflect the committed changes. Closed by commit rG92ad6d57c218: [ARM] Moving CMSE handling of half arguments and return to the backend (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rGada4c9dc4a63: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from… (authored by pratlucas). Changed prior to commit: https://reviews.llvm.org/D81451?vs=269453&id=271677#toc R

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

This revision was automatically updated to reflect the committed changes. Closed by commit rGa255931c4055: [ARM] Supporting lowering of half-precision FP arguments and returns in… (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] eb4c758 - [Matrix] Pass darwin tripe to SeamObjc test to fix windows bot failure.

Author: Florian Hahn Date: 2020-06-18T13:35:03+01:00 New Revision: eb4c758fe4b60ae3779d3e9401d00ee1450ae41b URL: https://github.com/llvm/llvm-project/commit/eb4c758fe4b60ae3779d3e9401d00ee1450ae41b DIFF: https://github.com/llvm/llvm-project/commit/eb4c758fe4b60ae3779d3e9401d00ee1450ae41b.diff

[clang] c7350a3 - [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump tests

Author: Bruno Ricci Date: 2020-06-18T13:37:29+01:00 New Revision: c7350a3bab14eb633f39a949f85ac0e690cd9b4d URL: https://github.com/llvm/llvm-project/commit/c7350a3bab14eb633f39a949f85ac0e690cd9b4d DIFF: https://github.com/llvm/llvm-project/commit/c7350a3bab14eb633f39a949f85ac0e690cd9b4d.diff L

[clang] 05843dc - [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

Author: Bruno Ricci Date: 2020-06-18T13:37:24+01:00 New Revision: 05843dc6ab97a00cbde7aa4f08bf3692eb83109d URL: https://github.com/llvm/llvm-project/commit/05843dc6ab97a00cbde7aa4f08bf3692eb83109d DIFF: https://github.com/llvm/llvm-project/commit/05843dc6ab97a00cbde7aa4f08bf3692eb83109d.diff L

[clang] 92d8ad0 - [HIP] Fix rocm not found on rocm3.5

Author: Yaxun (Sam) Liu Date: 2020-06-18T08:40:09-04:00 New Revision: 92d8ad02e92fed3884169ba5d98056fe4fa5660d URL: https://github.com/llvm/llvm-project/commit/92d8ad02e92fed3884169ba5d98056fe4fa5660d DIFF: https://github.com/llvm/llvm-project/commit/92d8ad02e92fed3884169ba5d98056fe4fa5660d.dif

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec, b-sumner, foad, nhaehnle. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, wdng, jvesely, kzhuravl. I wasn't sure what the best strategy was for the wave size difference. I went for an explicit, enforced builtin for

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

modocache added a reviewer: junparser. modocache added a subscriber: junparser. modocache added a comment. Excellent, thank you! The test failures on the diff appear to be legitimate, they reproduce for me when I apply this patch to my local checkout and run `ninja check-clang`. Could you take a

[PATCH] D82086: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein edited the summary of this revision. otherwise we'll run into code path which expects a good base specifiers, and lead to crashes. The crash only occurs in template instantiations (in non-templ

[PATCH] D81787: [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

This revision was automatically updated to reflect the committed changes. riccibruno marked an inline comment as done. Closed by commit rG05843dc6ab97: [clang] Fix the serialization of LambdaExpr and the bogus mutation in… (authored by riccibruno). Changed prior to commit: https://reviews.llvm.

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

This revision was automatically updated to reflect the committed changes. Closed by commit rG92d8ad02e92f: [HIP] Fix rocm not found on rocm3.5 (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D81713?vs=270298&id=271689#toc Repository: rG

[PATCH] D81786: [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7350a3bab14: [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump… (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 89ea0b0 - [MC] Pass down argv0 & cc1 cmd-line to the back-end and store in MCTargetOptions

Author: Alexandre Ganea Date: 2020-06-18T09:17:14-04:00 New Revision: 89ea0b05207d45c145fb525df554b3b986ae379b URL: https://github.com/llvm/llvm-project/commit/89ea0b05207d45c145fb525df554b3b986ae379b DIFF: https://github.com/llvm/llvm-project/commit/89ea0b05207d45c145fb525df554b3b986ae379b.dif

[clang] a45409d - [Clang] Move clang::Job::printArg to llvm::sys::printArg. NFCI.

Author: Alexandre Ganea Date: 2020-06-18T09:17:13-04:00 New Revision: a45409d8855a1e4538990507ef25e9b51c090193 URL: https://github.com/llvm/llvm-project/commit/a45409d8855a1e4538990507ef25e9b51c090193 DIFF: https://github.com/llvm/llvm-project/commit/a45409d8855a1e4538990507ef25e9b51c090193.dif

[clang] 403f953 - [CodeView] Add full repro to LF_BUILDINFO record

Author: Alexandre Ganea Date: 2020-06-18T09:17:15-04:00 New Revision: 403f9537924b8910ed4f741ed96c61f5e657915b URL: https://github.com/llvm/llvm-project/commit/403f9537924b8910ed4f741ed96c61f5e657915b DIFF: https://github.com/llvm/llvm-project/commit/403f9537924b8910ed4f741ed96c61f5e657915b.dif

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. **Ping?** CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 created this revision. njames93 added reviewers: alexfh, Eugene.Zelenko, angelgarcia, aaron.ballman, klimek. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Enables support for transforming loops of the form for (auto I = Cont.rbegin(), E = Cont.rend()

[PATCH] D82086: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/test/SemaCXX/invalid-template-base-specifier.cpp:6 +template +struct Crash : decltype(Foo(T())) { // expected-error {{no matching function for call to 'Foo'}} + Crash(){};

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

foad added a comment. > markTails function set IsTailcall bit for functions which are not > last calls: It's OK to set "tail" on any call that satisfies these requirements (from https://llvm.org/docs/LangRef.html#call-instruction): "Both markers [tail and musttail] imply that the callee does n

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2699 +RHSValue.getInt(), Result); + assert(LHSValue.getKind() == APValue::Float && "SHhuld be no other options"); + return handleLogicalOpForVector(LHSValue.getFl

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81972/new/ https://reviews.llvm.org/D81972 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

This revision was automatically updated to reflect the committed changes. Closed by commit rG403f9537924b: [CodeView] Add full repro to LF_BUILDINFO record (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D80833?vs=268906&id=271698#toc Repository: rG LLVM Github Monore

Re: [clang] eb4c758 - [Matrix] Pass darwin tripe to SeamObjc test to fix windows bot failure.

Thanks! I see it also fails on ARM (http://lab.llvm.org:8011/builders/clang-cmake-armv8-lld/builds/4438), so my sneaky change to fix the test (d8c612b7eabcc7ec399fad533d5beefa4ae08ac9) was not enough. On Thu, Jun 18, 2020 at 2:36 PM Florian Hahn via cfe-commits wrote: > > > Author: Florian Hahn >

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commi

[PATCH] D82059: [clang-tidy] RenamerClangTidy group redecls into 1 warning.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:383 +{ + const auto *Canonical = cast(Decl->getCanonicalDecl()); -

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

NoQ added a comment. > Balázs, could you please add the checker option within this patch? I'd rather have this decision made globally. Like, for all //leaks//, or something like that. Our behavior should be consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

Eugene.Zelenko added a comment. It'll be interesting to run improved check over LLVM code base. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:983 +const LangOptions &LangOpts) +: IsEnabled(false), UseCxx20IfAvailable(UseCxx20IfAvailable), +

[PATCH] D81930: [AArch64] Add -mbti flag.

danielkiss planned changes to this revision. danielkiss added a comment. I got some comment internally, the -mbti might suggest it enables the bti feature so I'm going to rename the flag to -mmark-bti-property. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:258 return CGOpts.DataSections && !CGOpts.DisableIntegratedAS; + case Triple::GOFF: +llvm::report_fatal_error("ASan not implemented for GOFF."); Minor nit: GOFF

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, vsavchenko. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Handle `\l` separately for

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, this simplification is obviously correct. I don't mind landing it regardless of the crash. If it gets rid of the crash, even better. I'm still worried about the root cause of the crash though. I

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff marked 2 inline comments as done. sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3814 + llvm::raw_fd_ostream OS(StatReportFile, EC, llvm::sys::fs::OF_Append); + if (!EC) { +if (auto L = OS.tryToLock()) ---

[clang] cab3fc5 - Fix linker error in clang-fuzzer following 89ea0b05207d45c145fb525df554b3b986ae379b.

Author: Alexandre Ganea Date: 2020-06-18T10:07:31-04:00 New Revision: cab3fc53d2e173243a462e9c8e914af58ddbeaba URL: https://github.com/llvm/llvm-project/commit/cab3fc53d2e173243a462e9c8e914af58ddbeaba DIFF: https://github.com/llvm/llvm-project/commit/cab3fc53d2e173243a462e9c8e914af58ddbeaba.dif

[clang] 8374bf4 - [CodeView] Fix generated command-line expansion in LF_BUILDINFO. Fix the 'pdb' entry which was previously a null reference, now an empty string.

Author: Alexandre Ganea Date: 2020-06-18T10:07:30-04:00 New Revision: 8374bf43634725dc02a262a77b5f940fca25938c URL: https://github.com/llvm/llvm-project/commit/8374bf43634725dc02a262a77b5f940fca25938c DIFF: https://github.com/llvm/llvm-project/commit/8374bf43634725dc02a262a77b5f940fca25938c.dif

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

NoQ added a comment. Here are some examples: void test1(int *a, int index1, int index2) { int x = a[index1]; a[index2] = 0; int y = a[index1]; // In reality we don't know but after your patch // we're confident that this is "TRUE". clang_analyzer_eval(x == y); }

[PATCH] D82026: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82026/new/ https://reviews.llvm.org/D82026 _

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM and cleaner than my sketch, thanks a lot :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81478/new/ https://reviews.llvm.org/D81478

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. Thanks again for the changes @sepavloff! Looks good to me! You might wait a bit before commiting, if there are further comments. Comment at: clang/lib/Driver/Driver.cpp:3806

[PATCH] D81593: [analyzer] SATest: Make docker interfaces transparent

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay transparency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81593/new/ https://reviews.llvm.org/D81593

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong added a comment. In D77658#2065174 , @MaskRay wrote: > `arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:` > `Subscribers:` `Tags:` and the text `Summary:` with the following script: > > arcfilter () { > arc amend >

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

NoQ added inline comments. Comment at: clang/utils/analyzer/Dockerfile:10 + +# newer CMake is required by LLVM +RUN wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /etc/apt/trusted.gpg.d/kitware.gpg >/dev/null --

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

NoQ added inline comments. Comment at: clang/utils/analyzer/.dockerignore:2 +./projects \ No newline at end of file NO NeWlINE At EnD oF fILE Comment at: clang/utils/analyzer/projects/box2d/run_static_analyzer.cmd:1 +cmake . -DCMAKE_BUILD_TYPE

[PATCH] D81572: [analyzer] SATest: Add convenience 'docker' command

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81572/new/ https://reviews.llvm.org/D81572 ___ cfe-c

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. I don't have commit access. @njames93 Could you please commit it for me (`hyd-dev `)? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cf

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I agree it is not a good idea. Let's hope no one will complain :) LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82019/new/ https://r

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

NoQ added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:23 +while True: +sleep(3600) + I request comments (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81598/new/ https://reviews.l

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

vsavchenko added a comment. Even though it doesn't seem that necessary, I would still vote to comply with `clang-format` in tests as well. Other then that looks good to me! Additionally, I want to make a note that we are not really working hard on keeping all the scripts and the analyzer itself

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

NoQ added inline comments. Comment at: clang/utils/analyzer/SATestBuild.py:650 Logger = logging.getLogger(test_info.project.name) LOCAL.stdout = StreamToLogger(Logger, logging.INFO) Now that you have a global `Logger`, is this

[PATCH] D81596: [analyzer] SATest: Do not re-run CMake in Docker if not needed

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yeet! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81596/new/ https://reviews.llvm.org/D81596 ___ cfe-

[PATCH] D81595: [analyzer] SATest: Make main script Python2 compatible

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Woohoo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81595/new/ https://reviews.llvm.org/D81595 ___ cf

[PATCH] D81599: [analyzer] SATest: Add 5 more projects for testing

NoQ added a comment. Like in D81592 , we should take a look at enabling assertions. If this boils down to `-DCMAKE_BUILD_TYPE=Debug` then so be it(?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81599/new/ https:

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

NoQ added inline comments. Comment at: clang/utils/analyzer/Dockerfile:15 +# test system dependencies +RUN apt-get update && apt-get install -y \ +git \ NoQ wrote: > Maybe put `apt-get update` on a separate line? > > Also i think you mentioned offline that y

  1   2   3   >