[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 271221. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen added a comment. In D80944#2095564 , @erichkeane wrote: > Note that this causes a regression (reported here) > https://bugs.llvm.org/show_bug.cgi?id=46336 > > The assert added here breaks in the case where a pragma loop attribute is > combined with

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596 } + // Include the filename in the symbol name. Including "sub_" matches gcc I think this patch is missing what @hubert.reinterpretcast mentioned in https://reviews.llvm.org/D7

[PATCH] D81975: [clangd] Add command line option for ClangTidyConfig

njames93 created this revision. njames93 added reviewers: sammccall, kadircet, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Adds a command line flag `clang-tidy-config` for specifing configuration of checks, i

[PATCH] D80342: [SVE] Deprecate default false variant of VectorType::get

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb81c85afdcd: [SVE] Deprecate default false variant of VectorType::get (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80342/new/ http

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 271232. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/Tooling/ReplacementsYaml.h llvm/lib

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81959/new/ https://reviews.llvm.org/D81959 ___ cfe-commits mailing list

[PATCH] D81970: [Clang][Driver] Remove gold linker support for PS4 toolchain

ychen updated this revision to Diff 271237. ychen added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81970/new/ https://reviews.llvm.org/D81970 Files: clang/lib/Driver/ToolChains/PS4CPU.cpp clang/test/Driver/ps4-link

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel marked 6 inline comments as done. ymandel added a comment. Thanks for the review! Comment at: clang/lib/Tooling/Transformer/Parsing.cpp:29 + +namespace { +using llvm::Error; gribozavr2 wrote: > I'm a bit concerned about the abundance of parsers in Clang

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel updated this revision to Diff 271246. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868 Files: clang/include/clang/Tooling/Transformer/Parsing.h clang/lib

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4489 + // DestructCallBlock, otherwise jump to EndBlock directly. + CGF.EmitCXXGuardedInitBranch(NeedsDestruct, DestructCallBlock, EndBlock, + CodeGenFunc

[PATCH] D81966: [clang][module] Improve -Wincomplete-umbrella

zixuw abandoned this revision. zixuw added a comment. Abandoning this revision because the upstream for this work is not correctly tracking the llvm.org branch. The method `setGenModuleActionWrapper` is available in `apple/master` but not in llvm. Repository: rG LLVM Github Monorepo CHANGES

[clang] 4a17769 - [CodeGen][TLS] Set TLS Model for __tls_guard as well.

Author: Jun Ma Date: 2020-06-17T08:31:13+08:00 New Revision: 4a1776979fd8e9473e433d7ec6f2bbf4bf9523ff URL: https://github.com/llvm/llvm-project/commit/4a1776979fd8e9473e433d7ec6f2bbf4bf9523ff DIFF: https://github.com/llvm/llvm-project/commit/4a1776979fd8e9473e433d7ec6f2bbf4bf9523ff.diff LOG: [

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a1776979fd8: [CodeGen][TLS] Set TLS Model for __tls_guard as well. (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https:

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Seems reasonable. I think we need similar handling for `CXXDefaultInitExpr`, for cases like this: int a; struct X { int b = ++a; }; int c = X{} + a; Comment at: clang

[PATCH] D79411: [VE] Clang toolchain for VE

kaz7 added reviewers: hfinkel, b-sumner, jmolloy, kparzysz, majnemer, igorb. kaz7 added a comment. Add people who reviewed patches adding new target to clang. Sorry for bothering you guys, but I appreciate if you review our patch or give us suggestions how to get reviewed. Thanks in advance.

[PATCH] D81330: [clang] SequenceChecker: C++17 sequencing rule for overloaded operators.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. It would be nice to avoid the duplication between the builtin and overloaded cases here, but I don't see a good way to do that. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627 + emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen); +} else { + OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S.hasCancel()); ABataev

[clang] 1b8125b - Don't assert if we find a dependently-typed variable in the

Author: Richard Smith Date: 2020-06-16T19:41:13-07:00 New Revision: 1b8125b041e28a315e5c5fe64441a2fb07a2f5ea URL: https://github.com/llvm/llvm-project/commit/1b8125b041e28a315e5c5fe64441a2fb07a2f5ea DIFF: https://github.com/llvm/llvm-project/commit/1b8125b041e28a315e5c5fe64441a2fb07a2f5ea.diff

[clang] 237c2a2 - DR458: Search template parameter scopes in the right order.

Author: Richard Smith Date: 2020-06-16T19:41:14-07:00 New Revision: 237c2a23b6d4fa953f5ae910dccf492db61bb959 URL: https://github.com/llvm/llvm-project/commit/237c2a23b6d4fa953f5ae910dccf492db61bb959 DIFF: https://github.com/llvm/llvm-project/commit/237c2a23b6d4fa953f5ae910dccf492db61bb959.diff

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval added a comment. In D81736#2096336 , @jdoerfert wrote: > In D81736#2095947 , @clementval > wrote: > > > In D81736#2093926 , @jdoerfert > > wrote: > > > > > Assum

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:64-65 +"-shared", +"-mllvm", +"-amdgpu-internalize-symbols", +"-o", We should probably ad

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware added a comment. In D81718#2096540 , @NoQ wrote: > In D81718#2095965 , > @baloghadamsoftware wrote: > > > Your test case unfortunately does not test what you want, because raw > > pointers are n

[clang] e3fd9dc - [clang] Enable -mms-bitfields by default for mingw targets

Author: Martin Storsjö Date: 2020-06-17T09:37:07+03:00 New Revision: e3fd9dc9734c5775dc6824d0a839702e8d43e7f6 URL: https://github.com/llvm/llvm-project/commit/e3fd9dc9734c5775dc6824d0a839702e8d43e7f6 DIFF: https://github.com/llvm/llvm-project/commit/e3fd9dc9734c5775dc6824d0a839702e8d43e7f6.diff

[clang] beeed36 - [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

Author: Martin Storsjö Date: 2020-06-17T09:37:07+03:00 New Revision: beeed368b60252178f66ab117d8a96ecdc35f60e URL: https://github.com/llvm/llvm-project/commit/beeed368b60252178f66ab117d8a96ecdc35f60e DIFF: https://github.com/llvm/llvm-project/commit/beeed368b60252178f66ab117d8a96ecdc35f60e.diff

[clang] 7b3fe96 - [clang] Don't emit warn_cxx_ms_struct when MSBitfields is enabled globally

Author: Martin Storsjö Date: 2020-06-17T09:37:07+03:00 New Revision: 7b3fe969927731c69ba4d8a428442e1e191f49b5 URL: https://github.com/llvm/llvm-project/commit/7b3fe969927731c69ba4d8a428442e1e191f49b5 DIFF: https://github.com/llvm/llvm-project/commit/7b3fe969927731c69ba4d8a428442e1e191f49b5.diff

[clang] 02fccc2 - Revert "DR458: Search template parameter scopes in the right order."

Author: Richard Smith Date: 2020-06-16T23:53:44-07:00 New Revision: 02fccc26cf6af22c07fb81ff3aa69abd77850028 URL: https://github.com/llvm/llvm-project/commit/02fccc26cf6af22c07fb81ff3aa69abd77850028 DIFF: https://github.com/llvm/llvm-project/commit/02fccc26cf6af22c07fb81ff3aa69abd77850028.diff

[clang] 564821a - [www] Update cxx_dr_status page for recent fixes.

Author: Richard Smith Date: 2020-06-16T23:56:45-07:00 New Revision: 564821ad65b6dae0c23f23ddcdfb997a0c5aab66 URL: https://github.com/llvm/llvm-project/commit/564821ad65b6dae0c23f23ddcdfb997a0c5aab66 DIFF: https://github.com/llvm/llvm-project/commit/564821ad65b6dae0c23f23ddcdfb997a0c5aab66.diff

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware added a comment. > It tests exactly what i want: the correctness of your code in //this very > patch// that was written to handle //this very case// for which you never > even bothered figuring out the correct solution but you already wrote //a > large amount of code// (inclu

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

mstorsjo added a comment. In D80880#2066938 , @amccarth wrote: > Yowza. Mingw still links against MSVCRT?! Sorry, I missed this comment earlier - that I see that I want to reply to. Traditionally, mingw still links against the OS private msvcrt.dll yes

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon added a comment. Seems that `test/OpenMP/nvptx_target_codegen.cpp` is completely not formatted. If I apply suggestion from pre-merge checks, this will look like a big unrelated to this patch change and it will contradict with the whole file style. Repository: rG LLVM Github Monorep

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

This revision was automatically updated to reflect the committed changes. Closed by commit rGbeeed368b602: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8088

[PATCH] D81794: [clang] Don't emit warn_cxx_ms_struct when MSBitfields is enabled globally

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b3fe9699277: [clang] Don't emit warn_cxx_ms_struct when MSBitfields is enabled globally (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3fd9dc9734c: [clang] Enable -mms-bitfields by default for mingw targets (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81795/new/ ht

<    1   2   3