[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

arsenm added a comment. In D81670#2088304 , @hliao wrote: > In D81670#2087974 , @arsenm wrote: > > > We should instead allow bitcast to perform no-op addrspacecasts > > > That may be a little bit challenging as so f

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

arsenm added a comment. It doesn't matter if we don't support isa linking. We should just use clang and default to -flto. LTO "just works" as is CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 ___ c

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

arsenm added a comment. In D81627#2088500 , @arsenm wrote: > It doesn't matter if we don't support isa linking. We should just use clang > and default to -flto. LTO "just works" as is This is a step forward, but the lack of ISA linking shouldn't block e

[clang] 385e5f7 - Fix incorrect call to ExprResult::get()

Author: Alex Richardson Date: 2020-06-11T22:23:33+01:00 New Revision: 385e5f7e147fcf792085b365cc48380850612025 URL: https://github.com/llvm/llvm-project/commit/385e5f7e147fcf792085b365cc48380850612025 DIFF: https://github.com/llvm/llvm-project/commit/385e5f7e147fcf792085b365cc48380850612025.dif

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] f44d242 - [clangd] Set CWD in semaCodeComplete

Author: Kadir Cetinkaya Date: 2020-06-11T23:35:47+02:00 New Revision: f44d2424f8d7735d7ab5ffd96f75300221afd099 URL: https://github.com/llvm/llvm-project/commit/f44d2424f8d7735d7ab5ffd96f75300221afd099 DIFF: https://github.com/llvm/llvm-project/commit/f44d2424f8d7735d7ab5ffd96f75300221afd099.dif

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

jdoerfert added a comment. In D81311#2088075 , @rjmccall wrote: > In D81311#2087592 , @jdoerfert wrote: > > > In D81311#2086326 , @rjmccall > > wrote: > > > > > In D81311#20

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jhuber6 updated this revision to Diff 270239. jhuber6 added a comment. Herald added subscribers: cfe-commits, aaron.ballman. Herald added a project: clang. Adding parameter and return attributes for pointers. There are some arguments I wasn't sure how they should be classified, like if every argu

[PATCH] D81244: [StackSafety] Control paramer access summary from frontend

eugenis added a comment. I like this in principle. Makes a lot more sense to control this directly from clang than to rely on function attributes. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriterPass.cpp:31 + EmitModuleHash); + } return PreservedAnal

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:305 + if (llvm::Function *unatexitFn = + dyn_cast(unatexit.getCallee())) +unatexitFn->setDoesNotThrow(); Xiangling_L wrote: > jasonliu wrote: > > Is there a va

[PATCH] D81608: Fix incorrect call to ExprResult::get()

This revision was automatically updated to reflect the committed changes. Closed by commit rG385e5f7e147f: Fix incorrect call to ExprResult::get() (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81608/new/ https://reviews.ll

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf44d2424f8d7: [clangd] Set CWD in semaCodeComplete (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES

[clang] 7fac1ac - Set the LLVM FP optimization flags conservatively.

Author: John McCall Date: 2020-06-11T18:16:41-04:00 New Revision: 7fac1acc617113b7a3276ee0f0664bedca978292 URL: https://github.com/llvm/llvm-project/commit/7fac1acc617113b7a3276ee0f0664bedca978292 DIFF: https://github.com/llvm/llvm-project/commit/7fac1acc617113b7a3276ee0f0664bedca978292.diff L

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

arsenm added a comment. In D81311#2088568 , @jdoerfert wrote: > In D81311#2088075 , @rjmccall wrote: > > > In D81311#2087592 , @jdoerfert > > wrote: > > > > > In D81311#2086

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

rjmccall added a comment. In D81311#2088568 , @jdoerfert wrote: > In D81311#2088075 , @rjmccall wrote: > > > In D81311#2087592 , @jdoerfert > > wrote: > > > > > In D81311#20

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall closed this revision. rjmccall added a comment. To ssh://github.com/llvm/llvm-project a98d618f6e5f..7fac1acc6171 master -> master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 _

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

jdoerfert added a comment. > But it does mess with the ABI; that's why it's being added. My worry is, that we do not clearly sate it does. I'm worried front-ends will use it to attach types to pointers once pointers do not have types anymore. I'll stop arguing on this one now, if you think this

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3537 AST_POLYMORPHIC_MATCHER_P_OVERLOAD( -hasType, -AST_POLYMORPHIC_SUPPORTED_TYPES(Expr, FriendDecl, ValueDecl, -

[clang] c9a52de - [CodeGen] Simplify the way lifetime of block captures is extended

Author: Akira Hatanaka Date: 2020-06-11T16:06:22-07:00 New Revision: c9a52de0026093327daedda7ea2eead8b64657b4 URL: https://github.com/llvm/llvm-project/commit/c9a52de0026093327daedda7ea2eead8b64657b4 DIFF: https://github.com/llvm/llvm-project/commit/c9a52de0026093327daedda7ea2eead8b64657b4.diff

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

jkorous added a comment. A slightly tangential thing - we recently got an internal bugreport about clangd handling combination of working directory and relative paths for `-fmodules-cache-path` combination in compile_command.json incorrectly. I tried some quick hacks but failed - it seems that u

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. does it look good to you? or any more comment? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. this patch has lasted for a couple of months. a bug in this area is hard and time-consuming to diagnose. it's better to get this fix in sooner than later. could someone review and approve it? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81624: [CodeGen] Simplify the way lifetime of block captures is extended

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a52de00260: [CodeGen] Simplify the way lifetime of block captures is extended (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81624/n

[PATCH] D80977: Diagnose cases where the name of a class member is used within a class definition before the member name is declared.

rsmith added a comment. I'm not entirely happy with this approach; there are lots of places where we perform lookups that are incidental and shouldn't result in an error if we end up looking outside the class, and I'm not sure I've marked them all as "synthetic". That said, I've tested this ove

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplate.cpp:1967 +TransformType(InnerTLB, OrigDecl->getTypeSourceInfo()->getTypeLoc()); +TypeSourceInfo *TSI = Context.getTriv

[PATCH] D81703: [Clang] Don't leave Expr::Classification fields uninitialized in default constructor

guiand created this revision. guiand added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. guiand edited the summary of this revision. This changes `Expr::Classification::{Kind, Modifiable}` fields so that they are initialized as `Unknown` rather than le

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 270267. Xiangling_L marked 21 inline comments as done. Xiangling_L added a comment. Address another round of reviews; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mang

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L added inline comments. Comment at: clang/include/clang/AST/Mangle.h:178 + virtual void mangleDynamicDestructor(const VarDecl *D, raw_ostream &Out) = 0; + hubert.reinterpretcast wrote: > I am not sure "destructor" is the right term here. This seems

[PATCH] D81242: [StackSafety] Run ThinLTO

eugenis added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows)

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser added a comment. kindly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D81707: [PowerPC][Power10] Implement Vector Clear Left/Rightmost Bytes Builtins in LLVM/Clang

amyk created this revision. amyk added reviewers: saghir, nemanjai, power-llvm-team, PowerPC, hfinkel. amyk added projects: clang, LLVM, PowerPC. Herald added subscribers: shchenz, hiraditya. This patch implements builtins for the following prototypes: vector signed char vec_clrl (vector signed

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1967 +TransformType(InnerTLB, OrigDecl->getTypeSourceInfo()->getTypeLoc()); +TypeSourceInfo *TSI = Context.getTrivialTypeSourceInfo(Transformed);

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:293 +CodeGenFunction::unregisterGlobalDtorWithUnAtExit(llvm::Function *dtorStub) { + // extern "C" int unatexit(void (*f)(void)); + assert(dtorStub->getFunctionType() == P

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

mehdi_amini added a comment. Do you need someone to land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 ___ cfe-commits mailing list cfe-commits@

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5231 + CXXNameMangler Mangler(*this, Out); + Mangler.getStream() << "__cxx_global_var_destruct_"; + if (shouldMangleDeclName(D)) I believe these are actually paired with

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:824 std::tie(CalleeTy, Callee, Arg) = DtorsAndObjects[e - i - 1]; - llvm::CallInst *CI = Builder.CreateCall(CalleeTy, Callee, Arg); + llvm::CallInst *CI = (Arg == nullptr) +

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl added a comment. In D81627#2088502 , @arsenm wrote: > In D81627#2088500 , @arsenm wrote: > > > It doesn't matter if we don't support isa linking. We should just use clang > > and default to -flto. LTO "just

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

yaxunl created this revision. yaxunl added reviewers: tra, arsenm. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. Currently rocm detector expects device library bitcodes named as *.bc instead of *.amdgcn.bc. However in rocm3.5 the device library bitcodes are named as *.amdgcn.bc, whic

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2725-2726 for (unsigned I = 0, E = GpuArchList.size(); I != E; ++I) { // Create a link action to link device IR with device library // and

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:682 void CodeGenModule::EmitCXXGlobalDtorFunc() { if (CXXGlobalDtors.empty()) return; hubert.reinterpretcast wrote: > Following from my previous comments on `CXXGlo

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

yaxunl updated this revision to Diff 270302. yaxunl marked 2 inline comments as done. yaxunl added a reviewer: ashi1. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 Files: clang/lib/Driver/

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:327 return true; TheCall->setArg(2, Arg.get()); } rjmccall wrote: > I know this is existing code, but this is a broken mess. Please change this > to: > > ``` > Exp

[PATCH] D81420: Fix size for _ExtInt types with builtins

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:327 return true; TheCall->setArg(2, Arg.get()); } jtmott-intel wrote: > rjmccall wrote: > > I know this is existing code, but this is a broken mess. Please change > > thi

[PATCH] D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

anil9 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:305 +// P10 Vector Centrifuge +BUILTIN(__builtin_altivec_vcfuged, "V2ULLiV2ULLiV2ULLi", "") nit : // P10 Vector Centrifuge built-in. Comment at: clang/include/

[PATCH] D81688: [WebAssembly] WebAssembly doesn't support "protected" visibility

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/WebAssembly.h:139 +// Emscripten targets. +return getTriple().isOSEmscripten(); + } I'm not sure we need thi

<    1   2