[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale added a comment. As far as I can tell the failures reported shouldn't be caused by this change. John, would you be able to land this on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269644. gamesh411 added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst clang/in

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM (after a minor comment), thank you for fixing this! Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:3598 + S = new (Context) BuiltinBitCastE

[PATCH] D81439: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5c28c409432: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81439/ne

[clang] 856ba63 - [clang][NFC] Fix and simplify the test added in 8dcc7eecb75b39d723fd6fee566369bf67e43fdf

Author: Bruno Ricci Date: 2020-06-09T21:17:19+01:00 New Revision: 856ba638d57ead6df85a4ff39531282c6c110232 URL: https://github.com/llvm/llvm-project/commit/856ba638d57ead6df85a4ff39531282c6c110232 DIFF: https://github.com/llvm/llvm-project/commit/856ba638d57ead6df85a4ff39531282c6c110232.diff L

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

arsenm added a comment. In D81311#2078235 , @rjmccall wrote: > I wonder if `byref` would be a better name for this, as a way to say that the > object is semantically a direct argument that's being passed by implicit > reference. This is probably a bett

[clang-tools-extra] 2a3ac01 - Reland [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

Author: Sam McCall Date: 2020-06-09T23:07:28+02:00 New Revision: 2a3ac01b689bb662d4b59ecf03e5f779d640a4ce URL: https://github.com/llvm/llvm-project/commit/2a3ac01b689bb662d4b59ecf03e5f779d640a4ce DIFF: https://github.com/llvm/llvm-project/commit/2a3ac01b689bb662d4b59ecf03e5f779d640a4ce.diff LO

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo updated this revision to Diff 269657. oontvoo marked an inline comment as done. oontvoo added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81444/new/ https://reviews.llvm.org/D81444 Files: clang/lib/Sem

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo marked 7 inline comments as done. oontvoo added inline comments. Comment at: clang/test/Sema/warn-missing-prototypes.c:62 + +const struct MyStruct get_struct() { // expected-warning{{no previous prototype for function 'get_struct'}} +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 269663. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2082017 , @ABataev wrote: > Do you have a test for mapping of something like `arr[0][:n]`, where the base > is an array subscript and the remaining part is an array section? I'm not having it right now, but it seems like

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:5217 + else +Mangler.getStream() << D->getName(); +} If I understand correctly, this function will come in pair with `__cxx_global_var_init`. `__cxx_global_var_init` use number as s

[PATCH] D79830: Add support of __builtin_expect_with_probability

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. LLVM side of change LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mai

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269677. gamesh411 added a comment. add ambiguity checking during invocation list parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. Bug report has been closed. I'm seeing some build failures in my inbox but eyeballing them doesn't make me think this change is related. What is the expectation for me in this scenario? Will I get an email letting me know once the build has been fixed? Repository:

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

anakryiko added a comment. IntrinsicsBPF.td uses `__builtin_bpf_load_u32_to_ptr`, while everywhere it is just `__builtin_load_u32_to_ptr`. I think having bpf prefix there is good, given this is bpf-specific. But either way, probably should be consistent everywhere? Repository: rG LLVM Githu

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu added a comment. Do you think adding `MSVC2019` to make the name mangling compatible with `MSVC v19.20` is acceptable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80409/new/ https://reviews.llvm.org/D80409 ___ cfe-commits mailin

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

yonghong-song added a comment. In D81479#2083510 , @anakryiko wrote: > IntrinsicsBPF.td uses `__builtin_bpf_load_u32_to_ptr`, while everywhere it is > just `__builtin_load_u32_to_ptr`. I think having bpf prefix there is good, > given this is bpf-specific

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 added a comment. In D79912#2083477 , @Tridacnid wrote: > Bug report has been closed. I'm seeing some build failures in my inbox but > eyeballing them doesn't make me think this change is related. What is the > expectation for me in this scenario

[PATCH] D81514: [Fuchsia] Set projects and runtimes in the cache file

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. We make assumptions about what projects and runtimes are enabled when configuring our toolchain build, so we should enable those in the cache file as we

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:524 + CallConv)) +return; EVT ValueVT = Val.getValueType(); I'm not sure I understand why the standard getCopyFromParts/g

[clang] f56659d - Don't use a variable that isn't defined

Author: Akira Hatanaka Date: 2020-06-09T16:07:29-07:00 New Revision: f56659d2bae67b26c016aed6503585d93fbafd23 URL: https://github.com/llvm/llvm-project/commit/f56659d2bae67b26c016aed6503585d93fbafd23 DIFF: https://github.com/llvm/llvm-project/commit/f56659d2bae67b26c016aed6503585d93fbafd23.diff

[clang] a21a462 - Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

Author: Vy Nguyen Date: 2020-06-09T19:34:57-04:00 New Revision: a21a462051659d8e1281af7d11738b8abc0557dc URL: https://github.com/llvm/llvm-project/commit/a21a462051659d8e1281af7d11738b8abc0557dc DIFF: https://github.com/llvm/llvm-project/commit/a21a462051659d8e1281af7d11738b8abc0557dc.diff LOG

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. I did run both of the testing targets you mentioned, but only on Linux. I'll keep an eye on the buildbot, thanks for the info! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 _

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa21a46205165: Make the diagnostic-missing-prototypes put the suggested `static` in front of… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 641d5ac - [X86] Assign a feature to tremont, goldmont, goldmont-plus, icelake-client, and icelake for target multiversioning priority.

Author: Craig Topper Date: 2020-06-09T16:39:41-07:00 New Revision: 641d5ac4d1965990fcf981f153369b038816cd16 URL: https://github.com/llvm/llvm-project/commit/641d5ac4d1965990fcf981f153369b038816cd16 DIFF: https://github.com/llvm/llvm-project/commit/641d5ac4d1965990fcf981f153369b038816cd16.diff

[clang] ccd1922 - Fix variables used only in asserts.

Author: Sterling Augustine Date: 2020-06-09T17:19:38-07:00 New Revision: ccd192204da45cc3f4b42f585f04c4f934b21bef URL: https://github.com/llvm/llvm-project/commit/ccd192204da45cc3f4b42f585f04c4f934b21bef DIFF: https://github.com/llvm/llvm-project/commit/ccd192204da45cc3f4b42f585f04c4f934b21bef.

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

saugustine added a comment. Unfortunately, after this change there are several variables only used in asserts, which creates build failures when assertions are disabled. I will be submitting https://reviews.llvm.org/D81522 shortly to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D81522: Fix variables used only in asserts.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGccd192204da4: Fix variables used only in asserts. (authored by saugustine). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D81522: Fix variables used only in asserts.

saugustine created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine edited the summary of this revision. saugustine added a reviewer: baloghadamsoftware. Herald added a subscriber: rnkovacs. Fix variables used only in asserts. For post-commit review

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

jaafar added a comment. Thnaks very much @hokein . The ones I need are: 9a5c448a31bacc08e73fcae4636094f9b6e2be6a eaf0c89ec5f866b6cef296c542c030bb2cf8481d d6

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

yonghong-song updated this revision to Diff 269721. yonghong-song retitled this revision from "[BPF] introduce __builtin_load_u32_to_ptr() intrinsic" to "[BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic". yonghong-song edited the summary of this revision. yonghong-song added a comment.

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

ast added a comment. It feels that the same thing can be represented as inline asm. What advantage builtin has? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81479/new/ https://reviews.llvm.org/D81479

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

yonghong-song added a comment. In D81479#2083933 , @ast wrote: > It feels that the same thing can be represented as inline asm. > What advantage builtin has? Yes, this can be represented as an inline asm. I have a tendency not liking inline assembly co

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

sammccall added a comment. @jaafar Thanks for the list, this is really useful for us. These all look reasonable to me, I've filed bugs to track them and if they look good to Haojian too we'll get them merged. See https://github.com/clangd/clangd/issues?q=is%3Aissue+label%3Acherrypick I've adde

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel marked an inline comment as done. jtmott-intel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7939 "to a non-const integer (%0 invalid)">; +def err_overflow_builtin_extint_size : Error< + "_ExtInt argument larger than 64-bits

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel updated this revision to Diff 269727. jtmott-intel added a comment. Limited diagnostic to *signed* _ExtInt, and added test to verify unsigned works. Reused existing diagnostic message rather than make a new one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81420/new/ https

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

sammccall added a subscriber: jaafar. sammccall added a comment. @jaafar would you be able to verify this is equivalent to D74731 for your purposes? If so I'd like to cherrypick this into tho 10.x branch after landing. Repository: rG LLVM Github Monorepo CHA

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

rjmccall added a comment. In D81311#2083295 , @arsenm wrote: > In D81311#2078235 , @rjmccall wrote: > > > I wonder if `byref` would be a better name for this, as a way to say that > > the object is semantically a d

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

sammccall added a comment. Sorry this got stalled, it's important (I hadn't realized we were crashing on *indexing* when boost was included). I've created D81530 derived from this which addresses the previous round of comments and adds a testcase for indexing.

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall added a subscriber: jaafar. sammccall added a comment. @jaafar would you be able to verify t

[PATCH] D81420: Fix size for _ExtInt types with builtins

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7939 "to a non-const integer (%0 invalid)">; +def err_overflow_builtin_extint_size : Error< + "_ExtInt argument larger than 64-bits to overflow builtin requires runtime "

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Sema/Sema.h:12126 + ExprResult SemaBuiltinMatrixColumnMajorLoadOverload(CallExpr *TheCall, +

[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, alright. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77592/new/ https://reviews.llvm.org/D77592 __

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

baloghadamsoftware added a comment. In D80286#2083753 , @saugustine wrote: > Unfortunately, after this change there are several variables only used in > asserts, which creates build failures when assertions are disabled. > > I will be submitting https://r

[PATCH] D81479: [BPF] introduce __builtin_bpf_load_u32_to_ptr() intrinsic

yonghong-song added a comment. I guess I will go with inline asm in kernel for now as llvm seems already doing a pretty good job parsing/understanding inline asm to integrated into optimization passes. A few passes like SimplifyCFG, GVN, etc. may have some impact but probably does not really ma

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

hokein added a comment. These changes look reasonable to me, thanks! Here is a list of commits that we plan to cherrypick, see https://github.com/clangd/clangd/issues/417. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74025/new/ https://reviews.ll

<    1   2   3